103156 2012-11-23 11:20:32 -0800 With composited scrolling, content should only appear behind overlay scrollbars 2017-07-18 08:27:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 94743 1 vollick vollick dglazkov eric simon.fraser skyostil tonikitoo webkit.review.bot oldest_to_newest 774661 0 vollick 2012-11-23 11:20:32 -0800 We just need to update the clip of the scrolling layer to exclude the scrollbars when they're not overlay scrollbars. 774662 1 175830 vollick 2012-11-23 11:25:11 -0800 Created attachment 175830 Patch 774675 2 175830 simon.fraser 2012-11-23 11:53:18 -0800 Comment on attachment 175830 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175830&action=review > Source/WebCore/ChangeLog:3 > + With composited scrolling, content should only appear behind overlay scrollbars This title is ambiguous. I think you mean "content should appear behind overlay scrollbars". > Source/WebCore/rendering/RenderLayerBacking.cpp:744 > + FloatSize clipSize = paddingBox.size(); > + if (m_layerForHorizontalScrollbar && !m_owningLayer->horizontalScrollbar()->isOverlayScrollbar()) > + clipSize.setHeight(clipSize.height() - m_layerForHorizontalScrollbar->size().height()); > + if (m_layerForVerticalScrollbar && !m_owningLayer->verticalScrollbar()->isOverlayScrollbar()) > + clipSize.setWidth(clipSize.width() - m_layerForVerticalScrollbar->size().width()); I think we have a "width for scrollbar" method somewhere that takes into account whether they are overlay scrollbars. 774680 3 175830 buildbot 2012-11-23 12:15:02 -0800 Comment on attachment 175830 Patch Attachment 175830 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14975397 New failing tests: compositing/overflow/clip-composited-content-under-overflow-controls.html 774701 4 175830 webkit.review.bot 2012-11-23 14:07:55 -0800 Comment on attachment 175830 Patch Attachment 175830 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14937845 New failing tests: platform/chromium/virtual/softwarecompositing/overflow/clip-composited-content-under-overflow-controls.html compositing/overflow/clip-composited-content-under-overflow-controls.html 175830 2012-11-23 11:25:11 -0800 2012-11-23 14:07:55 -0800 Patch bug-103156-20121123142254.patch text/plain 6247 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmE3YjQwYzk3YzJkNzkz ZWZhNGRjNzRkNGE5OTE4NmZkYjhmM2MwZi4uZTIyNzk1Nzk1YjAyZjY3NDVlNTk5ZjIxNDkxMTM0 NDQyNzc3YTYzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTIzICBJYW4g Vm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdpdGggY29tcG9zaXRl ZCBzY3JvbGxpbmcsIGNvbnRlbnQgc2hvdWxkIG9ubHkgYXBwZWFyIGJlaGluZCBvdmVybGF5IHNj cm9sbGJhcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMzE1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkanVzdHMgdGhlIGNsaXAgb2YgdGhlIHNjcm9sbGluZyBsYXllciBzbyB0aGF0IGl0IG9ubHkg aW5jbHVkZXMKKyAgICAgICAgc2Nyb2xsYmFycyBpZiB0aGV5IGFyZSBvdmVybGF5IHNjcm9sbGJh cnMuCisKKyAgICAgICAgVGVzdDogY29tcG9zaXRpbmcvb3ZlcmZsb3cvY2xpcC1jb21wb3NpdGVk LWNvbnRlbnQtdW5kZXItb3ZlcmZsb3ctY29udHJvbHMuaHRtbAorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXll ckJhY2tpbmc6OnVwZGF0ZUdyYXBoaWNzTGF5ZXJHZW9tZXRyeSk6CisKIDIwMTItMTEtMjMgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtFTkNI QU5UXSBJbmZpbml0ZSBsb29wIHdoZW4gZW5kIHdvcmQgcG9zaXRpb24gaXMgbm90IGZvdW5kCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4 IDg4YmUwOGRmZWJlNWY5YTdjYjc4OTI1ODA2NDhiNDRiYmRiOTNjNzQuLmZlZmEwZWVjNmYwOGFk ODFkN2ZhYWU1Zjk1ODI0NGIxZDJjZTQ4ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC03MzcsNyArNzM3LDEyIEBAIHZvaWQgUmVu ZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVHcmFwaGljc0xheWVyR2VvbWV0cnkoKQogCiAgICAgICAg IG1fc2Nyb2xsaW5nTGF5ZXItPnNldFBvc2l0aW9uKEZsb2F0UG9pbnQoKSArIChwYWRkaW5nQm94 LmxvY2F0aW9uKCkgLSBsb2NhbENvbXBvc2l0aW5nQm91bmRzLmxvY2F0aW9uKCkpKTsKIAotICAg ICAgICBtX3Njcm9sbGluZ0xheWVyLT5zZXRTaXplKHBhZGRpbmdCb3guc2l6ZSgpKTsKKyAgICAg ICAgRmxvYXRTaXplIGNsaXBTaXplID0gcGFkZGluZ0JveC5zaXplKCk7CisgICAgICAgIGlmICht X2xheWVyRm9ySG9yaXpvbnRhbFNjcm9sbGJhciAmJiAhbV9vd25pbmdMYXllci0+aG9yaXpvbnRh bFNjcm9sbGJhcigpLT5pc092ZXJsYXlTY3JvbGxiYXIoKSkKKyAgICAgICAgICAgIGNsaXBTaXpl LnNldEhlaWdodChjbGlwU2l6ZS5oZWlnaHQoKSAtIG1fbGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xs YmFyLT5zaXplKCkuaGVpZ2h0KCkpOworICAgICAgICBpZiAobV9sYXllckZvclZlcnRpY2FsU2Ny b2xsYmFyICYmICFtX293bmluZ0xheWVyLT52ZXJ0aWNhbFNjcm9sbGJhcigpLT5pc092ZXJsYXlT Y3JvbGxiYXIoKSkKKyAgICAgICAgICAgIGNsaXBTaXplLnNldFdpZHRoKGNsaXBTaXplLndpZHRo KCkgLSBtX2xheWVyRm9yVmVydGljYWxTY3JvbGxiYXItPnNpemUoKS53aWR0aCgpKTsKKyAgICAg ICAgbV9zY3JvbGxpbmdMYXllci0+c2V0U2l6ZShjbGlwU2l6ZSk7CiAgICAgICAgIG1fc2Nyb2xs aW5nQ29udGVudHNMYXllci0+c2V0UG9zaXRpb24oRmxvYXRQb2ludCgtc2Nyb2xsT2Zmc2V0Lndp ZHRoKCksIC1zY3JvbGxPZmZzZXQuaGVpZ2h0KCkpKTsKIAogICAgICAgICBJbnRTaXplIG9sZFNj cm9sbGluZ0xheWVyT2Zmc2V0ID0gbV9zY3JvbGxpbmdMYXllci0+b2Zmc2V0RnJvbVJlbmRlcmVy KCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggZGNhN2JlNWFhMmM4Y2QzY2MwNzg2ODE3YTkzNWNjYjA5M2QwZDIwMy4uYmRi MTQ1NzNmN2VlNjBkNjVlMjZmMGIyYzcwOGNjNjVjMTUxNTZiMSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTExLTIzICBJYW4gVm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFdpdGggY29tcG9zaXRlZCBzY3JvbGxpbmcsIGNvbnRlbnQgc2hvdWxkIG9ubHkgYXBw ZWFyIGJlaGluZCBvdmVybGF5IHNjcm9sbGJhcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzE1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkanVzdHMgdGhlIGNsaXAgb2YgdGhlIHNjcm9sbGluZyBs YXllciBzbyB0aGF0IGl0IG9ubHkgaW5jbHVkZXMKKyAgICAgICAgc2Nyb2xsYmFycyBpZiB0aGV5 IGFyZSBvdmVybGF5IHNjcm9sbGJhcnMuCisKKyAgICAgICAgKiBjb21wb3NpdGluZy9vdmVyZmxv dy9jbGlwLWNvbXBvc2l0ZWQtY29udGVudC11bmRlci1vdmVyZmxvdy1jb250cm9scy1leHBlY3Rl ZC5wbmc6IEFkZGVkLgorICAgICAgICAqIGNvbXBvc2l0aW5nL292ZXJmbG93L2NsaXAtY29tcG9z aXRlZC1jb250ZW50LXVuZGVyLW92ZXJmbG93LWNvbnRyb2xzLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogY29tcG9zaXRpbmcvb3ZlcmZsb3cvY2xpcC1jb21wb3NpdGVkLWNvbnRlbnQt dW5kZXItb3ZlcmZsb3ctY29udHJvbHMuaHRtbDogQWRkZWQuCisKIDIwMTItMTEtMjMgIFJvYmVy dCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQg Z2FyZGVuaW5nOiB0ZXN0IGV4cGVjdGF0aW9ucyBmYWlsdXJlcy4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2NvbXBvc2l0aW5nL292ZXJmbG93L2NsaXAtY29tcG9zaXRlZC1jb250ZW50LXVuZGVy LW92ZXJmbG93LWNvbnRyb2xzLWV4cGVjdGVkLnBuZyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5n L292ZXJmbG93L2NsaXAtY29tcG9zaXRlZC1jb250ZW50LXVuZGVyLW92ZXJmbG93LWNvbnRyb2xz LWV4cGVjdGVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jNWI4NDlhMjMxNWIwNzE4Y2NmOTdjZmU4NzdhODk2 ZmEyZDgyODIxCkdJVCBiaW5hcnkgcGF0Y2gKbGl0ZXJhbCAyODc1CnpjbWVBU0BOPyhvbEh5YHVW QnEhaWEweX55VXsrdllWMmE+aTAqWik9aF5obEElQFdzJGxIYG9rPG19P29UbX08awp6MyhKJkxC T3BwTkhMKX5LTzBoNkJIWng5MU5pbmRuRmZ+Z31kPWA+M200U2lsdGZ6fShOWDRBREgjWUpmM0pf cCoKej8xXzw+OChIRig/I2BOYHkpWENkbEllUjJOXmhVQlZQSlMrNlZBYFR1dFUwJGx8ZXVfZmBQ I2hnUiR9Tl5AbzJlCnp7fSYlJEQhVkBVRCt8S3xtem9VPjNgdERmMzxfJGE0RWhHYncpSnVhTEJe WV9tPjNFfD9YYm9jWDhocTB4dCo1dwp6bTVyZXhgcnw8K2g3THwwaEszbWpNajR9bEZxI3JaYkhR alg3fGpLdnhuTUxHNDNiPD4lYXw0fnUhPUc1KHN5OE0KT244RE40JnQ7dWNMSzZVaDJMKyUyCgps aXRlcmFsIDAKSGNtVj9kMDAwMDEKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGlu Zy9vdmVyZmxvdy9jbGlwLWNvbXBvc2l0ZWQtY29udGVudC11bmRlci1vdmVyZmxvdy1jb250cm9s cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9vdmVyZmxvdy9jbGlwLWNv bXBvc2l0ZWQtY29udGVudC11bmRlci1vdmVyZmxvdy1jb250cm9scy1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uOGIxMzc4OTE3OTFmZTk2OTI3YWQ3OGU2NGIwYWFkN2JkZWQwOGJkYwotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL292ZXJmbG93L2NsaXAtY29tcG9z aXRlZC1jb250ZW50LXVuZGVyLW92ZXJmbG93LWNvbnRyb2xzLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxIEBACisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL292ZXJmbG93L2Ns aXAtY29tcG9zaXRlZC1jb250ZW50LXVuZGVyLW92ZXJmbG93LWNvbnRyb2xzLmh0bWwgYi9MYXlv dXRUZXN0cy9jb21wb3NpdGluZy9vdmVyZmxvdy9jbGlwLWNvbXBvc2l0ZWQtY29udGVudC11bmRl ci1vdmVyZmxvdy1jb250cm9scy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjFhYTVkZmZkMDhhOWJiNDg5MWY1 OTBiMDFlZmE2YjEzMWViMDE3MWYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21w b3NpdGluZy9vdmVyZmxvdy9jbGlwLWNvbXBvc2l0ZWQtY29udGVudC11bmRlci1vdmVyZmxvdy1j b250cm9scy5odG1sCkBAIC0wLDAgKzEsNzEgQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgor LmNvbXBvc2l0ZWQgeworICAtd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWigwKTsKK30KKwor LmNvbnRhaW5lciB7CisgIHdpZHRoOjEwMHB4OworICBoZWlnaHQ6MTAwcHg7CisgIG92ZXJmbG93 OnNjcm9sbDsKKyAgcmVzaXplOmJvdGg7CisgIHBvc2l0aW9uOmFic29sdXRlOworfQorCisuY29u dGFpbmVyOjotd2Via2l0LXNjcm9sbGJhciB7CisgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMCwg MTI3LCAwLCAwLjUpOworfQorLmNvbnRhaW5lcjo6LXdlYmtpdC1yZXNpemVyIHsKKyAgYmFja2dy b3VuZC1jb2xvcjogcmdiYSgwLCAxMjcsIDAsIDAuNSk7Cit9CisKKy5ub3JtYWxDb250ZW50QXJl YSB7CisgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMCwgMTI3LCAwLCAwLjUpOworICBwb3NpdGlv bjphYnNvbHV0ZTsKKyAgdG9wOjBweDsKKyAgYm90dG9tOjBweDsKKyAgbGVmdDowcHg7CisgIHJp Z2h0OjBweAorfQorCisuYmVuZWF0aFZlcnRpY2FsU2Nyb2xsYmFyIHsKKyAgcG9zaXRpb246YWJz b2x1dGU7CisgIGJhY2tncm91bmQtY29sb3I6IHJlZDsKKyAgYm90dG9tOi0xNXB4OworICBsZWZ0 OjBweDsKKyAgcmlnaHQ6MHB4OworICBoZWlnaHQ6MTVweDsKK30KKworLmJlbmVhdGhIb3Jpem9u dGFsU2Nyb2xsYmFyIHsKKyAgcG9zaXRpb246YWJzb2x1dGU7CisgIGJhY2tncm91bmQtY29sb3I6 IHJlZDsKKyAgdG9wOjBweDsKKyAgYm90dG9tOjBweDsKKyAgcmlnaHQ6LTE1cHg7CisgIHdpZHRo OjE1cHg7Cit9CisKKy5iZW5lYXRoU2Nyb2xsQ29ybmVyIHsKKyAgcG9zaXRpb246YWJzb2x1dGU7 CisgIGJhY2tncm91bmQtY29sb3I6IHJlZDsKKyAgYm90dG9tOi0xNXB4OworICByaWdodDotMTVw eDsKKyAgaGVpZ2h0OjE1cHg7CisgIHdpZHRoOjE1cHg7Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4K K2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQodHJ1ZSk7 IC8vIE9ubHkgdXNlZnVsIGFzIGEgcGl4ZWwgdGVzdAorCitpZiAod2luZG93LmludGVybmFscykK KyAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRpbmdzLnNldEVuYWJsZUNvbXBvc2l0aW5nRm9yT3Zl cmZsb3dTY3JvbGwodHJ1ZSk7Cis8L3NjcmlwdD4KKzwhLS0gTm8gcmVkIHNob3VsZCBiZSB2aXNp YmxlLCBvbmx5IGEgc29saWQgZ3JlZW4gc3F1YXJlLiAtLT4KKzxkaXYgY2xhc3M9ImNvbnRhaW5l ciBjb21wb3NpdGVkIj4KKyAgPGRpdiBjbGFzcz0ibm9ybWFsQ29udGVudEFyZWEiPjwvZGl2Pgor ICA8ZGl2IGNsYXNzPSJiZW5lYXRoVmVydGljYWxTY3JvbGxiYXIiPjwvZGl2PgorICA8ZGl2IGNs YXNzPSJiZW5lYXRoSG9yaXpvbnRhbFNjcm9sbGJhciI+PC9kaXY+CisgIDxkaXYgY2xhc3M9ImJl bmVhdGhTY3JvbGxDb3JuZXIiPjwvZGl2PgorPC9kaXY+Cg==