102953 2012-11-21 09:33:59 -0800 [GTK][WTR] Implement AccessibilityUIElement::titleUIElement 2012-12-10 03:31:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98347 1 zan zan mario mrobinson pnormand oldest_to_newest 773032 0 zan 2012-11-21 09:33:59 -0800 [GTK][WTR] Implement AccessibilityUIElement::titleUIElement 773037 1 175465 zan 2012-11-21 09:35:45 -0800 Created attachment 175465 Patch 773223 2 mrobinson 2012-11-21 13:30:24 -0800 Hrm. Doesn't this change test results? 773241 3 zan 2012-11-21 13:46:49 -0800 (In reply to comment #2) > Hrm. Doesn't this change test results? No, it brings the WTR in line with DRT so wk1 baselines can be used without the tests failing in WTR. The affected tests are currently failing on WK2 builder, with the patch they pass. 773325 4 175465 mrobinson 2012-11-21 14:57:38 -0800 Comment on attachment 175465 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175465&action=review > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:274 > + g_object_unref(set); Not sure I understand this code. Doesn't this unref set multiple times? I wonder if this should be: g_object_unref(relation) 773709 5 175465 zan 2012-11-22 01:09:40 -0800 Comment on attachment 175465 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175465&action=review >> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:274 >> + g_object_unref(set); > > Not sure I understand this code. Doesn't this unref set multiple times? I wonder if this should be: g_object_unref(relation) Yeah, that looks wrong. The statement should probably be moved outside the loop. Mario or Joanie should have a look. 787133 6 178497 zan 2012-12-10 02:45:06 -0800 Created attachment 178497 Patch 787160 7 178497 zan 2012-12-10 03:31:33 -0800 Comment on attachment 178497 Patch Clearing flags on attachment: 178497 Committed r137130: <http://trac.webkit.org/changeset/137130> 787161 8 zan 2012-12-10 03:31:41 -0800 All reviewed patches have been landed. Closing bug. 175465 2012-11-21 09:35:45 -0800 2012-12-10 02:45:01 -0800 Patch bug-102953-20121121183331.patch text/plain 2284 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmEzYjBhZDE2YjUyYjNlODM3YjNhMjljYWQ4OGYxMmUy MWVmYTZkOS4uNmQ2Y2I0NGY0NWUyOTQ5NDhiYTI0ZGExY2Q2MTBlNzczNjAxZmRjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTExLTIxICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0dUS11bV1RSXSBJbXBsZW1lbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dGl0 bGVVSUVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjk1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEltcGxlbWVudCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojp0aXRsZVVJRWxlbWVudCBpbiB0 aGUgQVRLIGJhY2tlbmQKKyAgICAgICAgaW4gdGhlIHNhbWUgbWFubmVyIGl0IGlzIGltcGxlbWVu dGVkIGluIER1bXBSZW5kZXJUcmVlLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9Jbmpl Y3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHA6CisgICAgICAgIChX VFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnRpdGxlVUlFbGVtZW50KToKKwogMjAxMi0xMS0y MSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjEzNTM0MC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJ RWxlbWVudEF0ay5jcHAKaW5kZXggOWFlZWYzNzQyMTliNDc2Nzk3YTFhMjg1YzcyY2RkZGQ3N2U1 NGNjYi4uYjM2MjQzYjIyOTY1ZjU2ZDllOGE0YjI0MWEwOTUyMWJlNDlhNWRlNSAxMDA2NDQKLS0t IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0 eVVJRWxlbWVudEF0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTI1NSw4ICsyNTUsMjYg QEAgUGFzc1JlZlB0cjxBY2Nlc3NpYmlsaXR5VUlFbGVtZW50PiBBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50OjpzZWxlY3RlZFJvd0F0SW5kZXgodW4KIAogUGFzc1JlZlB0cjxBY2Nlc3NpYmlsaXR5VUlF bGVtZW50PiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojp0aXRsZVVJRWxlbWVudCgpCiB7Ci0gICAg Ly8gRklYTUU6IGltcGxlbWVudAotICAgIHJldHVybiAwOworICAgIGlmICghbV9lbGVtZW50KQor ICAgICAgICByZXR1cm4gMDsKKworICAgIEF0a1JlbGF0aW9uU2V0KiBzZXQgPSBhdGtfb2JqZWN0 X3JlZl9yZWxhdGlvbl9zZXQoQVRLX09CSkVDVChtX2VsZW1lbnQpKTsKKyAgICBpZiAoIXNldCkK KyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBBdGtPYmplY3QqIHRhcmdldCA9IDA7CisgICAgaW50 IGNvdW50ID0gYXRrX3JlbGF0aW9uX3NldF9nZXRfbl9yZWxhdGlvbnMoc2V0KTsKKyAgICBmb3Ig KGludCBpID0gMDsgaSA8IGNvdW50OyBpKyspIHsKKyAgICAgICAgQXRrUmVsYXRpb24qIHJlbGF0 aW9uID0gYXRrX3JlbGF0aW9uX3NldF9nZXRfcmVsYXRpb24oc2V0LCBpKTsKKyAgICAgICAgaWYg KGF0a19yZWxhdGlvbl9nZXRfcmVsYXRpb25fdHlwZShyZWxhdGlvbikgPT0gQVRLX1JFTEFUSU9O X0xBQkVMTEVEX0JZKSB7CisgICAgICAgICAgICBHUHRyQXJyYXkqIHRhcmdldExpc3QgPSBhdGtf cmVsYXRpb25fZ2V0X3RhcmdldChyZWxhdGlvbik7CisgICAgICAgICAgICBpZiAodGFyZ2V0TGlz dC0+bGVuKQorICAgICAgICAgICAgICAgIHRhcmdldCA9IHN0YXRpY19jYXN0PEF0a09iamVjdCo+ KGdfcHRyX2FycmF5X2luZGV4KHRhcmdldExpc3QsIDApKTsKKyAgICAgICAgfQorICAgICAgICBn X29iamVjdF91bnJlZihzZXQpOworICAgIH0KKworICAgIHJldHVybiB0YXJnZXQgPyBBY2Nlc3Np YmlsaXR5VUlFbGVtZW50OjpjcmVhdGUodGFyZ2V0KSA6IDA7CiB9CiAKIFBhc3NSZWZQdHI8QWNj ZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6cGFyZW50RWxlbWVu dCgpCg== 178497 2012-12-10 02:45:06 -0800 2012-12-10 03:31:33 -0800 Patch bug-102953-20121210114227.patch text/plain 3255 zan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNzEyNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDEyLTEyLTEwICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5j b20+CisKKyAgICAgICAgW0dUS11bV1RSXSBJbXBsZW1lbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVu dDo6dGl0bGVVSUVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMjk1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEltcGxlbWVudCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojp0aXRsZVVJRWxlbWVu dCBpbiB0aGUgQVRLIGJhY2tlbmQKKyAgICAgICAgaW4gdGhlIHNhbWUgbWFubmVyIGl0IGlzIGlt cGxlbWVudGVkIGluIER1bXBSZW5kZXJUcmVlLiBCb3RoIGltcGxlbWVudGF0aW9ucworICAgICAg ICBhcmUgdXBkYXRlZCB0byB1bnJlZiB0aGUgcmVsYXRpb24gc2V0IGJlZm9yZSB0aGUgZmluYWwg ZnVuY3Rpb24gcmV0dXJuCisgICAgICAgIHJhdGhlciB0aGFuIGF0IHRoZSBlbmQgb2YgZWFjaCBs b29wIHRocm91Z2ggdGhlIHJlbGF0aW9ucyBoZWxkIGluIHRoZSBzYWlkCisgICAgICAgIHJlbGF0 aW9uIHNldC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlF bGVtZW50R3RrLmNwcDoKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnRpdGxlVUlF bGVtZW50KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0ay9B Y2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcDoKKyAgICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0 eVVJRWxlbWVudDo6dGl0bGVVSUVsZW1lbnQpOgorCiAyMDEyLTEyLTEwICBNaWhuZWEgT3ZpZGVu aWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZGluZyBNaWhh aSBNYWVyZWFuIHRvIHRoZSBsaXN0IG9mIGNvbnRyaWJ1dG9ycywgd29ya2luZyBvbiBDU1NSZWdp b25zLgpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnRHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3Np YmlsaXR5VUlFbGVtZW50R3RrLmNwcAkocmV2aXNpb24gMTM3MTI0KQorKysgVG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMjAsNyArMzIwLDYgQEAgSlNTdHJpbmdSZWYgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6 YXR0cgogCiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnRp dGxlVUlFbGVtZW50KCkKIHsKLQogICAgIGlmICghbV9lbGVtZW50KQogICAgICAgICByZXR1cm4g MDsKIApAQCAtMzM3LDkgKzMzNiw5IEBAIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQgQWNjZXNzaWJp bGl0eVVJRWwKICAgICAgICAgICAgIGlmICh0YXJnZXRMaXN0LT5sZW4pCiAgICAgICAgICAgICAg ICAgdGFyZ2V0ID0gc3RhdGljX2Nhc3Q8QXRrT2JqZWN0Kj4oZ19wdHJfYXJyYXlfaW5kZXgodGFy Z2V0TGlzdCwgMCkpOwogICAgICAgICB9Ci0gICAgICAgIGdfb2JqZWN0X3VucmVmKHNldCk7CiAg ICAgfQogCisgICAgZ19vYmplY3RfdW5yZWYoc2V0KTsKICAgICByZXR1cm4gdGFyZ2V0ID8gQWNj ZXNzaWJpbGl0eVVJRWxlbWVudCh0YXJnZXQpIDogMDsKIH0KIApJbmRleDogVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9h dGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAJKHJldmlzaW9uIDEzNzEyNCkKKysrIFRv b2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVs ZW1lbnRBdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODEsOCArMzgxLDI2IEBAIFBhc3NSZWZQ dHI8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNjZXMKIAogUGFzc1JlZlB0cjxBY2Nlc3NpYmls aXR5VUlFbGVtZW50PiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojp0aXRsZVVJRWxlbWVudCgpCiB7 Ci0gICAgLy8gRklYTUU6IGltcGxlbWVudAotICAgIHJldHVybiAwOworICAgIGlmICghbV9lbGVt ZW50KQorICAgICAgICByZXR1cm4gMDsKKworICAgIEF0a1JlbGF0aW9uU2V0KiBzZXQgPSBhdGtf b2JqZWN0X3JlZl9yZWxhdGlvbl9zZXQoQVRLX09CSkVDVChtX2VsZW1lbnQpKTsKKyAgICBpZiAo IXNldCkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBBdGtPYmplY3QqIHRhcmdldCA9IDA7Cisg ICAgaW50IGNvdW50ID0gYXRrX3JlbGF0aW9uX3NldF9nZXRfbl9yZWxhdGlvbnMoc2V0KTsKKyAg ICBmb3IgKGludCBpID0gMDsgaSA8IGNvdW50OyBpKyspIHsKKyAgICAgICAgQXRrUmVsYXRpb24q IHJlbGF0aW9uID0gYXRrX3JlbGF0aW9uX3NldF9nZXRfcmVsYXRpb24oc2V0LCBpKTsKKyAgICAg ICAgaWYgKGF0a19yZWxhdGlvbl9nZXRfcmVsYXRpb25fdHlwZShyZWxhdGlvbikgPT0gQVRLX1JF TEFUSU9OX0xBQkVMTEVEX0JZKSB7CisgICAgICAgICAgICBHUHRyQXJyYXkqIHRhcmdldExpc3Qg PSBhdGtfcmVsYXRpb25fZ2V0X3RhcmdldChyZWxhdGlvbik7CisgICAgICAgICAgICBpZiAodGFy Z2V0TGlzdC0+bGVuKQorICAgICAgICAgICAgICAgIHRhcmdldCA9IHN0YXRpY19jYXN0PEF0a09i amVjdCo+KGdfcHRyX2FycmF5X2luZGV4KHRhcmdldExpc3QsIDApKTsKKyAgICAgICAgfQorICAg IH0KKworICAgIGdfb2JqZWN0X3VucmVmKHNldCk7CisgICAgcmV0dXJuIHRhcmdldCA/IEFjY2Vz c2liaWxpdHlVSUVsZW1lbnQ6OmNyZWF0ZSh0YXJnZXQpIDogMDsKIH0KIAogUGFzc1JlZlB0cjxB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50PiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpwYXJlbnRFbGVt ZW50KCkK