102908 2012-11-21 02:29:06 -0800 Make TiledBackingStore::adjustForContentsRect() handle the case when a bound rect does not contain a cover rect. 2014-02-05 11:05:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 102891 1 dongseong.hwang dongseong.hwang kenneth oldest_to_newest 772686 0 dongseong.hwang 2012-11-21 02:29:06 -0800 adjustForContentsRect() expects a bound rect to cover a cover rect. However, when TiledBackingStore is used by CoordinatedGraphicsLayer, this expectation is wrong, which r134048 clarified. adjustForContentsRect() does not yet handle the case when one side of the cover rect is longer than the bound rect. This patch makes the method handle the case. 772692 1 175387 dongseong.hwang 2012-11-21 02:34:08 -0800 Created attachment 175387 Patch 772693 2 dongseong.hwang 2012-11-21 02:34:46 -0800 r134048 is Bug 101656. It is a follow-up patch of r134048. 772700 3 175389 dongseong.hwang 2012-11-21 02:42:18 -0800 Created attachment 175389 Patch 976906 4 175389 andersca 2014-02-05 11:05:21 -0800 Comment on attachment 175389 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 175387 2012-11-21 02:34:08 -0800 2012-11-21 02:42:15 -0800 Patch bug-102908-20121121193155.patch text/plain 2251 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzJiNTc3NTUxNTkzYjZk OGI5MjJkODg4YzExNzhlMzhhZDJiYzU2NC4uZjc0YjJlYTVmOGQxYjk0YzMyMjM2ZmFhOGE2ZGE3 NTgzZjJiMzk4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTExLTIxICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIE1ha2UgVGls ZWRCYWNraW5nU3RvcmU6OmFkanVzdEZvckNvbnRlbnRzUmVjdCgpIGhhbmRsZSB0aGUgY2FzZSB3 aGVuIGEgYm91bmQgcmVjdCBkb2VzIG5vdCBjb250YWluIGEgY292ZXIgcmVjdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjkwOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGFkanVzdEZvckNvbnRlbnRz UmVjdCgpIGV4cGVjdHMgYSBib3VuZCByZWN0IHRvIGNvdmVyIGEgY292ZXIgcmVjdC4gSG93ZXZl ciwKKyAgICAgICAgd2hlbiBUaWxlZEJhY2tpbmdTdG9yZSBpcyB1c2VkIGJ5IENvb3JkaW5hdGVk R3JhcGhpY3NMYXllciwgdGhpcyBleHBlY3RhdGlvbiBpcworICAgICAgICB3cm9uZywgd2hpY2gg cjEzNDA0OCBjbGFyaWZpZWQuIEFsdGhvdWdoIHIxMzQwNDggYW1lbmRlZCBUaWxlZEJhY2tpbmdT dG9yZSBmb3IKKyAgICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3MsIGFkanVzdEZvckNvbnRlbnRz UmVjdCgpIGRvZXMgbm90IHlldCBoYW5kbGUgdGhlIGNhc2Ugd2hlbgorICAgICAgICBvbmUgc2lk ZSBvZiB0aGUgY292ZXIgcmVjdCBpcyBsb25nZXIgdGhhbiB0aGUgYm91bmQgcmVjdCdzLiBUaGlz IHBhdGNoIG1ha2VzIHRoZQorICAgICAgICBtZXRob2QgaGFuZGxlIHRoZSBjYXNlLgorCisgICAg ICAgIENoYW5naW5nIGNhY2hlIHBvbGljeSBpcyBub3QgdGVzdGFibGUgaW4gbGF5b3V0IHRlc3Rz LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VGlsZWRCYWNraW5nU3RvcmU6OmFkanVzdEZvckNvbnRlbnRzUmVj dCk6CisKKzIwMTItMTEtMjEgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CisKICAgICAgICAgUkVHUkVTU0lPTihyMTM1MjEyKTogRml4IGNyYXNoIGR1ZSB0byBhbiBp bmZpbml0ZSByZWN0LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAyODkxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAppbmRleCA0NWJiZGZmYzNiOGRhYjdmNDhmODE5ZTk5 N2FiNWZkYjBjZDU4NjU5Li5jN2JjZjZlMmI5OGM2NzE0ODQxNWQxYmI4ODk1M2Y1ODIzYWU1MjEx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tp bmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRC YWNraW5nU3RvcmUuY3BwCkBAIC0zNDcsNiArMzQ3LDEyIEBAIHZvaWQgVGlsZWRCYWNraW5nU3Rv cmU6OmFkanVzdEZvckNvbnRlbnRzUmVjdChJbnRSZWN0JiByZWN0KSBjb25zdAogICAgICAgICBy ZXR1cm47CiAgICAgfQogCisgICAgLy8gV2UgZG9uJ3QgbmVlZCB0byBtb3ZlIHRoZSByZWN0IGJl Y2F1c2UgYmVsb3cgY29kZSBtb3ZlcyB0aGUgcmVjdCBwcm9wZXJseS4KKyAgICBpZiAoY2FuZGlk YXRlU2l6ZS53aWR0aCgpID4gYm91bmRzLndpZHRoKCkpCisgICAgICAgIHJlY3Quc2V0V2lkdGgo Ym91bmRzLndpZHRoKCkpOworICAgIGlmIChjYW5kaWRhdGVTaXplLmhlaWdodCgpID4gYm91bmRz LmhlaWdodCgpKQorICAgICAgICByZWN0LnNldEhlaWdodChib3VuZHMuaGVpZ2h0KCkpOworCiAg ICAgLy8gV2Ugd2lsbCB0cnkgdG8ga2VlcCB0aGUgY292ZXIgYW5kIGtlZXAgcmVjdCB0aGUgc2Ft ZSBzaXplIGF0IGFsbCB0aW1lLCB3aGljaAogICAgIC8vIG1pZ2h0IG5vdCBiZSB0aGUgY2FzZSB3 aGVuIGF0IHRoZSBjb250ZW50IGVkZ2VzLgogCg== 175389 2012-11-21 02:42:18 -0800 2014-02-05 11:05:20 -0800 Patch bug-102908-20121121194005.patch text/plain 2848 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA2NThmZDE3MWU1Yzk5 MjZmODYwYTczZDRkMWJmZDAyMTkzZjdjZC4uYTI3ZjNkZmExM2RlZTllYmMzODJkMWFhNWUxNmQy ODVjMzc5NDY5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTIxICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIE1ha2UgVGls ZWRCYWNraW5nU3RvcmU6OmFkanVzdEZvckNvbnRlbnRzUmVjdCgpIGhhbmRsZSB0aGUgY2FzZSB3 aGVuIGEgYm91bmQgcmVjdCBkb2VzIG5vdCBjb250YWluIGEgY292ZXIgcmVjdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjkwOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGFkanVzdEZvckNvbnRlbnRz UmVjdCgpIGV4cGVjdHMgYSBib3VuZCByZWN0IHRvIGNvdmVyIGEgY292ZXIgcmVjdC4gSG93ZXZl ciwKKyAgICAgICAgd2hlbiBUaWxlZEJhY2tpbmdTdG9yZSBpcyB1c2VkIGJ5IENvb3JkaW5hdGVk R3JhcGhpY3NMYXllciwgdGhpcyBleHBlY3RhdGlvbiBpcworICAgICAgICB3cm9uZywgd2hpY2gg cjEzNDA0OCBjbGFyaWZpZWQuIEFsdGhvdWdoIHIxMzQwNDggYW1lbmRlZCBUaWxlZEJhY2tpbmdT dG9yZSBmb3IKKyAgICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3MsIGFkanVzdEZvckNvbnRlbnRz UmVjdCgpIGRvZXMgbm90IHlldCBoYW5kbGUgdGhlIGNhc2Ugd2hlbgorICAgICAgICBvbmUgc2lk ZSBvZiB0aGUgY292ZXIgcmVjdCBpcyBsb25nZXIgdGhhbiB0aGUgYm91bmQgcmVjdCdzLiBUaGlz IHBhdGNoIG1ha2VzIHRoZQorICAgICAgICBtZXRob2QgaGFuZGxlIHRoZSBjYXNlLgorCisgICAg ICAgIENoYW5naW5nIGNhY2hlIHBvbGljeSBpcyBub3QgdGVzdGFibGUgaW4gbGF5b3V0IHRlc3Rz LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VGlsZWRCYWNraW5nU3RvcmU6OmFkanVzdEZvckNvbnRlbnRzUmVj dCk6CisKIDIwMTItMTEtMjAgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFtWOF0gUmVtb3ZlIHY4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q29uc3RydWN0 b3IuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxl ZEJhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxl ZEJhY2tpbmdTdG9yZS5jcHAKaW5kZXggZmNlYWRhYTg0M2I0NzI4OWMyZDNkODEwNjQyZjZiOGM3 MDlhOTE4NS4uYzdiY2Y2ZTJiOThjNjcxNDg0MTVkMWJiODg5NTNmNTgyM2FlNTIxMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0 b3JlLmNwcApAQCAtMzQ3LDYgKzM0NywxMiBAQCB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjphZGp1 c3RGb3JDb250ZW50c1JlY3QoSW50UmVjdCYgcmVjdCkgY29uc3QKICAgICAgICAgcmV0dXJuOwog ICAgIH0KIAorICAgIC8vIFdlIGRvbid0IG5lZWQgdG8gbW92ZSB0aGUgcmVjdCBiZWNhdXNlIGJl bG93IGNvZGUgbW92ZXMgdGhlIHJlY3QgcHJvcGVybHkuCisgICAgaWYgKGNhbmRpZGF0ZVNpemUu d2lkdGgoKSA+IGJvdW5kcy53aWR0aCgpKQorICAgICAgICByZWN0LnNldFdpZHRoKGJvdW5kcy53 aWR0aCgpKTsKKyAgICBpZiAoY2FuZGlkYXRlU2l6ZS5oZWlnaHQoKSA+IGJvdW5kcy5oZWlnaHQo KSkKKyAgICAgICAgcmVjdC5zZXRIZWlnaHQoYm91bmRzLmhlaWdodCgpKTsKKwogICAgIC8vIFdl IHdpbGwgdHJ5IHRvIGtlZXAgdGhlIGNvdmVyIGFuZCBrZWVwIHJlY3QgdGhlIHNhbWUgc2l6ZSBh dCBhbGwgdGltZSwgd2hpY2gKICAgICAvLyBtaWdodCBub3QgYmUgdGhlIGNhc2Ugd2hlbiBhdCB0 aGUgY29udGVudCBlZGdlcy4KIApAQCAtMzYzLDEwICszNjksMTQgQEAgdm9pZCBUaWxlZEJhY2tp bmdTdG9yZTo6YWRqdXN0Rm9yQ29udGVudHNSZWN0KEludFJlY3QmIHJlY3QpIGNvbnN0CiAgICAg Ly8gb3Bwb3NpdGUgZGlyZWN0aW9ucy4KICAgICBpbnQgcGl4ZWxzQ292ZXJlZCA9IGNhbmRpZGF0 ZVNpemUud2lkdGgoKSAqIGNhbmRpZGF0ZVNpemUuaGVpZ2h0KCk7CiAKLSAgICBpZiAocmVjdC53 aWR0aCgpICE9IGNhbmRpZGF0ZVNpemUud2lkdGgoKSkKKyAgICBpZiAocmVjdC53aWR0aCgpICE9 IGNhbmRpZGF0ZVNpemUud2lkdGgoKSkgeworICAgICAgICBBU1NFUlQoIXJlY3Qud2lkdGgoKSk7 CiAgICAgICAgIHJlY3QuaW5mbGF0ZVkoKChwaXhlbHNDb3ZlcmVkIC8gcmVjdC53aWR0aCgpKSAt IHJlY3QuaGVpZ2h0KCkpIC8gMik7Ci0gICAgaWYgKHJlY3QuaGVpZ2h0KCkgIT0gY2FuZGlkYXRl U2l6ZS5oZWlnaHQoKSkKKyAgICB9CisgICAgaWYgKHJlY3QuaGVpZ2h0KCkgIT0gY2FuZGlkYXRl U2l6ZS5oZWlnaHQoKSkgeworICAgICAgICBBU1NFUlQoIXJlY3QuaGVpZ2h0KCkpOwogICAgICAg ICByZWN0LmluZmxhdGVYKCgocGl4ZWxzQ292ZXJlZCAvIHJlY3QuaGVpZ2h0KCkpIC0gcmVjdC53 aWR0aCgpKSAvIDIpOworICAgIH0KIAogICAgIHJlY3QuaW50ZXJzZWN0KGJvdW5kcyk7CiB9Cg==