102871 2012-11-20 21:41:25 -0800 Fix the ARM traditional build after r135330 2012-11-23 07:33:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 74040 102662 1 ossy gaborb barraclough fpizlo gaborb galpeter loki ossy rgabor sergio.martins webkit.review.bot zherczeg oldest_to_newest 772451 0 ossy 2012-11-20 21:41:25 -0800 In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:31:0: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In static member function 'static JSC::CodeLocationLabel JSC::RepatchBuffer::startOfBranchPtrWithPatchOnRegister(JSC::CodeLocationDataLabelPtr)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:146:16: error: 'startOfBranchPtrWithPatchOnRegister' is not a member of 'JSC::MacroAssembler' /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In static member function 'static JSC::CodeLocationLabel JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatchOnAddress(JSC::CodeLocationDataLabelPtr)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:151:16: error: 'startOfPatchableBranchPtrWithPatchOnAddress' is not a member of 'JSC::MacroAssembler' In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:31:0: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In member function 'void JSC::RepatchBuffer::revertJumpReplacementToBranchPtrWithPatch(JSC::CodeLocationLabel, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, void*)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:164:9: error: 'revertJumpReplacementToBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler' In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:47:0: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In static member function 'static JSC::CodeLocationLabel JSC::RepatchBuffer::startOfBranchPtrWithPatchOnRegister(JSC::CodeLocationDataLabelPtr)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:146:16: error: 'startOfBranchPtrWithPatchOnRegister' is not a member of 'JSC::MacroAssembler' /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In static member function 'static JSC::CodeLocationLabel JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatchOnAddress(JSC::CodeLocationDataLabelPtr)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:151:16: error: 'startOfPatchableBranchPtrWithPatchOnAddress' is not a member of 'JSC::MacroAssembler' In file included from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:47:0: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h: In member function 'void JSC::RepatchBuffer::revertJumpReplacementToBranchPtrWithPatch(JSC::CodeLocationLabel, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, void*)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/assembler/RepatchBuffer.h:164:9: error: 'revertJumpReplacementToBranchPtrWithPatch' is not a member of 'JSC::MacroAssembler' make[3]: *** [obj/release/bytecode/CallLinkInfo.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: *** [obj/release/bytecode/CodeBlock.o] Error 1 772888 1 ossy 2012-11-21 06:33:22 -0800 Gábor is working on it. 773932 2 sergio.martins 2012-11-22 07:07:18 -0800 Blocks 74040. Please add as blocker. 774526 3 175801 gaborb 2012-11-23 07:02:14 -0800 Created attachment 175801 Fix 774531 4 175801 zherczeg 2012-11-23 07:08:23 -0800 Comment on attachment 175801 Fix r=me 774549 5 175801 ossy 2012-11-23 07:33:30 -0800 Comment on attachment 175801 Fix Clearing flags on attachment: 175801 Committed r135610: <http://trac.webkit.org/changeset/135610> 774550 6 ossy 2012-11-23 07:33:36 -0800 All reviewed patches have been landed. Closing bug. 175801 2012-11-23 07:02:14 -0800 2012-11-23 07:33:30 -0800 Fix 2012-11-23-armbuildfixv3-changelog.patch text/plain 3107 gaborb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFkMWU0MjEuLmUyNzdhMmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTIzICBHYWJvciBCYWxsYWJh cyAgPGdhYm9yYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgRml4IHRoZSBBUk0gdHJhZGl0 aW9uYWwgYnVpbGQgYWZ0ZXIgcjEzNTMzMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAyODcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkZWQgbWlzc2luZyBmdW5jdGlvbmFsaXR5IHRvIHRyYWRpdGlv bmFsIEFSTSBhcmNoaXRlY3R1cmUuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvQVJNQXNzZW1ibGVy Lmg6CisgICAgICAgIChKU0M6OkFSTUFzc2VtYmxlcjo6cmV2ZXJ0SnVtcCk6CisgICAgICAgIChB Uk1Bc3NlbWJsZXIpOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oOgor ICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlckFSTTo6c3RhcnRPZlBhdGNoYWJsZUJyYW5jaFB0 cldpdGhQYXRjaE9uQWRkcmVzcyk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpz dGFydE9mQnJhbmNoUHRyV2l0aFBhdGNoT25SZWdpc3Rlcik6CisgICAgICAgIChNYWNyb0Fzc2Vt YmxlckFSTSk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpyZXZlcnRKdW1wUmVw bGFjZW1lbnRUb0JyYW5jaFB0cldpdGhQYXRjaCk6CisKIDIwMTItMTEtMTYgIFl1cnkgU2VtaWto YXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWVtb3J5IGluc3RydW1lbnRh dGlvbjogZXh0cmFjdCBNZW1vcnlPYmplY3RJbmZvIGRlY2xhcmF0aW9uIGludG8gYSBzZXBhcmF0 ZSBmaWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFz c2VtYmxlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIu aAppbmRleCAzOGQwYzVlLi5lYmFiNDZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKQEAgLTQwMiw2ICs0MDIsMTMgQEAgbmFtZXNwYWNlIEpT QyB7CiAgICAgICAgICAgICBlbWl0SW5zdHJ1Y3Rpb24odG9BUk1Xb3JkKGNjKSB8IE1PViB8IFNl dENvbmRpdGlvbmFsQ29kZXMsIHJkLCBBUk1SZWdpc3RlcnM6OnIwLCBvcDIpOwogICAgICAgICB9 CiAKKyAgICAgICAgc3RhdGljIHZvaWQgcmV2ZXJ0SnVtcCh2b2lkKiBpbnN0cnVjdGlvblN0YXJ0 LCBSZWdpc3RlcklEIHJkLCBBUk1Xb3JkIGltbSkKKyAgICAgICAgeworICAgICAgICAgICAgQVJN V29yZCogaW5zbiA9IHJlaW50ZXJwcmV0X2Nhc3Q8QVJNV29yZCo+KGluc3RydWN0aW9uU3RhcnQp OworICAgICAgICAgICAgQVJNV29yZCogYWRkcmVzcyA9IGdldExkckltbUFkZHJlc3MoaW5zbik7 CisgICAgICAgICAgICAqYWRkcmVzcyA9IGltbTsKKyAgICAgICAgfQorCiAgICAgICAgIHZvaWQg YmljKGludCByZCwgaW50IHJuLCBBUk1Xb3JkIG9wMiwgQ29uZGl0aW9uIGNjID0gQUwpCiAgICAg ICAgIHsKICAgICAgICAgICAgIGVtaXRJbnN0cnVjdGlvbih0b0FSTVdvcmQoY2MpIHwgQklDLCBy ZCwgcm4sIG9wMik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyQVJNLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyQVJNLmgKaW5kZXggMGViZGJkYS4uOWM3N2U5MyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaApAQCAtMTI2 OCwxMiArMTI2OCwyMiBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgYm9vbCBjYW5KdW1wUmVwbGFj ZVBhdGNoYWJsZUJyYW5jaFB0cldpdGhQYXRjaCgpIHsgcmV0dXJuIGZhbHNlOyB9CiAKLSAgICBz dGF0aWMgQ29kZUxvY2F0aW9uTGFiZWwgc3RhcnRPZlBhdGNoYWJsZUJyYW5jaFB0cldpdGhQYXRj aChDb2RlTG9jYXRpb25EYXRhTGFiZWxQdHIgbGFiZWwpCisgICAgc3RhdGljIENvZGVMb2NhdGlv bkxhYmVsIHN0YXJ0T2ZQYXRjaGFibGVCcmFuY2hQdHJXaXRoUGF0Y2hPbkFkZHJlc3MoQ29kZUxv Y2F0aW9uRGF0YUxhYmVsUHRyKQogICAgIHsKICAgICAgICAgVU5SRUFDSEFCTEVfRk9SX1BMQVRG T1JNKCk7CiAgICAgICAgIHJldHVybiBDb2RlTG9jYXRpb25MYWJlbCgpOwogICAgIH0KIAorICAg IHN0YXRpYyBDb2RlTG9jYXRpb25MYWJlbCBzdGFydE9mQnJhbmNoUHRyV2l0aFBhdGNoT25SZWdp c3RlcihDb2RlTG9jYXRpb25EYXRhTGFiZWxQdHIgbGFiZWwpCisgICAgeworICAgICAgICByZXR1 cm4gbGFiZWwubGFiZWxBdE9mZnNldCgwKTsKKyAgICB9CisKKyAgICBzdGF0aWMgdm9pZCByZXZl cnRKdW1wUmVwbGFjZW1lbnRUb0JyYW5jaFB0cldpdGhQYXRjaChDb2RlTG9jYXRpb25MYWJlbCBp bnN0cnVjdGlvblN0YXJ0LCBSZWdpc3RlcklEIHJlZywgdm9pZCogaW5pdGlhbFZhbHVlKQorICAg IHsKKyAgICAgICAgQVJNQXNzZW1ibGVyOjpyZXZlcnRKdW1wKGluc3RydWN0aW9uU3RhcnQuZGF0 YUxvY2F0aW9uKCksIHJlZywgcmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KGluaXRpYWxWYWx1 ZSkgJiAweGZmZmYpOworICAgIH0KKwogICAgIHN0YXRpYyB2b2lkIHJldmVydEp1bXBSZXBsYWNl bWVudFRvUGF0Y2hhYmxlQnJhbmNoUHRyV2l0aFBhdGNoKENvZGVMb2NhdGlvbkxhYmVsIGluc3Ry dWN0aW9uU3RhcnQsIEFkZHJlc3MsIHZvaWQqIGluaXRpYWxWYWx1ZSkKICAgICB7CiAgICAgICAg IFVOUkVBQ0hBQkxFX0ZPUl9QTEFURk9STSgpOwo=