102848 2012-11-20 16:12:27 -0800 REGRESSION(r131106): magnitude-perf.js calls bind on undefined 2012-11-20 17:11:48 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth ojan simonjam tony tonyg webkit.review.bot oldest_to_newest 772257 0 rniwa 2012-11-20 16:12:27 -0800 http://trac.webkit.org/changeset/131106/trunk/LayoutTests/resources/magnitude-perf.js replaced var nowFunction = window.performance.now || Date.now; with var nowFunction = window.performance.now.bind(window.performance) || Date.now; Calling bind on undefined object will results in an exception being thrown and "|| Date.now" is useless. 772259 1 175298 rniwa 2012-11-20 16:13:32 -0800 Created attachment 175298 Fixes the regression 772274 2 175298 ojan 2012-11-20 16:34:11 -0800 Comment on attachment 175298 Fixes the regression I don't see why we need to call bind at all. Why can't this just be: var nowFunction = window.performance.now || Date.now; The original patch that added the bind call doesn't explain this. 772295 3 simonjam 2012-11-20 16:50:58 -0800 (In reply to comment #2) > (From update of attachment 175298 [details]) > I don't see why we need to call bind at all. Why can't this just be: > var nowFunction = window.performance.now || Date.now; > > The original patch that added the bind call doesn't explain this. You get a TypeError: Illegal invocation without it. You can test it in the console. Try storing now in a variable and then invoke that variable. I don't fully understand why. I think this answer might explain it: http://stackoverflow.com/questions/1007340/javascript-function-aliasing-doesnt-seem-to-work 772299 4 ojan 2012-11-20 16:52:44 -0800 It seems wrong to me that you can alias Date.now but not window.performance.now. 772309 5 simonjam 2012-11-20 16:59:01 -0800 (In reply to comment #4) > It seems wrong to me that you can alias Date.now but not window.performance.now. performance.now() _does_ vary depending on which window you call it on. It measures the time since that window object started navigating. 772311 6 ojan 2012-11-20 17:01:40 -0800 oic. Sad. I wonder if we can make aliasing of these things work. Probably not. :( 772316 7 175298 webkit.review.bot 2012-11-20 17:11:44 -0800 Comment on attachment 175298 Fixes the regression Clearing flags on attachment: 175298 Committed r135335: <http://trac.webkit.org/changeset/135335> 772317 8 webkit.review.bot 2012-11-20 17:11:48 -0800 All reviewed patches have been landed. Closing bug. 175298 2012-11-20 16:13:32 -0800 2012-11-20 17:11:44 -0800 Fixes the regression bug-102848-20121120161120.patch text/plain 1393 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzNTMyNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTIwICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzMTEwNik6IG1hZ25pdHVk ZS1wZXJmLmpzIGNhbGxzIGJpbmQgb24gdW5kZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI4NDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB0aGUgZXhpc3RlbmNlIG9mIHBlcmZvcm1h bmNlLm5vdyBiZWZvcmUgY2FsbGluZyBiaW5kIG9uIGl0LgorCisgICAgICAgICogcmVzb3VyY2Vz L21hZ25pdHVkZS1wZXJmLmpzOgorICAgICAgICAoTWFnbml0dWRlLl9ydW5JdGVyYXRpb24pOgor CiAyMDEyLTExLTIwICBCZWFyIFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNvbT4KIAogICAgICAg ICBbQ1NTIEV4Y2x1c2lvbnNdIFN1cHBvcnQgb3V0c2lkZS1zaGFwZSB2YWx1ZSBvbiBzaGFwZS1p bnNpZGUKSW5kZXg6IExheW91dFRlc3RzL3Jlc291cmNlcy9tYWduaXR1ZGUtcGVyZi5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9yZXNvdXJjZXMvbWFnbml0dWRlLXBlcmYuanMJKHJldmlz aW9uIDEzNTMyNSkKKysrIExheW91dFRlc3RzL3Jlc291cmNlcy9tYWduaXR1ZGUtcGVyZi5qcwko d29ya2luZyBjb3B5KQpAQCAtMjAxLDcgKzIwMSw3IEBAIE1hZ25pdHVkZS5fcnVuSXRlcmF0aW9u ID0gZnVuY3Rpb24oc2V0dXAKICAgICBNYWduaXR1ZGUuX2RlYnVnKGRlYnVnU3RyKTsKIAogICAg IHZhciBpdGVyYXRpb25zID0gMDsKLSAgICB2YXIgbm93RnVuY3Rpb24gPSB3aW5kb3cucGVyZm9y bWFuY2Uubm93LmJpbmQod2luZG93LnBlcmZvcm1hbmNlKSB8fCBEYXRlLm5vdzsKKyAgICB2YXIg bm93RnVuY3Rpb24gPSB3aW5kb3cucGVyZm9ybWFuY2UgJiYgd2luZG93LnBlcmZvcm1hbmNlLm5v dyA/IHdpbmRvdy5wZXJmb3JtYW5jZS5ub3cuYmluZCh3aW5kb3cucGVyZm9ybWFuY2UpIDogRGF0 ZS5ub3c7CiAgICAgdmFyIHN0YXJ0ID0gbm93RnVuY3Rpb24oKTsKICAgICB3aGlsZSAobm93RnVu Y3Rpb24oKSAtIHN0YXJ0IDwgTWFnbml0dWRlLm1pbGxpc2Vjb25kc1Blckl0ZXJhdGlvbikgewog ICAgICAgICB0ZXN0KG1hZ25pdHVkZSk7Cg==