102826 2012-11-20 10:50:24 -0800 [CSS Regions] Elements using transforms are not repainted correctly when rendered in a region 2012-11-28 13:39:10 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 1 achicu achicu donggwan.kim eric hyatt mibalan mihnea ojan WebkitBugTracker webkit.review.bot oldest_to_newest 772006 0 achicu 2012-11-20 10:50:24 -0800 Elements with RenderLayers do not repaint correctly. See the attached test case. 772012 1 175246 achicu 2012-11-20 10:51:54 -0800 Created attachment 175246 test case 772210 2 achicu 2012-11-20 15:18:10 -0800 There are two separate issues in here: 1. When the <p> element is first created it will trigger a composited layer. Composited layers are disabled on the elements inside the flow, but when the style is first set on the just created RenderObject the flag "inRenderFlowThread" is not set yet. I've added https://bugs.webkit.org/show_bug.cgi?id=102839 to fix it. 2. When a composited layer is created, then the whole page becomes a composited layer too. That means that the parent repaint container will always be the page. Our check for the parent RenderFlowThread will always fail in this case because we already found a repaint container. This patch will fix that case. 772211 3 175289 achicu 2012-11-20 15:18:34 -0800 Created attachment 175289 Patch V1 777215 4 175289 hyatt 2012-11-27 14:14:46 -0800 Comment on attachment 175289 Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=175289&action=review r=me > Source/WebCore/rendering/RenderObject.cpp:1293 > - // Return the flow thread as a repaint container in order to create a chokepoint that allows us to change > + // Return the flow thread as a repaint container in order to create a checkpoint that allows us to change Not sure why you're changing this. "chokepoint" is a much more accurate term to describe this than "checkpoint" 777226 5 175289 webkit.review.bot 2012-11-27 14:24:12 -0800 Comment on attachment 175289 Patch V1 Clearing flags on attachment: 175289 Committed r135921: <http://trac.webkit.org/changeset/135921> 777227 6 webkit.review.bot 2012-11-27 14:24:16 -0800 All reviewed patches have been landed. Closing bug. 777261 7 achicu 2012-11-27 15:09:22 -0800 (In reply to comment #4) > (From update of attachment 175289 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175289&action=review > > r=me > > > Source/WebCore/rendering/RenderObject.cpp:1293 > > - // Return the flow thread as a repaint container in order to create a chokepoint that allows us to change > > + // Return the flow thread as a repaint container in order to create a checkpoint that allows us to change > > Not sure why you're changing this. "chokepoint" is a much more accurate term to describe this than "checkpoint" Hm, right. My editor suggested the correction, so I just accepted it. The patch already landed, but will make a simple unreviewed patch for it. 778285 8 176562 achicu 2012-11-28 13:39:10 -0800 Created attachment 176562 Follow up patch Follow up update after the original patch was landed by commit queue. Landed manually in http://trac.webkit.org/changeset/136054. 175246 2012-11-20 10:51:54 -0800 2012-11-20 10:51:54 -0800 test case regions.html text/html 2027 achicu PHN0eWxlPgoKI2NvbnRlbnQgewoJLXdlYmtpdC1mbG93LWludG86IGNvbnRlbnQtZmxvdzsKfQoK LnJlZ2lvbiB7Cgktd2Via2l0LWZsb3ctZnJvbTogY29udGVudC1mbG93OwoJYm9yZGVyOiAxcHgg c29saWQgcmVkOwoJbWFyZ2luOiAxMHB4OwoJcGFkZGluZzogMTBweDsKCWhlaWdodDogNjBweDsK fQoKLmluZGVudCB7CglwYWRkaW5nLWxlZnQ6IDVweDsKCW1hcmdpbi1sZWZ0OiA1cHg7Cgktd2Vi a2l0LXRyYW5zZm9ybTogcm90YXRlKDEwZGVnKTsKCS13ZWJraXQtdHJhbnNpdGlvbjogLXdlYmtp dC10cmFuc2Zvcm0gMXMgbGluZWFyOwp9CgouaW5kZW50OmhvdmVyIHsKCS13ZWJraXQtdHJhbnNm b3JtOiByb3RhdGUoMGRlZyk7Cn0KCi5pbmRlbnQuYmx1ZSB7Cglib3JkZXItbGVmdDogMnB4IHNv bGlkIGJsdWU7Cn0KCi5icmVhayB7Cgktd2Via2l0LWJyZWFrLWFmdGVyOiByZWdpb247Cn0KCnAg eyBtYXJnaW4gOiAwO30KPC9zdHlsZT4KCjxkaXYgaWQ9ImNvbnRlbnQiPgoKPHA+CkxvcmVtIGlw c3VtIGRvbG9yIHNpdCBhbWV0LCBjb25zZWN0ZXR1ciBhZGlwaXNjaW5nIGVsaXQuIERvbmVjIG5v biBsYWN1cyBjb25kaW1lbnR1bSBlcm9zIGFkaXBpc2NpbmcgbGFvcmVldCB1bGxhbWNvcnBlciBp biBwdXJ1cy4gTnVuYyBkaWN0dW0gY29tbW9kbyBtYWxlc3VhZGEuIER1aXMgdGluY2lkdW50IGZl cm1lbnR1bSBsZW8sIHNpdCBhbWV0IGhlbmRyZXJpdCBkb2xvciBsb2JvcnRpcyBldS4gTWF1cmlz IGNvbmRpbWVudHVtIHNlbSBvZGlvLCBuZWMgaW1wZXJkaWV0IHNlbS4gTnVsbGFtIHBoYXJldHJh IHF1YW0gYSBsb3JlbSBmYXVjaWJ1cyB2ZWwgdHJpc3RpcXVlIHRlbGx1cyBmYXVjaWJ1cy4gUGhh c2VsbHVzIGVnZXQgbGliZXJvIHV0IHRvcnRvciB2b2x1dHBhdCBtb2xlc3RpZSBldCBhdCBlbmlt LiBBbGlxdWFtIG1hdXJpcyB0ZWxsdXMsIHNvZGFsZXMgYWNjdW1zYW4gbWFsZXN1YWRhIHV0LCBw ZWxsZW50ZXNxdWUgcHVsdmluYXIgbGVjdHVzLiBOYW0gZXQgdXJuYSB1cm5hLiBQZWxsZW50ZXNx dWUgcGVsbGVudGVzcXVlLCBsZW8gbmVjIGZyaW5naWxsYSBhbGlxdWV0LCBlbmltIGZlbGlzIGNv bnZhbGxpcyB0dXJwaXMsIGF0IGlhY3VsaXMgZXJvcyBlbGl0IGVnZXQgbG9yZW0uIFNlZCBhIHR1 cnBpcyBmZWxpcywgaWQgZmVybWVudHVtIG1pLiBTdXNwZW5kaXNzZSBlZ2V0IGJsYW5kaXQgdHVy cGlzLjwvcD4KCjxkaXYgY2xhc3M9ImJyZWFrIj48L2Rpdj4KPHAgY2xhc3M9ImluZGVudCBibHVl Ij4KVml2YW11cyBudW5jIGxpYmVybywgcG9zdWVyZSBpZCBwcmV0aXVtIGlkLCBpbnRlcmR1bSBp ZCBzZW0uIEluIGlkIG5pYmggYSBpcHN1bSBjb25kaW1lbnR1bSBsdWN0dXMgcXVpcyB2ZWwgdHVy cGlzLiBDbGFzcyBhcHRlbnQgdGFjaXRpIHNvY2lvc3F1IGFkIGxpdG9yYSB0b3JxdWVudCBwZXIg Y29udWJpYSBub3N0cmEsIHBlciBpbmNlcHRvcyBoaW1lbmFlb3MuIFBoYXNlbGx1cyBkaWN0dW0g ZmFjaWxpc2lzIHJpc3VzIGEgdmVuZW5hdGlzLiBOdWxsYW0gcG9ydGEgbWkgbWF0dGlzIG51bmMg ZXVpc21vZCB2ZWhpY3VsYSBwb3J0dGl0b3Igc2VtIHZhcml1cy4KPC9wPgo8ZGl2IGNsYXNzPSJi cmVhayI+PC9kaXY+Cgo8cD4gTWF1cmlzIHNhZ2l0dGlzIGF1Z3VlIHNpdCBhbWV0IHRlbGx1cyBw aGFyZXRyYSBldSB0aW5jaWR1bnQgdmVsaXQgc29sbGljaXR1ZGluLiBNYWVjZW5hcyBsYW9yZWV0 IGVyb3MgcXVpcyB0b3J0b3IgdWxsYW1jb3JwZXIgdXQgdHJpc3RpcXVlIGRpYW0gZ3JhdmlkYS4g Q3VyYWJpdHVyIGxhb3JlZXQsIHRvcnRvciBhYyB0ZW1wdXMgdGVtcG9yLCBuaXNpIG5pc2wgdml2 ZXJyYSByaXN1cywgc2VkIGNvbW1vZG8gb3JjaSBsaWd1bGEgZWdldCB0b3J0b3IuIENyYXMgZXJv cyBvcmNpLCBjb21tb2RvIGVnZXQgdGVtcHVzIHNlZCwgcmhvbmN1cyBlZ2V0IHVybmEuCjwvcD4K CjwvZGl2PgoKPGRpdiBjbGFzcz0icmVnaW9uIj48L2Rpdj4KPGRpdiBjbGFzcz0icmVnaW9uIj48 L2Rpdj4KPGRpdiBjbGFzcz0icmVnaW9uIj48L2Rpdj4= 175289 2012-11-20 15:18:34 -0800 2012-11-27 14:24:12 -0800 Patch V1 bug102826.patch text/plain 6780 achicu ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NjA5NTQwLi4zOTA5ODliIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTEt MjAgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIFtD U1MgUmVnaW9uc10gRWxlbWVudHMgdXNpbmcgdHJhbnNmb3JtcyBhcmUgbm90IHJlcGFpbnRlZCBj b3JyZWN0bHkgd2hlbiByZW5kZXJlZCBpbiBhIHJlZ2lvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyODI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCBmaWxlIHRvIGNoZWNrIGZvciBy ZXBhaW50aW5nIGluc2lkZSBhIFJlbmRlckZsb3dUaHJlYWQgd2hlbiB0aGUgcGFnZSBpcyBpbiBj b21wb3NpdGVkIG1vZGUuCisKKyAgICAgICAgKiBmYXN0L3JlcGFpbnQvcmVnaW9uLXBhaW50aW5n LWluLWNvbXBvc2l0ZWQtdmlldy1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L3JlcGFpbnQvcmVnaW9uLXBhaW50aW5nLWluLWNvbXBvc2l0ZWQtdmlldy5odG1sOiBBZGRlZC4K KwogMjAxMi0xMS0yMCAgSGFucyBNdWxsZXIgIDxobXVsbGVyQGFkb2JlLmNvbT4KIAogICAgICAg ICBbQ1NTIEV4Y2x1c2lvbnNdIHdyaXRpbmctbW9kZTp2ZXJ0aWNhbC1ybCBzaGFwZS1pbnNpZGUg dGVzdHMgYXJlIGluY29ycmVjdGx5IGNvbmZpZ3VyZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvcmVwYWludC9yZWdpb24tcGFpbnRpbmctaW4tY29tcG9zaXRlZC12aWV3LWV4cGVjdGVk Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcmVnaW9uLXBhaW50aW5nLWluLWNvbXBv c2l0ZWQtdmlldy1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAuLjQwNGI1ZTgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQv cmVnaW9uLXBhaW50aW5nLWluLWNvbXBvc2l0ZWQtdmlldy1leHBlY3RlZC5odG1sCkBAIC0wLDAg KzEsMzkgQEAKKzwhZG9jdHlwZSBodG1sPgorPGhlYWQ+Cis8dGl0bGU+VGVzdCBmb3IgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjgyNjwvdGl0bGU+Cis8c3R5bGUg dHlwZT0idGV4dC9jc3MiPgorI3JlZ2lvbjEsICNyZWdpb24yIHsKKyAgICBwb3NpdGlvbjogYWJz b2x1dGU7CisgICAgdG9wOiAwcHg7CisgICAgbGVmdDogMHB4OworICAgIHdpZHRoOiAxMDBweDsK KyAgICBoZWlnaHQ6IDUwcHg7Cit9CisKKyNyZWdpb24xIHsKKyAgICBsZWZ0OiAxMjBweDsKKyAg ICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CisgICAgLyogV2UgbmVlZCBhIGNvbXBvc2l0ZWQgbGF5 ZXIsIHRvIG1ha2UgdGhlIG91dHB1dCAKKyAgICAgICBleGFjdGx5IHRoZSBzYW1lIGFzIHRoZSB0 ZXN0IGZpbGUuICovCisgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKDAsMCwwKTsK K30KKworI3JlZ2lvbjIgeworICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOworfQorCis8L3N0 eWxlPgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9yZXBhaW50LmpzIiB0eXBlPSJ0ZXh0L2phdmFz Y3JpcHQiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0aW9uIHJlcGFpbnRUZXN0KCkKK3sKKyAg ICAvLyBVc2luZyB0aGUgc2FtZSByZXBhaW50IGJlaGF2aW9yLCBzbyB0aGF0IHdlIGdldCB0aGUg c2FtZSByZXBhaW50IGFyZWEuCisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JlZ2lvbjEn KS5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IgPSAnZ3JlZW4nOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+ Cis8Ym9keSBvbmxvYWQ9InJ1blJlcGFpbnRUZXN0KCk7Ij4KKyAgICA8ZGl2IGlkPSJyZWdpb24x Ij48L2Rpdj4KKyAgICA8ZGl2IGlkPSJyZWdpb24yIj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9yZWdpb24tcGFpbnRpbmctaW4t Y29tcG9zaXRlZC12aWV3Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcmVnaW9uLXBh aW50aW5nLWluLWNvbXBvc2l0ZWQtdmlldy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLmQwMjcxMTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3Jl cGFpbnQvcmVnaW9uLXBhaW50aW5nLWluLWNvbXBvc2l0ZWQtdmlldy5odG1sCkBAIC0wLDAgKzEs NTggQEAKKzwhZG9jdHlwZSBodG1sPgorPGhlYWQ+Cis8dGl0bGU+VGVzdCBmb3IgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjgyNjwvdGl0bGU+Cis8c2NyaXB0Pgor ICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgd2luZG93LnRlc3RSdW5uZXIub3Zl cnJpZGVQcmVmZXJlbmNlKCJXZWJLaXRDU1NSZWdpb25zRW5hYmxlZCIsICIxIik7Cis8L3Njcmlw dD4KKzxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CisjY29udGVudCB7CisgICAgLXdlYmtpdC1mbG93 LWludG86IGZsb3cxOworfQorCisjdGFyZ2V0IHsgCisgICAgYmFja2dyb3VuZDogcmVkOyAKKyAg ICB3aWR0aDogMTAwcHg7IAorICAgIGhlaWdodDogNTBweDsKK30KKworI3JlZ2lvbjEsICNyZWdp b24yIHsKKyAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgdG9wOiAwcHg7CisgICAgd2lkdGg6 IDEwMHB4OworICAgIGhlaWdodDogNTBweDsKKyAgICAtd2Via2l0LWZsb3ctZnJvbTogZmxvdzE7 Cit9CisKKyNyZWdpb24xIHsKKyAgICAvKiBNYWtlIHN1cmUgdGhhdCB0aGUgY29udGVudCBvZiB0 aGUgZmlyc3QgcmVnaW9uIHdpbGwgZGlzcGxheSBpbiBhIHRvdGFsbHkKKyAgICAgICBkaWZmZXJl bnQgcGxhY2UgdGhhbiBpdCB3b3VsZCBoYXZlIGJlZW4gZGlzcGxheWVkIGlmIHJlZ2lvbnMgd2Vy ZSBub3QgdXNlZC4gKi8KKyAgICBsZWZ0OiAxMjBweDsKKyAgICAvKiBGb3JjZSB0aGUgY29tcG9z aXRlZCBtb2RlIG9uIHRoZSBjdXJyZW50IHBhZ2UuICovCisgICAgLXdlYmtpdC10cmFuc2Zvcm06 IHRyYW5zbGF0ZTNkKDAsMCwwKTsKK30KKworI3JlZ2lvbjIgeworICAgIGxlZnQ6IDBweDsKKyAg ICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKK30KKworPC9zdHlsZT4KKzxzY3JpcHQgc3JjPSJy ZXNvdXJjZXMvcmVwYWludC5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3NjcmlwdD4KKzxz Y3JpcHQ+CitmdW5jdGlvbiByZXBhaW50VGVzdCgpCit7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3RhcmdldCcpLnN0eWxlLmJhY2tncm91bmRDb2xvciA9ICdncmVlbic7Cit9Cis8L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuUmVwYWludFRlc3QoKTsiPgorICAgIDwh LS0gVGVzdGluZyB0aGF0IHRoZSByZXBhaW50IGdvZXMgdGhyb3VnaCB0aGUgUmVuZGVyUmVnaW9u cyBhbmQgbm90IAorICAgIGRpcmVjdGx5IHRvIHRoZSB2aWV3cG9ydC4gWW91IHNob3VsZCBzZWUg dHdvIGdyZWVuIHJlY3RhbmdsZXMuIC0tPgorICAgIDxkaXYgaWQ9ImNvbnRlbnQiPgorICAgICAg ICA8ZGl2IGlkPSJ0YXJnZXQiPjwvZGl2PgorICAgIDwvZGl2PgorICAgIDxkaXYgaWQ9InJlZ2lv bjEiPjwvZGl2PgorICAgIDxkaXYgaWQ9InJlZ2lvbjIiPjwvZGl2PgorPC9ib2R5PgorPC9odG1s PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDM4ZTNjZmYuLjFmNzRmZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MiBAQAorMjAxMi0xMS0yMCAgQWxleGFuZHJ1IENoaWN1bGl0YSAgPGFjaGljdUBhZG9iZS5jb20+ CisKKyAgICAgICAgW0NTUyBSZWdpb25zXSBFbGVtZW50cyB1c2luZyB0cmFuc2Zvcm1zIGFyZSBu b3QgcmVwYWludGVkIGNvcnJlY3RseSB3aGVuIHJlbmRlcmVkIGluIGEgcmVnaW9uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI4MjYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSBwYWdlIGlz IGNvbXBvc2l0ZWQsIGFsbCB0aGUgZWxlbWVudHMgd2lsbCBoYXZlIGEgY29tcG9zaXRlZCByZXBh aW50IGNvbnRhaW5lci4gSW4gdGhhdCBjYXNlIHdlIHdpbGwKKyAgICAgICAgbmV2ZXIgY2F0Y2gg dGhlIHJlcGFpbnRzIGluIHRoZSBSZW5kZXJGbG93VGhyZWFkLCBidXQgdGhleSB3aWxsIGdvIGRp cmVjdGx5IHRvIHRoZSBSZW5kZXJWaWV3LiAKKyAgICAgICAgVGhlcmUncyBhIHNpbmdsZSBjYXNl IHdoZW4gdGhlIHBhcmVudCBjb21wb3NpdGVkIGxheWVyIG9mIGFuIGVsZW1lbnQgaW5zaWRlIHRo ZSBSZW5kZXJGbG93VGhyZWFkIHdpbGwgZ2V0IAorICAgICAgICBpdHMgb3duIHJlcGFpbnRzLiBU aGF0IGNhc2Ugb25seSBoYXBwZW5zIHdoZW4gdGhlIHBhcmVudCBjb21wb3NpdGVkIGxheWVyIGlz IGFsc28gcGFydCBvZiB0aGUgc2FtZSBmbG93IHRocmVhZC4KKyAgICAgICAgUmlnaHQgbm93IGNv bXBvc2l0aW5nIGlzIGRpc2FibGVkIGZvciBlbGVtZW50cyBpbnNpZGUgdGhlIFJlbmRlckZsb3dU aHJlYWQsIHNvIHRoYXQgY2FzZSBkb2Vzbid0IGV2ZW4gaGFwcGVuIHlldC4KKyAgICAgICAgVGhh dCB3aWxsIGJlIGZpeGVkIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04NDkwMC4KKworICAgICAgICBUZXN0OiBmYXN0L3JlcGFpbnQvcmVnaW9uLXBhaW50aW5nLWlu LWNvbXBvc2l0ZWQtdmlldy5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6Y29udGFpbmVyRm9yUmVwYWlu dCk6CisKIDIwMTItMTEtMjAgIEphbWVzIFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIENvbnNvbGlkYXRlIEZyYW1lTG9hZGVyOjpsb2FkKCkgaW50byBvbmUgZnVu Y3Rpb24gdGFraW5nIGEgRnJhbWVMb2FkUmVxdWVzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyT2JqZWN0LmNwcAppbmRleCAxNWRjZGQwLi43NTRhZWUxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApAQCAtMTI5MCwxMiArMTI5MCwxNSBAQCBSZW5k ZXJMYXllck1vZGVsT2JqZWN0KiBSZW5kZXJPYmplY3Q6OmNvbnRhaW5lckZvclJlcGFpbnQoKSBj b25zdAogI2VuZGlmCiAKICAgICAvLyBJZiB3ZSBoYXZlIGEgZmxvdyB0aHJlYWQsIHRoZW4gd2Ug bmVlZCB0byBkbyBpbmRpdmlkdWFsIHJlcGFpbnRzIHdpdGhpbiB0aGUgUmVuZGVyUmVnaW9ucyBp bnN0ZWFkLgotICAgIC8vIFJldHVybiB0aGUgZmxvdyB0aHJlYWQgYXMgYSByZXBhaW50IGNvbnRh aW5lciBpbiBvcmRlciB0byBjcmVhdGUgYSBjaG9rZXBvaW50IHRoYXQgYWxsb3dzIHVzIHRvIGNo YW5nZQorICAgIC8vIFJldHVybiB0aGUgZmxvdyB0aHJlYWQgYXMgYSByZXBhaW50IGNvbnRhaW5l ciBpbiBvcmRlciB0byBjcmVhdGUgYSBjaGVja3BvaW50IHRoYXQgYWxsb3dzIHVzIHRvIGNoYW5n ZQogICAgIC8vIHJlcGFpbnRpbmcgdG8gZG8gaW5kaXZpZHVhbCByZWdpb24gcmVwYWludHMuCi0g ICAgLy8gRklYTUU6IENvbXBvc2l0ZWQgbGF5ZXJzIGluc2lkZSBhIGZsb3cgdGhyZWFkIHdpbGwg YnlwYXNzIHRoaXMgbWVjaGFuaXNtIGFuZCB3aWxsIG1hbGZ1bmN0aW9uLiBJdCdzIG5vdAotICAg IC8vIGNsZWFyIGhvdyB0byBhZGRyZXNzIHRoaXMgcHJvYmxlbSBmb3IgY29tcG9zaXRlZCBkZXNj ZW5kYW50cyBvZiBhIFJlbmRlckZsb3dUaHJlYWQuCi0gICAgaWYgKCFyZXBhaW50Q29udGFpbmVy ICYmIGluUmVuZGVyRmxvd1RocmVhZCgpKQotICAgICAgICByZXBhaW50Q29udGFpbmVyID0gZW5j bG9zaW5nUmVuZGVyRmxvd1RocmVhZCgpOworICAgIGlmIChpblJlbmRlckZsb3dUaHJlYWQoKSkg eworICAgICAgICBSZW5kZXJGbG93VGhyZWFkKiBwYXJlbnRSZW5kZXJGbG93VGhyZWFkID0gZW5j bG9zaW5nUmVuZGVyRmxvd1RocmVhZCgpOworICAgICAgICAvLyBJZiB3ZSBoYXZlIGFscmVhZHkg Zm91bmQgYSByZXBhaW50IGNvbnRhaW5lciB0aGVuIHdlIHdpbGwgcmVwYWludCBpbnRvIHRoYXQg Y29udGFpbmVyIG9ubHkgaWYgaXQgaXMgcGFydCBvZiB0aGUgc2FtZQorICAgICAgICAvLyBmbG93 IHRocmVhZC4gT3RoZXJ3aXNlIHdlIHdpbGwgbmVlZCB0byBjYXRjaCB0aGUgcmVwYWludCBjYWxs IGFuZCBzZW5kIGl0IHRvIHRoZSBmbG93IHRocmVhZC4KKyAgICAgICAgaWYgKCEocmVwYWludENv bnRhaW5lciAmJiByZXBhaW50Q29udGFpbmVyLT5pblJlbmRlckZsb3dUaHJlYWQoKSAmJiByZXBh aW50Q29udGFpbmVyLT5lbmNsb3NpbmdSZW5kZXJGbG93VGhyZWFkKCkgPT0gcGFyZW50UmVuZGVy Rmxvd1RocmVhZCkpCisgICAgICAgICAgICByZXBhaW50Q29udGFpbmVyID0gcGFyZW50UmVuZGVy Rmxvd1RocmVhZDsKKyAgICB9CiAgICAgcmV0dXJuIHJlcGFpbnRDb250YWluZXI7CiB9CiAK 176562 2012-11-28 13:39:10 -0800 2012-11-28 13:39:10 -0800 Follow up patch bug102826_comment.patch text/plain 1571 achicu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNTgwMWEwLi5kMTYyNzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMTEtMjggIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgor CisgICAgICAgIFtDU1MgUmVnaW9uc10gRWxlbWVudHMgdXNpbmcgdHJhbnNmb3JtcyBhcmUgbm90 IHJlcGFpbnRlZCBjb3JyZWN0bHkgd2hlbiByZW5kZXJlZCBpbiBhIHJlZ2lvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyODI2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KKworICAgICAgICBGb2xsb3cgdXAgdXBkYXRlIG9mIGEg Y29tbWVudCBhZnRlciB0aGUgcGF0Y2ggd2FzIGxhbmRlZCBieSB0aGUgY29tbWl0IHF1ZXVlIGlu IHIxMzU5MjEuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6Y29udGFpbmVyRm9yUmVwYWludCk6CisKIDIwMTIt MTEtMjggIEFudG9uIFZheXZvZCAgPGF2YXl2b2RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFRl eHQgQXV0b3NpemluZzogQ2x1c3RlcnMgc2hvdWxkIHVzZSB3aWR0aCBvZiBMQ0Egb2YgdGhlaXIg dGV4dCBub2RlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9i amVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRl eCA0ZGQ3MGVkLi5hZTVhMDFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcApAQCAtMTI5MCw3ICsxMjkwLDcgQEAgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCogUmVu ZGVyT2JqZWN0Ojpjb250YWluZXJGb3JSZXBhaW50KCkgY29uc3QKICNlbmRpZgogCiAgICAgLy8g SWYgd2UgaGF2ZSBhIGZsb3cgdGhyZWFkLCB0aGVuIHdlIG5lZWQgdG8gZG8gaW5kaXZpZHVhbCBy ZXBhaW50cyB3aXRoaW4gdGhlIFJlbmRlclJlZ2lvbnMgaW5zdGVhZC4KLSAgICAvLyBSZXR1cm4g dGhlIGZsb3cgdGhyZWFkIGFzIGEgcmVwYWludCBjb250YWluZXIgaW4gb3JkZXIgdG8gY3JlYXRl IGEgY2hlY2twb2ludCB0aGF0IGFsbG93cyB1cyB0byBjaGFuZ2UKKyAgICAvLyBSZXR1cm4gdGhl IGZsb3cgdGhyZWFkIGFzIGEgcmVwYWludCBjb250YWluZXIgaW4gb3JkZXIgdG8gY3JlYXRlIGEg Y2hva2Vwb2ludCB0aGF0IGFsbG93cyB1cyB0byBjaGFuZ2UKICAgICAvLyByZXBhaW50aW5nIHRv IGRvIGluZGl2aWR1YWwgcmVnaW9uIHJlcGFpbnRzLgogICAgIGlmIChpblJlbmRlckZsb3dUaHJl YWQoKSkgewogICAgICAgICBSZW5kZXJGbG93VGhyZWFkKiBwYXJlbnRSZW5kZXJGbG93VGhyZWFk ID0gZW5jbG9zaW5nUmVuZGVyRmxvd1RocmVhZCgpOwo=