102687 2012-11-19 06:55:25 -0800 [EFL] GLX detection is broken. 2012-11-21 22:26:36 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 101291 102991 0 kalyan.kondapally webkit-unassigned d-r gyuyoung.kim laszlo.gombos lucas.de.marchi ostap73 rakuco ryuan.choi tmpsantos webkit.review.bot yael oldest_to_newest 770701 0 kalyan.kondapally 2012-11-19 06:55:25 -0800 It seems HAVE_GLX is enabled automatically if WebGL is enabled (in OptionEfl.cmake which is wrong). If WebGL is not enabled than we never enable it. We need to add configure test for GLX and set HAVE_GLX flag appropriately. 771202 1 175076 kalyan.kondapally 2012-11-19 16:46:32 -0800 Created attachment 175076 WIP Patch does the following: Tries to compile some basic GLX code. If the compilation succeeds enables HAVE_GLX flag 771221 2 175076 kalyan.kondapally 2012-11-19 16:56:03 -0800 Comment on attachment 175076 WIP No review flag set yet. 771683 3 175076 rakuco 2012-11-20 02:14:31 -0800 Comment on attachment 175076 WIP View in context: https://bugs.webkit.org/attachment.cgi?id=175076&action=review > Source/cmake/OptionsEfl.cmake:190 > +include(CheckCSourceCompiles) > +include(CheckCXXSourceCompiles) Coding style: our CMake calls are all uppercased. > Source/cmake/OptionsEfl.cmake:200 > +CHECK_C_SOURCE_COMPILES( > +" > +#include <GL/glx.h> > +int main() > +{ > + GLXFBConfig c; > + return 0; > +} > +" > +GLXCOMPILATIONPASSED) Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL). > Source/cmake/OptionsEfl.cmake:203 > + SET(HAVE_GLX 1) This does not seem to be used anywhere. 771767 4 175076 tmpsantos 2012-11-20 05:10:14 -0800 Comment on attachment 175076 WIP View in context: https://bugs.webkit.org/attachment.cgi?id=175076&action=review >> Source/cmake/OptionsEfl.cmake:200 >> +GLXCOMPILATIONPASSED) > > Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL). That's true, you could use FIND_PACKAGE(OpenGL) + check if OPENGL_XMESA_FOUND is set. 771938 5 kalyan.kondapally 2012-11-20 09:43:25 -0800 (In reply to comment #3) > (From update of attachment 175076 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175076&action=review > > > Source/cmake/OptionsEfl.cmake:190 > > +include(CheckCSourceCompiles) > > +include(CheckCXXSourceCompiles) > > Coding style: our CMake calls are all uppercased. > > > Source/cmake/OptionsEfl.cmake:200 > > +CHECK_C_SOURCE_COMPILES( > > +" > > +#include <GL/glx.h> > > +int main() > > +{ > > + GLXFBConfig c; > > + return 0; > > +} > > +" > > +GLXCOMPILATIONPASSED) > > Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL). This assumption would be wrong on some platforms i.e wayland. > > Source/cmake/OptionsEfl.cmake:203 > > + SET(HAVE_GLX 1) > > This does not seem to be used anywhere. 771949 6 kalyan.kondapally 2012-11-20 09:51:52 -0800 (In reply to comment #4) > (From update of attachment 175076 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175076&action=review > > >> Source/cmake/OptionsEfl.cmake:200 > >> +GLXCOMPILATIONPASSED) > > > > Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL). > > That's true, you could use FIND_PACKAGE(OpenGL) + check if OPENGL_XMESA_FOUND is set. I was hoping we could do this. But the problem seems to be as follows: 1)In FindOpenGL.cmake OPENGL_XMESA_FOUND is set to True if OPENGL_xmesa_INCLUDE_DIR is True FIND_PATH(OPENGL_xmesa_INCLUDE_DIR GL/xmesa.h /usr/share/doc/NVIDIA_GLX-1.0/include /usr/openwin/share/include /opt/graphics/OpenGL/include /usr/X11R6/include ) Here GL/xmesa.h seems to be the problem. The "XMesa" interface is deprecated and GL/xmesa*.h files are no longer considered public. 771964 7 175240 kalyan.kondapally 2012-11-20 10:11:24 -0800 Created attachment 175240 WIP 772108 8 rakuco 2012-11-20 13:13:23 -0800 (In reply to comment #5) > > Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL). > > This assumption would be wrong on some platforms i.e wayland. (In reply to comment #6) > > That's true, you could use FIND_PACKAGE(OpenGL) + check if OPENGL_XMESA_FOUND is set. > > I was hoping we could do this. But the problem seems to be as follows: > > 1)In FindOpenGL.cmake OPENGL_XMESA_FOUND is set to True if OPENGL_xmesa_INCLUDE_DIR is True > > FIND_PATH(OPENGL_xmesa_INCLUDE_DIR GL/xmesa.h > /usr/share/doc/NVIDIA_GLX-1.0/include > /usr/openwin/share/include > /opt/graphics/OpenGL/include /usr/X11R6/include > ) > > Here GL/xmesa.h seems to be the problem. The "XMesa" interface is deprecated and GL/xmesa*.h files are no longer considered public. Could you elaborate on what the right solution that contemplated Wayland and didn't look for xmesa would be (ie. what libraries and headers would it look for)? As good citizens, it'd be nice to fix this upstream in CMake if possible. 772112 9 175240 rakuco 2012-11-20 13:18:27 -0800 Comment on attachment 175240 WIP View in context: https://bugs.webkit.org/attachment.cgi?id=175240&action=review I need your input to my comment #8 to properly comment on your new Find-file, but a few things should be improved regardless of that: o It needs some documentation at the top like the other Find-files. o We use a 4-space indentation style instead of a 2-space one. o The `X11_FOUND' check implicitly assumes FindX11.cmake was already called before, which is not always the case. Since you do not include X11 headers or link against any X11 library in your CHECK_C_SOURCE_COMPILES_CALL(), it might be worth simply not checking for `X11_FOUND' at all. o "YES" (a string) is different from YES (a boolean). Either way, we normally use FindPackageHandleStandardArguments() to set that, since it also handles other Find-module arguments such as QUIET and the like. > Source/cmake/OptionsEfl.cmake:161 > + FIND_PACKAGE(OpenGLX) > + > + IF (OPENGLX_FOUND) > + ADD_DEFINITIONS(-DHAVE_GLX) > + ENDIF() Do the tiled backing store and WebGL still work if the GLX is not found? 772347 10 kalyan.kondapally 2012-11-20 18:04:28 -0800 (In reply to comment #8) > (In reply to comment #5) > > > Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL). > > > > This assumption would be wrong on some platforms i.e wayland. > > (In reply to comment #6) > > > That's true, you could use FIND_PACKAGE(OpenGL) + check if OPENGL_XMESA_FOUND is set. > > > > I was hoping we could do this. But the problem seems to be as follows: > > > > 1)In FindOpenGL.cmake OPENGL_XMESA_FOUND is set to True if OPENGL_xmesa_INCLUDE_DIR is True > > > > FIND_PATH(OPENGL_xmesa_INCLUDE_DIR GL/xmesa.h > > /usr/share/doc/NVIDIA_GLX-1.0/include > > /usr/openwin/share/include > > /opt/graphics/OpenGL/include /usr/X11R6/include > > ) > > > > Here GL/xmesa.h seems to be the problem. The "XMesa" interface is deprecated and GL/xmesa*.h files are no longer considered public. > > Could you elaborate on what the right solution that contemplated Wayland and didn't look for xmesa would be (ie. what libraries and headers would it look for)? As good citizens, it'd be nice to fix this upstream in CMake if possible. Wayland Example: https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/097771054ec91728efb08b883ae88e697df3a5c0/entry/cmake/modules/FindWayland.cmake We should look for GL/glx.h instead of GL/xmesa.h. I was bit pessimistic here thinking about the cases where we could have bogus Glx.h file. i.e. Header present without any proper support for the interface, or completely wrong contents with the name etc. So I ended up with this sol, trying to compile some basic code. 772353 11 kalyan.kondapally 2012-11-20 18:14:06 -0800 (In reply to comment #9) > (From update of attachment 175240 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175240&action=review > > I need your input to my comment #8 to properly comment on your new Find-file, but a few things should be improved regardless of that: > o It needs some documentation at the top like the other Find-files. > o We use a 4-space indentation style instead of a 2-space one. > o The `X11_FOUND' check implicitly assumes FindX11.cmake was already called before, which is not always the case. Since you do not include X11 headers or link against any X11 library in your CHECK_C_SOURCE_COMPILES_CALL(), it might be worth simply not checking for `X11_FOUND' at all. > o "YES" (a string) is different from YES (a boolean). Either way, we normally use FindPackageHandleStandardArguments() to set that, since it also handles other Find-module arguments such as QUIET and the like. > > > Source/cmake/OptionsEfl.cmake:161 > > + FIND_PACKAGE(OpenGLX) > > + > > + IF (OPENGLX_FOUND) > > + ADD_DEFINITIONS(-DHAVE_GLX) > > + ENDIF() > > Do the tiled backing store and WebGL still work if the GLX is not found? : Current Situation: No. Once these things are fixed for GLX we need to add support for EGL. Than we need some kind of mechanism to configure what back end we would like to use(GLX or EGL or something else ?). I see we already have support for configuration flags like --enable-egl , --enable--glx and so on. Probably we can investigate more on this front when we start adding support for EGL. 772366 12 kalyan.kondapally 2012-11-20 18:30:04 -0800 (In reply to comment #10) > (In reply to comment #8) > > (In reply to comment #5) > > > > Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL). > > > > > > This assumption would be wrong on some platforms i.e wayland. > > > > (In reply to comment #6) > > > > That's true, you could use FIND_PACKAGE(OpenGL) + check if OPENGL_XMESA_FOUND is set. > > > > > > I was hoping we could do this. But the problem seems to be as follows: > > > > > > 1)In FindOpenGL.cmake OPENGL_XMESA_FOUND is set to True if OPENGL_xmesa_INCLUDE_DIR is True > > > > > > FIND_PATH(OPENGL_xmesa_INCLUDE_DIR GL/xmesa.h > > > /usr/share/doc/NVIDIA_GLX-1.0/include > > > /usr/openwin/share/include > > > /opt/graphics/OpenGL/include /usr/X11R6/include > > > ) > > > > > > Here GL/xmesa.h seems to be the problem. The "XMesa" interface is deprecated and GL/xmesa*.h files are no longer considered public. > > > > Could you elaborate on what the right solution that contemplated Wayland and didn't look for xmesa would be (ie. what libraries and headers would it look for)? As good citizens, it'd be nice to fix this upstream in CMake if possible. > > Wayland Example: https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/097771054ec91728efb08b883ae88e697df3a5c0/entry/cmake/modules/FindWayland.cmake > > We should look for GL/glx.h instead of GL/xmesa.h. I was bit pessimistic here thinking about the cases where we could have bogus Glx.h file. i.e. Header present without any proper support for the interface, or completely wrong contents with the name etc. So I ended up with this sol, trying to compile some basic code. Something to add: Wayland, doesn't support GLX interface. It rather uses Mesa EGL/EGL-X11 interface. 772972 13 175446 kalyan.kondapally 2012-11-21 07:54:11 -0800 Created attachment 175446 proposed patch 773046 14 175446 laszlo.gombos 2012-11-21 09:52:13 -0800 Comment on attachment 175446 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=175446&action=review Overall looks good to me. > Source/cmake/OptionsEfl.cmake:161 > + IF (OPENGLX_FOUND) > + ADD_DEFINITIONS(-DHAVE_GLX) > + ENDIF() The rule of finding and defining GLX does not seems to be EFL specific, this could be shared (perhaps at later stage) with other CMake based ports. 773069 15 175446 laszlo.gombos 2012-11-21 10:09:15 -0800 Comment on attachment 175446 proposed patch r=me. A step in the right direction. 773491 16 175446 webkit.review.bot 2012-11-21 19:09:28 -0800 Comment on attachment 175446 proposed patch Clearing flags on attachment: 175446 Committed r135463: <http://trac.webkit.org/changeset/135463> 773492 17 webkit.review.bot 2012-11-21 19:09:33 -0800 All reviewed patches have been landed. Closing bug. 773576 18 ryuan.choi 2012-11-21 22:26:36 -0800 *** Bug 102990 has been marked as a duplicate of this bug. *** 175076 2012-11-19 16:46:32 -0800 2012-11-20 10:11:24 -0800 WIP WIP.patch text/plain 645 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBTb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZQppbmRleCBjMmZkNDNjLi5mODM0NTliIDEwMDY0NAotLS0gU291cmNlL2Nt YWtlL09wdGlvbnNFZmwuY21ha2UKKysrIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBA IC0xODQsNyArMTg0LDI0IEBAIEVORElGKCkKIElGIChFTkFCTEVfV0VCR0wpCiAgIFNFVCAoRU5B QkxFX1dFQkdMIDEpCiAgIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0VfR1JBUEhJQ1NfU1VSRkFD RT0xKQotICBBRERfREVGSU5JVElPTlMoLURIQVZFX0dMWCkKK0VORElGKCkKKworaW5jbHVkZShD aGVja0NTb3VyY2VDb21waWxlcykKK2luY2x1ZGUoQ2hlY2tDWFhTb3VyY2VDb21waWxlcykKK0NI RUNLX0NfU09VUkNFX0NPTVBJTEVTKAorIgorI2luY2x1ZGUgPEdML2dseC5oPgoraW50IG1haW4o KQoreworICAgIEdMWEZCQ29uZmlnIGM7CisgICAgcmV0dXJuIDA7Cit9CisiCitHTFhDT01QSUxB VElPTlBBU1NFRCkKKworSUYgKEdMWENPTVBJTEFUSU9OUEFTU0VEKQorICAgIFNFVChIQVZFX0dM WCAxKQorICAgIEFERF9ERUZJTklUSU9OUygtREhBVkVfR0xYPTEpCiBFTkRJRigpCiAKIElGIChF TkFCTEVfU1BFTExDSEVDSykK 175240 2012-11-20 10:11:24 -0800 2012-11-21 07:54:11 -0800 WIP WIP.patch text/plain 2615 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvY21ha2UvRmluZE9wZW5HTFguY21ha2UgU291cmNlL2NtYWtlL0Zp bmRPcGVuR0xYLmNtYWtlCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmJlY2Zk MjYKLS0tIC9kZXYvbnVsbAorKysgU291cmNlL2NtYWtlL0ZpbmRPcGVuR0xYLmNtYWtlCkBAIC0w LDAgKzEsNDEgQEAKKyMgQ29weXJpZ2h0IChDKSAyMDEyIEludGVsIENvcnBvcmF0aW9uLiBBbGwg cmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVy bWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisjIGFyZSBtZXQ6 CisjIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQg dGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0 aGUKKyMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3 aXRoIHRoZSBkaXN0cmlidXRpb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkg VEhFIENPUFlSSUdIVCBIT0xERVIgQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUworIyBJUycnIEFO RCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBM SU1JVEVEIFRPLAorIyBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBB TkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisjIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElO IE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQgSE9MREVSIE9SIElUUworIyBDT05UUklCVVRP UlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lB TCwKKyMgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVU IE5PVCBMSU1JVEVEIFRPLAorIyBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF UlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsKKyMgT1IgQlVTSU5FU1MgSU5U RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFks CisjIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQgKElOQ0xV RElORyBORUdMSUdFTkNFIE9SCisjIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBP RiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYKKyMgQURWSVNFRCBPRiBUSEUgUE9T U0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK0lGIChYMTFfRk9VTkQpCisgIElOQ0xVREUoQ2hl Y2tDU291cmNlQ29tcGlsZXMpCisgIElOQ0xVREUoQ2hlY2tDWFhTb3VyY2VDb21waWxlcykKKyAg Q0hFQ0tfQ19TT1VSQ0VfQ09NUElMRVMoCisgICIKKyAgI2luY2x1ZGUgPEdML2dseC5oPgorICBp bnQgbWFpbigpCisgIHsKKyAgICAgIEdMWEZCQ29uZmlnIGM7CisgICAgICByZXR1cm4gMDsKKyAg fQorICAiCisgIEdMWENPTVBJTEFUSU9OUEFTU0VEKQorCisgIElGIChHTFhDT01QSUxBVElPTlBB U1NFRCkKKyAgICBTRVQoT1BFTkdMWF9GT1VORCAiWUVTIikKKyAgRU5ESUYoKQorRU5ESUYoKQpk aWZmIC0tZ2l0IFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlIFNvdXJjZS9jbWFrZS9PcHRp b25zRWZsLmNtYWtlCmluZGV4IGMyZmQ0M2MuLmNiZGI5MGYgMTAwNjQ0Ci0tLSBTb3VyY2UvY21h a2UvT3B0aW9uc0VmbC5jbWFrZQorKysgU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKQEAg LTE1Miw4ICsxNTIsMTMgQEAgSUYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FVRElPKQog ICAgIEZJTkRfUEFDS0FHRShHU3RyZWFtZXIgUkVRVUlSRUQgQ09NUE9ORU5UUyAke0dTVFJFQU1F Ul9DT01QT05FTlRTfSkKIEVORElGICgpCiAKLUlGIChFTkFCTEVfV0VCR0wpCitJRiAoRU5BQkxF X1dFQkdMIE9SIFdURl9VU0VfVElMRURfQkFDS0lOR19TVE9SRSkKICAgRklORF9QQUNLQUdFKE9w ZW5HTCBSRVFVSVJFRCkKKyAgRklORF9QQUNLQUdFKE9wZW5HTFgpCisKKyAgSUYgKE9QRU5HTFhf Rk9VTkQpCisgICAgQUREX0RFRklOSVRJT05TKC1ESEFWRV9HTFgpCisgIEVORElGKCkKIEVORElG ICgpCiAKIElGIChFTkFCTEVfSU5TUEVDVE9SKQpAQCAtMTc4LDcgKzE4Myw2IEBAIElGIChXVEZf VVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUpCiAgIFNFVChFTkFCTEVfM0RfUkVOREVSSU5HIDEpCiAg IEFERF9ERUZJTklUSU9OUygtREVOQUJMRV8zRF9SRU5ERVJJTkc9MSkKIAotICBGSU5EX1BBQ0tB R0UoT3BlbkdMIFJFUVVJUkVEKQogRU5ESUYoKQogCiBJRiAoRU5BQkxFX1dFQkdMKQo= 175446 2012-11-21 07:54:11 -0800 2012-11-21 19:09:28 -0800 proposed patch cmakechanges.patch text/plain 1646 kalyan.kondapally ZGlmZiAtLWdpdCBDaGFuZ2VMb2cgQ2hhbmdlTG9nCmluZGV4IDIzNGM3YjMuLjZkOGU3YmYgMTAw NjQ0Ci0tLSBDaGFuZ2VMb2cKKysrIENoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEx LTIxICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KKwor ICAgICAgICBbRUZMXSBHTFggZGV0ZWN0aW9uIGlzIGJyb2tlbi4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjY4Ny4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIQVZFX0dMWCBpcyBlbmFibGVkIG9ubHkg aWYgV2ViR0wgaXMgZW5hYmxlZC4gVGhpcyBpcyB3cm9uZyBhbmQgd2Ugc2hvdWxkCisgICAgICAg IGV4cGxpY2l0bHkgdGVzdCBmb3IgR0xYIHN1cHBvcnQuCisgICAgICAgIFRoaXMgcGF0Y2ggbWFr ZXMgY2hhbmdlcyBzbyB0aGF0IHdlIGNoZWNrIGZvciBnbHguaCBoZWFkZXIgYW5kIHNldHMgSEFW RV9HTFggZmxhZyBhcHByb3ByaWF0ZWx5LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlv bnNFZmwuY21ha2U6CisKIDIwMTItMTEtMjEgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25AaW50 ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIFR1cm4gb24gV1RGX1VTRV9USUxFRF9CQUNLSU5HX1NU T1JFIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBT b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRleCBjMmZkNDNjLi5lNzI2YzYyIDEwMDY0 NAotLS0gU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKKysrIFNvdXJjZS9jbWFrZS9PcHRp b25zRWZsLmNtYWtlCkBAIC0xNTIsOCArMTUyLDEzIEBAIElGIChFTkFCTEVfVklERU8gT1IgRU5B QkxFX1dFQl9BVURJTykKICAgICBGSU5EX1BBQ0tBR0UoR1N0cmVhbWVyIFJFUVVJUkVEIENPTVBP TkVOVFMgJHtHU1RSRUFNRVJfQ09NUE9ORU5UU30pCiBFTkRJRiAoKQogCi1JRiAoRU5BQkxFX1dF QkdMKQotICBGSU5EX1BBQ0tBR0UoT3BlbkdMIFJFUVVJUkVEKQorSUYgKEVOQUJMRV9XRUJHTCBP UiBXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUpCisgICAgRklORF9QQUNLQUdFKE9wZW5HTCBS RVFVSVJFRCkKKyAgICBDSEVDS19JTkNMVURFX0ZJTEVTKCJHTC9nbHguaCIgT1BFTkdMWF9GT1VO RCkKKworICAgIElGIChPUEVOR0xYX0ZPVU5EKQorICAgICAgICBBRERfREVGSU5JVElPTlMoLURI QVZFX0dMWCkKKyAgICBFTkRJRigpCiBFTkRJRiAoKQogCiBJRiAoRU5BQkxFX0lOU1BFQ1RPUikK QEAgLTE3NywxNCArMTgyLDExIEBAIElGIChXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUpCiAK ICAgU0VUKEVOQUJMRV8zRF9SRU5ERVJJTkcgMSkKICAgQUREX0RFRklOSVRJT05TKC1ERU5BQkxF XzNEX1JFTkRFUklORz0xKQotCi0gIEZJTkRfUEFDS0FHRShPcGVuR0wgUkVRVUlSRUQpCiBFTkRJ RigpCiAKIElGIChFTkFCTEVfV0VCR0wpCiAgIFNFVCAoRU5BQkxFX1dFQkdMIDEpCiAgIEFERF9E RUZJTklUSU9OUygtRFdURl9VU0VfR1JBUEhJQ1NfU1VSRkFDRT0xKQotICBBRERfREVGSU5JVElP TlMoLURIQVZFX0dMWCkKIEVORElGKCkKIAogSUYgKEVOQUJMRV9TUEVMTENIRUNLKQo=