102503 2012-11-16 07:08:34 -0800 Update DOMException name: NetworkError 2012-11-19 07:35:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101606 1 arv arv haraken webkit.review.bot oldest_to_newest 769234 0 arv 2012-11-16 07:08:34 -0800 Update DOMException name: NetworkError 769248 1 174679 arv 2012-11-16 07:21:26 -0800 Created attachment 174679 Patch 770216 2 174679 haraken 2012-11-18 16:05:07 -0800 Comment on attachment 174679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174679&action=review ok > Source/WebCore/dom/DOMCoreException.cpp:56 > // FIXME: Couldn't find a description in the HTML/DOM specifications for NETWORK_ERR, ABORT_ERR, URL_MISMATCH_ERR, and QUOTA_EXCEEDED_ERR Given that they are not speced nor used in WebKit, maybe it's time to remove them from WebKit? You can do it in a follow-up patch if needed. 770660 3 arv 2012-11-19 06:12:37 -0800 (In reply to comment #2) > (From update of attachment 174679 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174679&action=review > > ok > > > Source/WebCore/dom/DOMCoreException.cpp:56 > > // FIXME: Couldn't find a description in the HTML/DOM specifications for NETWORK_ERR, ABORT_ERR, URL_MISMATCH_ERR, and QUOTA_EXCEEDED_ERR > > Given that they are not speced nor used in WebKit, maybe it's time to remove them from WebKit? You can do it in a follow-up patch if needed. These have descriptions in the latest spec. I have an open bug to fix these to. Bug 101953. These are used but this is partially covered by bug 102506 . 770669 4 174679 webkit.review.bot 2012-11-19 06:26:37 -0800 Comment on attachment 174679 Patch Rejecting attachment 174679 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/DOMCoreException.cpp Hunk #1 FAILED at 54. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14909217 770713 5 174974 arv 2012-11-19 07:04:00 -0800 Created attachment 174974 Patch for landing 770735 6 174974 webkit.review.bot 2012-11-19 07:35:51 -0800 Comment on attachment 174974 Patch for landing Clearing flags on attachment: 174974 Committed r135157: <http://trac.webkit.org/changeset/135157> 770736 7 webkit.review.bot 2012-11-19 07:35:55 -0800 All reviewed patches have been landed. Closing bug. 174679 2012-11-16 07:21:26 -0800 2012-11-19 07:03:57 -0800 Patch bug-102503-20121116101921.patch text/plain 1928 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZlMjIxODAwMmRmMjQ1 ZTBlNmY3YzcwZmI1NzRjZDMzMjI0Y2RkYy4uNGI5YmQ3MDc2ZWFiMWM1M2YyZTY4ZjI2YjYyZTcz MTBiNzcyYWNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTE2ICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXBkYXRlIERPTUV4Y2Vw dGlvbiBuYW1lOiBOZXR3b3JrRXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMjUwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFBhdGNoIDE5IG9mIDI1IHRvIHVwZGF0ZSBET01FeGNlcHRpb24gbmFt ZSB0byBtYXRjaCB0aGUgc3BlYyBhbmQgRmlyZWZveC4KKworICAgICAgICBObyBjb2RlIHVzZXMg RE9NRXhjZXB0aW9uIE5ldHdvcmtFcnJvci4gV2UgZG8gdXNlIE5FVFdPUktfRVJSIGZvciBYTUxI dHRwUmVxdWVzdEV4Y2VwdGlvbi4gU2VlIGJ1ZyAxMDI1MDYuCisKKyAgICAgICAgKiBkb20vRE9N Q29yZUV4Y2VwdGlvbi5jcHA6CisKIDIwMTItMTEtMTYgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gUmVtb3ZlIElzU3ViVHlwZSgpIGZyb20gQ29k ZUdlbmVyYXRvclY4LnBtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NQ29yZUV4 Y2VwdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5jcHAKaW5k ZXggNzNhZGRmYWQ5Y2ZiZTBhNDA1MTA1ODYzNGJiNjAyZjk0OTRhYzdiMi4uZjZiZmEzZWRlOTM3 MzM0ZDViYzMxMmU0Y2M5ODg0OGZiYjUyNDBkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0RPTUNvcmVFeGNlcHRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01Db3Jl RXhjZXB0aW9uLmNwcApAQCAtNTQsNyArNTQsNyBAQCBzdGF0aWMgc3RydWN0IENvcmVFeGNlcHRp b24gewogICAgIHsgIlRZUEVfTUlTTUFUQ0hfRVJSIiwgIlRoZSB0eXBlIG9mIGFuIG9iamVjdCB3 YXMgaW5jb21wYXRpYmxlIHdpdGggdGhlIGV4cGVjdGVkIHR5cGUgb2YgdGhlIHBhcmFtZXRlciBh c3NvY2lhdGVkIHRvIHRoZSBvYmplY3QuIiB9LAogICAgIHsgIlNFQ1VSSVRZX0VSUiIsICJBbiBh dHRlbXB0IHdhcyBtYWRlIHRvIGJyZWFrIHRocm91Z2ggdGhlIHNlY3VyaXR5IHBvbGljeSBvZiB0 aGUgdXNlciBhZ2VudC4iIH0sCiAgICAgLy8gRklYTUU6IENvdWxkbid0IGZpbmQgYSBkZXNjcmlw dGlvbiBpbiB0aGUgSFRNTC9ET00gc3BlY2lmaWNhdGlvbnMgZm9yIE5FVFdPUktfRVJSLCBBQk9S VF9FUlIsIFVSTF9NSVNNQVRDSF9FUlIsIGFuZCBRVU9UQV9FWENFRURFRF9FUlIKLSAgICB7ICJO RVRXT1JLX0VSUiIsICJBIG5ldHdvcmsgZXJyb3Igb2NjdXJyZWQuIiB9LAorICAgIHsgIk5ldHdv cmtFcnJvciIsICJBIG5ldHdvcmsgZXJyb3Igb2NjdXJyZWQuIiB9LAogICAgIHsgIkFCT1JUX0VS UiIsICJUaGUgdXNlciBhYm9ydGVkIGEgcmVxdWVzdC4iIH0sCiAgICAgeyAiVVJMX01JU01BVENI X0VSUiIsICJBIHdvcmtlciBnbG9iYWwgc2NvcGUgcmVwcmVzZW50ZWQgYW4gYWJzb2x1dGUgVVJM IHRoYXQgaXMgbm90IGVxdWFsIHRvIHRoZSByZXN1bHRpbmcgYWJzb2x1dGUgVVJMLiIgfSwKICAg ICB7ICJRVU9UQV9FWENFRURFRF9FUlIiLCAiQW4gYXR0ZW1wdCB3YXMgbWFkZSB0byBhZGQgc29t ZXRoaW5nIHRvIHN0b3JhZ2UgdGhhdCBleGNlZWRlZCB0aGUgcXVvdGEuIiB9LAo= 174974 2012-11-19 07:04:00 -0800 2012-11-19 07:35:51 -0800 Patch for landing bug-102503-20121119100151.patch text/plain 1965 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQzMGJjMjI0ZTY0ZGRm NGYyY2VjYzRjYjYzNDg3ZTk0MzU1NDIxYy4uZWMwN2ZiYjIzMGQ3YTRkYTdiNGFjMThkMDc3MDZi ZWIzMzE0MjU0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTE2ICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXBkYXRlIERPTUV4Y2Vw dGlvbiBuYW1lOiBOZXR3b3JrRXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMjUwMworCisgICAgICAgIFJldmlld2VkIGJ5IEtlbnRhcm8gSGFy YS4KKworICAgICAgICBQYXRjaCAxOSBvZiAyNSB0byB1cGRhdGUgRE9NRXhjZXB0aW9uIG5hbWUg dG8gbWF0Y2ggdGhlIHNwZWMgYW5kIEZpcmVmb3guCisKKyAgICAgICAgTm8gY29kZSB1c2VzIERP TUV4Y2VwdGlvbiBOZXR3b3JrRXJyb3IuIFdlIGRvIHVzZSBORVRXT1JLX0VSUiBmb3IgWE1MSHR0 cFJlcXVlc3RFeGNlcHRpb24uIFNlZSBidWcgMTAyNTA2LgorCisgICAgICAgICogZG9tL0RPTUNv cmVFeGNlcHRpb24uY3BwOgorCiAyMDEyLTExLTE5ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xv QGNocm9taXVtLm9yZz4KIAogICAgICAgICB3ZWJhdWRpbzogbGVhazogQXVkaW9Db250ZXh0IG9i amVjdHMgYXJlIGxlYWtpbmcuIFRoZXkgcmV0YWluIDM2bWIgb2Ygc2hhcmVkIGRhdGEuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5jcHAKaW5kZXggNWM1YmQzOWM4OGVkYWYwOGVk MDUyMjQ2NTBhOTEzYTg3YjRkNzgzNy4uZjFkMTA5Nzk1M2E2MGM0YTBlMWIxMjAzMjRjM2Q3YmVk MDU3YmM1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RPTUNvcmVFeGNlcHRpb24u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01Db3JlRXhjZXB0aW9uLmNwcApAQCAtNTQs NyArNTQsNyBAQCBzdGF0aWMgc3RydWN0IENvcmVFeGNlcHRpb24gewogICAgIHsgIlR5cGVNaXNt YXRjaEVycm9yIiwgIlRoZSB0eXBlIG9mIGFuIG9iamVjdCB3YXMgaW5jb21wYXRpYmxlIHdpdGgg dGhlIGV4cGVjdGVkIHR5cGUgb2YgdGhlIHBhcmFtZXRlciBhc3NvY2lhdGVkIHRvIHRoZSBvYmpl Y3QuIiB9LAogICAgIHsgIlNFQ1VSSVRZX0VSUiIsICJBbiBhdHRlbXB0IHdhcyBtYWRlIHRvIGJy ZWFrIHRocm91Z2ggdGhlIHNlY3VyaXR5IHBvbGljeSBvZiB0aGUgdXNlciBhZ2VudC4iIH0sCiAg ICAgLy8gRklYTUU6IENvdWxkbid0IGZpbmQgYSBkZXNjcmlwdGlvbiBpbiB0aGUgSFRNTC9ET00g c3BlY2lmaWNhdGlvbnMgZm9yIE5FVFdPUktfRVJSLCBBQk9SVF9FUlIsIFVSTF9NSVNNQVRDSF9F UlIsIGFuZCBRVU9UQV9FWENFRURFRF9FUlIKLSAgICB7ICJORVRXT1JLX0VSUiIsICJBIG5ldHdv cmsgZXJyb3Igb2NjdXJyZWQuIiB9LAorICAgIHsgIk5ldHdvcmtFcnJvciIsICJBIG5ldHdvcmsg ZXJyb3Igb2NjdXJyZWQuIiB9LAogICAgIHsgIkFib3J0RXJyb3IiLCAiVGhlIHVzZXIgYWJvcnRl ZCBhIHJlcXVlc3QuIiB9LAogICAgIHsgIlVSTF9NSVNNQVRDSF9FUlIiLCAiQSB3b3JrZXIgZ2xv YmFsIHNjb3BlIHJlcHJlc2VudGVkIGFuIGFic29sdXRlIFVSTCB0aGF0IGlzIG5vdCBlcXVhbCB0 byB0aGUgcmVzdWx0aW5nIGFic29sdXRlIFVSTC4iIH0sCiAgICAgeyAiUXVvdGFFeGNlZWRlZEVy cm9yIiwgIkFuIGF0dGVtcHQgd2FzIG1hZGUgdG8gYWRkIHNvbWV0aGluZyB0byBzdG9yYWdlIHRo YXQgZXhjZWVkZWQgdGhlIHF1b3RhLiIgfSwK