102500 2012-11-16 06:40:46 -0800 DOM/DOMWalk.html is flaky in Chromium Win Release Perf bot 2013-01-15 01:43:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken dominicc dominicc noel.gordon rniwa webkit.review.bot oldest_to_newest 769214 0 haraken 2012-11-16 06:40:46 -0800 It sometimes show the following error: Running DOM/DOMWalk.html (35 of 112) runFunction returned a non-positive value: 0 runFunction returned a non-positive value: 0 FAILED Finished: 9.609000 s See http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Perf%29/builds/4412/steps/perf-test/logs/stdio 807054 1 dominicc 2013-01-15 00:30:51 -0800 *** Bug 104866 has been marked as a duplicate of this bug. *** 807073 2 182715 dominicc 2013-01-15 00:59:15 -0800 Created attachment 182715 Patch 807079 3 dominicc 2013-01-15 01:03:11 -0800 I am assuming that zero is a plausible result for some of the (micro) benchmarks in DOM/DOMWalk.html. One thing that makes me suspicious is that Dromaeo results on the Windows bots are typically numerically larger than those of the Mac bots, yet the Mac bot does not exhibit this failure. Perhaps the timer works differently on those platforms. If this warrants more investigation, the alternative is to add more instrumentation to Dromaeo so we can see which specific test functions are failing (it is a flaky set, usually >1 but from zero to a few tests fail this way.) For now proposing that we assume the result is correct and allow zero as a (very fast) result to green the Windows perf bot. 807086 4 182715 haraken 2013-01-15 01:11:31 -0800 Comment on attachment 182715 Patch Looks reasonable to me as an immediate fix to suppress the win bot errors, though we want to improve the test so it won't return zero (zero means that we're not testing something meaningful). 807091 5 182715 dominicc 2013-01-15 01:17:28 -0800 Comment on attachment 182715 Patch Thank you for the quick review. I filed bug 106882 to improve the test. 807116 6 182715 webkit.review.bot 2013-01-15 01:43:51 -0800 Comment on attachment 182715 Patch Clearing flags on attachment: 182715 Committed r139728: <http://trac.webkit.org/changeset/139728> 807117 7 webkit.review.bot 2013-01-15 01:43:54 -0800 All reviewed patches have been landed. Closing bug. 182715 2013-01-15 00:59:15 -0800 2013-01-15 01:43:51 -0800 Patch bug-102500-20130115175615.patch text/plain 1529 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NzIzCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQwZDc1M2IyYWE3 ZjE5YmMyMWY2YzdiYzRiMGY2ODg3MTZmNTg0N2IuLjYxYzNmZGFmZDA1Mzk1MWQwNjUyMTRmMzEw MWYxODk4NmJkMmIyYzUgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDEt MTUgIERvbWluaWMgQ29vbmV5ICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFs bG93IHplcm8gdmFsdWVzIGFzIHJlc3VsdHMgZnJvbSB0aGUgcnVuRnVuY3Rpb24uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI1MDAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBET00vRE9NV2Fsay5qcyBm YWlscyBvbiB0aGUgQ2hyb21pdW0gV2luIHBlcmYgYm90IGJlY2F1c2Ugb25lIG9yCisgICAgICAg IG1vcmUgcGFydHMgb2YgdGhlIHRlc3QgdXN1YWxseSByZXR1cm4gemVybyBhdCBzb21lIHBvaW50 LgorCisgICAgICAgICogcmVzb3VyY2VzL3J1bm5lci5qczogQWNjZXB0IG1lcmVseSBub24tbmVn YXRpdmUgcmVzdWx0cy4KKwogMjAxMi0xMi0yOCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW5hbWUgZGlzdGFuY2VUb1dp bmRvdyB0byBkaXN0YW5jZQpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9yZXNvdXJjZXMv cnVubmVyLmpzIGIvUGVyZm9ybWFuY2VUZXN0cy9yZXNvdXJjZXMvcnVubmVyLmpzCmluZGV4IDBj YjZlMDczMGUxOWFkM2Y3MTYwMWIyNzg0NGRlZGY1Y2U3ODI5OTMuLjM2YWU1NjEzZmZhZDFkMGYx M2JiYTc2NDU5MjU2YjliYjRiMTUwZjMgMTAwNzU1Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvcmVz b3VyY2VzL3J1bm5lci5qcworKysgYi9QZXJmb3JtYW5jZVRlc3RzL3Jlc291cmNlcy9ydW5uZXIu anMKQEAgLTI1Nyw4ICsyNTcsOCBAQCBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKICAgICAgICAg dmFyIGVuZCA9IFBlcmZUZXN0UnVubmVyLm5vdygpOwogCiAgICAgICAgIGlmIChyZXR1cm5WYWx1 ZSAtIDAgPT09IHJldHVyblZhbHVlKSB7Ci0gICAgICAgICAgICBpZiAocmV0dXJuVmFsdWUgPD0g MCkKLSAgICAgICAgICAgICAgICBQZXJmVGVzdFJ1bm5lci5sb2coInJ1bkZ1bmN0aW9uIHJldHVy bmVkIGEgbm9uLXBvc2l0aXZlIHZhbHVlOiAiICsgcmV0dXJuVmFsdWUpOworICAgICAgICAgICAg aWYgKHJldHVyblZhbHVlIDwgMCkKKyAgICAgICAgICAgICAgICBQZXJmVGVzdFJ1bm5lci5sb2co InJ1bkZ1bmN0aW9uIHJldHVybmVkIGEgbmVnYXRpdmUgdmFsdWU6ICIgKyByZXR1cm5WYWx1ZSk7 CiAgICAgICAgICAgICByZXR1cm4gcmV0dXJuVmFsdWU7CiAgICAgICAgIH0KIAo=