102475 2012-11-16 03:38:51 -0800 [Qt][Mac] Fix the build after r124873 2012-11-16 06:59:17 -0800 1 1 1 Unclassified WebKit New Bugs 420+ All All RESOLVED FIXED P1 Blocker --- 101023 1 ossy webkit-unassigned dongseong.hwang galpeter hausmann noam ossy rafael.lobo webkit.review.bot zeno oldest_to_newest 769081 0 ossy 2012-11-16 03:38:51 -0800 In file included from /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:30: In file included from /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:25: In file included from /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:24: In file included from /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:33: In file included from /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Shared/WebLayerTreeInfo.h:25: In file included from /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:29: /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:39:11: error: member reference base type 'const unsigned long' is not a structure or union t.encode(encoder); ~ ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h:92:27: note: in instantiation of member function 'CoreIPC::ArgumentCoder<unsigned long>::encode' requested here ArgumentCoder<T>::encode(*this, t); ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Platform/CoreIPC/Arguments.h:62:17: note: in instantiation of function template specialization 'CoreIPC::ArgumentEncoder::encode<unsigned long>' requested here encoder.encode(argument1); ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:39:11: note: in instantiation of member function 'CoreIPC::Arguments1<const unsigned long &>::encode' requested here t.encode(encoder); ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h:92:27: note: in instantiation of member function 'CoreIPC::ArgumentCoder<Messages::LayerTreeCoordinatorProxy::CreateImageBacking>::encode' requested here ArgumentCoder<T>::encode(*this, t); ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Platform/CoreIPC/MessageSender.h:45:18: note: in instantiation of function template specialization 'CoreIPC::ArgumentEncoder::encode<Messages::LayerTreeCoordinatorProxy::CreateImageBacking>' requested here encoder->encode(message); ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/Platform/CoreIPC/MessageSender.h:38:16: note: in instantiation of function template specialization 'CoreIPC::MessageSender<WebKit::WebPage>::send<Messages::LayerTreeCoordinatorProxy::CreateImageBacking>' requested here return send(message, static_cast<T*>(this)->destinationID()); ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:486:16: note: in instantiation of function template specialization 'CoreIPC::MessageSender<WebKit::WebPage>::send<Messages::LayerTreeCoordinatorProxy::CreateImageBacking>' requested here m_webPage->send(Messages::LayerTreeCoordinatorProxy::CreateImageBacking(imageID)); ^ 1 error generated. make[3]: *** [obj/release/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.o] Error 1 769134 1 galpeter 2012-11-16 05:03:45 -0800 So... I think this is the problem (if I'm correct: CreateImageBacking(uintptr_t imageID) on linux (64bit) the uintptr_t is typedef for unsigned int, also the uint32_t is unsigned int. But, on the mac the unitptr_t is unsigned long long, the uint32_t is just unsigned int. So on linux uintptr_t is just as uint32_t. But on mac it isn't. In the ArgumentEncoder class there are methods for encoding like: void ArgumentEncoder::encode(uint32_t n) this results that on linux there is a way to encode the uintptr_t, on on mac there is no such method. (This holds only true if I understand the Argument* classes correctly.) So... could what should we do about this? use uint[32/64]_t or create an encode/decode function for the uintptr_t on mac? 769169 2 174658 galpeter 2012-11-16 05:52:36 -0800 Created attachment 174658 speculative thingy... Just in case, if we decide to go with the uint64_t way. :) 769229 3 174658 webkit.review.bot 2012-11-16 06:59:13 -0800 Comment on attachment 174658 speculative thingy... Clearing flags on attachment: 174658 Committed r134946: <http://trac.webkit.org/changeset/134946> 769230 4 webkit.review.bot 2012-11-16 06:59:17 -0800 All reviewed patches have been landed. Closing bug. 174658 2012-11-16 05:52:36 -0800 2012-11-16 06:59:13 -0800 speculative thingy... mac_qt_coordgraph_ptr.patch text/plain 2416 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjMTJlOTJlLi5kZWUzNTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMTEtMTYgIFBldGVyIEdhbCAgPGdhbHBldGVyQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBbUXRdW01hY10gRml4IHRoZSBidWlsZCBhZnRlciByMTI0ODczCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI0NzUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdGhlIENvb3JkaW5h dGVkSW1hZ2VCYWNraW5nSUQgdHlwZWRlZiBmcm9tIHVpbnRwdHJfdCB0byB1aW50NjRfdC4KKwor ICAgICAgICAqIFNoYXJlZC9XZWJMYXllclRyZWVJbmZvLmg6CisgICAgICAgICogVUlQcm9jZXNz L0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3JQcm94eS5tZXNzYWdlcy5p bjoKKwogMjAxMi0xMS0xNiAgSGVsZGVyIENvcnJlaWEgIDxoZWxkZXIuY29ycmVpYUBub2tpYS5j b20+CiAKICAgICAgICAgW0Nvb3JkR2Z4XSBGb2xsb3cgY29kaW5nIHN0eWxlIG9uIGV4cGxpY2l0 IGNvbnN0cnVjdG9ycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkxheWVy VHJlZUluZm8uaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJMYXllclRyZWVJbmZvLmgKaW5k ZXggZTZhMmFlZC4uY2YzMjM3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dl YkxheWVyVHJlZUluZm8uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViTGF5ZXJUcmVl SW5mby5oCkBAIC0zMyw3ICszMyw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogdHlwZWRlZiB1aW50 MzJfdCBXZWJMYXllcklEOwogZW51bSB7IEludmFsaWRXZWJMYXllcklEID0gMCB9OwogCi10eXBl ZGVmIHVpbnRwdHJfdCBDb29yZGluYXRlZEltYWdlQmFja2luZ0lEOwordHlwZWRlZiB1aW50NjRf dCBDb29yZGluYXRlZEltYWdlQmFja2luZ0lEOwogZW51bSB7IEludmFsaWRDb29yZGluYXRlZElt YWdlQmFja2luZ0lEID0gMCB9OwogCiAvLyBOT1RFOiBXZWJMYXllckluZm8gc2hvdWxkIG9ubHkg dXNlIFBPRCB0eXBlcywgYXMgdG8gbWFrZSBzZXJpYWxpemF0aW9uIGZhc3Rlci4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJl ZUNvb3JkaW5hdG9yUHJveHkubWVzc2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Q29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVDb29yZGluYXRvclByb3h5Lm1lc3NhZ2VzLmlu CmluZGV4IDdmNzQ0YTYuLjhhZWIwMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZUNvb3JkaW5hdG9yUHJveHkubWVzc2Fn ZXMuaW4KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv TGF5ZXJUcmVlQ29vcmRpbmF0b3JQcm94eS5tZXNzYWdlcy5pbgpAQCAtMzEsOSArMzEsOSBAQCBt ZXNzYWdlcyAtPiBMYXllclRyZWVDb29yZGluYXRvclByb3h5IHsKICAgICBSZW1vdmVUaWxlRm9y TGF5ZXIodWludDMyX3QgbGF5ZXJJRCwgaW50IHRpbGVJRCkKICAgICBDcmVhdGVVcGRhdGVBdGxh cyhpbnQgYXRsYXNJRCwgV2ViS2l0OjpTaGFyZWFibGVTdXJmYWNlOjpIYW5kbGUgaGFuZGxlKQog ICAgIFJlbW92ZVVwZGF0ZUF0bGFzKGludCBhdGxhc0lEKQotICAgIENyZWF0ZUltYWdlQmFja2lu Zyh1aW50cHRyX3QgaW1hZ2VJRCkKLSAgICBVcGRhdGVJbWFnZUJhY2tpbmcodWludHB0cl90IGlt YWdlSUQsIFdlYktpdDo6U2hhcmVhYmxlU3VyZmFjZTo6SGFuZGxlIGhhbmRsZSkKLSAgICBSZW1v dmVJbWFnZUJhY2tpbmcodWludHB0cl90IGltYWdlSUQpCisgICAgQ3JlYXRlSW1hZ2VCYWNraW5n KHVpbnQ2NF90IGltYWdlSUQpCisgICAgVXBkYXRlSW1hZ2VCYWNraW5nKHVpbnQ2NF90IGltYWdl SUQsIFdlYktpdDo6U2hhcmVhYmxlU3VyZmFjZTo6SGFuZGxlIGhhbmRsZSkKKyAgICBSZW1vdmVJ bWFnZUJhY2tpbmcodWludDY0X3QgaW1hZ2VJRCkKICAgICBEaWRSZW5kZXJGcmFtZShXZWJDb3Jl OjpJbnRTaXplIGNvbnRlbnRzU2l6ZSwgV2ViQ29yZTo6SW50UmVjdCBjb3ZlcmVkUmVjdCkKICAg ICBEaWRDaGFuZ2VTY3JvbGxQb3NpdGlvbihXZWJDb3JlOjpJbnRQb2ludCBwb3NpdGlvbikKICAg ICBTZXRMYXllckFuaW1hdGlvbnModWludDMyX3QgaWQsIFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJB bmltYXRpb25zIGFuaW1hdGlvbnMpCg==