102465 2012-11-15 23:31:48 -0800 [WK2] Bug on ASSERT code in CoordinatedBackingStore.cpp 2012-11-16 01:18:13 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101023 1 ktf.kim ktf.kim dongseong.hwang lucas.de.marchi noam ossy webkit.review.bot zeno oldest_to_newest 768958 0 ktf.kim 2012-11-15 23:31:48 -0800 There's build error on Debug build on the ASSERT code in CoordinatedBackingStore.cpp (regression from https://bugs.webkit.org/show_bug.cgi?id=101023) because the ‘operator>=’ is not defined for WebCore::IntSize. Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:52:105: error: no match for ‘operator>=’ in ‘textureMapper->WebCore::TextureMapper::maxTextureSize() >= std::max [with _Tp = int]((* &((WebKit::CoordinatedBackingStoreTile*)this)->WebKit::CoordinatedBackingStoreTile::m_tileRect.WebCore::IntRect::size().WebCore::IntSize::width()), (* &((WebKit::CoordinatedBackingStoreTile*)this)->WebKit::CoordinatedBackingStoreTile::m_tileRect.WebCore::IntRect::size().WebCore::IntSize::height()))’ 768960 1 174613 ktf.kim 2012-11-15 23:36:03 -0800 Created attachment 174613 Patch 768963 2 174616 ktf.kim 2012-11-15 23:38:47 -0800 Created attachment 174616 Patch 768969 3 174616 dbates 2012-11-15 23:48:48 -0800 Comment on attachment 174616 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174616&action=review > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:52 > + ASSERT(textureMapper->maxTextureSize().width() >= m_tileRect.size().width() && textureMapper->maxTextureSize().height() >= m_tileRect.size().height()); Nit: There are two space characters before the "&&". 768974 4 174618 ktf.kim 2012-11-16 00:02:10 -0800 Created attachment 174618 Patch 768990 5 174618 ossy 2012-11-16 00:23:39 -0800 Comment on attachment 174618 Patch Clearing flags on attachment: 174618 Committed r134912: <http://trac.webkit.org/changeset/134912> 768991 6 ossy 2012-11-16 00:23:45 -0800 All reviewed patches have been landed. Closing bug. 769025 7 dongseong.hwang 2012-11-16 01:18:13 -0800 Thank you for fixing. I really appreciate! 174613 2012-11-15 23:36:03 -0800 2012-11-15 23:38:42 -0800 Patch bug-102465-20121116163400.patch text/plain 1846 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDY0YWVjNTEzZWI2NmU3 OWMyMzVmNWQxMTMzZTE1MzFhOTk2NWJmZC4uNDRjNWYwMTIwYWM3NjgxZDJkOTliZGYzNTY4NGY0 MmMxYTI4MTQyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTE1ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXSzJdIEJ1ZyBvbiBB U1NFUlQgY29kZSBpbiBDb29yZGluYXRlZEJhY2tpbmdTdG9yZS5jcHAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQ2NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlJ3MgYnVpbGQgZXJyb3Igb24g RGVidWcgYnVpbGQgYmVjYXVzZSB0aGUg4oCYb3BlcmF0b3I+PeKAmSBpcyBub3QgZGVmaW5lZCBm b3IgV2ViQ29yZTo6SW50U2l6ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29v cmRpbmF0ZWRCYWNraW5nU3RvcmVUaWxlOjpzd2FwQnVmZmVycyk6CisKIDIwMTItMTEtMTUgIEh1 YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgQ29vcmRp bmF0ZWQgR3JhcGhpY3M6IFJlZmFjdG9yIGNvZGUgcmVsYXRlZCB0byBkaXJlY3RseSBjb21wb3Np dGVkIGltYWdlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGlu YXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkQmFja2luZ1N0b3JlLmNw cAppbmRleCAwNTRhMWU5YmQ2OWYxNGIzMjY5ZjY4YzNhZDM0ZjhhZGE3OTE0YTQ3Li5mNTFhOTg2 YWRiNGZhNjc1NWUzMDc5YTllZGE2NWM4Mzk4YTUyYzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEJhY2tpbmdTdG9y ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv Q29vcmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwCkBAIC00OSw3ICs0OSw3IEBAIHZvaWQgQ29vcmRp bmF0ZWRCYWNraW5nU3RvcmVUaWxlOjpzd2FwQnVmZmVycyhXZWJDb3JlOjpUZXh0dXJlTWFwcGVy KiB0ZXh0dXJlTWFwCiAgICAgICAgIHNob3VsZFJlc2V0ID0gdHJ1ZTsKICAgICB9CiAKLSAgICBB U1NFUlQodGV4dHVyZU1hcHBlci0+bWF4VGV4dHVyZVNpemUoKSA+PSBzdGQ6Om1heChtX3RpbGVS ZWN0LnNpemUoKS53aWR0aCgpLCBtX3RpbGVSZWN0LnNpemUoKS5oZWlnaHQoKSkpOworICAgIEFT U0VSVCh0ZXh0dXJlTWFwcGVyLT5tYXhUZXh0dXJlU2l6ZSgpLndpZHRoKCkgPj0gbV90aWxlUmVj dC5zaXplKCkud2lkdGgoKSAgJiYgdGV4dHVyZU1hcHBlci0+bWF4VGV4dHVyZVNpemUoKS5oZWln aHQoKSA+PSBtX3RpbGVSZWN0LnNpemUoKS5oZWlnaHQoKSk7CiAgICAgaWYgKHNob3VsZFJlc2V0 KQogICAgICAgICB0ZXh0dXJlLT5yZXNldChtX3RpbGVSZWN0LnNpemUoKSwgbV9zdXJmYWNlLT5m bGFncygpICYgU2hhcmVhYmxlQml0bWFwOjpTdXBwb3J0c0FscGhhID8gQml0bWFwVGV4dHVyZTo6 U3VwcG9ydHNBbHBoYSA6IDApOwogCg== 174616 2012-11-15 23:38:47 -0800 2012-11-16 00:02:03 -0800 Patch bug-102465-20121116163645.patch text/plain 1839 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDY0YWVjNTEzZWI2NmU3 OWMyMzVmNWQxMTMzZTE1MzFhOTk2NWJmZC4uYjBlMjEwN2FlZDA4NDlkNGQ2ZTgzODk4ZjQ5NTk3 ZWM4MDJmYzZjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTE1ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXSzJdIEJ1ZyBvbiBB U1NFUlQgY29kZSBpbiBDb29yZGluYXRlZEJhY2tpbmdTdG9yZS5jcHAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQ2NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBBU1NFUlQgY29kZSBzaG91bGQg YmUgZml4ZWQgYmVjYXVzZSB0aGUgJ29wZXJhdG9yPj0nIGlzIG5vdCBkZWZpbmVkIGZvciBXZWJD b3JlOjpJbnRTaXplLgorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv Q29vcmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRl ZEJhY2tpbmdTdG9yZVRpbGU6OnN3YXBCdWZmZXJzKToKKwogMjAxMi0xMS0xNSAgSHVhbmcgRG9u Z3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBDb29yZGluYXRlZCBH cmFwaGljczogUmVmYWN0b3IgY29kZSByZWxhdGVkIHRvIGRpcmVjdGx5IGNvbXBvc2l0ZWQgaW1h Z2VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvQ29vcmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4 IDA1NGExZTliZDY5ZjE0YjMyNjlmNjhjM2FkMzRmOGFkYTc5MTRhNDcuLmY1MWE5ODZhZGI0ZmE2 NzU1ZTMwNzlhOWVkYTY1YzgzOThhNTJjMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkQmFja2luZ1N0b3JlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGlu YXRlZEJhY2tpbmdTdG9yZS5jcHAKQEAgLTQ5LDcgKzQ5LDcgQEAgdm9pZCBDb29yZGluYXRlZEJh Y2tpbmdTdG9yZVRpbGU6OnN3YXBCdWZmZXJzKFdlYkNvcmU6OlRleHR1cmVNYXBwZXIqIHRleHR1 cmVNYXAKICAgICAgICAgc2hvdWxkUmVzZXQgPSB0cnVlOwogICAgIH0KIAotICAgIEFTU0VSVCh0 ZXh0dXJlTWFwcGVyLT5tYXhUZXh0dXJlU2l6ZSgpID49IHN0ZDo6bWF4KG1fdGlsZVJlY3Quc2l6 ZSgpLndpZHRoKCksIG1fdGlsZVJlY3Quc2l6ZSgpLmhlaWdodCgpKSk7CisgICAgQVNTRVJUKHRl eHR1cmVNYXBwZXItPm1heFRleHR1cmVTaXplKCkud2lkdGgoKSA+PSBtX3RpbGVSZWN0LnNpemUo KS53aWR0aCgpICAmJiB0ZXh0dXJlTWFwcGVyLT5tYXhUZXh0dXJlU2l6ZSgpLmhlaWdodCgpID49 IG1fdGlsZVJlY3Quc2l6ZSgpLmhlaWdodCgpKTsKICAgICBpZiAoc2hvdWxkUmVzZXQpCiAgICAg ICAgIHRleHR1cmUtPnJlc2V0KG1fdGlsZVJlY3Quc2l6ZSgpLCBtX3N1cmZhY2UtPmZsYWdzKCkg JiBTaGFyZWFibGVCaXRtYXA6OlN1cHBvcnRzQWxwaGEgPyBCaXRtYXBUZXh0dXJlOjpTdXBwb3J0 c0FscGhhIDogMCk7CiAK 174618 2012-11-16 00:02:10 -0800 2012-11-16 00:23:39 -0800 Patch bug-102465-20121116170008.patch text/plain 1838 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDY0YWVjNTEzZWI2NmU3 OWMyMzVmNWQxMTMzZTE1MzFhOTk2NWJmZC4uYjRkMWFjMTUxMGI3MTgxM2EyZDllNDM4ZTQzNWVm NDg2NWFlZGY4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTE1ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXSzJdIEJ1ZyBvbiBB U1NFUlQgY29kZSBpbiBDb29yZGluYXRlZEJhY2tpbmdTdG9yZS5jcHAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQ2NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5vYW0gUm9zZW50aGFsLgorCisgICAgICAgIFRoZSBBU1NFUlQgY29kZSBzaG91bGQg YmUgZml4ZWQgYmVjYXVzZSB0aGUgJ29wZXJhdG9yPj0nIGlzIG5vdCBkZWZpbmVkIGZvciBXZWJD b3JlOjpJbnRTaXplLgorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv Q29vcmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRl ZEJhY2tpbmdTdG9yZVRpbGU6OnN3YXBCdWZmZXJzKToKKwogMjAxMi0xMS0xNSAgSHVhbmcgRG9u Z3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBDb29yZGluYXRlZCBH cmFwaGljczogUmVmYWN0b3IgY29kZSByZWxhdGVkIHRvIGRpcmVjdGx5IGNvbXBvc2l0ZWQgaW1h Z2VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvQ29vcmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4 IDA1NGExZTliZDY5ZjE0YjMyNjlmNjhjM2FkMzRmOGFkYTc5MTRhNDcuLjJiNjdmOGFlNTA5MjZi NGEwNTJlYjk5NGQzNjVhODBjNGQ2NGI0MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkQmFja2luZ1N0b3JlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGlu YXRlZEJhY2tpbmdTdG9yZS5jcHAKQEAgLTQ5LDcgKzQ5LDcgQEAgdm9pZCBDb29yZGluYXRlZEJh Y2tpbmdTdG9yZVRpbGU6OnN3YXBCdWZmZXJzKFdlYkNvcmU6OlRleHR1cmVNYXBwZXIqIHRleHR1 cmVNYXAKICAgICAgICAgc2hvdWxkUmVzZXQgPSB0cnVlOwogICAgIH0KIAotICAgIEFTU0VSVCh0 ZXh0dXJlTWFwcGVyLT5tYXhUZXh0dXJlU2l6ZSgpID49IHN0ZDo6bWF4KG1fdGlsZVJlY3Quc2l6 ZSgpLndpZHRoKCksIG1fdGlsZVJlY3Quc2l6ZSgpLmhlaWdodCgpKSk7CisgICAgQVNTRVJUKHRl eHR1cmVNYXBwZXItPm1heFRleHR1cmVTaXplKCkud2lkdGgoKSA+PSBtX3RpbGVSZWN0LnNpemUo KS53aWR0aCgpICYmIHRleHR1cmVNYXBwZXItPm1heFRleHR1cmVTaXplKCkuaGVpZ2h0KCkgPj0g bV90aWxlUmVjdC5zaXplKCkuaGVpZ2h0KCkpOwogICAgIGlmIChzaG91bGRSZXNldCkKICAgICAg ICAgdGV4dHVyZS0+cmVzZXQobV90aWxlUmVjdC5zaXplKCksIG1fc3VyZmFjZS0+ZmxhZ3MoKSAm IFNoYXJlYWJsZUJpdG1hcDo6U3VwcG9ydHNBbHBoYSA/IEJpdG1hcFRleHR1cmU6OlN1cHBvcnRz QWxwaGEgOiAwKTsKIAo=