102416 2012-11-15 11:44:55 -0800 Update DOMException name: ValidationError 2012-11-15 19:51:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101606 1 arv arv haraken webkit.review.bot oldest_to_newest 768350 0 arv 2012-11-15 11:44:55 -0800 Update DOMException name: ValidationError 768351 1 174493 arv 2012-11-15 11:45:52 -0800 Created attachment 174493 Patch 768606 2 174493 haraken 2012-11-15 16:12:36 -0800 Comment on attachment 174493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174493&action=review Looks OK. > Source/WebCore/dom/ExceptionCode.h:56 > + VALIDATION_ERR = 16, // Historical BTW, are you going to remove these enums once you have replaced all DOM exceptions? 768833 3 arv 2012-11-15 19:14:35 -0800 (In reply to comment #2) > (From update of attachment 174493 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174493&action=review > > Looks OK. > > > Source/WebCore/dom/ExceptionCode.h:56 > > + VALIDATION_ERR = 16, // Historical > > BTW, are you going to remove these enums once you have replaced all DOM exceptions? That is the plan. https://bugs.webkit.org/show_bug.cgi?id=102095 768860 4 174493 webkit.review.bot 2012-11-15 19:51:44 -0800 Comment on attachment 174493 Patch Clearing flags on attachment: 174493 Committed r134882: <http://trac.webkit.org/changeset/134882> 768861 5 webkit.review.bot 2012-11-15 19:51:47 -0800 All reviewed patches have been landed. Closing bug. 174493 2012-11-15 11:45:52 -0800 2012-11-15 19:51:44 -0800 Patch bug-102416-20121115144348.patch text/plain 2885 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0ODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQwOWViNzU3NTI4Mzhk NjJiZTI0YjNhZmQwZjQ2ODRiOThkNjEwMi4uMjk5ZTgxMGU1NGNlMTIwODZjNGVkZTk0YTVlZDRl OTQ0MGU0NGYxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTE1ICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXBkYXRlIERPTUV4Y2Vw dGlvbiBuYW1lOiBWYWxpZGF0aW9uRXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMjQxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFBhdGNoIDE2IG9mIDI1IHRvIHVwZGF0ZSBET01FeGNlcHRpb24g bmFtZSB0byBtYXRjaCB0aGUgc3BlYyBhbmQgRmlyZWZveC4KKworICAgICAgICBWQUxJREFUSU9O X0VSUiBpcyBoaXN0b3JpY2FsIGFuZCBub3QgdXNlZCBpbiBhbnkgc3BlYyBvciBvdXIgY29kZS4K KworICAgICAgICAqIGRvbS9ET01Db3JlRXhjZXB0aW9uLmNwcDoKKyAgICAgICAgKiBkb20vRXhj ZXB0aW9uQ29kZS5oOgorCiAyMDEyLTExLTE1ICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bn b29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gTWVkaWFTdHJlYW0gQVBJOiBBZGQgbWlz c2luZyBXZWJSVENQZWVyQ29ubmVjdGlvbkhhbmRsZXJDbGllbnQ6OmRpZEFkZFJlbW90ZURhdGFD aGFubmVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlvbi5jcHAKaW5kZXggNjRmMmFl OTAwNWVhOGJhN2I2NzNiM2Y4MDFkODYxMTRiYWIxYTM1Ny4uMzZjZDcwMzg0ZjdlYzMyNTI2ZGZh NDU2M2U5NTUxZTNhOTc0OGNhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RPTUNv cmVFeGNlcHRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01Db3JlRXhjZXB0aW9u LmNwcApAQCAtNTAsNyArNTAsNyBAQCBzdGF0aWMgc3RydWN0IENvcmVFeGNlcHRpb24gewogICAg IHsgIkludmFsaWRNb2RpZmljYXRpb25FcnJvciIsICJBbiBhdHRlbXB0IHdhcyBtYWRlIHRvIG1v ZGlmeSB0aGUgdHlwZSBvZiB0aGUgdW5kZXJseWluZyBvYmplY3QuIiB9LAogICAgIHsgIk5BTUVT UEFDRV9FUlIiLCAiQW4gYXR0ZW1wdCB3YXMgbWFkZSB0byBjcmVhdGUgb3IgY2hhbmdlIGFuIG9i amVjdCBpbiBhIHdheSB3aGljaCBpcyBpbmNvcnJlY3Qgd2l0aCByZWdhcmQgdG8gbmFtZXNwYWNl cy4iIH0sCiAgICAgeyAiSU5WQUxJRF9BQ0NFU1NfRVJSIiwgIkEgcGFyYW1ldGVyIG9yIGFuIG9w ZXJhdGlvbiB3YXMgbm90IHN1cHBvcnRlZCBieSB0aGUgdW5kZXJseWluZyBvYmplY3QuIiB9LAot ICAgIHsgIlZBTElEQVRJT05fRVJSIiwgIkEgY2FsbCB0byBhIG1ldGhvZCBzdWNoIGFzIGluc2Vy dEJlZm9yZSBvciByZW1vdmVDaGlsZCB3b3VsZCBtYWtlIHRoZSBOb2RlIGludmFsaWQgd2l0aCBy ZXNwZWN0IHRvIFwicGFydGlhbCB2YWxpZGl0eVwiLCB0aGlzIGV4Y2VwdGlvbiB3b3VsZCBiZSBy YWlzZWQgYW5kIHRoZSBvcGVyYXRpb24gd291bGQgbm90IGJlIGRvbmUuIiB9LAorICAgIHsgIlZh bGlkYXRpb25FcnJvciIsICJBIGNhbGwgdG8gYSBtZXRob2Qgc3VjaCBhcyBpbnNlcnRCZWZvcmUg b3IgcmVtb3ZlQ2hpbGQgd291bGQgbWFrZSB0aGUgTm9kZSBpbnZhbGlkIHdpdGggcmVzcGVjdCB0 byBcInBhcnRpYWwgdmFsaWRpdHlcIiwgdGhpcyBleGNlcHRpb24gd291bGQgYmUgcmFpc2VkIGFu ZCB0aGUgb3BlcmF0aW9uIHdvdWxkIG5vdCBiZSBkb25lLiIgfSwKICAgICB7ICJUWVBFX01JU01B VENIX0VSUiIsICJUaGUgdHlwZSBvZiBhbiBvYmplY3Qgd2FzIGluY29tcGF0aWJsZSB3aXRoIHRo ZSBleHBlY3RlZCB0eXBlIG9mIHRoZSBwYXJhbWV0ZXIgYXNzb2NpYXRlZCB0byB0aGUgb2JqZWN0 LiIgfSwKICAgICB7ICJTRUNVUklUWV9FUlIiLCAiQW4gYXR0ZW1wdCB3YXMgbWFkZSB0byBicmVh ayB0aHJvdWdoIHRoZSBzZWN1cml0eSBwb2xpY3kgb2YgdGhlIHVzZXIgYWdlbnQuIiB9LAogICAg IC8vIEZJWE1FOiBDb3VsZG4ndCBmaW5kIGEgZGVzY3JpcHRpb24gaW4gdGhlIEhUTUwvRE9NIHNw ZWNpZmljYXRpb25zIGZvciBORVRXT1JLX0VSUiwgQUJPUlRfRVJSLCBVUkxfTUlTTUFUQ0hfRVJS LCBhbmQgUVVPVEFfRVhDRUVERURfRVJSCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v RXhjZXB0aW9uQ29kZS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0V4Y2VwdGlvbkNvZGUuaAppbmRl eCAxY2E4N2I4YWViNjkxOGVjNjI0N2NjM2Y5NjFiNjRmMDE5YzZhYmY1Li4zNzY2OTNhNjJmOGEx YWY0NDc3OGM2ZTZjMDRhZTg0MjNiNmNkZjI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vRXhjZXB0aW9uQ29kZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FeGNlcHRpb25Db2Rl LmgKQEAgLTUzLDcgKzUzLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBJTlZBTElE X0FDQ0VTU19FUlIgPSAxNSwKIAogICAgICAgICAvLyBJbnRyb2R1Y2VkIGluIERPTSBMZXZlbCAz OgotICAgICAgICBWQUxJREFUSU9OX0VSUiA9IDE2LAorICAgICAgICBWQUxJREFUSU9OX0VSUiA9 IDE2LCAvLyBIaXN0b3JpY2FsCiAgICAgICAgIFRZUEVfTUlTTUFUQ0hfRVJSID0gMTcsCiAKICAg ICAgICAgLy8gWE1MSHR0cFJlcXVlc3QgZXh0ZW5zaW9uOgo=