102309 2012-11-14 17:59:24 -0800 Coordinated Graphics: A Minor optimization of calculating transforms in CoordinagedGraphicsLayer. 2012-11-15 17:24:48 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102313 1 dongseong.hwang dongseong.hwang gtk-ews noam webkit.review.bot xan.lopez zeno oldest_to_newest 767533 0 dongseong.hwang 2012-11-14 17:59:24 -0800 We calculate an inverse transform each tiledBackingStoreVisibleRect() call by a TiledBackingStore and every tiles. This patch caches the inverse transform to reuse it. 767536 1 174304 dongseong.hwang 2012-11-14 18:00:46 -0800 Created attachment 174304 Patch 767773 2 174304 kenneth 2012-11-14 23:36:59 -0800 Comment on attachment 174304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174304&action=review > Source/WebKit2/ChangeLog:8 > + We calculate an inverse transform each tiledBackingStoreVisibleRect() call by > + a TiledBackingStore and every tiles. > + This patch caches the inverse transform to reuse it. anyway we can assert to make sure it is always updated before use? 767896 3 174391 dongseong.hwang 2012-11-15 03:15:57 -0800 Created attachment 174391 Patch 767897 4 174304 dongseong.hwang 2012-11-15 03:16:41 -0800 Comment on attachment 174304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174304&action=review >> Source/WebKit2/ChangeLog:8 >> + This patch caches the inverse transform to reuse it. > > anyway we can assert to make sure it is always updated before use? Thanks for review! That's good idea! I'll update. 767898 5 dongseong.hwang 2012-11-15 03:17:00 -0800 (In reply to comment #3) > Created an attachment (id=174391) [details] > Patch Add ASSERT :) 767953 6 174391 kenneth 2012-11-15 04:45:24 -0800 Comment on attachment 174391 Patch Do you have any performance data? like how much of an improvement is it? We normally require that 768239 7 174391 gtk-ews 2012-11-15 10:15:40 -0800 Comment on attachment 174391 Patch Attachment 174391 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14831845 768622 8 dongseong.hwang 2012-11-15 16:19:12 -0800 (In reply to comment #6) > (From update of attachment 174391 [details]) > Do you have any performance data? like how much of an improvement is it? We normally require that Fortunately, I can get the data in my machine (Intel® Xeon(R) CPU X5650 @ 2.67GHz × 6). In morphing cubes demo (https://www.webkit.org/blog-files/3d-transforms/morphing-cubes.html), when we push "toggle shape" button, CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect() is called. At the moment, CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly() takes 118ns. CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect() taske 65ns. It means inverse transform takes 55% of times during whole CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly() process. Inverse transform is heavier than what I expected. However, this patch does not improve morphing cubes demo's performance because all layers have just one tile. If we have large layers with 3d transform animation, this patch increase performance fairly. 768638 9 174548 dongseong.hwang 2012-11-15 16:24:13 -0800 Created attachment 174548 Patch 768642 10 dongseong.hwang 2012-11-15 16:25:01 -0800 patch due to flaky gtk ews fail. 768729 11 174548 webkit.review.bot 2012-11-15 17:22:37 -0800 Comment on attachment 174548 Patch Clearing flags on attachment: 174548 Committed r134868: <http://trac.webkit.org/changeset/134868> 768730 12 webkit.review.bot 2012-11-15 17:22:41 -0800 All reviewed patches have been landed. Closing bug. 768732 13 dongseong.hwang 2012-11-15 17:24:48 -0800 Thank Kenneth and noam for review! :) 174304 2012-11-14 18:00:46 -0800 2012-11-15 03:16:41 -0800 Patch bug-102309-20121115105813.patch text/plain 3829 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Njg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTk1Y2ZhODI3OTE5NjNk ZjcwZDUyZGM2MjY0MTRlNDUwZWE4YThmZi4uMzQxNDBkZTVhZjNiMjdhYmEzMjEwNTQ1ZWU4YWIx OWE2MTU5NGUwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTExLTE0ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBBIE1pbm9yIG9wdGltaXphdGlvbiBvZiBjYWxjdWxhdGluZyB0cmFuc2Zv cm1zIGluIENvb3JkaW5hZ2VkR3JhcGhpY3NMYXllci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjMwOQorCisgICAgICAgIFdlIGNhbGN1bGF0ZSBh biBpbnZlcnNlIHRyYW5zZm9ybSBlYWNoIHRpbGVkQmFja2luZ1N0b3JlVmlzaWJsZVJlY3QoKSBj YWxsIGJ5CisgICAgICAgIGEgVGlsZWRCYWNraW5nU3RvcmUgYW5kIGV2ZXJ5IHRpbGVzLgorICAg ICAgICBUaGlzIHBhdGNoIGNhY2hlcyB0aGUgaW52ZXJzZSB0cmFuc2Zvcm0gdG8gcmV1c2UgaXQu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5 ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjp0aWxl ZEJhY2tpbmdTdG9yZVZpc2libGVSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVk R3JhcGhpY3NMYXllcjo6Y29tcHV0ZVRyYW5zZm9ybWVkVmlzaWJsZVJlY3QpOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3NMYXllci5oOgorICAgICAgICAoQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKToKKworMjAxMi0x MS0xNCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKwogICAgICAg ICBDb29yZGluYXRlZCBHcmFwaGljczogUmVtb3ZlIHVudXNlZCBtZW1iZXJzIGFuZCBtZXRob2Rz IGluIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllci4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjE3MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBo aWNzTGF5ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5h dGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcAppbmRleCA1YTUwZjY4MjRk OWViMmIyOTJlYjY3N2Q5ZWVmMjZkNTEwYTE4M2Y2Li45ZWUyNWQ0YzVlNTJjOTRhNmYzNDljMmI2 OTMyMDkxOGE2YmQ3MTYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKQEAgLTY1Niw3ICs2NTYsNyBAQCBJbnRSZWN0 IENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6dGlsZWRCYWNraW5nU3RvcmVWaXNpYmxlUmVjdCgp CiAgICAgLy8gUmV0dXJuIGEgcHJvamVjdGlvbiBvZiB0aGUgdmlzaWJsZSByZWN0IChzdXJmYWNl IGNvb3JkaW5hdGVzKSBvbnRvIHRoZSBsYXllcidzIHBsYW5lIChsYXllciBjb29yZGluYXRlcyku CiAgICAgLy8gVGhlIHJlc3VsdGluZyBxdWFkIG1pZ2h0IGJlIHNxdWV3ZWQgYW5kIHRoZSB2aXNp YmxlIHJlY3QgaXMgdGhlIGJvdW5kaW5nIGJveCBvZiB0aGlzIHF1YWQsCiAgICAgLy8gc28gaXQg bWlnaHQgc3ByZWFkIGZ1cnRoZXIgdGhhbiB0aGUgcmVhbCB2aXNpYmxlIGFyZWEgKGFuZCB0aGVu IGV2ZW4gbW9yZSBhbXBsaWZpZWQgYnkgdGhlIGNvdmVyIHJlY3QgbXVsdGlwbGllcikuCi0gICAg cmV0dXJuIGVuY2xvc2luZ0ludFJlY3QobV9sYXllclRyYW5zZm9ybS5jb21iaW5lZCgpLmludmVy c2UoKS5jbGFtcGVkQm91bmRzT2ZQcm9qZWN0ZWRRdWFkKEZsb2F0UXVhZChGbG9hdFJlY3QobV9j b29yZGluYXRvci0+dmlzaWJsZUNvbnRlbnRzUmVjdCgpKSkpKTsKKyAgICByZXR1cm4gZW5jbG9z aW5nSW50UmVjdChtX2NhY2hlZEludmVyc2VUcmFuc2Zvcm0uY2xhbXBlZEJvdW5kc09mUHJvamVj dGVkUXVhZChGbG9hdFF1YWQoRmxvYXRSZWN0KG1fY29vcmRpbmF0b3ItPnZpc2libGVDb250ZW50 c1JlY3QoKSkpKSk7CiB9CiAKIENvbG9yIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6dGlsZWRC YWNraW5nU3RvcmVCYWNrZ3JvdW5kQ29sb3IoKSBjb25zdApAQCAtNzY1LDYgKzc2NSw3IEBAIHZv aWQgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpjb21wdXRlVHJhbnNmb3JtZWRWaXNpYmxlUmVj dCgpCiAgICAgbV9sYXllclRyYW5zZm9ybS5zZXRGbGF0dGVuaW5nKCFwcmVzZXJ2ZXMzRCgpKTsK ICAgICBtX2xheWVyVHJhbnNmb3JtLnNldENoaWxkcmVuVHJhbnNmb3JtKGNoaWxkcmVuVHJhbnNm b3JtKCkpOwogICAgIG1fbGF5ZXJUcmFuc2Zvcm0uY29tYmluZVRyYW5zZm9ybXMocGFyZW50KCkg PyB0b0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllcihwYXJlbnQoKSktPm1fbGF5ZXJUcmFuc2Zvcm0u Y29tYmluZWRGb3JDaGlsZHJlbigpIDogVHJhbnNmb3JtYXRpb25NYXRyaXgoKSk7CisgICAgbV9j YWNoZWRJbnZlcnNlVHJhbnNmb3JtID0gbV9sYXllclRyYW5zZm9ybS5jb21iaW5lZCgpLmludmVy c2UoKTsKIAogICAgIC8vIFRoZSBjb21iaW5lZCB0cmFuc2Zvcm0gd2lsbCBiZSB1c2VkIGluIHRp bGVkQmFja2luZ1N0b3JlVmlzaWJsZVJlY3QuCiAgICAgYWRqdXN0VmlzaWJsZVJlY3QoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVy LmgKaW5kZXggODk0Yjk4ZjYxOTJmMzMwMjc1NTlhYTMzZjBkN2UwODMyMTY0ZmUzMC4uMzg4NDRk ZjNjOTBhOGY1ZWY4MGNiMjY4YmUwOTY3M2ExMmY5ZDcwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRH cmFwaGljc0xheWVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nv b3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmgKQEAgLTE5Niw2ICsx OTYsNyBAQCBwcml2YXRlOgogICAgIFdlYktpdDo6V2ViTGF5ZXJJbmZvIG1fbGF5ZXJJbmZvOwog ICAgIEdyYXBoaWNzTGF5ZXIqIG1fbWFza1RhcmdldDsKICAgICBHcmFwaGljc0xheWVyVHJhbnNm b3JtIG1fbGF5ZXJUcmFuc2Zvcm07CisgICAgVHJhbnNmb3JtYXRpb25NYXRyaXggbV9jYWNoZWRJ bnZlcnNlVHJhbnNmb3JtOwogICAgIGJvb2wgbV9pblVwZGF0ZU1vZGUgOiAxOwogICAgIGJvb2wg bV9zaG91bGRVcGRhdGVWaXNpYmxlUmVjdDogMTsKICAgICBib29sIG1fc2hvdWxkU3luY0xheWVy U3RhdGU6IDE7Cg== 174391 2012-11-15 03:15:57 -0800 2012-11-15 16:24:09 -0800 Patch bug-102309-20121115201323.patch text/plain 3909 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODE1NmZjM2M3ZTk1YTJm ODliY2IxNTUwMzMyMWJhNmQwOTlhZTcwYS4uYjRkYTMyMWQ0NWYxNGEyZWZiNzJjMDg1YTA0MDg4 NDI4MmY0NzlmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTExLTE0ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBBIE1pbm9yIG9wdGltaXphdGlvbiBvZiBjYWxjdWxhdGluZyB0cmFuc2Zv cm1zIGluIENvb3JkaW5hZ2VkR3JhcGhpY3NMYXllci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjMwOQorCisgICAgICAgIFdlIGNhbGN1bGF0ZSBh biBpbnZlcnNlIHRyYW5zZm9ybSBlYWNoIHRpbGVkQmFja2luZ1N0b3JlVmlzaWJsZVJlY3QoKSBj YWxsIGJ5CisgICAgICAgIGEgVGlsZWRCYWNraW5nU3RvcmUgYW5kIGV2ZXJ5IHRpbGVzLgorICAg ICAgICBUaGlzIHBhdGNoIGNhY2hlcyB0aGUgaW52ZXJzZSB0cmFuc2Zvcm0gdG8gcmV1c2UgaXQu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5 ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjp0aWxl ZEJhY2tpbmdTdG9yZVZpc2libGVSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVk R3JhcGhpY3NMYXllcjo6Y29tcHV0ZVRyYW5zZm9ybWVkVmlzaWJsZVJlY3QpOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3NMYXllci5oOgorICAgICAgICAoQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKToKKworMjAxMi0x MS0xNCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKwogICAgICAg ICBDb29yZGluYXRlZCBHcmFwaGljczogUmVtb3ZlIHVudXNlZCBtZW1iZXJzIGFuZCBtZXRob2Rz IGluIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllci4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjE3MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBo aWNzTGF5ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5h dGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcAppbmRleCA1YTUwZjY4MjRk OWViMmIyOTJlYjY3N2Q5ZWVmMjZkNTEwYTE4M2Y2Li4wMjE0MjEyMzU5NGJhZTIxNGZmYzk5MGJk NGYzNjQ2MzM5NWZmNmM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKQEAgLTY1Niw3ICs2NTYsOCBAQCBJbnRSZWN0 IENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6dGlsZWRCYWNraW5nU3RvcmVWaXNpYmxlUmVjdCgp CiAgICAgLy8gUmV0dXJuIGEgcHJvamVjdGlvbiBvZiB0aGUgdmlzaWJsZSByZWN0IChzdXJmYWNl IGNvb3JkaW5hdGVzKSBvbnRvIHRoZSBsYXllcidzIHBsYW5lIChsYXllciBjb29yZGluYXRlcyku CiAgICAgLy8gVGhlIHJlc3VsdGluZyBxdWFkIG1pZ2h0IGJlIHNxdWV3ZWQgYW5kIHRoZSB2aXNp YmxlIHJlY3QgaXMgdGhlIGJvdW5kaW5nIGJveCBvZiB0aGlzIHF1YWQsCiAgICAgLy8gc28gaXQg bWlnaHQgc3ByZWFkIGZ1cnRoZXIgdGhhbiB0aGUgcmVhbCB2aXNpYmxlIGFyZWEgKGFuZCB0aGVu IGV2ZW4gbW9yZSBhbXBsaWZpZWQgYnkgdGhlIGNvdmVyIHJlY3QgbXVsdGlwbGllcikuCi0gICAg cmV0dXJuIGVuY2xvc2luZ0ludFJlY3QobV9sYXllclRyYW5zZm9ybS5jb21iaW5lZCgpLmludmVy c2UoKS5jbGFtcGVkQm91bmRzT2ZQcm9qZWN0ZWRRdWFkKEZsb2F0UXVhZChGbG9hdFJlY3QobV9j b29yZGluYXRvci0+dmlzaWJsZUNvbnRlbnRzUmVjdCgpKSkpKTsKKyAgICBBU1NFUlQobV9jYWNo ZWRJbnZlcnNlVHJhbnNmb3JtID09IG1fbGF5ZXJUcmFuc2Zvcm0uY29tYmluZWQoKS5pbnZlcnNl KCkpOworICAgIHJldHVybiBlbmNsb3NpbmdJbnRSZWN0KG1fY2FjaGVkSW52ZXJzZVRyYW5zZm9y bS5jbGFtcGVkQm91bmRzT2ZQcm9qZWN0ZWRRdWFkKEZsb2F0UXVhZChGbG9hdFJlY3QobV9jb29y ZGluYXRvci0+dmlzaWJsZUNvbnRlbnRzUmVjdCgpKSkpKTsKIH0KIAogQ29sb3IgQ29vcmRpbmF0 ZWRHcmFwaGljc0xheWVyOjp0aWxlZEJhY2tpbmdTdG9yZUJhY2tncm91bmRDb2xvcigpIGNvbnN0 CkBAIC03NjUsNiArNzY2LDcgQEAgdm9pZCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OmNvbXB1 dGVUcmFuc2Zvcm1lZFZpc2libGVSZWN0KCkKICAgICBtX2xheWVyVHJhbnNmb3JtLnNldEZsYXR0 ZW5pbmcoIXByZXNlcnZlczNEKCkpOwogICAgIG1fbGF5ZXJUcmFuc2Zvcm0uc2V0Q2hpbGRyZW5U cmFuc2Zvcm0oY2hpbGRyZW5UcmFuc2Zvcm0oKSk7CiAgICAgbV9sYXllclRyYW5zZm9ybS5jb21i aW5lVHJhbnNmb3JtcyhwYXJlbnQoKSA/IHRvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKHBhcmVu dCgpKS0+bV9sYXllclRyYW5zZm9ybS5jb21iaW5lZEZvckNoaWxkcmVuKCkgOiBUcmFuc2Zvcm1h dGlvbk1hdHJpeCgpKTsKKyAgICBtX2NhY2hlZEludmVyc2VUcmFuc2Zvcm0gPSBtX2xheWVyVHJh bnNmb3JtLmNvbWJpbmVkKCkuaW52ZXJzZSgpOwogCiAgICAgLy8gVGhlIGNvbWJpbmVkIHRyYW5z Zm9ybSB3aWxsIGJlIHVzZWQgaW4gdGlsZWRCYWNraW5nU3RvcmVWaXNpYmxlUmVjdC4KICAgICBh ZGp1c3RWaXNpYmxlUmVjdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmgg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaAppbmRleCA4OTRiOThmNjE5MmYzMzAyNzU1OWFhMzNm MGQ3ZTA4MzIxNjRmZTMwLi4zODg0NGRmM2M5MGE4ZjVlZjgwY2IyNjhiZTA5NjczYTEyZjlkNzAy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBo aWNzTGF5ZXIuaApAQCAtMTk2LDYgKzE5Niw3IEBAIHByaXZhdGU6CiAgICAgV2ViS2l0OjpXZWJM YXllckluZm8gbV9sYXllckluZm87CiAgICAgR3JhcGhpY3NMYXllciogbV9tYXNrVGFyZ2V0Owog ICAgIEdyYXBoaWNzTGF5ZXJUcmFuc2Zvcm0gbV9sYXllclRyYW5zZm9ybTsKKyAgICBUcmFuc2Zv cm1hdGlvbk1hdHJpeCBtX2NhY2hlZEludmVyc2VUcmFuc2Zvcm07CiAgICAgYm9vbCBtX2luVXBk YXRlTW9kZSA6IDE7CiAgICAgYm9vbCBtX3Nob3VsZFVwZGF0ZVZpc2libGVSZWN0OiAxOwogICAg IGJvb2wgbV9zaG91bGRTeW5jTGF5ZXJTdGF0ZTogMTsK 174548 2012-11-15 16:24:13 -0800 2012-11-15 17:22:37 -0800 Patch bug-102309-20121116092136.patch text/plain 3909 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0ODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWFmZTQxNzZkN2E2ZGFl NjhiZmEwYzdhYzg5MzJhMzI4MDVhNTQ3Ny4uNzgwY2I4ODhiMWJmMjhiMDY0NDljNzkzYzZmZGU1 ZTBlZWFjYTkyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTExLTE0ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBBIE1pbm9yIG9wdGltaXphdGlvbiBvZiBjYWxjdWxhdGluZyB0cmFuc2Zv cm1zIGluIENvb3JkaW5hZ2VkR3JhcGhpY3NMYXllci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjMwOQorCisgICAgICAgIFdlIGNhbGN1bGF0ZSBh biBpbnZlcnNlIHRyYW5zZm9ybSBlYWNoIHRpbGVkQmFja2luZ1N0b3JlVmlzaWJsZVJlY3QoKSBj YWxsIGJ5CisgICAgICAgIGEgVGlsZWRCYWNraW5nU3RvcmUgYW5kIGV2ZXJ5IHRpbGVzLgorICAg ICAgICBUaGlzIHBhdGNoIGNhY2hlcyB0aGUgaW52ZXJzZSB0cmFuc2Zvcm0gdG8gcmV1c2UgaXQu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5 ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjp0aWxl ZEJhY2tpbmdTdG9yZVZpc2libGVSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVk R3JhcGhpY3NMYXllcjo6Y29tcHV0ZVRyYW5zZm9ybWVkVmlzaWJsZVJlY3QpOgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3NMYXllci5oOgorICAgICAgICAoQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKToKKworMjAxMi0x MS0xNCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKwogICAgICAg ICBDb29yZGluYXRlZCBHcmFwaGljczogUmVtb3ZlIHVudXNlZCBtZW1iZXJzIGFuZCBtZXRob2Rz IGluIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllci4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjE3MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBo aWNzTGF5ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5h dGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcAppbmRleCBlOWUyMzc3NWYz NTg4ODQzMDJkOThkYjk0ZDE1NTBmMTNiYTZlYTJiLi40M2U3ZDYzNjNkMmU5NDE2M2Y1MzU3MGY5 ZDQ2MTQ1NjgyNDM3ODU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKQEAgLTY1Niw3ICs2NTYsOCBAQCBJbnRSZWN0 IENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6dGlsZWRCYWNraW5nU3RvcmVWaXNpYmxlUmVjdCgp CiAgICAgLy8gUmV0dXJuIGEgcHJvamVjdGlvbiBvZiB0aGUgdmlzaWJsZSByZWN0IChzdXJmYWNl IGNvb3JkaW5hdGVzKSBvbnRvIHRoZSBsYXllcidzIHBsYW5lIChsYXllciBjb29yZGluYXRlcyku CiAgICAgLy8gVGhlIHJlc3VsdGluZyBxdWFkIG1pZ2h0IGJlIHNxdWV3ZWQgYW5kIHRoZSB2aXNp YmxlIHJlY3QgaXMgdGhlIGJvdW5kaW5nIGJveCBvZiB0aGlzIHF1YWQsCiAgICAgLy8gc28gaXQg bWlnaHQgc3ByZWFkIGZ1cnRoZXIgdGhhbiB0aGUgcmVhbCB2aXNpYmxlIGFyZWEgKGFuZCB0aGVu IGV2ZW4gbW9yZSBhbXBsaWZpZWQgYnkgdGhlIGNvdmVyIHJlY3QgbXVsdGlwbGllcikuCi0gICAg cmV0dXJuIGVuY2xvc2luZ0ludFJlY3QobV9sYXllclRyYW5zZm9ybS5jb21iaW5lZCgpLmludmVy c2UoKS5jbGFtcGVkQm91bmRzT2ZQcm9qZWN0ZWRRdWFkKEZsb2F0UXVhZChGbG9hdFJlY3QobV9j b29yZGluYXRvci0+dmlzaWJsZUNvbnRlbnRzUmVjdCgpKSkpKTsKKyAgICBBU1NFUlQobV9jYWNo ZWRJbnZlcnNlVHJhbnNmb3JtID09IG1fbGF5ZXJUcmFuc2Zvcm0uY29tYmluZWQoKS5pbnZlcnNl KCkpOworICAgIHJldHVybiBlbmNsb3NpbmdJbnRSZWN0KG1fY2FjaGVkSW52ZXJzZVRyYW5zZm9y bS5jbGFtcGVkQm91bmRzT2ZQcm9qZWN0ZWRRdWFkKEZsb2F0UXVhZChGbG9hdFJlY3QobV9jb29y ZGluYXRvci0+dmlzaWJsZUNvbnRlbnRzUmVjdCgpKSkpKTsKIH0KIAogQ29sb3IgQ29vcmRpbmF0 ZWRHcmFwaGljc0xheWVyOjp0aWxlZEJhY2tpbmdTdG9yZUJhY2tncm91bmRDb2xvcigpIGNvbnN0 CkBAIC03NjUsNiArNzY2LDcgQEAgdm9pZCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OmNvbXB1 dGVUcmFuc2Zvcm1lZFZpc2libGVSZWN0KCkKICAgICBtX2xheWVyVHJhbnNmb3JtLnNldEZsYXR0 ZW5pbmcoIXByZXNlcnZlczNEKCkpOwogICAgIG1fbGF5ZXJUcmFuc2Zvcm0uc2V0Q2hpbGRyZW5U cmFuc2Zvcm0oY2hpbGRyZW5UcmFuc2Zvcm0oKSk7CiAgICAgbV9sYXllclRyYW5zZm9ybS5jb21i aW5lVHJhbnNmb3JtcyhwYXJlbnQoKSA/IHRvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKHBhcmVu dCgpKS0+bV9sYXllclRyYW5zZm9ybS5jb21iaW5lZEZvckNoaWxkcmVuKCkgOiBUcmFuc2Zvcm1h dGlvbk1hdHJpeCgpKTsKKyAgICBtX2NhY2hlZEludmVyc2VUcmFuc2Zvcm0gPSBtX2xheWVyVHJh bnNmb3JtLmNvbWJpbmVkKCkuaW52ZXJzZSgpOwogCiAgICAgLy8gVGhlIGNvbWJpbmVkIHRyYW5z Zm9ybSB3aWxsIGJlIHVzZWQgaW4gdGlsZWRCYWNraW5nU3RvcmVWaXNpYmxlUmVjdC4KICAgICBh ZGp1c3RWaXNpYmxlUmVjdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmgg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaAppbmRleCA4YmI4MWQ2YWMyMmNlZjg1MGY0ZTU4N2Rl ZjYwYzIzYzk2OTRiMzY3Li4yZTk0ZmU0NWQwMWVkZjMzYjMyN2MyNWJlNzU4MTFiYWQwNDVhMmJj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBo aWNzTGF5ZXIuaApAQCAtMTk4LDYgKzE5OCw3IEBAIHByaXZhdGU6CiAgICAgV2ViS2l0OjpXZWJM YXllckluZm8gbV9sYXllckluZm87CiAgICAgR3JhcGhpY3NMYXllciogbV9tYXNrVGFyZ2V0Owog ICAgIEdyYXBoaWNzTGF5ZXJUcmFuc2Zvcm0gbV9sYXllclRyYW5zZm9ybTsKKyAgICBUcmFuc2Zv cm1hdGlvbk1hdHJpeCBtX2NhY2hlZEludmVyc2VUcmFuc2Zvcm07CiAgICAgYm9vbCBtX2luVXBk YXRlTW9kZSA6IDE7CiAgICAgYm9vbCBtX3Nob3VsZFVwZGF0ZVZpc2libGVSZWN0OiAxOwogICAg IGJvb2wgbV9zaG91bGRTeW5jTGF5ZXJTdGF0ZTogMTsK