102288 2012-11-14 14:52:23 -0800 IndexedDB: Add clear() method to JSC ScriptValue 2012-11-14 16:24:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 45110 0 michael webkit-unassigned alecflett haraken jsbell webkit.review.bot oldest_to_newest 767338 0 michael 2012-11-14 14:52:23 -0800 IDBRequest::dispatchEvent() calls ScriptValue::clear(), which exists only in the V8 implementation of ScriptValue. This patch adds a clear() method to the JSC implementation of ScriptValue. 767351 1 174267 michael 2012-11-14 15:07:08 -0800 Created attachment 174267 Add clear() method to JSC ScriptValue 767390 2 174267 haraken 2012-11-14 15:47:20 -0800 Comment on attachment 174267 Add clear() method to JSC ScriptValue View in context: https://bugs.webkit.org/attachment.cgi?id=174267&action=review > Source/WebCore/bindings/js/ScriptValue.h:66 > + void clear() > + { > + m_value.clear(); > + } Nit: you can write it in one line. 767402 3 174276 michael 2012-11-14 15:57:03 -0800 Created attachment 174276 Add clear() method to JSC ScriptValue 767407 4 174276 haraken 2012-11-14 16:02:41 -0800 Comment on attachment 174276 Add clear() method to JSC ScriptValue thanks 767431 5 174276 webkit.review.bot 2012-11-14 16:24:28 -0800 Comment on attachment 174276 Add clear() method to JSC ScriptValue Clearing flags on attachment: 174276 Committed r134689: <http://trac.webkit.org/changeset/134689> 767432 6 webkit.review.bot 2012-11-14 16:24:32 -0800 All reviewed patches have been landed. Closing bug. 174267 2012-11-14 15:07:08 -0800 2012-11-14 15:57:03 -0800 Add clear() method to JSC ScriptValue indexeddb-script-value-clear.patch text/plain 1738 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogV2VkLCAxNCBOb3Yg MjAxMiAxMTo0NjowOSAtMDgwMApTdWJqZWN0OiBJbmRleGVkREI6IEFkZCBjbGVhcigpIG1ldGhv ZCB0byBKU0MgU2NyaXB0VmFsdWUKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1NjcmlwdFZhbHVlLmggfCAgICA1ICsrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDIyIGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODNjZjkzMy4uNGEwZmQ0OSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIwIEBACisyMDEyLTExLTE0ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhr Lm9yZz4KKworICAgICAgICBJbmRleGVkREI6IEFkZCBjbGVhcigpIG1ldGhvZCB0byBKU0MgU2Ny aXB0VmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMjI4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluZGV4ZWREQiB1c2VzIHRoZSBTY3JpcHRWYWx1ZTo6Y2xlYXIoKSBtZXRob2QsIHdoaWNoIGV4 aXN0ZWQKKyAgICAgICAgcHJldmlvdXNseSBvbmx5IGluIHRoZSBWOCBpbXBsZW1lbnRhdGlvbiBv ZiBTY3JpcHRWYWx1ZS4gVGhpcworICAgICAgICBjaGFuZ2UgaXMgbmVjZXNzYXJ5IHRvIGltcGxl bWVudCBJbmRleGVkREIgZm9yIEpTQy4KKworICAgICAgICBUZXN0czogc3RvcmFnZS9pbmRleGVk ZGIvKgorCisgICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0VmFsdWUuaDoKKyAgICAgICAgKFdl YkNvcmU6OlNjcmlwdFZhbHVlOjpjbGVhcik6CisgICAgICAgIChTY3JpcHRWYWx1ZSk6CisKIDIw MTItMTEtMTQgIEhlbGRlciBDb3JyZWlhICA8aGVsZGVyLmNvcnJlaWFAbm9raWEuY29tPgogCiAg ICAgICAgIFtUZXhNYXBdW0NhaXJvXSBBY2NlbGVyYXRlZCBjb21wb3NpdGluZyBkZWJ1ZyB2aXN1 YWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRWYWx1ZS5o IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0VmFsdWUuaAppbmRleCAyNDZjYWUw Li5lNjYxNDhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRW YWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmgKQEAg LTYwLDYgKzYwLDExIEBAIHB1YmxpYzoKICAgICBib29sIGlzRnVuY3Rpb24oKSBjb25zdDsKICAg ICBib29sIGhhc05vVmFsdWUoKSBjb25zdCB7IHJldHVybiAhbV92YWx1ZTsgfQogCisgICAgdm9p ZCBjbGVhcigpCisgICAgeworICAgICAgICBtX3ZhbHVlLmNsZWFyKCk7CisgICAgfQorCiAgICAg Ym9vbCBvcGVyYXRvcj09KGNvbnN0IFNjcmlwdFZhbHVlJiBvdGhlcikgY29uc3QgeyByZXR1cm4g bV92YWx1ZSA9PSBvdGhlci5tX3ZhbHVlOyB9CiAKICAgICBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZT4gc2VyaWFsaXplKFNjcmlwdFN0YXRlKiwgU2VyaWFsaXphdGlvbkVycm9yTW9k ZSA9IFRocm93aW5nKTsKLS0gCjEuNy45LjUKCg== 174276 2012-11-14 15:57:03 -0800 2012-11-14 16:24:28 -0800 Add clear() method to JSC ScriptValue indexeddb-script-value-clear.patch text/plain 1713 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogV2VkLCAxNCBOb3Yg MjAxMiAxNTo1MzozNyAtMDgwMApTdWJqZWN0OiBJbmRleGVkREI6IEFkZCBjbGVhcigpIG1ldGhv ZCB0byBKU0MgU2NyaXB0VmFsdWUKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1NjcmlwdFZhbHVlLmggfCAgICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODNjZjkzMy4uZmQ2ZjQ1NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIwIEBACisyMDEyLTExLTE0ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9y Zz4KKworICAgICAgICBJbmRleGVkREI6IEFkZCBjbGVhcigpIG1ldGhvZCB0byBKU0MgU2NyaXB0 VmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MjI4OAorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbnRhcm8gSGFyYS4KKworICAgICAgICBJbmRl eGVkREIgdXNlcyB0aGUgU2NyaXB0VmFsdWU6OmNsZWFyKCkgbWV0aG9kLCB3aGljaCBleGlzdGVk CisgICAgICAgIHByZXZpb3VzbHkgb25seSBpbiB0aGUgVjggaW1wbGVtZW50YXRpb24gb2YgU2Ny aXB0VmFsdWUuIFRoaXMKKyAgICAgICAgY2hhbmdlIGlzIG5lY2Vzc2FyeSB0byBpbXBsZW1lbnQg SW5kZXhlZERCIGZvciBKU0MuCisKKyAgICAgICAgVGVzdHM6IHN0b3JhZ2UvaW5kZXhlZGRiLyoK KworICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmg6CisgICAgICAgIChXZWJDb3Jl OjpTY3JpcHRWYWx1ZTo6Y2xlYXIpOgorICAgICAgICAoU2NyaXB0VmFsdWUpOgorCiAyMDEyLTEx LTE0ICBIZWxkZXIgQ29ycmVpYSAgPGhlbGRlci5jb3JyZWlhQG5va2lhLmNvbT4KIAogICAgICAg ICBbVGV4TWFwXVtDYWlyb10gQWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgZGVidWcgdmlzdWFscwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0VmFsdWUuaCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmgKaW5kZXggMjQ2Y2FlMC4uMGMz MjRjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0VmFsdWUu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRWYWx1ZS5oCkBAIC02MCw2 ICs2MCw4IEBAIHB1YmxpYzoKICAgICBib29sIGlzRnVuY3Rpb24oKSBjb25zdDsKICAgICBib29s IGhhc05vVmFsdWUoKSBjb25zdCB7IHJldHVybiAhbV92YWx1ZTsgfQogCisgICAgdm9pZCBjbGVh cigpIHsgbV92YWx1ZS5jbGVhcigpOyB9CisKICAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgU2Ny aXB0VmFsdWUmIG90aGVyKSBjb25zdCB7IHJldHVybiBtX3ZhbHVlID09IG90aGVyLm1fdmFsdWU7 IH0KIAogICAgIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBzZXJpYWxpemUoU2Ny aXB0U3RhdGUqLCBTZXJpYWxpemF0aW9uRXJyb3JNb2RlID0gVGhyb3dpbmcpOwotLSAKMS43Ljku NQoK