102089 2012-11-13 08:09:45 -0800 Update DOMException name: DOMStringSizeError 2012-11-15 15:26:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101606 1 arv arv ojan webkit.review.bot oldest_to_newest 765614 0 arv 2012-11-13 08:09:45 -0800 Update DOMException name: DOMStringSizeError 765615 1 173896 arv 2012-11-13 08:11:04 -0800 Created attachment 173896 Patch 765656 2 173896 ojan 2012-11-13 08:51:42 -0800 Comment on attachment 173896 Patch Can we just comment out the enum value with a short explanatory comment and get rid of the entry in coreExceptions? 765662 3 arv 2012-11-13 08:59:51 -0800 (In reply to comment #2) > (From update of attachment 173896 [details]) > Can we just comment out the enum value with a short explanatory comment and get rid of the entry in coreExceptions? Yes, lets do that https://bugs.webkit.org/show_bug.cgi?id=102095 768070 4 arv 2012-11-15 07:55:07 -0800 Ojan, can I get an r+ on this one? 768237 5 173896 webkit.review.bot 2012-11-15 10:14:37 -0800 Comment on attachment 173896 Patch Rejecting attachment 173896 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: le Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/DOMCoreException.cpp Hunk #1 FAILED at 36. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/DOMCoreException.cpp.rej patching file Source/WebCore/dom/ExceptionCode.h Hunk #1 succeeded at 35 with fuzz 1 (offset 3 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14848442 768343 6 174492 arv 2012-11-15 11:36:58 -0800 Created attachment 174492 Patch for landing 768568 7 174492 webkit.review.bot 2012-11-15 15:26:50 -0800 Comment on attachment 174492 Patch for landing Clearing flags on attachment: 174492 Committed r134840: <http://trac.webkit.org/changeset/134840> 768569 8 webkit.review.bot 2012-11-15 15:26:53 -0800 All reviewed patches have been landed. Closing bug. 173896 2012-11-13 08:11:04 -0800 2012-11-15 11:36:55 -0800 Patch bug-102089-20121113110905.patch text/plain 2344 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM3MGM5OWU4ODIwNjZj ZGEwOWQ5MTdmOWQ4Yjg0YmY0YzljY2I4OC4uNzg4MzY3YjIwZWYwZTIwOTQyYjJlZGYzZGMxOTNm NThlMzdiNWFmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTEzICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXBkYXRlIERPTUV4Y2Vw dGlvbiBuYW1lOiBET01TdHJpbmdTaXplRXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjA4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFBhdGNoIDIgb2YgMjUgdG8gdXBkYXRlIERPTUV4Y2VwdGlv biBuYW1lIHRvIG1hdGNoIHRoZSBzcGVjIGFuZCBGaXJlZm94LgorCisgICAgICAgIERPTVNUUklO R19TSVpFX0VSUiBpcyBoaXN0b3JpY2FsIGFuZCBub3QgdXNlZCBpbiBhbnkgc3BlYyBvciBpbiBv dXIgY29kZS4KKworICAgICAgICAqIGRvbS9ET01Db3JlRXhjZXB0aW9uLmNwcDoKKyAgICAgICAg KiBkb20vRXhjZXB0aW9uQ29kZS5oOgorCiAyMDEyLTExLTEzICBBbmRyZWFzIEtsaW5nICA8a2xp bmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBFeHBsb2l0IEVsZW1lbnRBdHRyaWJ1dGVEYXRhIHNo YXJpbmcgaW4gTm9kZS5jbG9uZU5vZGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v RE9NQ29yZUV4Y2VwdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRE9NQ29yZUV4Y2VwdGlv bi5jcHAKaW5kZXggMTQ5NWNhNjAxNjQ1YTBjNmUzNmYwYTYwZTBlNzk3MDMwMmQ2NzBlZC4uMDk4 YmVlMDdiZDU4NjM0N2NmZmM5YTEzZTI5MTRjM2EyNTg5ODU1NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0RPTUNvcmVFeGNlcHRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9ET01Db3JlRXhjZXB0aW9uLmNwcApAQCAtMzYsNyArMzYsNyBAQCBzdGF0aWMgc3RydWN0IENv cmVFeGNlcHRpb24gewogICAgIGNvbnN0IGNoYXIqIGNvbnN0IGRlc2NyaXB0aW9uOwogfSBjb3Jl RXhjZXB0aW9uc1tdID0gewogICAgIHsgIklOREVYX1NJWkVfRVJSIiwgIkluZGV4IG9yIHNpemUg d2FzIG5lZ2F0aXZlLCBvciBncmVhdGVyIHRoYW4gdGhlIGFsbG93ZWQgdmFsdWUuIiB9LAotICAg IHsgIkRPTVNUUklOR19TSVpFX0VSUiIsICJUaGUgc3BlY2lmaWVkIHJhbmdlIG9mIHRleHQgZGlk IG5vdCBmaXQgaW50byBhIERPTVN0cmluZy4iIH0sCisgICAgeyAiRE9NU3RyaW5nU2l6ZUVycm9y IiwgIlRoZSBzcGVjaWZpZWQgcmFuZ2Ugb2YgdGV4dCBkaWQgbm90IGZpdCBpbnRvIGEgRE9NU3Ry aW5nLiIgfSwKICAgICB7ICJISUVSQVJDSFlfUkVRVUVTVF9FUlIiLCAiQSBOb2RlIHdhcyBpbnNl cnRlZCBzb21ld2hlcmUgaXQgZG9lc24ndCBiZWxvbmcuIiB9LAogICAgIHsgIldST05HX0RPQ1VN RU5UX0VSUiIsICJBIE5vZGUgd2FzIHVzZWQgaW4gYSBkaWZmZXJlbnQgZG9jdW1lbnQgdGhhbiB0 aGUgb25lIHRoYXQgY3JlYXRlZCBpdCAodGhhdCBkb2Vzbid0IHN1cHBvcnQgaXQpLiIgfSwKICAg ICB7ICJJTlZBTElEX0NIQVJBQ1RFUl9FUlIiLCAiQW4gaW52YWxpZCBvciBpbGxlZ2FsIGNoYXJh Y3RlciB3YXMgc3BlY2lmaWVkLCBzdWNoIGFzIGluIGFuIFhNTCBuYW1lLiIgfSwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FeGNlcHRpb25Db2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9k b20vRXhjZXB0aW9uQ29kZS5oCmluZGV4IDUxZjhkYzJkM2YxMjQ5YjgzYTVmZGQ4NDM2OGU0Y2M5 MzM0MjY0OTkuLmQ1MTVhNzk0N2EyZDhiODYyOTc2YzIyMWFiOGJkNzRhZDk5MDMxODcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FeGNlcHRpb25Db2RlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0V4Y2VwdGlvbkNvZGUuaApAQCAtMzIsNyArMzIsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKICAgICBlbnVtIHsKICAgICAgICAgSU5ERVhfU0laRV9FUlIgPSAxLAotICAgICAg ICBET01TVFJJTkdfU0laRV9FUlIgPSAyLAorICAgICAgICBET01TVFJJTkdfU0laRV9FUlIgPSAy LCAvLyBoaXN0b3JpY2FsCiAgICAgICAgIEhJRVJBUkNIWV9SRVFVRVNUX0VSUiA9IDMsCiAgICAg ICAgIFdST05HX0RPQ1VNRU5UX0VSUiA9IDQsCiAgICAgICAgIElOVkFMSURfQ0hBUkFDVEVSX0VS UiA9IDUsCg== 174492 2012-11-15 11:36:58 -0800 2012-11-15 15:26:50 -0800 Patch for landing bug-102089-20121115143455.patch text/plain 2438 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0ODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQwOWViNzU3NTI4Mzhk NjJiZTI0YjNhZmQwZjQ2ODRiOThkNjEwMi4uNWVlMWNlZDJkMjYxYzY2M2Y5YTRhNjkwMTc2MjQ4 Y2M5NTNmN2ZhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTEzICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVXBkYXRlIERPTUV4Y2Vw dGlvbiBuYW1lOiBET01TdHJpbmdTaXplRXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjA4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE9qYW4g VmFmYWkuCisKKyAgICAgICAgUGF0Y2ggMiBvZiAyNSB0byB1cGRhdGUgRE9NRXhjZXB0aW9uIG5h bWUgdG8gbWF0Y2ggdGhlIHNwZWMgYW5kIEZpcmVmb3guCisKKyAgICAgICAgRE9NU1RSSU5HX1NJ WkVfRVJSIGlzIGhpc3RvcmljYWwgYW5kIG5vdCB1c2VkIGluIGFueSBzcGVjIG9yIGluIG91ciBj b2RlLgorCisgICAgICAgICogZG9tL0RPTUNvcmVFeGNlcHRpb24uY3BwOgorICAgICAgICAqIGRv bS9FeGNlcHRpb25Db2RlLmg6CisKIDIwMTItMTEtMTUgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9t bXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBNZWRpYVN0cmVhbSBBUEk6IEFk ZCBtaXNzaW5nIFdlYlJUQ1BlZXJDb25uZWN0aW9uSGFuZGxlckNsaWVudDo6ZGlkQWRkUmVtb3Rl RGF0YUNoYW5uZWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01Db3JlRXhjZXB0 aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9ET01Db3JlRXhjZXB0aW9uLmNwcAppbmRleCA2 NGYyYWU5MDA1ZWE4YmE3YjY3M2IzZjgwMWQ4NjExNGJhYjFhMzU3Li42YWI5ZTNmZjVlNDQ4MTUz MjM3YjcxNDQ4ZmIxZTZjZTJkNjk5YmEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RE9NQ29yZUV4Y2VwdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RPTUNvcmVFeGNl cHRpb24uY3BwCkBAIC0zNiw3ICszNiw3IEBAIHN0YXRpYyBzdHJ1Y3QgQ29yZUV4Y2VwdGlvbiB7 CiAgICAgY29uc3QgY2hhciogY29uc3QgZGVzY3JpcHRpb247CiB9IGNvcmVFeGNlcHRpb25zW10g PSB7CiAgICAgeyAiSW5kZXhTaXplRXJyb3IiLCAiSW5kZXggb3Igc2l6ZSB3YXMgbmVnYXRpdmUs IG9yIGdyZWF0ZXIgdGhhbiB0aGUgYWxsb3dlZCB2YWx1ZS4iIH0sCi0gICAgeyAiRE9NU1RSSU5H X1NJWkVfRVJSIiwgIlRoZSBzcGVjaWZpZWQgcmFuZ2Ugb2YgdGV4dCBkaWQgbm90IGZpdCBpbnRv IGEgRE9NU3RyaW5nLiIgfSwKKyAgICB7ICJET01TdHJpbmdTaXplRXJyb3IiLCAiVGhlIHNwZWNp ZmllZCByYW5nZSBvZiB0ZXh0IGRpZCBub3QgZml0IGludG8gYSBET01TdHJpbmcuIiB9LAogICAg IHsgIkhpZXJhcmNoeVJlcXVlc3RFcnJvciIsICJBIE5vZGUgd2FzIGluc2VydGVkIHNvbWV3aGVy ZSBpdCBkb2Vzbid0IGJlbG9uZy4iIH0sCiAgICAgeyAiV3JvbmdEb2N1bWVudEVycm9yIiwgIkEg Tm9kZSB3YXMgdXNlZCBpbiBhIGRpZmZlcmVudCBkb2N1bWVudCB0aGFuIHRoZSBvbmUgdGhhdCBj cmVhdGVkIGl0ICh0aGF0IGRvZXNuJ3Qgc3VwcG9ydCBpdCkuIiB9LAogICAgIHsgIkludmFsaWRD aGFyYWN0ZXJFcnJvciIsICJBbiBpbnZhbGlkIG9yIGlsbGVnYWwgY2hhcmFjdGVyIHdhcyBzcGVj aWZpZWQsIHN1Y2ggYXMgaW4gYW4gWE1MIG5hbWUuIiB9LApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL0V4Y2VwdGlvbkNvZGUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FeGNlcHRpb25D b2RlLmgKaW5kZXggMWNhODdiOGFlYjY5MThlYzYyNDdjYzNmOTYxYjY0ZjAxOWM2YWJmNS4uYzgz ODAzNmE0MDYxNzM2ODVlNzE1NTA4ZGQ0NTgyZmE4ZWQ3NDNmNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0V4Y2VwdGlvbkNvZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXhj ZXB0aW9uQ29kZS5oCkBAIC0zNSw3ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAv LyBjaGFuZ2VkIG9yIHJlbW92ZWQgZnJvbSB0aGUgc3BlY2lmaWNhdGlvbnMuCiAgICAgZW51bSB7 CiAgICAgICAgIElOREVYX1NJWkVfRVJSID0gMSwKLSAgICAgICAgRE9NU1RSSU5HX1NJWkVfRVJS ID0gMiwKKyAgICAgICAgRE9NU1RSSU5HX1NJWkVfRVJSID0gMiwgLy8gaGlzdG9yaWNhbAogICAg ICAgICBISUVSQVJDSFlfUkVRVUVTVF9FUlIgPSAzLAogICAgICAgICBXUk9OR19ET0NVTUVOVF9F UlIgPSA0LAogICAgICAgICBJTlZBTElEX0NIQVJBQ1RFUl9FUlIgPSA1LAo=