102035 2012-11-12 19:29:29 -0800 REGRESSION(134048): TiledBackingStore must create tiles when the contents rect is changed. 2012-11-21 02:36:07 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101656 1 dongseong.hwang dongseong.hwang kenneth webkit.review.bot oldest_to_newest 765132 0 dongseong.hwang 2012-11-12 19:29:29 -0800 Before r134048, the visibleRect contained information of both the viewport and the contents rect. Now the visible rect is related to only the viewport. So TiledBackingStore::coverWithTilesIfNeeded() early returns even if the contents rect is changed, because changing the contents rect is independent on changing both a trajectory vector and the visible rect. 765133 1 173796 dongseong.hwang 2012-11-12 19:34:07 -0800 Created attachment 173796 Patch 765710 2 173796 darin 2012-11-13 09:54:34 -0800 Comment on attachment 173796 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173796&action=review > Source/WebCore/platform/graphics/TiledBackingStore.cpp:72 > + const IntRect rect = mapFromContents(m_client->tiledBackingStoreContentsRect()); The const here is unneeded and not the right coding style. The visibleRect variable on the previous line is equally constant. 766076 3 173994 dongseong.hwang 2012-11-13 14:44:03 -0800 Created attachment 173994 Patch 766077 4 dongseong.hwang 2012-11-13 14:44:29 -0800 (In reply to comment #2) > (From update of attachment 173796 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173796&action=review > > > Source/WebCore/platform/graphics/TiledBackingStore.cpp:72 > > + const IntRect rect = mapFromContents(m_client->tiledBackingStoreContentsRect()); > > The const here is unneeded and not the right coding style. The visibleRect variable on the previous line is equally constant. Thanks for review! I removed 'const'. 772662 5 173994 kenneth 2012-11-21 02:09:33 -0800 Comment on attachment 173994 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173994&action=review > Source/WebCore/platform/graphics/TiledBackingStore.cpp:77 > > - if (m_trajectoryVector == normalizedVector && m_visibleRect == visibleRect) > + if (m_trajectoryVector == normalizedVector && m_visibleRect == visibleRect && m_rect == rect) I would have added a comment here 772673 6 173994 webkit.review.bot 2012-11-21 02:18:40 -0800 Comment on attachment 173994 Patch Clearing flags on attachment: 173994 Committed r135366: <http://trac.webkit.org/changeset/135366> 772674 7 webkit.review.bot 2012-11-21 02:18:43 -0800 All reviewed patches have been landed. Closing bug. 772694 8 173994 dongseong.hwang 2012-11-21 02:36:07 -0800 Comment on attachment 173994 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173994&action=review >> Source/WebCore/platform/graphics/TiledBackingStore.cpp:77 >> + if (m_trajectoryVector == normalizedVector && m_visibleRect == visibleRect && m_rect == rect) > > I would have added a comment here Thanks for your favor! 173796 2012-11-12 19:34:07 -0800 2012-11-13 14:44:00 -0800 Patch bug-102035-20121113123144.patch text/plain 2228 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzI1MjZjNTIzM2UxZTYy MmE3M2I5ZTkwYjNlOTIxNTI3NjY5MGVjNS4uZTQ5MWVjY2ViNGI0MzJlOTNhNTA1MmRmNDhjZmU5 YWNmOWRjZWY4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTExLTEyICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIFJFR1JFU1NJ T04oMTM0MDQ4KTogVGlsZWRCYWNraW5nU3RvcmUgbXVzdCBjcmVhdGUgdGlsZXMgd2hlbiB0aGUg Y29udGVudHMgcmVjdCBpcyBjaGFuZ2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMDM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQmVmb3JlIHIxMzQwNDgsIHRoZSB2aXNpYmxlUmVjdCBjb250YWlu ZWQgaW5mb3JtYXRpb24gb2YgYm90aCB0aGUgdmlld3BvcnQgYW5kCisgICAgICAgIHRoZSBjb250 ZW50cyByZWN0LiBOb3cgdGhlIHZpc2libGUgcmVjdCBpcyByZWxhdGVkIHRvIG9ubHkgdGhlIHZp ZXdwb3J0LiBTbworICAgICAgICBUaWxlZEJhY2tpbmdTdG9yZTo6Y292ZXJXaXRoVGlsZXNJZk5l ZWRlZCgpIGVhcmx5IHJldHVybnMgZXZlbiBpZiB0aGUgY29udGVudHMKKyAgICAgICAgcmVjdCBp cyBjaGFuZ2VkLCBiZWNhdXNlIGNoYW5naW5nIHRoZSBjb250ZW50cyByZWN0IGlzIGluZGVwZW5k ZW50IG9uIGNoYW5naW5nCisgICAgICAgIGJvdGggYSB0cmFqZWN0b3J5IHZlY3RvciBhbmQgdGhl IHZpc2libGUgcmVjdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2lu Z1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkQmFja2luZ1N0b3JlOjpjb3Zlcldp dGhUaWxlc0lmTmVlZGVkKToKKworMjAxMi0xMS0xMiAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxs YUBjb21wYW55MTAwLm5ldD4KKwogICAgICAgICBbUXRdIFJFR1JFU1NJT04oMTM0MTQyKTogb3Zl cnNjYWxlZCB0aWxlcyBpbiBwaXhlbCB0ZXN0IHJlc3VsdHMgYW5kIE1pbmlCcm93c2VyCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE5MTgKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3Rv cmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3Rv cmUuY3BwCmluZGV4IGZjZWFkYWE4NDNiNDcyODljMmQzZDgxMDY0MmY2YjhjNzA5YTkxODUuLjg5 NTc5NmJmMGExNWFjOTc5MGRhMzNkYTFlNWMyMWM3MTgxNTMzMzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKQEAg LTY5LDExICs2OSwxMiBAQCB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjpzZXRUaWxlQ3JlYXRpb25E ZWxheShkb3VibGUgZGVsYXkpCiB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjpjb3ZlcldpdGhUaWxl c0lmTmVlZGVkKGNvbnN0IEZsb2F0UG9pbnQmIHRyYWplY3RvcnlWZWN0b3IpCiB7CiAgICAgSW50 UmVjdCB2aXNpYmxlUmVjdCA9IHRoaXMtPnZpc2libGVSZWN0KCk7CisgICAgY29uc3QgSW50UmVj dCByZWN0ID0gbWFwRnJvbUNvbnRlbnRzKG1fY2xpZW50LT50aWxlZEJhY2tpbmdTdG9yZUNvbnRl bnRzUmVjdCgpKTsKIAogICAgIEZsb2F0UG9pbnQgbm9ybWFsaXplZFZlY3RvciA9IHRyYWplY3Rv cnlWZWN0b3I7CiAgICAgbm9ybWFsaXplZFZlY3Rvci5ub3JtYWxpemUoKTsKIAotICAgIGlmICht X3RyYWplY3RvcnlWZWN0b3IgPT0gbm9ybWFsaXplZFZlY3RvciAmJiBtX3Zpc2libGVSZWN0ID09 IHZpc2libGVSZWN0KQorICAgIGlmIChtX3RyYWplY3RvcnlWZWN0b3IgPT0gbm9ybWFsaXplZFZl Y3RvciAmJiBtX3Zpc2libGVSZWN0ID09IHZpc2libGVSZWN0ICYmIG1fcmVjdCA9PSByZWN0KQog ICAgICAgICByZXR1cm47CiAKICAgICBtX3RyYWplY3RvcnlWZWN0b3IgPSBub3JtYWxpemVkVmVj dG9yOwo= 173994 2012-11-13 14:44:03 -0800 2012-11-21 02:36:07 -0800 Patch bug-102035-20121114074136.patch text/plain 2150 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRiNTYwMWQ0MzRlYTYz NWEzZjI4YTVjN2QyZjZjYmYyYjVjYTMyOS4uMmI3NGNhN2MxMzZiNWVkYzE1OGIwYzNhY2RmM2Rh ZmM5OWU2Njc0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTEzICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFJFR1JFU1NJ T04oMTM0MDQ4KTogVGlsZWRCYWNraW5nU3RvcmUgbXVzdCBjcmVhdGUgdGlsZXMgd2hlbiB0aGUg Y29udGVudHMgcmVjdCBpcyBjaGFuZ2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMDM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQmVmb3JlIHIxMzQwNDgsIHRoZSB2aXNpYmxlUmVjdCBjb250YWlu ZWQgaW5mb3JtYXRpb24gb2YgYm90aCB0aGUgdmlld3BvcnQgYW5kCisgICAgICAgIHRoZSBjb250 ZW50cyByZWN0LiBOb3cgdGhlIHZpc2libGUgcmVjdCBpcyByZWxhdGVkIHRvIG9ubHkgdGhlIHZp ZXdwb3J0LiBTbworICAgICAgICBUaWxlZEJhY2tpbmdTdG9yZTo6Y292ZXJXaXRoVGlsZXNJZk5l ZWRlZCgpIGVhcmx5IHJldHVybnMgZXZlbiBpZiB0aGUgY29udGVudHMKKyAgICAgICAgcmVjdCBp cyBjaGFuZ2VkLCBiZWNhdXNlIGNoYW5naW5nIHRoZSBjb250ZW50cyByZWN0IGlzIGluZGVwZW5k ZW50IG9uIGNoYW5naW5nCisgICAgICAgIGJvdGggYSB0cmFqZWN0b3J5IHZlY3RvciBhbmQgdGhl IHZpc2libGUgcmVjdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1RpbGVkQmFja2lu Z1N0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkQmFja2luZ1N0b3JlOjpjb3Zlcldp dGhUaWxlc0lmTmVlZGVkKToKKwogMjAxMi0xMS0xMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIFtWOF0gaW5zdGFudGlhdGVWOE9iamVjdCBzaG91bGQgZW5jYXB1 bGF0ZSB0aGUgdHJpY2t5IGNyZWF0aW9uQ29udGV4dCBsb2dpYwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4IGZj ZWFkYWE4NDNiNDcyODljMmQzZDgxMDY0MmY2YjhjNzA5YTkxODUuLjlhMzdhOTZmYWIyZWI2N2Ey NTE3MzVlZjlkZWMwZmE4ZjhiNGYyYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKQEAgLTY5LDExICs2OSwxMiBA QCB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjpzZXRUaWxlQ3JlYXRpb25EZWxheShkb3VibGUgZGVs YXkpCiB2b2lkIFRpbGVkQmFja2luZ1N0b3JlOjpjb3ZlcldpdGhUaWxlc0lmTmVlZGVkKGNvbnN0 IEZsb2F0UG9pbnQmIHRyYWplY3RvcnlWZWN0b3IpCiB7CiAgICAgSW50UmVjdCB2aXNpYmxlUmVj dCA9IHRoaXMtPnZpc2libGVSZWN0KCk7CisgICAgSW50UmVjdCByZWN0ID0gbWFwRnJvbUNvbnRl bnRzKG1fY2xpZW50LT50aWxlZEJhY2tpbmdTdG9yZUNvbnRlbnRzUmVjdCgpKTsKIAogICAgIEZs b2F0UG9pbnQgbm9ybWFsaXplZFZlY3RvciA9IHRyYWplY3RvcnlWZWN0b3I7CiAgICAgbm9ybWFs aXplZFZlY3Rvci5ub3JtYWxpemUoKTsKIAotICAgIGlmIChtX3RyYWplY3RvcnlWZWN0b3IgPT0g bm9ybWFsaXplZFZlY3RvciAmJiBtX3Zpc2libGVSZWN0ID09IHZpc2libGVSZWN0KQorICAgIGlm IChtX3RyYWplY3RvcnlWZWN0b3IgPT0gbm9ybWFsaXplZFZlY3RvciAmJiBtX3Zpc2libGVSZWN0 ID09IHZpc2libGVSZWN0ICYmIG1fcmVjdCA9PSByZWN0KQogICAgICAgICByZXR1cm47CiAKICAg ICBtX3RyYWplY3RvcnlWZWN0b3IgPSBub3JtYWxpemVkVmVjdG9yOwo=