101911 2012-11-12 02:14:55 -0800 [Cairo] fillRectWithColor with Color::transparent doesn't perform anything 2012-11-26 10:57:50 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Android Linux RESOLVED FIXED P2 Normal --- 103081 0 hurnjoo.lee webkit-unassigned d-r kenneth tmpsantos webkit.review.bot yael oldest_to_newest 764165 0 hurnjoo.lee 2012-11-12 02:14:55 -0800 fillRectWithColor with Color::transparent doesn't perform anything because fillRectWithColor does early-return if the alpha value of color is zero. But we expect that fill the rect with transparent color in case the cairo_operator is CAIRO_OPERATOR_SOURCE. 764166 1 173591 hurnjoo.lee 2012-11-12 02:17:18 -0800 Created attachment 173591 proposed patch 764394 2 173591 d-r 2012-11-12 07:24:16 -0800 Comment on attachment 173591 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=173591&action=review > Source/WebCore/ChangeLog:13 > + Covered by existing tests. Do you have an example? Which test is passing with this change, or in other words: What was broken before? 765311 3 hurnjoo.lee 2012-11-12 23:40:26 -0800 (In reply to comment #2) > (From update of attachment 173591 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173591&action=review > > > Source/WebCore/ChangeLog:13 > > + Covered by existing tests. > > Do you have an example? Which test is passing with this change, or in other words: What was broken before? I wrote it in meaning that do not affect to existing test. If there is any problem in this expression, I will revise it. Actually, the problem is occurred in case using TextureMapper on WebKit2 EFL port. In UpdateAtlas::beginPaintingOnAvailableBuffer, in case of using GraphicsContextCairo (EFL or GTK), doesn't fill the reused area with transparent color. 765522 4 d-r 2012-11-13 06:05:05 -0800 (In reply to comment #3) > I wrote it in meaning that do not affect to existing test. If there is any problem in this expression, I will revise it. > Actually, the problem is occurred in case using TextureMapper on WebKit2 EFL port. > In UpdateAtlas::beginPaintingOnAvailableBuffer, in case of using GraphicsContextCairo (EFL or GTK), doesn't fill the reused area with transparent color. Thanks, I understand. If there is such an actual problem - as you describe -please provide a layout test exactly reproducing this problem or provide convincing reasoning why it's not possible to create such a regression test. 775597 5 173591 kenneth 2012-11-26 10:03:27 -0800 Comment on attachment 173591 proposed patch This fixes 103081! 775599 6 d-r 2012-11-26 10:05:21 -0800 Please consider creating a regression test for this. 775601 7 kenneth 2012-11-26 10:06:20 -0800 Btw I would love if someone could performance test fillRect (transparent) vs clearRect! 775656 8 173591 webkit.review.bot 2012-11-26 10:50:40 -0800 Comment on attachment 173591 proposed patch Clearing flags on attachment: 173591 Committed r135737: <http://trac.webkit.org/changeset/135737> 775658 9 webkit.review.bot 2012-11-26 10:50:44 -0800 All reviewed patches have been landed. Closing bug. 775672 10 yael 2012-11-26 10:57:50 -0800 (In reply to comment #5) > (From update of attachment 173591 [details]) > This fixes 103081! Also https://bugs.webkit.org/show_bug.cgi?id=102989 173591 2012-11-12 02:17:18 -0800 2012-11-26 10:50:40 -0800 proposed patch 101911.patch text/plain 1805 hurnjoo.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkOWUyODM3Li5hOWZmYWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMTEtMDggIEh1cm5qb28gTGVlICA8aHVybmpvby5sZWVAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0NhaXJvXSBmaWxsUmVjdFdpdGhDb2xvciB3aXRoIENvbG9yOjp0cmFuc3BhcmVu dCBkb2Vzbid0IHBlcmZvcm0gYW55dGhpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMTkxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGZpbGxSZWN0V2l0aENvbG9yIHdpdGggQ29sb3I6OnRyYW5zcGFy ZW50IGRvZXNuJ3QgcGVyZm9ybSBhbnl0aGluZworICAgICAgICBiZWNhdXNlIGZpbGxSZWN0V2l0 aENvbG9yIGRvZXMgZWFybHktcmV0dXJuIGlmIHRoZSBhbHBoYSB2YWx1ZSBvZgorICAgICAgICBj b2xvciBpcyB6ZXJvLiBCdXQgd2UgZXhwZWN0IHRoYXQgZmlsbCB0aGUgcmVjdCB3aXRoIHRyYW5z cGFyZW50IGNvbG9yCisgICAgICAgIGluIGNhc2UgdGhlIGNhaXJvX29wZXJhdG9yIGlzIENBSVJP X09QRVJBVE9SX1NPVVJDRS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6ZmlsbFJlY3RXaXRoQ29sb3IpOkFkZCBjb25kaXRpb24g dG8gcHJldmVudCBlYXJseS1yZXR1cm4gaWYKKyAgICAgICAgY2Fpcm9fb3BlcmF0b3IgaXMgbm90 IENBSVJPX09QRVJBVE9SX09WRVIKKwogMjAxMi0xMS0wNyAgVnNldm9sb2QgVmxhc292ICA8dnNl dmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbmZpbml0ZSBsb29w IGluIERhdGFHcmlkOjphdXRvU2l6ZUNvbHVtbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3Bw CmluZGV4IGU1YWRmNDEuLmI4N2FmNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAK QEAgLTcwLDcgKzcwLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogLy8gQSBoZWxwZXIgd2hpY2gg cXVpY2tseSBmaWxscyBhIHJlY3RhbmdsZSB3aXRoIGEgc2ltcGxlIGNvbG9yIGZpbGwuCiBzdGF0 aWMgaW5saW5lIHZvaWQgZmlsbFJlY3RXaXRoQ29sb3IoY2Fpcm9fdCogY3IsIGNvbnN0IEZsb2F0 UmVjdCYgcmVjdCwgY29uc3QgQ29sb3ImIGNvbG9yKQogewotICAgIGlmICghY29sb3IuYWxwaGEo KSkKKyAgICBpZiAoIWNvbG9yLmFscGhhKCkgJiYgY2Fpcm9fZ2V0X29wZXJhdG9yKGNyKSA9PSBD QUlST19PUEVSQVRPUl9PVkVSKQogICAgICAgICByZXR1cm47CiAgICAgc2V0U291cmNlUkdCQUZy b21Db2xvcihjciwgY29sb3IpOwogICAgIGNhaXJvX3JlY3RhbmdsZShjciwgcmVjdC54KCksIHJl Y3QueSgpLCByZWN0LndpZHRoKCksIHJlY3QuaGVpZ2h0KCkpOwo=