101702 2012-11-08 21:32:19 -0800 [Refactoring] Remove shadowPseudoId() and use pseudo() instead in TextTrackCue 2012-11-08 23:28:44 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101171 1 shinyak shinyak webcomponents-bugzilla webkit.review.bot oldest_to_newest 762535 0 shinyak 2012-11-08 21:32:19 -0800 We would like to remove shadowPseudoId, and use pseudo() instead. 762545 1 173200 shinyak 2012-11-08 21:47:07 -0800 Created attachment 173200 Patch 762594 2 173200 morrita 2012-11-08 22:50:52 -0800 Comment on attachment 173200 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173200&action=review > Source/WebCore/html/track/TextTrackCue.h:57 > + box->setPseudo(textTrackCueBoxShadowPseudoId()); Can we do this in the constructor? 762604 3 173211 shinyak 2012-11-08 23:03:49 -0800 Created attachment 173211 Patch for landing 762607 4 shinyak 2012-11-08 23:04:26 -0800 (In reply to comment #2) > (From update of attachment 173200 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173200&action=review > > > Source/WebCore/html/track/TextTrackCue.h:57 > > + box->setPseudo(textTrackCueBoxShadowPseudoId()); > > Can we do this in the constructor? Done. 762617 5 173211 webkit.review.bot 2012-11-08 23:28:41 -0800 Comment on attachment 173211 Patch for landing Clearing flags on attachment: 173211 Committed r134020: <http://trac.webkit.org/changeset/134020> 762618 6 webkit.review.bot 2012-11-08 23:28:44 -0800 All reviewed patches have been landed. Closing bug. 173200 2012-11-08 21:47:07 -0800 2012-11-08 23:03:45 -0800 Patch bug-101702-20121109144515.patch text/plain 2552 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI4OWY5ZTM0OGRjZTgx OTkxYWRhYjZkOTY0ZDVhZjc2ZTA0Y2U0Ni4uZjM4MDQxNWQ0YjBkYzYwOTkwZjBjOWE1NjY0NzA1 MDUxYTQ1MDBmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTA4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIFJlbW92ZSBzaGFkb3dQc2V1ZG9JZCgpIGFuZCB1c2UgcHNldWRvKCkgaW5zdGVhZCBpbiBU ZXh0VHJhY2tDdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMTcwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlJ3JlIG1pZ3JhdGluZyBzaGFkb3dQc2V1ZG9JZCgpIHRvIHBzZXVkbygpLiBXZSByZW1v dmUgc2hhZG93UHNldWRvSWQoKSBmcm9tIFRleHRUcmFja0N1ZSBhbmQgdXNlCisgICAgICAgIHNl dFBzZXVkbygpL3BzZXVkbygpIGluc3RlYWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW1w bGUgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBodG1sL3RyYWNrL1RleHRUcmFja0N1ZS5jcHA6 CisgICAgICAgICogaHRtbC90cmFjay9UZXh0VHJhY2tDdWUuaDoKKyAgICAgICAgKFdlYkNvcmU6 OlRleHRUcmFja0N1ZUJveDo6Y3JlYXRlKToKKyAgICAgICAgKFRleHRUcmFja0N1ZUJveCk6CisK IDIwMTItMTEtMDggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJl bmFtZWQgLi4uSW5saW5lTWV0aG9kcy5oIGZpbGVzIHRvIC4uLklubGluZXMuaC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcAppbmRleCA0YWE5NTYyNGFlODBhMzBl YjRjN2RhMTM3MTQyNjM4NmE3ZjY5ODYwLi4xZmFkZTYzYTA0YTk1MmQ1OGIyNDAwYzg2MzI3ZTU3 ODgyYzQzODQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFj a0N1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWUuY3Bw CkBAIC0xNzMsMTEgKzE3Myw2IEBAIGNvbnN0IEF0b21pY1N0cmluZyYgVGV4dFRyYWNrQ3VlQm94 Ojp0ZXh0VHJhY2tDdWVCb3hTaGFkb3dQc2V1ZG9JZCgpCiAgICAgcmV0dXJuIHRyYWNrRGlzcGxh eUJveFNoYWRvd1BzZXVkb0lkOwogfQogCi1jb25zdCBBdG9taWNTdHJpbmcmIFRleHRUcmFja0N1 ZUJveDo6c2hhZG93UHNldWRvSWQoKSBjb25zdAotewotICAgIHJldHVybiB0ZXh0VHJhY2tDdWVC b3hTaGFkb3dQc2V1ZG9JZCgpOwotfQotCiBSZW5kZXJPYmplY3QqIFRleHRUcmFja0N1ZUJveDo6 Y3JlYXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZSopCiB7CiAgICAg cmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlclRleHRUcmFja0N1ZSh0aGlzKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmggYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL3RyYWNrL1RleHRUcmFja0N1ZS5oCmluZGV4IDAxYTBlNjYwMzdhNTBjMTZkYjg0NDEx YWUyZGQyZjFlNDMzMDY0NTYuLjYyNGQ3MzQ5ZjQwMWJmYWViMDRjZTM5OGZiNDkxMThmNTU2MGIx NGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWUuaApAQCAtNTMsMTMg KzUzLDE0IEBAIGNsYXNzIFRleHRUcmFja0N1ZUJveCA6IHB1YmxpYyBIVE1MRWxlbWVudCB7CiBw dWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8VGV4dFRyYWNrQ3VlQm94PiBjcmVhdGUoRG9j dW1lbnQqIGRvY3VtZW50LCBUZXh0VHJhY2tDdWUqIGN1ZSkKICAgICB7Ci0gICAgICAgIHJldHVy biBhZG9wdFJlZihuZXcgVGV4dFRyYWNrQ3VlQm94KGRvY3VtZW50LCBjdWUpKTsKKyAgICAgICAg UmVmUHRyPFRleHRUcmFja0N1ZUJveD4gYm94ID0gYWRvcHRSZWYobmV3IFRleHRUcmFja0N1ZUJv eChkb2N1bWVudCwgY3VlKSk7CisgICAgICAgIGJveC0+c2V0UHNldWRvKHRleHRUcmFja0N1ZUJv eFNoYWRvd1BzZXVkb0lkKCkpOworICAgICAgICByZXR1cm4gYm94LnJlbGVhc2UoKTsKICAgICB9 CiAKICAgICBUZXh0VHJhY2tDdWUqIGdldEN1ZSgpIGNvbnN0OwogICAgIHZvaWQgYXBwbHlDU1NQ cm9wZXJ0aWVzKCk7CiAKLSAgICB2aXJ0dWFsIGNvbnN0IEF0b21pY1N0cmluZyYgc2hhZG93UHNl dWRvSWQoKSBjb25zdCBPVkVSUklERTsKICAgICBzdGF0aWMgY29uc3QgQXRvbWljU3RyaW5nJiB0 ZXh0VHJhY2tDdWVCb3hTaGFkb3dQc2V1ZG9JZCgpOwogCiBwcml2YXRlOgo= 173211 2012-11-08 23:03:49 -0800 2012-11-08 23:28:41 -0800 Patch for landing bug-101702-20121109160157.patch text/plain 2436 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMyYmVmZjgzMTU2NmZj YjI3MGI2OWY5M2E0MjkyZDBlOTY1ZDFiMS4uNDA2NjQ1MjkxYzQzYjI5OWFhMjljODk0ZTNmOWVi OTA5ZDNlOTc0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTA4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIFJlbW92ZSBzaGFkb3dQc2V1ZG9JZCgpIGFuZCB1c2UgcHNldWRvKCkgaW5zdGVhZCBpbiBU ZXh0VHJhY2tDdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMTcwMgorCisgICAgICAgIFJldmlld2VkIGJ5IEhhamltZSBNb3JpdGEuCisKKyAgICAg ICAgV2UncmUgbWlncmF0aW5nIHNoYWRvd1BzZXVkb0lkKCkgdG8gcHNldWRvKCkuIFdlIHJlbW92 ZSBzaGFkb3dQc2V1ZG9JZCgpIGZyb20gVGV4dFRyYWNrQ3VlIGFuZCB1c2UKKyAgICAgICAgc2V0 UHNldWRvKCkvcHNldWRvKCkgaW5zdGVhZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNpbXBs ZSByZWZhY3RvcmluZy4KKworICAgICAgICAqIGh0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlRleHRUcmFja0N1ZUJveDo6VGV4dFRyYWNrQ3VlQm94KToKKyAg ICAgICAgKiBodG1sL3RyYWNrL1RleHRUcmFja0N1ZS5oOgorICAgICAgICAoVGV4dFRyYWNrQ3Vl Qm94KToKKwogMjAxMi0xMS0wOCAgSmFuIEtlcm9tbmVzICA8amFueEBsaW51eC5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3Rvcjogc3RvcCB1c2luZyBjdXJzb3JDb29yZHMgaW4gQ29kZU1pcnJv clRleHRFZGl0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRy YWNrQ3VlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcApp bmRleCA0YWE5NTYyNGFlODBhMzBlYjRjN2RhMTM3MTQyNjM4NmE3ZjY5ODYwLi4zOWQwMmU1MmZk NmNmYmM2NWQwNmQ1ZmE4NTIwNTQ2NDlkNGFlMmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL3RyYWNrL1RleHRUcmFja0N1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC90 cmFjay9UZXh0VHJhY2tDdWUuY3BwCkBAIC05NSw2ICs5NSw3IEBAIFRleHRUcmFja0N1ZUJveDo6 VGV4dFRyYWNrQ3VlQm94KERvY3VtZW50KiBkb2N1bWVudCwgVGV4dFRyYWNrQ3VlKiBjdWUpCiAg ICAgOiBIVE1MRWxlbWVudChkaXZUYWcsIGRvY3VtZW50KQogICAgICwgbV9jdWUoY3VlKQogewor ICAgIHNldFBzZXVkbyh0ZXh0VHJhY2tDdWVCb3hTaGFkb3dQc2V1ZG9JZCgpKTsKIH0KIAogVGV4 dFRyYWNrQ3VlKiBUZXh0VHJhY2tDdWVCb3g6OmdldEN1ZSgpIGNvbnN0CkBAIC0xNzMsMTEgKzE3 NCw2IEBAIGNvbnN0IEF0b21pY1N0cmluZyYgVGV4dFRyYWNrQ3VlQm94Ojp0ZXh0VHJhY2tDdWVC b3hTaGFkb3dQc2V1ZG9JZCgpCiAgICAgcmV0dXJuIHRyYWNrRGlzcGxheUJveFNoYWRvd1BzZXVk b0lkOwogfQogCi1jb25zdCBBdG9taWNTdHJpbmcmIFRleHRUcmFja0N1ZUJveDo6c2hhZG93UHNl dWRvSWQoKSBjb25zdAotewotICAgIHJldHVybiB0ZXh0VHJhY2tDdWVCb3hTaGFkb3dQc2V1ZG9J ZCgpOwotfQotCiBSZW5kZXJPYmplY3QqIFRleHRUcmFja0N1ZUJveDo6Y3JlYXRlUmVuZGVyZXIo UmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZSopCiB7CiAgICAgcmV0dXJuIG5ldyAoYXJl bmEpIFJlbmRlclRleHRUcmFja0N1ZSh0aGlzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1Rl eHRUcmFja0N1ZS5oCmluZGV4IDAxYTBlNjYwMzdhNTBjMTZkYjg0NDExYWUyZGQyZjFlNDMzMDY0 NTYuLjViOGUzZjEzMWRlMjI5ZTFjMWE3NTY0NTEyMTUxYjZjZjkwMWNiNjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWUuaApAQCAtNTksNyArNTksNiBAQCBwdWJsaWM6 CiAgICAgVGV4dFRyYWNrQ3VlKiBnZXRDdWUoKSBjb25zdDsKICAgICB2b2lkIGFwcGx5Q1NTUHJv cGVydGllcygpOwogCi0gICAgdmlydHVhbCBjb25zdCBBdG9taWNTdHJpbmcmIHNoYWRvd1BzZXVk b0lkKCkgY29uc3QgT1ZFUlJJREU7CiAgICAgc3RhdGljIGNvbnN0IEF0b21pY1N0cmluZyYgdGV4 dFRyYWNrQ3VlQm94U2hhZG93UHNldWRvSWQoKTsKIAogcHJpdmF0ZToK