101692 2012-11-08 19:25:18 -0800 [Refactoring] Expose collectFeaturesFromSelector from RuleSet.cpp 2012-11-08 22:18:04 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101180 1 shinyak shinyak cmarcelo macpherson menard webcomponents-bugzilla webkit.review.bot oldest_to_newest 762457 0 shinyak 2012-11-08 19:25:18 -0800 We would like to reuse it. RuleFeatureSet should have the method. 762466 1 173179 shinyak 2012-11-08 19:46:09 -0800 Created attachment 173179 Patch 762562 2 173179 webkit.review.bot 2012-11-08 22:18:00 -0800 Comment on attachment 173179 Patch Clearing flags on attachment: 173179 Committed r134008: <http://trac.webkit.org/changeset/134008> 762563 3 webkit.review.bot 2012-11-08 22:18:04 -0800 All reviewed patches have been landed. Closing bug. 173179 2012-11-08 19:46:09 -0800 2012-11-08 22:18:00 -0800 Patch bug-101692-20121109124417.patch text/plain 5380 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI4OWY5ZTM0OGRjZTgx OTkxYWRhYjZkOTY0ZDVhZjc2ZTA0Y2U0Ni4uYmM0YTIwOGIzMTAwZmQ3ZmY4OWRmZjNhYjc3MmJl ZGEwNzY3YTRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTA4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIEV4cG9zZSBjb2xsZWN0RmVhdHVyZXNGcm9tU2VsZWN0b3IgZnJvbSBSdWxlU2V0LmNwcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNjkyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZXhwb3Nl IGNvbGxlY3RGZWF0dXJlc0Zyb21TZWxlY3RvciBpbiBSdWxlU2V0LmNwcCB0byB1c2UgaXQgZm9y IGNvbGxlY3RpbmcgU2hhZG93RE9NIHNlbGVjdCBhdHRyaWJ1dGUgZmVhdHVyZXMuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBzaW1wbGUgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBjc3MvUnVs ZUZlYXR1cmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UnVsZUZlYXR1cmVTZXQ6OmNvbGxlY3RG ZWF0dXJlc0Zyb21TZWxlY3Rvcik6IE1vdmVkIGZyb20gUnVsZVNldC5jcHAuCisgICAgICAgIChX ZWJDb3JlKToKKyAgICAgICAgKiBjc3MvUnVsZUZlYXR1cmUuaDoKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAoUnVsZUZlYXR1cmVTZXQpOgorICAgICAgICAqIGNzcy9SdWxlU2V0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNvbGxlY3RGZWF0dXJlc0Zyb21SdWxlRGF0YSk6CisKIDIwMTIt MTEtMDggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZWQg Li4uSW5saW5lTWV0aG9kcy5oIGZpbGVzIHRvIC4uLklubGluZXMuaC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9SdWxlRmVhdHVyZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVs ZUZlYXR1cmUuY3BwCmluZGV4IGIxZjkyOTY4NzkyN2ZkNzcwOWZmMDIyZjU1ZDBlYjNkOTdjMmQ3 ZGMuLjFiMTFjOGZhZWQ0Mzg0MWI4N2MxZjYxOTYyNDBhNWIyM2U3NDRhOTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9SdWxlRmVhdHVyZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL1J1bGVGZWF0dXJlLmNwcApAQCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgImNvbmZpZy5o IgogI2luY2x1ZGUgIlJ1bGVGZWF0dXJlLmgiCiAKKyNpbmNsdWRlICJDU1NTZWxlY3Rvci5oIgog I2luY2x1ZGUgIldlYkNvcmVNZW1vcnlJbnN0cnVtZW50YXRpb24uaCIKICNpbmNsdWRlIDx3dGYv TWVtb3J5SW5zdHJ1bWVudGF0aW9uSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9NZW1vcnlJbnN0 cnVtZW50YXRpb25IYXNoU2V0Lmg+CkBAIC0zNiw2ICszNywyNyBAQAogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKK3ZvaWQgUnVsZUZlYXR1cmVTZXQ6OmNvbGxlY3RGZWF0dXJlc0Zyb21TZWxlY3Rv cihjb25zdCBDU1NTZWxlY3Rvciogc2VsZWN0b3IpCit7CisgICAgaWYgKHNlbGVjdG9yLT5tX21h dGNoID09IENTU1NlbGVjdG9yOjpJZCkKKyAgICAgICAgaWRzSW5SdWxlcy5hZGQoc2VsZWN0b3It PnZhbHVlKCkuaW1wbCgpKTsKKyAgICBlbHNlIGlmIChzZWxlY3Rvci0+bV9tYXRjaCA9PSBDU1NT ZWxlY3Rvcjo6Q2xhc3MpCisgICAgICAgIGNsYXNzZXNJblJ1bGVzLmFkZChzZWxlY3Rvci0+dmFs dWUoKS5pbXBsKCkpOworICAgIGVsc2UgaWYgKHNlbGVjdG9yLT5pc0F0dHJpYnV0ZVNlbGVjdG9y KCkpCisgICAgICAgIGF0dHJzSW5SdWxlcy5hZGQoc2VsZWN0b3ItPmF0dHJpYnV0ZSgpLmxvY2Fs TmFtZSgpLmltcGwoKSk7CisgICAgc3dpdGNoIChzZWxlY3Rvci0+cHNldWRvVHlwZSgpKSB7Cisg ICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvRmlyc3RMaW5lOgorICAgICAgICB1c2VzRmlyc3RM aW5lUnVsZXMgPSB0cnVlOworICAgICAgICBicmVhazsKKyAgICBjYXNlIENTU1NlbGVjdG9yOjpQ c2V1ZG9CZWZvcmU6CisgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvQWZ0ZXI6CisgICAgICAg IHVzZXNCZWZvcmVBZnRlclJ1bGVzID0gdHJ1ZTsKKyAgICAgICAgYnJlYWs7CisgICAgZGVmYXVs dDoKKyAgICAgICAgYnJlYWs7CisgICAgfQorfQorCiB2b2lkIFJ1bGVGZWF0dXJlU2V0OjphZGQo Y29uc3QgUnVsZUZlYXR1cmVTZXQmIG90aGVyKQogewogICAgIEhhc2hTZXQ8QXRvbWljU3RyaW5n SW1wbCo+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBvdGhlci5pZHNJblJ1bGVzLmVuZCgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVGZWF0dXJlLmggYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvUnVsZUZlYXR1cmUuaAppbmRleCBjZTZkMDRlNjY0ZTQyZjRmYWJmYmYyNWYzOGRkYjJi NGUyYmJhM2I3Li4wZmZjNmU1ZWUyMTcyYTY3YjdlN2VkOWMwOWYxMTJmYWNlNzgxNDNlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVsZUZlYXR1cmUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvUnVsZUZlYXR1cmUuaApAQCAtMzAsNiArMzAsNyBAQAogbmFtZXNwYWNlIFdlYkNv cmUgewogCiBjbGFzcyBTdHlsZVJ1bGU7CitjbGFzcyBDU1NTZWxlY3RvcjsKIAogc3RydWN0IFJ1 bGVGZWF0dXJlIHsKICAgICBSdWxlRmVhdHVyZShTdHlsZVJ1bGUqIHJ1bGUsIHVuc2lnbmVkIHNl bGVjdG9ySW5kZXgsIGJvb2wgaGFzRG9jdW1lbnRTZWN1cml0eU9yaWdpbikKQEAgLTUxLDcgKzUy LDExIEBAIHN0cnVjdCBSdWxlRmVhdHVyZVNldCB7CiAKICAgICB2b2lkIGFkZChjb25zdCBSdWxl RmVhdHVyZVNldCYpOwogICAgIHZvaWQgY2xlYXIoKTsKKworICAgIHZvaWQgY29sbGVjdEZlYXR1 cmVzRnJvbVNlbGVjdG9yKGNvbnN0IENTU1NlbGVjdG9yKik7CisKICAgICB2b2lkIHJlcG9ydE1l bW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qKSBjb25zdDsKKwogICAgIEhhc2hTZXQ8QXRvbWlj U3RyaW5nSW1wbCo+IGlkc0luUnVsZXM7CiAgICAgSGFzaFNldDxBdG9taWNTdHJpbmdJbXBsKj4g Y2xhc3Nlc0luUnVsZXM7CiAgICAgSGFzaFNldDxBdG9taWNTdHJpbmdJbXBsKj4gYXR0cnNJblJ1 bGVzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVTZXQuY3BwIGIvU291cmNl L1dlYkNvcmUvY3NzL1J1bGVTZXQuY3BwCmluZGV4IGU5MmQxNzY4YjI5OGQ3YWU4OTZjMDdiZTI4 ODdhYTc0MWM1YTZkMzguLmE1MzY3ZWU4MmRiZDU5MzFlOTRiNjg0OWQ0M2U3YjFlZmQ5YzkxODYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9SdWxlU2V0LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvUnVsZVNldC5jcHAKQEAgLTE1NywzOCArMTU3LDE3IEBAIHZvaWQgUnVsZVNl dDo6UnVsZVNldFNlbGVjdG9yUGFpcjo6cmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5m byogbWVtb3J5T2JqCiAgICAgaW5mby5hZGRNZW1iZXIocnVsZVNldCk7CiB9CiAKLXN0YXRpYyBp bmxpbmUgdm9pZCBjb2xsZWN0RmVhdHVyZXNGcm9tU2VsZWN0b3IoUnVsZUZlYXR1cmVTZXQmIGZl YXR1cmVzLCBjb25zdCBDU1NTZWxlY3Rvciogc2VsZWN0b3IpCi17Ci0gICAgaWYgKHNlbGVjdG9y LT5tX21hdGNoID09IENTU1NlbGVjdG9yOjpJZCkKLSAgICAgICAgZmVhdHVyZXMuaWRzSW5SdWxl cy5hZGQoc2VsZWN0b3ItPnZhbHVlKCkuaW1wbCgpKTsKLSAgICBlbHNlIGlmIChzZWxlY3Rvci0+ bV9tYXRjaCA9PSBDU1NTZWxlY3Rvcjo6Q2xhc3MpCi0gICAgICAgIGZlYXR1cmVzLmNsYXNzZXNJ blJ1bGVzLmFkZChzZWxlY3Rvci0+dmFsdWUoKS5pbXBsKCkpOwotICAgIGVsc2UgaWYgKHNlbGVj dG9yLT5pc0F0dHJpYnV0ZVNlbGVjdG9yKCkpCi0gICAgICAgIGZlYXR1cmVzLmF0dHJzSW5SdWxl cy5hZGQoc2VsZWN0b3ItPmF0dHJpYnV0ZSgpLmxvY2FsTmFtZSgpLmltcGwoKSk7Ci0gICAgc3dp dGNoIChzZWxlY3Rvci0+cHNldWRvVHlwZSgpKSB7Ci0gICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNl dWRvRmlyc3RMaW5lOgotICAgICAgICBmZWF0dXJlcy51c2VzRmlyc3RMaW5lUnVsZXMgPSB0cnVl OwotICAgICAgICBicmVhazsKLSAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9CZWZvcmU6Ci0g ICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvQWZ0ZXI6Ci0gICAgICAgIGZlYXR1cmVzLnVzZXNC ZWZvcmVBZnRlclJ1bGVzID0gdHJ1ZTsKLSAgICAgICAgYnJlYWs7Ci0gICAgZGVmYXVsdDoKLSAg ICAgICAgYnJlYWs7Ci0gICAgfQotfQotCiBzdGF0aWMgdm9pZCBjb2xsZWN0RmVhdHVyZXNGcm9t UnVsZURhdGEoUnVsZUZlYXR1cmVTZXQmIGZlYXR1cmVzLCBjb25zdCBSdWxlRGF0YSYgcnVsZURh dGEpCiB7CiAgICAgYm9vbCBmb3VuZFNpYmxpbmdTZWxlY3RvciA9IGZhbHNlOwogICAgIGZvciAo Q1NTU2VsZWN0b3IqIHNlbGVjdG9yID0gcnVsZURhdGEuc2VsZWN0b3IoKTsgc2VsZWN0b3I7IHNl bGVjdG9yID0gc2VsZWN0b3ItPnRhZ0hpc3RvcnkoKSkgewotICAgICAgICBjb2xsZWN0RmVhdHVy ZXNGcm9tU2VsZWN0b3IoZmVhdHVyZXMsIHNlbGVjdG9yKTsKKyAgICAgICAgZmVhdHVyZXMuY29s bGVjdEZlYXR1cmVzRnJvbVNlbGVjdG9yKHNlbGVjdG9yKTsKICAgICAgICAgCiAgICAgICAgIGlm IChDU1NTZWxlY3Rvckxpc3QqIHNlbGVjdG9yTGlzdCA9IHNlbGVjdG9yLT5zZWxlY3Rvckxpc3Qo KSkgewogICAgICAgICAgICAgZm9yIChDU1NTZWxlY3Rvciogc3ViU2VsZWN0b3IgPSBzZWxlY3Rv ckxpc3QtPmZpcnN0KCk7IHN1YlNlbGVjdG9yOyBzdWJTZWxlY3RvciA9IENTU1NlbGVjdG9yTGlz dDo6bmV4dChzdWJTZWxlY3RvcikpIHsKICAgICAgICAgICAgICAgICBpZiAoIWZvdW5kU2libGlu Z1NlbGVjdG9yICYmIHNlbGVjdG9yLT5pc1NpYmxpbmdTZWxlY3RvcigpKQogICAgICAgICAgICAg ICAgICAgICBmb3VuZFNpYmxpbmdTZWxlY3RvciA9IHRydWU7Ci0gICAgICAgICAgICAgICAgY29s bGVjdEZlYXR1cmVzRnJvbVNlbGVjdG9yKGZlYXR1cmVzLCBzdWJTZWxlY3Rvcik7CisgICAgICAg ICAgICAgICAgZmVhdHVyZXMuY29sbGVjdEZlYXR1cmVzRnJvbVNlbGVjdG9yKHN1YlNlbGVjdG9y KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfSBlbHNlIGlmICghZm91bmRTaWJsaW5nU2VsZWN0 b3IgJiYgc2VsZWN0b3ItPmlzU2libGluZ1NlbGVjdG9yKCkpCiAgICAgICAgICAgICBmb3VuZFNp YmxpbmdTZWxlY3RvciA9IHRydWU7Cg==