<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>101365</bug_id>
          
          <creation_ts>2012-11-06 09:58:53 -0800</creation_ts>
          <short_desc>Should ARMv7Assembler::replaceWithJump cache-flush the nop on page boundary</short_desc>
          <delta_ts>2013-03-01 08:36:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>102759</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>108645</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Yong Li">yong.li.webkit</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>759794</commentid>
    <comment_count>0</comment_count>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2012-11-06 09:58:53 -0800</bug_when>
    <thetext>ARMv7Assembler::replaceWithJump() contains following code:

if (spansTwo4K) {
   ptr[-2] = OP_NOP_T1;
   ptr++;
}

After that, it calls linkJumpT4(ptr, to) and then cacheFlush(ptr - 2,
sizeof(uint16_t) * 2), so it doesn&apos;t cache-flush this instruction.

According to the comments, this seems a work around of a Cortex-A8 bug. 

I&apos;m not sure if we should make sure the nop instruction should also be
cache-flushed, because the instruction was probably nop anyway.

Also, these spansTwo4K are said to workaround a Cortex-A8 issue. Does this also give perf penalty to other cores?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>845203</commentid>
    <comment_count>1</comment_count>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2013-03-01 08:36:41 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 102759 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>