101277 2012-11-05 16:43:07 -0800 Remove branch from inside RenderObject::view now that renderer() is more expensive 2012-11-06 14:12:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100057 1 esprehn esprehn eric webkit.review.bot oldest_to_newest 759024 0 esprehn 2012-11-05 16:43:07 -0800 Remove branch from inside RenderObject::view now that renderer() is more expensive 759033 1 172438 esprehn 2012-11-05 16:48:22 -0800 Created attachment 172438 Patch 759041 2 172438 eric 2012-11-05 16:54:09 -0800 Comment on attachment 172438 Patch LGTM. Do we have numbers for this perf change? 759052 3 esprehn 2012-11-05 16:58:46 -0800 (In reply to comment #2) > (From update of attachment 172438 [details]) > LGTM. Do we have numbers for this perf change? Nope, but I can run Parser/html5-full-render. I don't know what other thing to run, have any ideas? I'm also looking into how to run the page cycler. 759054 4 eric 2012-11-05 17:00:01 -0800 It might show up in html5-full-render. Regardless of the perf impact, I think this is a good change and worth the space trade-off (for code-clarity if nothing else). 759055 5 172438 eric 2012-11-05 17:00:50 -0800 Comment on attachment 172438 Patch Are there places which call m_renderer = 0 instead of setRenderer that we need to worry about? 759060 6 esprehn 2012-11-05 17:03:55 -0800 (In reply to comment #5) > (From update of attachment 172438 [details]) > Are there places which call m_renderer = 0 instead of setRenderer that we need to worry about? Nope, m_renderer is in Node.h and is private, and I made sure Node always goes through setRenderer(0) in the previous patch. 759149 7 172438 buildbot 2012-11-05 18:45:13 -0800 Comment on attachment 172438 Patch Attachment 172438 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14721887 759931 8 esprehn 2012-11-06 11:44:51 -0800 (In reply to comment #4) > It might show up in html5-full-render. > > Regardless of the perf impact, I think this is a good change and worth the space trade-off (for code-clarity if nothing else). This looks like about a 1% improvement on Parser/html5-full-render.html r133501 baseline: 4713.22 ± 0.59% 1.01% Worse 4655.67 ± 0.51% 4666.32 ± 0.47% With this patch: 4608.43 ± 0.68% 1.24% Better 4643.20 ± 0.28% 0.50% Better 4632.21 ± 0.45% 0.73% Better 759934 9 eric 2012-11-06 11:48:11 -0800 Looks like you need to clean up the exported symbols list too: "__ZNK7WebCore8Document10renderViewEv", referenced from: -exported_symbol[s_list] command line option 759964 10 172632 esprehn 2012-11-06 12:46:09 -0800 Created attachment 172632 Patch Fix exports 760035 11 172632 webkit.review.bot 2012-11-06 14:12:41 -0800 Comment on attachment 172632 Patch Clearing flags on attachment: 172632 Committed r133671: <http://trac.webkit.org/changeset/133671> 760036 12 webkit.review.bot 2012-11-06 14:12:44 -0800 All reviewed patches have been landed. Closing bug. 172438 2012-11-05 16:48:22 -0800 2012-11-06 12:46:07 -0800 Patch bug-101277-20121105164636.patch text/plain 5042 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY0YTE0MGQ4OTBhNDE3 OThiNmRlNjk2ZjljYjEzMGM1MzEyZmFkNC4uYTYwZDc0ZmU1NTMwMzk0ZjE1OTc2NWIyMzc0MmM3 NzBhYzk0ZTVlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTExLTA1ICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBicmFu Y2ggZnJvbSBpbnNpZGUgUmVuZGVyT2JqZWN0Ojp2aWV3IG5vdyB0aGF0IHJlbmRlcmVyKCkgaXMg bW9yZSBleHBlbnNpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMTI3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEl0IHdhcyBvYnNlcnZlZCBpbiBCdWcgMTAwMDU3IHRoYXQgY2FsbGluZyByZW5kZXJl cigpIHJlcGVhdGVkbHkgbm93IHRoYXQgaXQgaGFzIGEgYnJhbmNoCisgICAgICAgIGNhbiBiZSBh IHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb24uIE5vdyB0aGF0IHdlIG5vIGxvbmdlciBrZWVwIGEgc2Vw YXJhdGUgcG9pbnRlciBmb3IgcmFyZSBkYXRhCisgICAgICAgIGluIERvY3VtZW50LCB3ZSBjYW4g dXNlIHRoYXQgc3BhY2UgZm9yIGEgcG9pbnRlciB0byB0aGUgUmVuZGVyVmlldyBtYWtpbmcgUmVu ZGVyT2JqZWN0Ojp2aWV3KCkKKyAgICAgICAgZmFzdGVyIGFuZCByZW1vdmluZyB0aGUgYnJhbmNo LiAgICAgICAKKworICAgICAgICBUaGlzIGFsc28gY2xlYW5zIHVwIHRoZSBjb2RlIGJlY2F1c2Ug aXQgdHVybnMgb3V0IHdlIGRvbid0IG5lZWQgdG8gaGF2ZSBSZW5kZXJPYmplY3Q6OnZpZXcoKSBp bgorICAgICAgICBSZW5kZXJWaWV3LmggYmVjYXVzZSB3ZSBjYW4ganVzdCBjYWxsIERvY3VtZW50 OjpyZW5kZXJWaWV3KCkgYW5kIG5vdCBkbyB0b1JlbmRlclZpZXcuIFRoaXMgbWFrZXMKKyAgICAg ICAgaXQgZWFzaWVyIHRvIGZpbmQgdGhpcyBtZXRob2QgYXMgaXQgZXhpc3RzIGluIHRoZSByaWdo dCBoZWFkZXIgZmlsZSBub3cuCisgCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBqdXN0 IGEgcmVmYWN0b3IuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RG9jdW1lbnQ6OkRvY3VtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpz ZXRSZW5kZXJlcik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBkb20vRG9jdW1lbnQu aDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpyZW5kZXJWaWV3KToKKyAgICAgICAgKERv Y3VtZW50KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnZpZXcpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJW aWV3Lmg6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0xMS0wNSAgR2VuZXZpZXZlIE1hayAg PGdtYWtAcmltLmNvbT4KIAogICAgICAgICBbQkxBQ0tCRVJSWV0gVXBkYXRlIHRvdWNoIGNvZGUg dG8gcmVmbGVjdCB0b3VjaCByZWZhY3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggNjM4 ODU5NDAxZTBlMDNjZDBkZmMzMmVjNDQyZGYzZTcyNDEyN2I0OS4uMGQ2YWZmYjUzODJkZjJiMTU4 ZTYyZTdhYjAwMzliZjUxNjZjYjhhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC00Nzgs NiArNDc4LDcgQEAgRG9jdW1lbnQ6OkRvY3VtZW50KEZyYW1lKiBmcmFtZSwgY29uc3QgS1VSTCYg dXJsLCBib29sIGlzWEhUTUwsIGJvb2wgaXNIVE1MKQogICAgICwgbV9pc1ZpZXdTb3VyY2UoZmFs c2UpCiAgICAgLCBtX3Nhd0VsZW1lbnRzSW5Lbm93bk5hbWVzcGFjZXMoZmFsc2UpCiAgICAgLCBt X2lzU3JjZG9jRG9jdW1lbnQoZmFsc2UpCisgICAgLCBtX3JlbmRlclZpZXcoMCkKICAgICAsIG1f ZXZlbnRRdWV1ZShEb2N1bWVudEV2ZW50UXVldWU6OmNyZWF0ZSh0aGlzKSkKICAgICAsIG1fd2Vh a1JlZmVyZW5jZShEb2N1bWVudFdlYWtSZWZlcmVuY2U6OmNyZWF0ZSh0aGlzKSkKICAgICAsIG1f aWRBdHRyaWJ1dGVOYW1lKGlkQXR0cikKQEAgLTIwNDksNiArMjA1MCwxMiBAQCB2b2lkIERvY3Vt ZW50OjpjbGVhclN0eWxlUmVzb2x2ZXIoKQogICAgIG1fc3R5bGVSZXNvbHZlci5jbGVhcigpOwog fQogCit2b2lkIERvY3VtZW50OjpzZXRSZW5kZXJlcihSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQor eworICAgIG1fcmVuZGVyVmlldyA9IHRvUmVuZGVyVmlldyhyZW5kZXJlcik7CisgICAgTm9kZTo6 c2V0UmVuZGVyZXIocmVuZGVyZXIpOworfQorCiB2b2lkIERvY3VtZW50OjphdHRhY2goKQogewog ICAgIEFTU0VSVCghYXR0YWNoZWQoKSk7CkBAIC0yMTkzLDExICsyMjAwLDYgQEAgdm9pZCBEb2N1 bWVudDo6cmVzdW1lQWN0aXZlRE9NT2JqZWN0cygpCiAjZW5kaWYKIH0KIAotUmVuZGVyVmlldyog RG9jdW1lbnQ6OnJlbmRlclZpZXcoKSBjb25zdAotewotICAgIHJldHVybiB0b1JlbmRlclZpZXco cmVuZGVyZXIoKSk7Ci19Ci0KIHZvaWQgRG9jdW1lbnQ6OmNsZWFyQVhPYmplY3RDYWNoZSgpCiB7 CiAgICAgLy8gY2xlYXIgY2FjaGUgaW4gdG9wIGRvY3VtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmlu ZGV4IGFhNWQzZDg0MWIyMjM4NTYzMjRlMmU4YWU1NDRlNzIwMjI3YjcxNzkuLjRhYTQ3YjQwMDAw NThkMGMzOWMwZGEzZWZhYzU5ZDkwYzFkYWFiM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC01 NTYsNyArNTU2LDggQEAgcHVibGljOgogCiAgICAgUmVuZGVyQXJlbmEqIHJlbmRlckFyZW5hKCkg eyByZXR1cm4gbV9yZW5kZXJBcmVuYS5nZXQoKTsgfQogCi0gICAgUmVuZGVyVmlldyogcmVuZGVy VmlldygpIGNvbnN0OworICAgIFJlbmRlclZpZXcqIHJlbmRlclZpZXcoKSBjb25zdCB7IHJldHVy biBtX3JlbmRlclZpZXc7IH0KKyAgICB2b2lkIHNldFJlbmRlcmVyKFJlbmRlck9iamVjdCopOwog CiAgICAgdm9pZCBjbGVhckFYT2JqZWN0Q2FjaGUoKTsKICAgICBBWE9iamVjdENhY2hlKiBheE9i amVjdENhY2hlKCkgY29uc3Q7CkBAIC0xNDI1LDYgKzE0MjYsNyBAQCBwcml2YXRlOgogICAgIGJv b2wgbV9zYXdFbGVtZW50c0luS25vd25OYW1lc3BhY2VzOwogICAgIGJvb2wgbV9pc1NyY2RvY0Rv Y3VtZW50OwogCisgICAgUmVuZGVyVmlldyogbV9yZW5kZXJWaWV3OwogICAgIFJlZlB0cjxEb2N1 bWVudEV2ZW50UXVldWU+IG1fZXZlbnRRdWV1ZTsKIAogICAgIFJlZlB0cjxEb2N1bWVudFdlYWtS ZWZlcmVuY2U+IG1fd2Vha1JlZmVyZW5jZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJP YmplY3QuaAppbmRleCA4YTU3ODE5NjZhZTBjOTBjNzliN2I0YmY0MzQxOWY3Y2I1NmMxODgzLi42 N2E0ZDM3OTY0NTQ0YzM1NWRjNzczYWFkYjBmZDdkMmFkMjMxNjYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCkBAIC02MTUsOCArNjE1LDcgQEAgcHVibGljOgogICAg IAogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVEcmFnU3RhdGUoYm9vbCBkcmFnT24pOwogCi0gICAg Ly8gSW5saW5lZCBpbnRvIFJlbmRlclZpZXcuaCBmb3IgcGVyZm9ybWFuY2UgYW5kIHRvIGF2b2lk IGEgY3ljbGljIGRlcGVuZGVuY3kuCi0gICAgUmVuZGVyVmlldyogdmlldygpIGNvbnN0OworICAg IFJlbmRlclZpZXcqIHZpZXcoKSBjb25zdCB7IHJldHVybiBkb2N1bWVudCgpLT5yZW5kZXJWaWV3 KCk7IH07CiAKICAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhpcyByZW5kZXJlciBpcyByb290ZWQs IGFuZCBvcHRpb25hbGx5IHJldHVybnMgdGhlIGhvc3RpbmcgdmlldyAodGhlIHJvb3Qgb2YgdGhl IGhpZXJhcmNoeSkuCiAgICAgYm9vbCBpc1Jvb3RlZChSZW5kZXJWaWV3KiogPSAwKSBjb25zdDsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmggYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oCmluZGV4IDA4NGQ3ZDVhN2NmODhkZmVj ZTczMjVhNmExMTVlMjBmZmUyYzgwMDQuLmZlMjhlNTU1MWNkNWVmNjU1N2NiZTFhY2M4NmU0MDcz YjcyODY2NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaApAQCAtMzUyLDEy ICszNTIsNiBAQCBpbmxpbmUgY29uc3QgUmVuZGVyVmlldyogdG9SZW5kZXJWaWV3KGNvbnN0IFJl bmRlck9iamVjdCogb2JqZWN0KQogLy8gVGhpcyB3aWxsIGNhdGNoIGFueW9uZSBkb2luZyBhbiB1 bm5lY2Vzc2FyeSBjYXN0Lgogdm9pZCB0b1JlbmRlclZpZXcoY29uc3QgUmVuZGVyVmlldyopOwog Ci0KLUFMV0FZU19JTkxJTkUgUmVuZGVyVmlldyogUmVuZGVyT2JqZWN0Ojp2aWV3KCkgY29uc3QK LXsKLSAgICByZXR1cm4gdG9SZW5kZXJWaWV3KGRvY3VtZW50KCktPnJlbmRlcmVyKCkpOwotfQot CiAvLyBTdGFjay1iYXNlZCBjbGFzcyB0byBhc3Npc3Qgd2l0aCBMYXlvdXRTdGF0ZSBwdXNoL3Bv cAogY2xhc3MgTGF5b3V0U3RhdGVNYWludGFpbmVyIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJM RShMYXlvdXRTdGF0ZU1haW50YWluZXIpOwo= 172632 2012-11-06 12:46:09 -0800 2012-11-06 14:12:41 -0800 Patch bug-101277-20121106124421.patch text/plain 5789 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY0YTE0MGQ4OTBhNDE3 OThiNmRlNjk2ZjljYjEzMGM1MzEyZmFkNC4uNjU5ZmU3NjVmZDMwMzFlMDkyYjIxN2ZlNDc3MjFl MjU5NDYzMzZiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDEyLTExLTA2ICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBicmFu Y2ggZnJvbSBpbnNpZGUgUmVuZGVyT2JqZWN0Ojp2aWV3IG5vdyB0aGF0IHJlbmRlcmVyKCkgaXMg bW9yZSBleHBlbnNpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMTI3NworCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgorCisgICAg ICAgIEl0IHdhcyBvYnNlcnZlZCBpbiBCdWcgMTAwMDU3IHRoYXQgY2FsbGluZyByZW5kZXJlcigp IHJlcGVhdGVkbHkgbm93IHRoYXQgaXQgaGFzIGEgYnJhbmNoCisgICAgICAgIGNhbiBiZSBhIHBl cmZvcm1hbmNlIHJlZ3Jlc3Npb24uIE5vdyB0aGF0IHdlIG5vIGxvbmdlciBrZWVwIGEgc2VwYXJh dGUgcG9pbnRlciBmb3IgcmFyZSBkYXRhCisgICAgICAgIGluIERvY3VtZW50LCB3ZSBjYW4gdXNl IHRoYXQgc3BhY2UgZm9yIGEgcG9pbnRlciB0byB0aGUgUmVuZGVyVmlldyBtYWtpbmcgUmVuZGVy T2JqZWN0Ojp2aWV3KCkKKyAgICAgICAgZmFzdGVyIGFuZCByZW1vdmluZyB0aGUgYnJhbmNoLgor CisgICAgICAgIFRoaXMgaXMgYSAxJSBpbXByb3ZlbWVudCBvbiBQYXJzZXIvaHRtbDUtZnVsbC1y ZW5kZXIuaHRtbAorCisgICAgICAgIFRoaXMgYWxzbyBjbGVhbnMgdXAgdGhlIGNvZGUgYmVjYXVz ZSBpdCB0dXJucyBvdXQgd2UgZG9uJ3QgbmVlZCB0byBoYXZlIFJlbmRlck9iamVjdDo6dmlldygp IGluCisgICAgICAgIFJlbmRlclZpZXcuaCBiZWNhdXNlIHdlIGNhbiBqdXN0IGNhbGwgRG9jdW1l bnQ6OnJlbmRlclZpZXcoKSBhbmQgbm90IGRvIHRvUmVuZGVyVmlldy4gVGhpcyBtYWtlcworICAg ICAgICBpdCBlYXNpZXIgdG8gZmluZCB0aGlzIG1ldGhvZCBhcyBpdCBleGlzdHMgaW4gdGhlIHJp Z2h0IGhlYWRlciBmaWxlIG5vdy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHRoaXMgaXMganVz dCBhIHJlZmFjdG9yLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46IFJlbW92ZSBleHBvcnQg b2YgRG9jdW1lbnQ6OnJlbmRlclZpZXcgc2luY2UgaXQncyBpbmxpbmUgbm93LgorICAgICAgICAq IGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6RG9jdW1lbnQp OgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldFJlbmRlcmVyKToKKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RG9j dW1lbnQ6OnJlbmRlclZpZXcpOgorICAgICAgICAoRG9jdW1lbnQpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJPYmplY3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6dmll dyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcuaDoKKyAgICAgICAgKFdlYkNvcmUp OgorCiAyMDEyLTExLTA1ICBHZW5ldmlldmUgTWFrICA8Z21ha0ByaW0uY29tPgogCiAgICAgICAg IFtCTEFDS0JFUlJZXSBVcGRhdGUgdG91Y2ggY29kZSB0byByZWZsZWN0IHRvdWNoIHJlZmFjdG9y CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiBiL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZXhwLmluCmluZGV4IGY2ZDE4NmQ0ZTA2NWYwMzExODk5ZmQ3NjNiY2QwNTM3 ZmU0NDRmYWYuLmE0OGFlYzNlYzBmY2YxOTNkYzhhZTQ5NDY1YmY5NmZhMTlmNzY0YWEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCisrKyBiL1NvdXJjZS9XZWJDb3Jl L1dlYkNvcmUuZXhwLmluCkBAIC0xNDQ3LDcgKzE0NDcsNiBAQCBfX1pOSzdXZWJDb3JlN0ludFJl Y3QxMGludGVyc2VjdHNFUktTMF8KIF9fWk5LN1dlYkNvcmU3SW50UmVjdDhjb250YWluc0VSS1Mw XwogX19aTks3V2ViQ29yZTdJbnRSZWN0Y3Y2Q0dSZWN0RXYKIF9fWk5LN1dlYkNvcmU3UnVuTG9v cDlUaW1lckJhc2U4aXNBY3RpdmVFdgotX19aTks3V2ViQ29yZThEb2N1bWVudDEwcmVuZGVyVmll d0V2CiBfX1pOSzdXZWJDb3JlOERvY3VtZW50MTFjb21wbGV0ZVVSTEVSS04zV1RGNlN0cmluZ0UK IF9fWk5LN1dlYkNvcmU4RG9jdW1lbnQxM2F4T2JqZWN0Q2FjaGVFdgogX19aTks3V2ViQ29yZThE b2N1bWVudDEzbm9kZXNGcm9tUmVjdEVpaWpqampiYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5k ZXggNjM4ODU5NDAxZTBlMDNjZDBkZmMzMmVjNDQyZGYzZTcyNDEyN2I0OS4uMGQ2YWZmYjUzODJk ZjJiMTU4ZTYyZTdhYjAwMzliZjUxNjZjYjhhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBA IC00NzgsNiArNDc4LDcgQEAgRG9jdW1lbnQ6OkRvY3VtZW50KEZyYW1lKiBmcmFtZSwgY29uc3Qg S1VSTCYgdXJsLCBib29sIGlzWEhUTUwsIGJvb2wgaXNIVE1MKQogICAgICwgbV9pc1ZpZXdTb3Vy Y2UoZmFsc2UpCiAgICAgLCBtX3Nhd0VsZW1lbnRzSW5Lbm93bk5hbWVzcGFjZXMoZmFsc2UpCiAg ICAgLCBtX2lzU3JjZG9jRG9jdW1lbnQoZmFsc2UpCisgICAgLCBtX3JlbmRlclZpZXcoMCkKICAg ICAsIG1fZXZlbnRRdWV1ZShEb2N1bWVudEV2ZW50UXVldWU6OmNyZWF0ZSh0aGlzKSkKICAgICAs IG1fd2Vha1JlZmVyZW5jZShEb2N1bWVudFdlYWtSZWZlcmVuY2U6OmNyZWF0ZSh0aGlzKSkKICAg ICAsIG1faWRBdHRyaWJ1dGVOYW1lKGlkQXR0cikKQEAgLTIwNDksNiArMjA1MCwxMiBAQCB2b2lk IERvY3VtZW50OjpjbGVhclN0eWxlUmVzb2x2ZXIoKQogICAgIG1fc3R5bGVSZXNvbHZlci5jbGVh cigpOwogfQogCit2b2lkIERvY3VtZW50OjpzZXRSZW5kZXJlcihSZW5kZXJPYmplY3QqIHJlbmRl cmVyKQoreworICAgIG1fcmVuZGVyVmlldyA9IHRvUmVuZGVyVmlldyhyZW5kZXJlcik7CisgICAg Tm9kZTo6c2V0UmVuZGVyZXIocmVuZGVyZXIpOworfQorCiB2b2lkIERvY3VtZW50OjphdHRhY2go KQogewogICAgIEFTU0VSVCghYXR0YWNoZWQoKSk7CkBAIC0yMTkzLDExICsyMjAwLDYgQEAgdm9p ZCBEb2N1bWVudDo6cmVzdW1lQWN0aXZlRE9NT2JqZWN0cygpCiAjZW5kaWYKIH0KIAotUmVuZGVy VmlldyogRG9jdW1lbnQ6OnJlbmRlclZpZXcoKSBjb25zdAotewotICAgIHJldHVybiB0b1JlbmRl clZpZXcocmVuZGVyZXIoKSk7Ci19Ci0KIHZvaWQgRG9jdW1lbnQ6OmNsZWFyQVhPYmplY3RDYWNo ZSgpCiB7CiAgICAgLy8gY2xlYXIgY2FjaGUgaW4gdG9wIGRvY3VtZW50CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5oCmluZGV4IGFhNWQzZDg0MWIyMjM4NTYzMjRlMmU4YWU1NDRlNzIwMjI3YjcxNzkuLjRhYTQ3 YjQwMDAwNThkMGMzOWMwZGEzZWZhYzU5ZDkwYzFkYWFiM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o CkBAIC01NTYsNyArNTU2LDggQEAgcHVibGljOgogCiAgICAgUmVuZGVyQXJlbmEqIHJlbmRlckFy ZW5hKCkgeyByZXR1cm4gbV9yZW5kZXJBcmVuYS5nZXQoKTsgfQogCi0gICAgUmVuZGVyVmlldyog cmVuZGVyVmlldygpIGNvbnN0OworICAgIFJlbmRlclZpZXcqIHJlbmRlclZpZXcoKSBjb25zdCB7 IHJldHVybiBtX3JlbmRlclZpZXc7IH0KKyAgICB2b2lkIHNldFJlbmRlcmVyKFJlbmRlck9iamVj dCopOwogCiAgICAgdm9pZCBjbGVhckFYT2JqZWN0Q2FjaGUoKTsKICAgICBBWE9iamVjdENhY2hl KiBheE9iamVjdENhY2hlKCkgY29uc3Q7CkBAIC0xNDI1LDYgKzE0MjYsNyBAQCBwcml2YXRlOgog ICAgIGJvb2wgbV9zYXdFbGVtZW50c0luS25vd25OYW1lc3BhY2VzOwogICAgIGJvb2wgbV9pc1Ny Y2RvY0RvY3VtZW50OwogCisgICAgUmVuZGVyVmlldyogbV9yZW5kZXJWaWV3OwogICAgIFJlZlB0 cjxEb2N1bWVudEV2ZW50UXVldWU+IG1fZXZlbnRRdWV1ZTsKIAogICAgIFJlZlB0cjxEb2N1bWVu dFdlYWtSZWZlcmVuY2U+IG1fd2Vha1JlZmVyZW5jZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuaAppbmRleCA4YTU3ODE5NjZhZTBjOTBjNzliN2I0YmY0MzQxOWY3Y2I1NmMx ODgzLi42N2E0ZDM3OTY0NTQ0YzM1NWRjNzczYWFkYjBmZDdkMmFkMjMxNjYyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCkBAIC02MTUsOCArNjE1LDcgQEAgcHVibGlj OgogICAgIAogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVEcmFnU3RhdGUoYm9vbCBkcmFnT24pOwog Ci0gICAgLy8gSW5saW5lZCBpbnRvIFJlbmRlclZpZXcuaCBmb3IgcGVyZm9ybWFuY2UgYW5kIHRv IGF2b2lkIGEgY3ljbGljIGRlcGVuZGVuY3kuCi0gICAgUmVuZGVyVmlldyogdmlldygpIGNvbnN0 OworICAgIFJlbmRlclZpZXcqIHZpZXcoKSBjb25zdCB7IHJldHVybiBkb2N1bWVudCgpLT5yZW5k ZXJWaWV3KCk7IH07CiAKICAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhpcyByZW5kZXJlciBpcyBy b290ZWQsIGFuZCBvcHRpb25hbGx5IHJldHVybnMgdGhlIGhvc3RpbmcgdmlldyAodGhlIHJvb3Qg b2YgdGhlIGhpZXJhcmNoeSkuCiAgICAgYm9vbCBpc1Jvb3RlZChSZW5kZXJWaWV3KiogPSAwKSBj b25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oCmluZGV4IDA4NGQ3ZDVhN2Nm ODhkZmVjZTczMjVhNmExMTVlMjBmZmUyYzgwMDQuLmZlMjhlNTU1MWNkNWVmNjU1N2NiZTFhY2M4 NmU0MDczYjcyODY2NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaApAQCAt MzUyLDEyICszNTIsNiBAQCBpbmxpbmUgY29uc3QgUmVuZGVyVmlldyogdG9SZW5kZXJWaWV3KGNv bnN0IFJlbmRlck9iamVjdCogb2JqZWN0KQogLy8gVGhpcyB3aWxsIGNhdGNoIGFueW9uZSBkb2lu ZyBhbiB1bm5lY2Vzc2FyeSBjYXN0Lgogdm9pZCB0b1JlbmRlclZpZXcoY29uc3QgUmVuZGVyVmll dyopOwogCi0KLUFMV0FZU19JTkxJTkUgUmVuZGVyVmlldyogUmVuZGVyT2JqZWN0Ojp2aWV3KCkg Y29uc3QKLXsKLSAgICByZXR1cm4gdG9SZW5kZXJWaWV3KGRvY3VtZW50KCktPnJlbmRlcmVyKCkp OwotfQotCiAvLyBTdGFjay1iYXNlZCBjbGFzcyB0byBhc3Npc3Qgd2l0aCBMYXlvdXRTdGF0ZSBw dXNoL3BvcAogY2xhc3MgTGF5b3V0U3RhdGVNYWludGFpbmVyIHsKICAgICBXVEZfTUFLRV9OT05D T1BZQUJMRShMYXlvdXRTdGF0ZU1haW50YWluZXIpOwo=