100995 2012-11-01 15:19:31 -0700 [Qt][Mac][Win] r133182 broke the build 2012-11-03 04:13:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Blocker --- 100907 0 hnandor webkit-unassigned dongseong.hwang gustavo noam ossy philn xan.lopez oldest_to_newest 756675 0 hnandor 2012-11-01 15:19:31 -0700 c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\webpage\coordinatedgraphics\CoordinatedGraphicsLayer.h(116) : error C3668: 'WebCore::CoordinatedGraphicsLayer::setContentsScale' : method with override specifier 'override' did not override any base class methods c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\webpage\coordinatedgraphics\CoordinatedGraphicsLayer.h(117) : error C3668: 'WebCore::CoordinatedGraphicsLayer::setVisibleContentRectTrajectoryVector' : method with override specifier 'override' did not override any base class methods 756677 1 171943 hnandor 2012-11-01 15:23:13 -0700 Created attachment 171943 proposed patch 756693 2 171943 webkit-ews 2012-11-01 15:47:53 -0700 Comment on attachment 171943 proposed patch Attachment 171943 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14686645 756698 3 171947 hnandor 2012-11-01 15:57:47 -0700 Created attachment 171947 proposed patch Fix pure virtual problem. 756717 4 171947 buildbot 2012-11-01 16:30:05 -0700 Comment on attachment 171947 proposed patch Attachment 171947 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14656691 756720 5 dongseong.hwang 2012-11-01 16:31:42 -0700 Thanks for reporting and patch. Who broke build is me. I think we should not add this API in GraphicLayer. I made a mistake to put virtual and OVERRIDE to two methods in CoordinatedGraphicsLayer. virtual void setContentsScale(float) OVERRIDE; virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&) OVERRIDE; How about removing virtual and OVERRIDE from two methods in CoordinatedGraphicsLayer like this. void setContentsScale(float); void setVisibleContentRectTrajectoryVector(const FloatPoint&); I need two methods position in header file is also changed, because two methods mix with overrided methods of GraphicsLayer. Could you do that? 756948 6 hnandor 2012-11-02 00:37:11 -0700 (In reply to comment #5) > Thanks for reporting and patch. Who broke build is me. > > I think we should not add this API in GraphicLayer. > > I made a mistake to put virtual and OVERRIDE to two methods in CoordinatedGraphicsLayer. > virtual void setContentsScale(float) OVERRIDE; > virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&) OVERRIDE; > > How about removing virtual and OVERRIDE from two methods in CoordinatedGraphicsLayer like this. > void setContentsScale(float); > void setVisibleContentRectTrajectoryVector(const FloatPoint&); > > I need two methods position in header file is also changed, because two methods mix with overrided methods of GraphicsLayer. > > Could you do that? Thank you for the tip, of course I will do that. Unfortunately I chose the wrong way of fixing first. Now I see that other platforms do not need these methods. 756967 7 172001 hnandor 2012-11-02 01:06:56 -0700 Created attachment 172001 proposed patch 756977 8 dongseong.hwang 2012-11-02 01:40:52 -0700 (In reply to comment #7) > Created an attachment (id=172001) [details] > proposed patch Thanks. LGTM! :) 756998 9 172001 ossy 2012-11-02 02:16:33 -0700 Comment on attachment 172001 proposed patch Clearing flags on attachment: 172001 Committed r133276: <http://trac.webkit.org/changeset/133276> 756999 10 ossy 2012-11-02 02:16:39 -0700 All reviewed patches have been landed. Closing bug. 757696 11 172001 darin 2012-11-02 15:57:38 -0700 Comment on attachment 172001 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172001&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:126 > + virtual void setContentsScale(float); > + virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&); The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in! 757876 12 dongseong.hwang 2012-11-02 20:51:09 -0700 (In reply to comment #11) > (From update of attachment 172001 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172001&action=review > > > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:126 > > + virtual void setContentsScale(float); > > + virtual void setVisibleContentRectTrajectoryVector(const FloatPoint&); > > The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in! Thanks. I filed Bug 101141. 757941 13 hnandor 2012-11-03 04:13:42 -0700 (In reply to comment #11) > The change log said you’d remove the virtual as well as OVERRIDE, but the patch removes OVERRIDE but leaves virtual in! I forgot to delete it too, thank you for the remark! 171943 2012-11-01 15:23:13 -0700 2012-11-01 15:57:47 -0700 proposed patch gardening.diff text/plain 1418 hnandor ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZDQ5NzQ0Li45M2NkYmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTEtMDEgIE5hbmRvciBIdXN6a2EgIDxobmFuZG9yQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBbUXRdW01hY11bV2luXSBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMTMz MTgyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw OTk1CisKKyAgICAgICAgSW1wbGVtZW50IGVtcHR5IG1ldGhvZCBib2RpZXMsIGJlY2F1c2UgdGhl eSBzaG91bGQgYmUgb3ZlcnJpZGRlbiBpbiBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCB0aGVyZSBpcyBubyBiZWhhdmlvdXIgY2hhbmdlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oOgorICAgICAgICAoR3JhcGhp Y3NMYXllcik6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyOjpzZXRDb250ZW50c1Nj YWxlKToKKwogMjAxMi0xMS0wMSAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgog CiAgICAgICAgIFBhcnQyIG9mOiBFeHRlbmQgLXdlYmtpdC11c2VyLXNlbGVjdCB3aXRoIG5ldyB2 YWx1ZSAiYWxsIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NMYXllci5oCmluZGV4IDUwODkzY2QuLmIxMzNjM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgKQEAgLTMxNyw2ICszMTcsOSBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldE5lZWRzRGlzcGxheUluUmVjdChjb25zdCBGbG9h dFJlY3QmKSA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q29udGVudHNOZWVkc0Rpc3BsYXko KSB7IH07CisgICAgCisgICAgdmlydHVhbCB2b2lkIHNldENvbnRlbnRzU2NhbGUoZmxvYXQgc2Nh bGUpIHsgfTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0VmlzaWJsZUNvbnRlbnRSZWN0VHJhamVjdG9y eVZlY3Rvcihjb25zdCBGbG9hdFBvaW50JikgPSAwOwogCiAgICAgLy8gU2V0IHRoYXQgdGhlIHBv c2l0aW9uL3NpemUgb2YgdGhlIGNvbnRlbnRzIChpbWFnZSBvciB2aWRlbykuCiAgICAgSW50UmVj dCBjb250ZW50c1JlY3QoKSBjb25zdCB7IHJldHVybiBtX2NvbnRlbnRzUmVjdDsgfQo= 171947 2012-11-01 15:57:47 -0700 2012-11-02 01:06:56 -0700 proposed patch gardening.diff text/plain 1423 hnandor ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZDQ5NzQ0Li45M2NkYmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTEtMDEgIE5hbmRvciBIdXN6a2EgIDxobmFuZG9yQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBbUXRdW01hY11bV2luXSBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMTMz MTgyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw OTk1CisKKyAgICAgICAgSW1wbGVtZW50IG1ldGhvZHMgd2l0aCBlbXB0eSBib2RpZXMsIGJlY2F1 c2UgdGhleSBzaG91bGQgYmUgb3ZlcnJpZGRlbiBpbiBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXIu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGVyZSBpcyBubyBiZWhhdmlvdXIgY2hhbmdlLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oOgorICAgICAgICAo R3JhcGhpY3NMYXllcik6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyOjpzZXRDb250 ZW50c1NjYWxlKToKKwogMjAxMi0xMS0wMSAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIFBhcnQyIG9mOiBFeHRlbmQgLXdlYmtpdC11c2VyLXNlbGVjdCB3aXRo IG5ldyB2YWx1ZSAiYWxsIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NMYXllci5oCmluZGV4IDUwODkzY2QuLmE3ZDEzNDUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgKQEAgLTMxNyw2ICszMTcs OSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldE5lZWRzRGlzcGxheUluUmVjdChjb25z dCBGbG9hdFJlY3QmKSA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q29udGVudHNOZWVkc0Rp c3BsYXkoKSB7IH07CisgICAgCisgICAgdmlydHVhbCB2b2lkIHNldENvbnRlbnRzU2NhbGUoZmxv YXQgc2NhbGUpIHsgfTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0VmlzaWJsZUNvbnRlbnRSZWN0VHJh amVjdG9yeVZlY3Rvcihjb25zdCBGbG9hdFBvaW50JikgeyB9CiAKICAgICAvLyBTZXQgdGhhdCB0 aGUgcG9zaXRpb24vc2l6ZSBvZiB0aGUgY29udGVudHMgKGltYWdlIG9yIHZpZGVvKS4KICAgICBJ bnRSZWN0IGNvbnRlbnRzUmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fY29udGVudHNSZWN0OyB9Cg== 172001 2012-11-02 01:06:56 -0700 2012-11-02 15:57:38 -0700 proposed patch gardening.diff text/plain 2112 hnandor ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNzRiYTA3Li4yZWYxZWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTItMTEtMDIgIE5hbmRvciBIdXN6a2EgIDxobmFuZG9yQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBbUXRdW01hY11bV2luXSBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMTMz MTgyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA5 OTUKKworICAgICAgICBSZW1vdmUgdHdvIG1ldGhvZHMnIE9WRVJSSURFIGFuZCB2aXJ0dWFsIG1v ZGlmaWVycywgYmVjYXVzZSB0aGV5IGNhbm5vdCBiZSBmb3VuZCBpbiBhbnkgYmFzZSBjbGFzcy4K KyAgICAgICAgQWxzbyByZWxvY2F0ZSB0aGVpciBwcm90b3R5cGVzLCBiZWNhdXNlIHRoZXkgbWl4 IHdpdGggdGhlIG92ZXJyaWRkZW4gb25lcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oOgorICAgICAg ICAoQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKToKKwogMjAxMi0xMS0wMiAgSHVhbmcgRG9uZ3N1 bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBDb29yZGluYXRlZCBHcmFw aGljczogTWFuYWdlIHRoZSBsaWZlY3ljbGUgb2Ygc2hhcmVhYmxlIHN1cmZhY2VzIHByZWNpc2Vs eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGlj c0xheWVyLmgKaW5kZXggYjhlODU5NS4uZmI4Nzg3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFw aGljc0xheWVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmgKQEAgLTExMyw4ICsxMTMs NiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldE5lZWRzRGlzcGxheSgpIE9WRVJSSURF OwogICAgIHZpcnR1YWwgdm9pZCBzZXROZWVkc0Rpc3BsYXlJblJlY3QoY29uc3QgRmxvYXRSZWN0 JikgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHNldENvbnRlbnRzTmVlZHNEaXNwbGF5KCkg T1ZFUlJJREU7Ci0gICAgdmlydHVhbCB2b2lkIHNldENvbnRlbnRzU2NhbGUoZmxvYXQpIE9WRVJS SURFOwotICAgIHZpcnR1YWwgdm9pZCBzZXRWaXNpYmxlQ29udGVudFJlY3RUcmFqZWN0b3J5VmVj dG9yKGNvbnN0IEZsb2F0UG9pbnQmKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgZmx1c2hD b21wb3NpdGluZ1N0YXRlKGNvbnN0IEZsb2F0UmVjdCYpIE9WRVJSSURFOwogICAgIHZpcnR1YWwg dm9pZCBmbHVzaENvbXBvc2l0aW5nU3RhdGVGb3JUaGlzTGF5ZXJPbmx5KCkgT1ZFUlJJREU7CiAj aWYgRU5BQkxFKENTU19GSUxURVJTKQpAQCAtMTIzLDYgKzEyMSw5IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIGJvb2wgYWRkQW5pbWF0aW9uKGNvbnN0IEtleWZyYW1lVmFsdWVMaXN0JiwgY29uc3Qg SW50U2l6ZSYsIGNvbnN0IEFuaW1hdGlvbiosIGNvbnN0IFN0cmluZyYsIGRvdWJsZSkgT1ZFUlJJ REU7CiAgICAgdmlydHVhbCB2b2lkIHBhdXNlQW5pbWF0aW9uKGNvbnN0IFN0cmluZyYsIGRvdWJs ZSkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHJlbW92ZUFuaW1hdGlvbihjb25zdCBTdHJp bmcmKSBPVkVSUklERTsKKyAgICAKKyAgICB2aXJ0dWFsIHZvaWQgc2V0Q29udGVudHNTY2FsZShm bG9hdCk7CisgICAgdmlydHVhbCB2b2lkIHNldFZpc2libGVDb250ZW50UmVjdFRyYWplY3RvcnlW ZWN0b3IoY29uc3QgRmxvYXRQb2ludCYpOwogCiAgICAgdm9pZCBzZXRSb290TGF5ZXIoYm9vbCk7 CiAK