100822 2012-10-31 00:21:50 -0700 [EFL][WK2] Add File Chooser dialog support to MiniBrowser 2012-11-01 08:42:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100818 100962 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 755021 0 cdumez 2012-10-31 00:21:50 -0700 MiniBrowser should show a file chooser dialog when the user click on an input element of type "file". 756157 1 171829 cdumez 2012-11-01 06:29:31 -0700 Created attachment 171829 Patch 756210 2 171829 webkit.review.bot 2012-11-01 07:18:05 -0700 Comment on attachment 171829 Patch Clearing flags on attachment: 171829 Committed r133163: <http://trac.webkit.org/changeset/133163> 756211 3 webkit.review.bot 2012-11-01 07:18:10 -0700 All reviewed patches have been landed. Closing bug. 756277 4 171829 naginenis 2012-11-01 08:31:33 -0700 Comment on attachment 171829 Patch I am wondering what happens if we close the main window when the dialog is opened since it is not a modal dialog. My guess is that it can cause the MiniBrowser to crash. 756283 5 cdumez 2012-11-01 08:33:50 -0700 (In reply to comment #4) > (From update of attachment 171829 [details]) > I am wondering what happens if we close the main window when the dialog is opened since it is not a modal dialog. My guess is that it can cause the MiniBrowser to crash. Good point babu. I have to admit I did not try that. I'll check now. 171829 2012-11-01 06:29:31 -0700 2012-11-01 08:31:33 -0700 Patch 100822_minibrowser_file_picker.patch text/plain 4130 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMjky ZmNiLi5iYWFmNTQ5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMTEtMDEgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCBGaWxl IENob29zZXIgZGlhbG9nIHN1cHBvcnQgdG8gTWluaUJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDgyMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB2ZXJ5IGJhc2ljIGZpbGUgcGlja2Vy IGRpYWxvZyB0byBNaW5pQnJvd3NlciBzbyB0aGF0CisgICAgICAgIHRoZSB1c2VyIGNhbiBzZWxl Y3QgYSBmaWxlIGZyb20gdGhlIGZpbGUgc3lzdGVtIHdoZW4KKyAgICAgICAgY2xpY2tpbmcgYW4g aW5wdXQgZWxlbWVudCBvZiB0eXBlICJmaWxlIi4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2Vm bC9tYWluLmM6CisgICAgICAgIChjbG9zZV9maWxlX3BpY2tlcik6CisgICAgICAgIChvbl9maWxl cGlja2VyX2RlbGV0aW9uKToKKyAgICAgICAgKG9uX2ZpbGVzZWxlY3Rvcl9kb25lKToKKyAgICAg ICAgKG9uX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0KToKKyAgICAgICAgKHdpbmRvd19jcmVhdGUpOgor CiAyMDEyLTEwLTMxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIE5SV1Q6IGxpbnQgd2FybmluZ3MgZG9uJ3Qgc2hvdyB1cCBieSBkZWZhdWx0CmRpZmYgLS1n aXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZs L21haW4uYwppbmRleCBiMDhkN2ViLi4wZTJlYTJmIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJv d3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTMw OCw2ICszMDgsNjQgQEAgb25fZG93bmxvYWRfcmVxdWVzdCh2b2lkICp1c2VyX2RhdGEsIEV2YXNf T2JqZWN0ICp3ZWJ2aWV3LCB2b2lkICpldmVudF9pbmZvKQogICAgIGVpbmFfc3RyYnVmX2ZyZWUo ZGVzdGluYXRpb25fcGF0aCk7CiB9CiAKK3R5cGVkZWYgc3RydWN0IHsKKyAgICBFdmFzX09iamVj dCAqd2luZG93OworICAgIEV3a19GaWxlX0Nob29zZXJfUmVxdWVzdCAqcmVxdWVzdDsKK30gRmls ZVNlbGVjdG9yRGF0YTsKKworc3RhdGljIHZvaWQgY2xvc2VfZmlsZV9waWNrZXIoRmlsZVNlbGVj dG9yRGF0YSogZnNfZGF0YSkKK3sKKyAgICBldmFzX29iamVjdF9kZWwoZnNfZGF0YS0+d2luZG93 KTsKKyAgICBld2tfZmlsZV9jaG9vc2VyX3JlcXVlc3RfdW5yZWYoZnNfZGF0YS0+cmVxdWVzdCk7 CisgICAgZnJlZShmc19kYXRhKTsKK30KKworc3RhdGljIHZvaWQKK29uX2ZpbGVwaWNrZXJfZGVs ZXRpb24odm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAqd2luZG93LCB2b2lkICpldmVudF9p bmZvKQoreworICAgIGNsb3NlX2ZpbGVfcGlja2VyKChGaWxlU2VsZWN0b3JEYXRhICopdXNlcl9k YXRhKTsKK30KKworc3RhdGljIHZvaWQKK29uX2ZpbGVzZWxlY3Rvcl9kb25lKHZvaWQgKnVzZXJf ZGF0YSwgRXZhc19PYmplY3QgKmZpbGVfc2VsZWN0b3IsIHZvaWQgKmV2ZW50X2luZm8pCit7Cisg ICAgRmlsZVNlbGVjdG9yRGF0YSAqZnNfZGF0YSA9IChGaWxlU2VsZWN0b3JEYXRhICopdXNlcl9k YXRhOworCisgICAgY29uc3QgY2hhciAqc2VsZWN0ZWQgPSAoY29uc3QgY2hhciAqKWV2ZW50X2lu Zm87CisgICAgaWYgKHNlbGVjdGVkICYmICpzZWxlY3RlZCkKKyAgICAgICAgZXdrX2ZpbGVfY2hv b3Nlcl9yZXF1ZXN0X2ZpbGVfY2hvb3NlKGZzX2RhdGEtPnJlcXVlc3QsIHNlbGVjdGVkKTsKKwor ICAgIGNsb3NlX2ZpbGVfcGlja2VyKGZzX2RhdGEpOworfQorCitzdGF0aWMgdm9pZAorb25fZmls ZV9jaG9vc2VyX3JlcXVlc3Qodm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAqd2Vidmlldywg dm9pZCAqZXZlbnRfaW5mbykKK3sKKyAgICBFd2tfRmlsZV9DaG9vc2VyX1JlcXVlc3QgKnJlcXVl c3QgPSAoRXdrX0ZpbGVfQ2hvb3Nlcl9SZXF1ZXN0ICopZXZlbnRfaW5mbzsKKworICAgIC8vIFNo b3cgYmFzaWMgZmlsZSBwaWNrZXIgd2hpY2ggZG9lcyBub3QgY3VycmVudGx5IHN1cHBvcnQgbXVs dGlwbGUgZmlsZXMKKyAgICAvLyBvciBNSU1FIHR5cGUgZmlsdGVyaW5nLgorICAgIEV2YXNfT2Jq ZWN0ICp3aW5kb3cgPSBlbG1fd2luX3V0aWxfc3RhbmRhcmRfYWRkKCJmaWxlLXBpY2tlci13aW5k b3ciLCAiRmlsZSBwaWNrZXIiKTsKKworICAgIEZpbGVTZWxlY3RvckRhdGEqIGZzX2RhdGEgPSAo RmlsZVNlbGVjdG9yRGF0YSopbWFsbG9jKHNpemVvZihGaWxlU2VsZWN0b3JEYXRhKSk7CisgICAg ZnNfZGF0YS0+d2luZG93ID0gd2luZG93OworICAgIGZzX2RhdGEtPnJlcXVlc3QgPSBld2tfZmls ZV9jaG9vc2VyX3JlcXVlc3RfcmVmKHJlcXVlc3QpOworICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2Nh bGxiYWNrX2FkZCh3aW5kb3csICJkZWxldGUscmVxdWVzdCIsIG9uX2ZpbGVwaWNrZXJfZGVsZXRp b24sIGZzX2RhdGEpOworCisgICAgRXZhc19PYmplY3QgKmZpbGVfc2VsZWN0b3IgPSBlbG1fZmls ZXNlbGVjdG9yX2FkZCh3aW5kb3cpOworICAgIGNvbnN0IGNoYXIgKmhvbWVfcGF0aCA9IGdldGVu digiSE9NRSIpOworICAgIGVsbV9maWxlc2VsZWN0b3JfcGF0aF9zZXQoZmlsZV9zZWxlY3Rvciwg aG9tZV9wYXRoID8gaG9tZV9wYXRoIDogIi9ob21lIik7CisgICAgZXZhc19vYmplY3Rfc2l6ZV9o aW50X3dlaWdodF9zZXQoZmlsZV9zZWxlY3RvciwgRVZBU19ISU5UX0VYUEFORCwgRVZBU19ISU5U X0VYUEFORCk7CisgICAgZWxtX3dpbl9yZXNpemVfb2JqZWN0X2FkZCh3aW5kb3csIGZpbGVfc2Vs ZWN0b3IpOworICAgIGV2YXNfb2JqZWN0X3Nob3coZmlsZV9zZWxlY3Rvcik7CisKKyAgICBldmFz X29iamVjdF9zbWFydF9jYWxsYmFja19hZGQoZmlsZV9zZWxlY3RvciwgImRvbmUiLCBvbl9maWxl c2VsZWN0b3JfZG9uZSwgZnNfZGF0YSk7CisKKyAgICBldmFzX29iamVjdF9yZXNpemUod2luZG93 LCA0MDAsIDQwMCk7CisgICAgZWxtX3dpbl9jZW50ZXIod2luZG93LCBFSU5BX1RSVUUsIEVJTkFf VFJVRSk7CisgICAgZXZhc19vYmplY3Rfc2hvdyh3aW5kb3cpOworfQorCiBzdGF0aWMgdm9pZAog b25fZG93bmxvYWRfZmluaXNoZWQodm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAqd2Vidmll dywgdm9pZCAqZXZlbnRfaW5mbykKIHsKQEAgLTcxOCw2ICs3NzYsNyBAQCBzdGF0aWMgQnJvd3Nl cl9XaW5kb3cgKndpbmRvd19jcmVhdGUoY29uc3QgY2hhciAqdXJsKQogICAgIGV2YXNfb2JqZWN0 X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImRvd25sb2FkLGZhaWxlZCIs IG9uX2Rvd25sb2FkX2ZhaWxlZCwgYXBwX2RhdGEpOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2Nh bGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImRvd25sb2FkLGZpbmlzaGVkIiwgb25fZG93 bmxvYWRfZmluaXNoZWQsIGFwcF9kYXRhKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFj a19hZGQoYXBwX2RhdGEtPndlYnZpZXcsICJkb3dubG9hZCxyZXF1ZXN0Iiwgb25fZG93bmxvYWRf cmVxdWVzdCwgYXBwX2RhdGEpOworICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChh cHBfZGF0YS0+d2VidmlldywgImZpbGUsY2hvb3NlcixyZXF1ZXN0Iiwgb25fZmlsZV9jaG9vc2Vy X3JlcXVlc3QsIGFwcF9kYXRhKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQo YXBwX2RhdGEtPndlYnZpZXcsICJpY29uLGNoYW5nZWQiLCBvbl92aWV3X2ljb25fY2hhbmdlZCwg YXBwX2RhdGEpOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+ d2VidmlldywgImxvYWQsZXJyb3IiLCBvbl9lcnJvciwgYXBwX2RhdGEpOwogICAgIGV2YXNfb2Jq ZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImxvYWQscHJvZ3Jlc3Mi LCBvbl9wcm9ncmVzcywgYXBwX2RhdGEpOwo=