100765 2012-10-30 09:23:13 -0700 [CSS Exclusions] remove null exclusion shape check from ExclusionShape::createExclusionShape 2012-11-19 08:55:36 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe giles_joplin dglazkov eric giles_joplin webkit.review.bot oldest_to_newest 754427 0 bjonesbe 2012-10-30 09:23:13 -0700 It doesn't really make sense for createExclusionShape to return null. It would be more with WebKit style to ensure that it need gets passed a null shape and have it ASSERT that the shape is not null. See comments on bug 100398 for the genesis of this bug. 768673 1 174557 giles_joplin 2012-11-15 16:44:26 -0800 Created attachment 174557 Patch ExclusionShape::createExclusionShape now ASSERTs that its basicShape argument isn't null, since the caller is expected to ensure as much. 768789 2 174557 webkit.review.bot 2012-11-15 18:07:32 -0800 Comment on attachment 174557 Patch Attachment 174557 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14848604 New failing tests: platform/chromium/virtual/threaded/compositing/webgl/webgl-background-color.html 769360 3 174708 giles_joplin 2012-11-16 09:32:06 -0800 Created attachment 174708 Patch The probability that my small change to createExclusionShape() impacted a WebGL test seems extremely small so I've sync'd with the latest repository and uploaded a new version of the same patch. 770795 4 174708 webkit.review.bot 2012-11-19 08:55:32 -0800 Comment on attachment 174708 Patch Clearing flags on attachment: 174708 Committed r135166: <http://trac.webkit.org/changeset/135166> 770796 5 webkit.review.bot 2012-11-19 08:55:36 -0800 All reviewed patches have been landed. Closing bug. 174557 2012-11-15 16:44:26 -0800 2012-11-16 09:32:06 -0800 Patch tmp.patch text/plain 1680 giles_joplin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5OTM5Yzk2Li5mMDQ4YzE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTEtMTUgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAg ICAgW0NTUyBFeGNsdXNpb25zXSByZW1vdmUgbnVsbCBleGNsdXNpb24gc2hhcGUgY2hlY2sgZnJv bSBFeGNsdXNpb25TaGFwZTo6Y3JlYXRlRXhjbHVzaW9uU2hhcGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDc2NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4Y2x1c2lvblNoYXBlOjpjcmVhdGVFeGNs dXNpb25TaGFwZSBub3cgQVNTRVJUcyB0aGF0IGl0cyBiYXNpY1NoYXBlIGFyZ3VtZW50CisgICAg ICAgIGlzbid0IG51bGwsIHNpbmNlIHRoZSBjYWxsZXIgaXMgZXhwZWN0ZWQgdG8gZW5zdXJlIGFz IG11Y2guICBObyBuZXcgdGVzdHMgd2VyZQorICAgICAgICBuZWVkZWQgc2luY2UgdGhpcyBpcyBh IG5lYXItdHJpdmlhbCBjbGVhbnVwLgorCisgICAgICAgICogcmVuZGVyaW5nL0V4Y2x1c2lvblNo YXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV4Y2x1c2lvblNoYXBlOjpjcmVhdGVFeGNsdXNp b25TaGFwZSk6IFRoaXMgbWV0aG9kIG5vIGxvbmdlciBkZWZlbmRzIGFnYWluc3QgYSBudWxsIGJh c2ljU2hhcGUgYXJndW1lbnQgYnkgcmV0dXJuaW5nIG51bGwuCisKIDIwMTItMTEtMTUgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRW5zdXJlIHRoYXQg c2Nyb2xsYmFyIGxheWVycyBzaG93IGRlYnVnIGJvcmRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9FeGNsdXNpb25TaGFwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvRXhjbHVzaW9uU2hhcGUuY3BwCmluZGV4IGY1ZDg1YjIuLjVlMGVhOGIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9FeGNsdXNpb25TaGFwZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0V4Y2x1c2lvblNoYXBlLmNwcApAQCAtNzAsOCArNzAsNyBA QCBzdGF0aWMgUGFzc093blB0cjxFeGNsdXNpb25TaGFwZT4gY3JlYXRlRXhjbHVzaW9uUG9seWdv bihQYXNzT3duUHRyPFZlY3RvcjxGbG9hdAogCiBQYXNzT3duUHRyPEV4Y2x1c2lvblNoYXBlPiBF eGNsdXNpb25TaGFwZTo6Y3JlYXRlRXhjbHVzaW9uU2hhcGUoY29uc3QgQmFzaWNTaGFwZSogYmFz aWNTaGFwZSwgZmxvYXQgbG9naWNhbEJveFdpZHRoLCBmbG9hdCBsb2dpY2FsQm94SGVpZ2h0LCBX cml0aW5nTW9kZSB3cml0aW5nTW9kZSkKIHsKLSAgICBpZiAoIWJhc2ljU2hhcGUpCi0gICAgICAg IHJldHVybiBudWxscHRyOworICAgIEFTU0VSVChiYXNpY1NoYXBlKTsKIAogICAgIGJvb2wgaG9y aXpvbnRhbFdyaXRpbmdNb2RlID0gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUod3JpdGluZ01vZGUp OwogICAgIGZsb2F0IGJveFdpZHRoID0gaG9yaXpvbnRhbFdyaXRpbmdNb2RlID8gbG9naWNhbEJv eFdpZHRoIDogbG9naWNhbEJveEhlaWdodDsK 174708 2012-11-16 09:32:06 -0800 2012-11-19 08:55:32 -0800 Patch tmp.patch text/plain 1672 giles_joplin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwNGE4ZDU1Li44NjRlZDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTEtMTUgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAg ICAgW0NTUyBFeGNsdXNpb25zXSByZW1vdmUgbnVsbCBleGNsdXNpb24gc2hhcGUgY2hlY2sgZnJv bSBFeGNsdXNpb25TaGFwZTo6Y3JlYXRlRXhjbHVzaW9uU2hhcGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDc2NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4Y2x1c2lvblNoYXBlOjpjcmVhdGVFeGNs dXNpb25TaGFwZSBub3cgQVNTRVJUcyB0aGF0IGl0cyBiYXNpY1NoYXBlIGFyZ3VtZW50CisgICAg ICAgIGlzbid0IG51bGwsIHNpbmNlIHRoZSBjYWxsZXIgaXMgZXhwZWN0ZWQgdG8gZW5zdXJlIGFz IG11Y2guICBObyBuZXcgdGVzdHMgd2VyZQorICAgICAgICBuZWVkZWQgc2luY2UgdGhpcyBpcyBh IG5lYXItdHJpdmlhbCBjbGVhbnVwLgorCisgICAgICAgICogcmVuZGVyaW5nL0V4Y2x1c2lvblNo YXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV4Y2x1c2lvblNoYXBlOjpjcmVhdGVFeGNsdXNp b25TaGFwZSk6IFRoaXMgbWV0aG9kIG5vIGxvbmdlciBkZWZlbmRzIGFnYWluc3QgYSBudWxsIGJh c2ljU2hhcGUgYXJndW1lbnQgYnkgcmV0dXJuaW5nIG51bGwuCisKIDIwMTItMTEtMTYgIEVyaWsg QXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVcGRhdGUgRE9NRXhjZXB0 aW9uIG5hbWU6IFR5cGVNaXNtYXRjaEVycm9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvRXhjbHVzaW9uU2hhcGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0V4 Y2x1c2lvblNoYXBlLmNwcAppbmRleCBmNWQ4NWIyLi41ZTBlYThiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvRXhjbHVzaW9uU2hhcGUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9FeGNsdXNpb25TaGFwZS5jcHAKQEAgLTcwLDggKzcwLDcgQEAgc3RhdGlj IFBhc3NPd25QdHI8RXhjbHVzaW9uU2hhcGU+IGNyZWF0ZUV4Y2x1c2lvblBvbHlnb24oUGFzc093 blB0cjxWZWN0b3I8RmxvYXQKIAogUGFzc093blB0cjxFeGNsdXNpb25TaGFwZT4gRXhjbHVzaW9u U2hhcGU6OmNyZWF0ZUV4Y2x1c2lvblNoYXBlKGNvbnN0IEJhc2ljU2hhcGUqIGJhc2ljU2hhcGUs IGZsb2F0IGxvZ2ljYWxCb3hXaWR0aCwgZmxvYXQgbG9naWNhbEJveEhlaWdodCwgV3JpdGluZ01v ZGUgd3JpdGluZ01vZGUpCiB7Ci0gICAgaWYgKCFiYXNpY1NoYXBlKQotICAgICAgICByZXR1cm4g bnVsbHB0cjsKKyAgICBBU1NFUlQoYmFzaWNTaGFwZSk7CiAKICAgICBib29sIGhvcml6b250YWxX cml0aW5nTW9kZSA9IGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKHdyaXRpbmdNb2RlKTsKICAgICBm bG9hdCBib3hXaWR0aCA9IGhvcml6b250YWxXcml0aW5nTW9kZSA/IGxvZ2ljYWxCb3hXaWR0aCA6 IGxvZ2ljYWxCb3hIZWlnaHQ7Cg==