100459 2012-10-25 22:13:02 -0700 [Refactoring] Use isActiveInsertionPoint instead of isInsertionPoint 2012-10-29 05:51:51 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97279 1 shinyak shinyak webcomponents-bugzilla webkit.review.bot oldest_to_newest 751541 0 shinyak 2012-10-25 22:13:02 -0700 Basically inert InsertionPoint has no meaning. We don't need to cast it to InsertionPoint. So it would be good to have isActiveInsertionPoint instead of isInsertionPoint so that we don't miss isActive check. 753061 1 171156 shinyak 2012-10-28 22:14:27 -0700 Created attachment 171156 Patch 753315 2 171156 webkit.review.bot 2012-10-29 05:51:48 -0700 Comment on attachment 171156 Patch Clearing flags on attachment: 171156 Committed r132791: <http://trac.webkit.org/changeset/132791> 753316 3 webkit.review.bot 2012-10-29 05:51:51 -0700 All reviewed patches have been landed. Closing bug. 171156 2012-10-28 22:14:27 -0700 2012-10-29 05:51:48 -0700 Patch bug-100459-20121029141254.patch text/plain 5933 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2I0NTRiOGMxYzQ3NmFm NTFlNWQ4NDFiN2NhYjZjZDkzZWU5ZTNhZC4uYzU5MWQxMDY4OWFmYmNhMTM5ZDdlNjA1Y2U0Yzdk ZjcyMDhjNDE3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTEwLTI4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4gCisKKyAgICAgICAgW1JlZmFjdG9y aW5nXSBVc2UgaXNBY3RpdmVJbnNlcnRpb25Qb2ludCgpIGluc3RlYWQgb2YgaXNJbnNlcnRpb25Q b2ludCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDA0NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aGVja2luZyBJbnNlcnRpb25Qb2ludCBhbmQgaXRzIGFjdGl2ZW5lc3Mgd2l0aCB0d28gaWYtc3Rh dGVtZW50IGlzIGVycm9yLXByb25lLiBXZSB3b3VsZCBsaWtlIHRvCisgICAgICAgIHVzZSBhIHV0 aWxpdHkgZnVuY3Rpb24gd2hpY2ggY2hlY2tzIGJvdGggYXQgb25jZS4KKworICAgICAgICBXZSBy ZXdyaXRlIHNvbWUgbGluZXMgd2l0aCBzdWNoIGZ1bmN0aW9uLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgc2ltcGxlIHJlZmFjdG9yaW5nLgorCisgICAgICAgICogZG9tL0NvbXBvc2VkU2hhZG93 VHJlZVdhbGtlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NlZFNoYWRvd1RyZWVXYWxr ZXI6OnRyYXZlcnNlTm9kZSk6CisgICAgICAgICogaHRtbC9zaGFkb3cvQ29udGVudERpc3RyaWJ1 dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnREaXN0cmlidXRvcjo6cG9wdWxhdGUp OgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudERpc3RyaWJ1dG9yOjpkaXN0cmlidXRlKToKKyAg ICAgICAgKFdlYkNvcmU6OkNvbnRlbnREaXN0cmlidXRvcjo6ZGlzdHJpYnV0ZU5vZGVDaGlsZHJl blRvKToKKyAgICAgICAgKiBodG1sL3NoYWRvdy9JbnNlcnRpb25Qb2ludC5oOgorICAgICAgICAo V2ViQ29yZTo6aXNJbnNlcnRpb25Qb2ludCk6IFNpbmNlIG91ciBjb252ZW50aW9uIGlzIHRoZSBh cmd1bWVudCBvZiB0aGlzIGtpbmQgb2YgZnVuY3Rpb24gc2hvdWxkIG5vdCBiZSBudWxsLAorICAg ICAgICB3ZSB3b3VsZCBsaWtlIHRvIG1ha2UgaXQgc2ltaWxhciB0byB0aGUgb3RoZXIgZnVuY3Rp b25zLgorICAgICAgICAoV2ViQ29yZTo6dG9JbnNlcnRpb25Qb2ludCk6CisgICAgICAgIChXZWJD b3JlOjppc0xvd2VyRW5jYXBzdWxhdGlvbkJvdW5kYXJ5KToKKwogMjAxMi0xMC0yOCAgU2hpbnlh IEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVGhlIHNoYWRvdyBl bGVtZW50IGlzIG5vdCByZXByb2plY3RlZCB0byBhIG5lc3RlZCBTaGFkb3dSb290LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbXBvc2VkU2hhZG93VHJlZVdhbGtlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyLmNwcAppbmRleCAyNmI4 M2YzMWUwNWYxYWI5M2MwMWRiODlhZGFjYWZiNjQyYTljYzE1Li45MTA1N2Y4NGFmMGMyY2FmOTc3 ODViZDgzMTc3MzAwNThmZTI3OGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29t cG9zZWRTaGFkb3dUcmVlV2Fsa2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9z ZWRTaGFkb3dUcmVlV2Fsa2VyLmNwcApAQCAtMTk4LDExICsxOTgsOSBAQCBOb2RlKiBDb21wb3Nl ZFNoYWRvd1RyZWVXYWxrZXI6OnRyYXZlcnNlU2libGluZ3MoY29uc3QgTm9kZSogbm9kZSwgVHJh dmVyc2FsRGlyZQogTm9kZSogQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyOjp0cmF2ZXJzZU5vZGUo Y29uc3QgTm9kZSogbm9kZSwgVHJhdmVyc2FsRGlyZWN0aW9uIGRpcmVjdGlvbikKIHsKICAgICBB U1NFUlQobm9kZSk7Ci0gICAgaWYgKCFpc0luc2VydGlvblBvaW50KG5vZGUpKQorICAgIGlmICgh aXNBY3RpdmVJbnNlcnRpb25Qb2ludChub2RlKSkKICAgICAgICAgcmV0dXJuIGNvbnN0X2Nhc3Q8 Tm9kZSo+KG5vZGUpOwogICAgIGNvbnN0IEluc2VydGlvblBvaW50KiBpbnNlcnRpb25Qb2ludCA9 IHRvSW5zZXJ0aW9uUG9pbnQobm9kZSk7Ci0gICAgaWYgKCFpbnNlcnRpb25Qb2ludC0+aXNBY3Rp dmUoKSkKLSAgICAgICAgcmV0dXJuIGNvbnN0X2Nhc3Q8Tm9kZSo+KG5vZGUpOwogICAgIGlmIChO b2RlKiBmb3VuZCA9IHRyYXZlcnNlRGlzdHJpYnV0ZWROb2RlcyhkaXJlY3Rpb24gPT0gVHJhdmVy c2FsRGlyZWN0aW9uRm9yd2FyZCA/IGluc2VydGlvblBvaW50LT5maXJzdCgpIDogaW5zZXJ0aW9u UG9pbnQtPmxhc3QoKSwgaW5zZXJ0aW9uUG9pbnQsIGRpcmVjdGlvbikpCiAgICAgICAgIHJldHVy biBmb3VuZDsKICAgICByZXR1cm4gdHJhdmVyc2VMaWdodENoaWxkcmVuKG5vZGUsIGRpcmVjdGlv bik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9Db250ZW50RGlzdHJp YnV0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvQ29udGVudERpc3RyaWJ1dG9y LmNwcAppbmRleCA5ZjQ0YTUwMGRkMGI2MDYxNDYxMzI5NTA0YmQ1ZmY1ZDg1ODVlM2FjLi4wYTJk OTI2MmQwMmVjZjVhOGM3OTI2MGE4YTQwYjM0ZGM2NzRiNTRkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9Db250ZW50RGlzdHJpYnV0b3IuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvc2hhZG93L0NvbnRlbnREaXN0cmlidXRvci5jcHAKQEAgLTUyLDE3ICs1Miwx MiBAQCBJbnNlcnRpb25Qb2ludCogQ29udGVudERpc3RyaWJ1dG9yOjpmaW5kSW5zZXJ0aW9uUG9p bnRGb3IoY29uc3QgTm9kZSoga2V5KSBjb25zdAogCiB2b2lkIENvbnRlbnREaXN0cmlidXRvcjo6 cG9wdWxhdGUoTm9kZSogbm9kZSwgQ29udGVudERpc3RyaWJ1dGlvbiYgcG9vbCkKIHsKLSAgICBp ZiAoIWlzSW5zZXJ0aW9uUG9pbnQobm9kZSkpIHsKKyAgICBpZiAoIWlzQWN0aXZlSW5zZXJ0aW9u UG9pbnQobm9kZSkpIHsKICAgICAgICAgcG9vbC5hcHBlbmQobm9kZSk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKICAgICBJbnNlcnRpb25Qb2ludCogaW5zZXJ0aW9uUG9pbnQgPSB0b0luc2Vy dGlvblBvaW50KG5vZGUpOwotICAgIGlmICghaW5zZXJ0aW9uUG9pbnQtPmlzQWN0aXZlKCkpIHsK LSAgICAgICAgcG9vbC5hcHBlbmQoaW5zZXJ0aW9uUG9pbnQpOwotICAgICAgICByZXR1cm47Ci0g ICAgfQotCiAgICAgaWYgKGluc2VydGlvblBvaW50LT5oYXNEaXN0cmlidXRpb24oKSkgewogICAg ICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGluc2VydGlvblBvaW50LT5zaXplKCk7ICsraSkK ICAgICAgICAgICAgIHBvcHVsYXRlKGluc2VydGlvblBvaW50LT5hdChpKSwgcG9vbCk7CkBAIC05 MSwxMSArODYsOSBAQCB2b2lkIENvbnRlbnREaXN0cmlidXRvcjo6ZGlzdHJpYnV0ZShFbGVtZW50 KiBob3N0KQogICAgICAgICBIVE1MU2hhZG93RWxlbWVudCogZmlyc3RBY3RpdmVTaGFkb3dJbnNl cnRpb25Qb2ludCA9IDA7CiAKICAgICAgICAgZm9yIChOb2RlKiBub2RlID0gcm9vdDsgbm9kZTsg bm9kZSA9IG5vZGUtPnRyYXZlcnNlTmV4dE5vZGUocm9vdCkpIHsKLSAgICAgICAgICAgIGlmICgh aXNJbnNlcnRpb25Qb2ludChub2RlKSkKKyAgICAgICAgICAgIGlmICghaXNBY3RpdmVJbnNlcnRp b25Qb2ludChub2RlKSkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIElu c2VydGlvblBvaW50KiBwb2ludCA9IHRvSW5zZXJ0aW9uUG9pbnQobm9kZSk7Ci0gICAgICAgICAg ICBpZiAoIXBvaW50LT5pc0FjdGl2ZSgpKQotICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAg ICAgICAgICAgICBpZiAoaXNIVE1MU2hhZG93RWxlbWVudChub2RlKSkgewogICAgICAgICAgICAg ICAgIGlmICghZmlyc3RBY3RpdmVTaGFkb3dJbnNlcnRpb25Qb2ludCkKQEAgLTE3OSw3ICsxNzIs NyBAQCB2b2lkIENvbnRlbnREaXN0cmlidXRvcjo6ZGlzdHJpYnV0ZU5vZGVDaGlsZHJlblRvKElu c2VydGlvblBvaW50KiBpbnNlcnRpb25Qb2ludAogewogICAgIENvbnRlbnREaXN0cmlidXRpb24g ZGlzdHJpYnV0aW9uOwogICAgIGZvciAoTm9kZSogbm9kZSA9IGNvbnRhaW5lck5vZGUtPmZpcnN0 Q2hpbGQoKTsgbm9kZTsgbm9kZSA9IG5vZGUtPm5leHRTaWJsaW5nKCkpIHsKLSAgICAgICAgaWYg KGlzSW5zZXJ0aW9uUG9pbnQobm9kZSkgJiYgdG9JbnNlcnRpb25Qb2ludChub2RlKS0+aXNBY3Rp dmUoKSkgeworICAgICAgICBpZiAoaXNBY3RpdmVJbnNlcnRpb25Qb2ludChub2RlKSkgewogICAg ICAgICAgICAgSW5zZXJ0aW9uUG9pbnQqIGlubmVySW5zZXJ0aW9uUG9pbnQgPSB0b0luc2VydGlv blBvaW50KG5vZGUpOwogICAgICAgICAgICAgaWYgKGlubmVySW5zZXJ0aW9uUG9pbnQtPmhhc0Rp c3RyaWJ1dGlvbigpKSB7CiAgICAgICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBp bm5lckluc2VydGlvblBvaW50LT5zaXplKCk7ICsraSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9zaGFkb3cvSW5zZXJ0aW9uUG9pbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv c2hhZG93L0luc2VydGlvblBvaW50LmgKaW5kZXggZjllMDg0ZmIwYzg4NjUyZGVlNjA5YTFiNGYw ZjQ4ZjBhNjFjNjY3Ni4uMjY4NTZkZDc1MThkNDNlZWZlYjY2YTdmODg2MjIyMThjMWNhOWQ3ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvSW5zZXJ0aW9uUG9pbnQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9JbnNlcnRpb25Qb2ludC5oCkBAIC04Niw5 ICs4Niw2IEBAIHByaXZhdGU6CiAKIGlubGluZSBib29sIGlzSW5zZXJ0aW9uUG9pbnQoY29uc3Qg Tm9kZSogbm9kZSkKIHsKLSAgICBpZiAoIW5vZGUpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQog ICAgIGlmIChub2RlLT5pc0hUTUxFbGVtZW50KCkgJiYgdG9IVE1MRWxlbWVudChub2RlKS0+aXNJ bnNlcnRpb25Qb2ludCgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIApAQCAtOTcsMTMgKzk0LDEz IEBAIGlubGluZSBib29sIGlzSW5zZXJ0aW9uUG9pbnQoY29uc3QgTm9kZSogbm9kZSkKIAogaW5s aW5lIEluc2VydGlvblBvaW50KiB0b0luc2VydGlvblBvaW50KE5vZGUqIG5vZGUpCiB7Ci0gICAg QVNTRVJUKGlzSW5zZXJ0aW9uUG9pbnQobm9kZSkpOworICAgIEFTU0VSVCghbm9kZSB8fCBpc0lu c2VydGlvblBvaW50KG5vZGUpKTsKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8SW5zZXJ0aW9uUG9p bnQqPihub2RlKTsKIH0KIAogaW5saW5lIGNvbnN0IEluc2VydGlvblBvaW50KiB0b0luc2VydGlv blBvaW50KGNvbnN0IE5vZGUqIG5vZGUpCiB7Ci0gICAgQVNTRVJUKGlzSW5zZXJ0aW9uUG9pbnQo bm9kZSkpOworICAgIEFTU0VSVCghbm9kZSB8fCBpc0luc2VydGlvblBvaW50KG5vZGUpKTsKICAg ICByZXR1cm4gc3RhdGljX2Nhc3Q8Y29uc3QgSW5zZXJ0aW9uUG9pbnQqPihub2RlKTsKIH0KIApA QCAtMTE0LDcgKzExMSw3IEBAIGlubGluZSBib29sIGlzQWN0aXZlSW5zZXJ0aW9uUG9pbnQoY29u c3QgTm9kZSogbm9kZSkKIAogaW5saW5lIGJvb2wgaXNMb3dlckVuY2Fwc3VsYXRpb25Cb3VuZGFy eShOb2RlKiBub2RlKQogewotICAgIGlmICghaXNJbnNlcnRpb25Qb2ludChub2RlKSkKKyAgICBp ZiAoIW5vZGUgfHwgIWlzSW5zZXJ0aW9uUG9pbnQobm9kZSkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICByZXR1cm4gdG9JbnNlcnRpb25Qb2ludChub2RlKS0+aXNTaGFkb3dCb3VuZGFyeSgp OwogfQo=