<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100320</bug_id>
          
          <creation_ts>2012-10-24 19:49:50 -0700</creation_ts>
          <short_desc>Fix potential overflow in jpeg exif reader. Found by aedla@google.com.</short_desc>
          <delta_ts>2012-10-30 16:44:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>100191</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Nico Weber">thakis</reporter>
          <assigned_to name="Nico Weber">thakis</assigned_to>
          <cc>eric</cc>
    
    <cc>noel.gordon</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>750317</commentid>
    <comment_count>0</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-24 19:49:50 -0700</bug_when>
    <thetext>Fix potential overflow in jpeg exif reader. Found by aedla@google.com.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>750318</commentid>
    <comment_count>1</comment_count>
      <attachid>170540</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-24 19:50:06 -0700</bug_when>
    <thetext>Created attachment 170540
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>751126</commentid>
    <comment_count>2</comment_count>
      <attachid>170540</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-25 12:38:03 -0700</bug_when>
    <thetext>Comment on attachment 170540
Patch

Sounds like the security folks are still tweaking what to do here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753818</commentid>
    <comment_count>3</comment_count>
      <attachid>171328</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-29 15:48:35 -0700</bug_when>
    <thetext>Created attachment 171328
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753849</commentid>
    <comment_count>4</comment_count>
      <attachid>171328</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-29 16:32:50 -0700</bug_when>
    <thetext>Comment on attachment 171328
Patch

This is really a Noel review.  If he says LGTM, then I&apos;m happy to r+.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753850</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-29 16:33:15 -0700</bug_when>
    <thetext>Noel really should add himself to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/watchlist for all the decoder files. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754389</commentid>
    <comment_count>6</comment_count>
      <attachid>171460</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-30 08:34:40 -0700</bug_when>
    <thetext>Created attachment 171460
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754711</commentid>
    <comment_count>7</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-30 15:20:03 -0700</bug_when>
    <thetext>Sounds like folks are happy with this. Can I get r+?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754723</commentid>
    <comment_count>8</comment_count>
      <attachid>171460</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-30 15:30:01 -0700</bug_when>
    <thetext>Comment on attachment 171460
Patch

I assume Noel had a chance to look (and may have just commented to you over IRC)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754724</commentid>
    <comment_count>9</comment_count>
      <attachid>171460</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-30 15:30:23 -0700</bug_when>
    <thetext>Comment on attachment 171460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171460&amp;action=review

&gt; Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:192
&gt; +        if (marker-&gt;data_length &lt; 6 || ifdOffset &gt;= marker-&gt;data_length - 6)
&gt; +            continue;
&gt;          ifdOffset += 6; // Account for &apos;Exif\0&lt;fill byte&gt;&apos; header.

6 should probably be a constant with a nice name instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754732</commentid>
    <comment_count>10</comment_count>
      <attachid>171534</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-30 15:39:31 -0700</bug_when>
    <thetext>Created attachment 171534
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754733</commentid>
    <comment_count>11</comment_count>
      <attachid>171535</attachid>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-30 15:40:05 -0700</bug_when>
    <thetext>Created attachment 171535
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754781</commentid>
    <comment_count>12</comment_count>
    <who name="noel gordon">noel.gordon</who>
    <bug_when>2012-10-30 16:38:02 -0700</bug_when>
    <thetext>LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754785</commentid>
    <comment_count>13</comment_count>
      <attachid>171535</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-30 16:44:07 -0700</bug_when>
    <thetext>Comment on attachment 171535
Patch for landing

Clearing flags on attachment: 171535

Committed r132961: &lt;http://trac.webkit.org/changeset/132961&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754788</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-30 16:44:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>170540</attachid>
            <date>2012-10-24 19:50:06 -0700</date>
            <delta_ts>2012-10-29 15:48:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100320-20121024194842.patch</filename>
            <type>text/plain</type>
            <size>1544</size>
            <attacher name="Nico Weber">thakis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhjZDVlZWQzMzAxMDJi
ZDU0NzQ0Mjg2MDBiMzQ4ZmQ5YTY3ODdjMy4uYWY2NWI4NTE2Zjc0ZThjYWRjMDhlMTllNGQ4YTg5
MzIyOTE3NDk3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTI0ICBOaWNv
IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcG90ZW50aWFsIG92
ZXJmbG93IGluIGpwZWcgZXhpZiByZWFkZXIuIEZvdW5kIGJ5IGFlZGxhQGdvb2dsZS5jb20uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzMjAKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt
L2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpyZWFkSW1hZ2VPcmllbnRhdGlvbik6CisKIDIwMTItMTAtMjQgIExldmkgV2VpbnRyYXVi
ICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeGluZyB0aGUgQ2hyb21pdW0gYnVp
bGQgYWZ0ZXIgdHlwbyBpbiByMTMyMzY3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHAK
aW5kZXggMTQxMzM3Y2YwMTgwM2I2MTIzZjU5NTcyZjlhZDM3ODAyNDg1MTIyNy4uMDY1ZWIxZmI5
Y2ZiNDlhNThlNjU3NzZlOGQ3OWI3MjQ2NDAzZTJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURl
Y29kZXIuY3BwCkBAIC0xOTQsNiArMTk0LDggQEAgc3RhdGljIEltYWdlT3JpZW50YXRpb24gcmVh
ZEltYWdlT3JpZW50YXRpb24oanBlZ19kZWNvbXByZXNzX3N0cnVjdCogaW5mbykKICAgICAgICAg
Ly8gaHR0cDovL3BhcnRuZXJzLmFkb2JlLmNvbS9wdWJsaWMvZGV2ZWxvcGVyL2VuL3RpZmYvVElG
RjYucGRmCiAgICAgICAgIEpPQ1RFVCogaWZkID0gbWFya2VyLT5kYXRhICsgaWZkT2Zmc2V0Owog
ICAgICAgICBKT0NURVQqIGVuZCA9IG1hcmtlci0+ZGF0YSArIG1hcmtlci0+ZGF0YV9sZW5ndGg7
CisgICAgICAgIGlmIChlbmQgPCBpZmQpIC8vIENhdGNoIG92ZXJmbG93CisgICAgICAgICAgICBj
b250aW51ZTsKICAgICAgICAgaWYgKGVuZCAtIGlmZCA8IDIpCiAgICAgICAgICAgICBjb250aW51
ZTsKICAgICAgICAgdW5zaWduZWQgdGFnQ291bnQgPSByZWFkVWludDE2KGlmZCwgaXNCaWdFbmRp
YW4pOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171328</attachid>
            <date>2012-10-29 15:48:35 -0700</date>
            <delta_ts>2012-10-30 08:34:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100320-20121029154708.patch</filename>
            <type>text/plain</type>
            <size>1858</size>
            <attacher name="Nico Weber">thakis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJjNTlkNTFkOWY5ZjZh
ZDZmMzMxMGEzYzc1MDE4MTUzMGUxY2M3OC4uOGUwNDcyMTU3ODZlMjExODEwNWNlOGIxMjY2ZmMx
ZDljNjM4NGQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTI5ICBOaWNv
IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcG90ZW50aWFsIG92
ZXJmbG93IGluIGpwZWcgZXhpZiByZWFkZXIuIEZvdW5kIGJ5IGFlZGxhQGdvb2dsZS5jb20uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzMjAKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgbW9y
ZSB0aGFuIDEgZWxlbWVudCBwYXN0IGFuIGFycmF5IGlzIHVuZGVmaW5lZCwgc28gZG9uJ3QgZG8g
aXQuCisKKyAgICAgICAgTm8gdGVzdCwgc2luY2UgaW4gcHJhY3RpY2UgaWZkIHdpbGwganVzdCBv
dmVyZmxvdyBhbmQgYGVuZCAtIGlmZGAgd2lsbAorICAgICAgICBiZWNvbWUgbXVjaCBsYXJnZXQg
dGhhbiAyIGFuZCB0aGUgYGlmIChlbmQgLSBpZmQgPCAyKWAgYSBmZXcgbGluZXMKKyAgICAgICAg
ZG93biB3aWxsIGNhdGNoIHRoYXQgY2FzZS4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRl
Y29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZWFk
SW1hZ2VPcmllbnRhdGlvbik6CisKIDIwMTItMTAtMjkgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h
bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYmluZCByZWRvIHRvIEN0
cmwrWSBvbiBub24tbWFjIHBsYXRmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHAK
aW5kZXggYWZiNDQ3NWUyY2RlNmYyMTkxNzUxNTBmMzg2M2Y1MmJmZmY4NDk2YS4uZThjYmM4OWQx
ZTZkMjg2MDYwYzM2ZDBiNzE1OTY0MDI5ZmRiYzdjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURl
Y29kZXIuY3BwCkBAIC0xODgsNiArMTg4LDggQEAgc3RhdGljIEltYWdlT3JpZW50YXRpb24gcmVh
ZEltYWdlT3JpZW50YXRpb24oanBlZ19kZWNvbXByZXNzX3N0cnVjdCogaW5mbykKICAgICAgICAg
aWYgKCFjaGVja0V4aWZIZWFkZXIobWFya2VyLCBpc0JpZ0VuZGlhbiwgaWZkT2Zmc2V0KSkKICAg
ICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBpZmRPZmZzZXQgKz0gNjsgLy8gQWNjb3VudCBm
b3IgJ0V4aWZcMDxmaWxsIGJ5dGU+JyBoZWFkZXIuCisgICAgICAgIGlmIChpZmRPZmZzZXQgPj0g
bWFya2VyLT5kYXRhX2xlbmd0aCkKKyAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIC8v
IFRoZSBqcGVnIGV4aWYgY29udGFpbmVyIGZvcm1hdCBjb250YWlucyBhIHRpZmYgYmxvY2sgZm9y
IG1ldGFkYXRhLgogICAgICAgICAvLyBBIHRpZmYgaW1hZ2UgZmlsZSBkaXJlY3RvcnkgKGlmZCkg
Y29uc2lzdHMgb2YgYSB1aW50MTZfdCBkZXNjcmliaW5nCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171460</attachid>
            <date>2012-10-30 08:34:40 -0700</date>
            <delta_ts>2012-10-30 15:39:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100320-20121030083314.patch</filename>
            <type>text/plain</type>
            <size>1838</size>
            <attacher name="Nico Weber">thakis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJjNTlkNTFkOWY5ZjZh
ZDZmMzMxMGEzYzc1MDE4MTUzMGUxY2M3OC4uZGNjMjM1ZWVmNGZjYzQ3OWJkYmQzY2MxY2ZhMmNh
OGU1M2MyMjlmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTMwICBOaWNv
IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcG90ZW50aWFsIG92
ZXJmbG93IGluIGpwZWcgZXhpZiByZWFkZXIuIEZvdW5kIGJ5IGFlZGxhQGdvb2dsZS5jb20uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzMjAKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgbW9y
ZSB0aGFuIDEgZWxlbWVudCBwYXN0IGFuIGFycmF5IGlzIHVuZGVmaW5lZCwgc28gZG9uJ3QgZG8g
aXQuCisKKyAgICAgICAgTm8gdGVzdCwgc2luY2UgaW4gcHJhY3RpY2UgaWZkIHdpbGwganVzdCBv
dmVyZmxvdyBhbmQgYGVuZCAtIGlmZGAgd2lsbAorICAgICAgICBiZWNvbWUgbXVjaCBsYXJnZXQg
dGhhbiAyIGFuZCB0aGUgYGlmIChlbmQgLSBpZmQgPCAyKWAgYSBmZXcgbGluZXMKKyAgICAgICAg
ZG93biB3aWxsIGNhdGNoIHRoYXQgY2FzZS4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRl
Y29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZWFk
SW1hZ2VPcmllbnRhdGlvbik6CisKIDIwMTItMTAtMjkgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h
bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYmluZCByZWRvIHRvIEN0
cmwrWSBvbiBub24tbWFjIHBsYXRmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHAK
aW5kZXggYWZiNDQ3NWUyY2RlNmYyMTkxNzUxNTBmMzg2M2Y1MmJmZmY4NDk2YS4uMzMwM2NmZTZh
Njc1NzcyNjdjZGIyYmE3ZDVhZWMwMzM3NTdmZmVkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURl
Y29kZXIuY3BwCkBAIC0xODcsNiArMTg3LDggQEAgc3RhdGljIEltYWdlT3JpZW50YXRpb24gcmVh
ZEltYWdlT3JpZW50YXRpb24oanBlZ19kZWNvbXByZXNzX3N0cnVjdCogaW5mbykKICAgICAgICAg
dW5zaWduZWQgaWZkT2Zmc2V0OwogICAgICAgICBpZiAoIWNoZWNrRXhpZkhlYWRlcihtYXJrZXIs
IGlzQmlnRW5kaWFuLCBpZmRPZmZzZXQpKQogICAgICAgICAgICAgY29udGludWU7CisgICAgICAg
IGlmIChtYXJrZXItPmRhdGFfbGVuZ3RoIDwgNiB8fCBpZmRPZmZzZXQgPj0gbWFya2VyLT5kYXRh
X2xlbmd0aCAtIDYpCisgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgaWZkT2Zmc2V0ICs9
IDY7IC8vIEFjY291bnQgZm9yICdFeGlmXDA8ZmlsbCBieXRlPicgaGVhZGVyLgogCiAgICAgICAg
IC8vIFRoZSBqcGVnIGV4aWYgY29udGFpbmVyIGZvcm1hdCBjb250YWlucyBhIHRpZmYgYmxvY2sg
Zm9yIG1ldGFkYXRhLgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171534</attachid>
            <date>2012-10-30 15:39:31 -0700</date>
            <delta_ts>2012-10-30 15:40:03 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-100320-20121030153809.patch</filename>
            <type>text/plain</type>
            <size>2117</size>
            <attacher name="Nico Weber">thakis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZkNmYzZWQwYWUyNWIz
MDQwZTFhMTA2MGU2NWY4MGM2NWE4YzBiZC4uMjQ2NTAyNzI1Y2JjZjRlMWZhM2ZhMDg0MWYzZTUy
MWVkNmI0MTllOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTMwICBOaWNv
IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcG90ZW50aWFsIG92
ZXJmbG93IGluIGpwZWcgZXhpZiByZWFkZXIuIEZvdW5kIGJ5IGFlZGxhQGdvb2dsZS5jb20uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzMjAKKwor
ICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBBZGRpbmcgbW9yZSB0
aGFuIDEgZWxlbWVudCBwYXN0IGFuIGFycmF5IGlzIHVuZGVmaW5lZCwgc28gZG9uJ3QgZG8gaXQu
CisKKyAgICAgICAgTm8gdGVzdCwgc2luY2UgaW4gcHJhY3RpY2UgaWZkIHdpbGwganVzdCBvdmVy
ZmxvdyBhbmQgYGVuZCAtIGlmZGAgd2lsbAorICAgICAgICBiZWNvbWUgbXVjaCBsYXJnZXQgdGhh
biAyIGFuZCB0aGUgYGlmIChlbmQgLSBpZmQgPCAyKWAgYSBmZXcgbGluZXMKKyAgICAgICAgZG93
biB3aWxsIGNhdGNoIHRoYXQgY2FzZS4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29k
ZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZWFkSW1h
Z2VPcmllbnRhdGlvbik6CisKIDIwMTItMTAtMjkgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUu
Y29tPgogCiAgICAgICAgIEZpeCBhIHR5cG8gdGhhdCBjYXVzZWQgU1ZHIGV4dGVybmFsIHJlc291
cmNlcyB0byBiZSBibG9ja2VkIG9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAppbmRl
eCBhZmI0NDc1ZTJjZGU2ZjIxOTE3NTE1MGYzODYzZjUyYmZmZjg0OTZhLi44N2Y1NjM0Mjc1ZWVm
OTcyYzM3YzAxOTY2OTFhMWMwNTJkNTFlYTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rl
ci5jcHAKQEAgLTE4Nyw3ICsxODcsMTAgQEAgc3RhdGljIEltYWdlT3JpZW50YXRpb24gcmVhZElt
YWdlT3JpZW50YXRpb24oanBlZ19kZWNvbXByZXNzX3N0cnVjdCogaW5mbykKICAgICAgICAgdW5z
aWduZWQgaWZkT2Zmc2V0OwogICAgICAgICBpZiAoIWNoZWNrRXhpZkhlYWRlcihtYXJrZXIsIGlz
QmlnRW5kaWFuLCBpZmRPZmZzZXQpKQogICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGlm
ZE9mZnNldCArPSA2OyAvLyBBY2NvdW50IGZvciAnRXhpZlwwPGZpbGwgYnl0ZT4nIGhlYWRlci4K
KyAgICAgICAgY29uc3QgdW5zaWduZWQgb2Zmc2V0VG9UaWZmRGF0YSA9IDY7IC8vIEFjY291bnQg
Zm9yICdFeGlmXDA8ZmlsbCBieXRlPicgaGVhZGVyLgorICAgICAgICBpZiAobWFya2VyLT5kYXRh
X2xlbmd0aCA8IG9mZnNldFRvVGlmZkRhdGEgfHwgaWZkT2Zmc2V0ID49IG1hcmtlci0+ZGF0YV9s
ZW5ndGggLSBvZmZzZXRUb1RpZmZEYXRhKQorICAgICAgICAgICAgY29udGludWU7CisgICAgICAg
IGlmZE9mZnNldCArPSBvZmZzZXRUb1RpZmZEYXRhOyAvLyBBY2NvdW50IGZvciAnRXhpZlwwPGZp
bGwgYnl0ZT4nIGhlYWRlci4KIAogICAgICAgICAvLyBUaGUganBlZyBleGlmIGNvbnRhaW5lciBm
b3JtYXQgY29udGFpbnMgYSB0aWZmIGJsb2NrIGZvciBtZXRhZGF0YS4KICAgICAgICAgLy8gQSB0
aWZmIGltYWdlIGZpbGUgZGlyZWN0b3J5IChpZmQpIGNvbnNpc3RzIG9mIGEgdWludDE2X3QgZGVz
Y3JpYmluZwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171535</attachid>
            <date>2012-10-30 15:40:05 -0700</date>
            <delta_ts>2012-10-30 16:44:07 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-100320-20121030153843.patch</filename>
            <type>text/plain</type>
            <size>2074</size>
            <attacher name="Nico Weber">thakis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZkNmYzZWQwYWUyNWIz
MDQwZTFhMTA2MGU2NWY4MGM2NWE4YzBiZC4uMjQ2NTAyNzI1Y2JjZjRlMWZhM2ZhMDg0MWYzZTUy
MWVkNmI0MTllOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTMwICBOaWNv
IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcG90ZW50aWFsIG92
ZXJmbG93IGluIGpwZWcgZXhpZiByZWFkZXIuIEZvdW5kIGJ5IGFlZGxhQGdvb2dsZS5jb20uCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAzMjAKKwor
ICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBBZGRpbmcgbW9yZSB0
aGFuIDEgZWxlbWVudCBwYXN0IGFuIGFycmF5IGlzIHVuZGVmaW5lZCwgc28gZG9uJ3QgZG8gaXQu
CisKKyAgICAgICAgTm8gdGVzdCwgc2luY2UgaW4gcHJhY3RpY2UgaWZkIHdpbGwganVzdCBvdmVy
ZmxvdyBhbmQgYGVuZCAtIGlmZGAgd2lsbAorICAgICAgICBiZWNvbWUgbXVjaCBsYXJnZXQgdGhh
biAyIGFuZCB0aGUgYGlmIChlbmQgLSBpZmQgPCAyKWAgYSBmZXcgbGluZXMKKyAgICAgICAgZG93
biB3aWxsIGNhdGNoIHRoYXQgY2FzZS4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29k
ZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZWFkSW1h
Z2VPcmllbnRhdGlvbik6CisKIDIwMTItMTAtMjkgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUu
Y29tPgogCiAgICAgICAgIEZpeCBhIHR5cG8gdGhhdCBjYXVzZWQgU1ZHIGV4dGVybmFsIHJlc291
cmNlcyB0byBiZSBibG9ja2VkIG9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAppbmRl
eCBhZmI0NDc1ZTJjZGU2ZjIxOTE3NTE1MGYzODYzZjUyYmZmZjg0OTZhLi5lNDM3NDNmOWExNjc1
ZjJlOGViZDk4OTJlM2MyMjhmYzcxNjYzZDViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rl
ci5jcHAKQEAgLTE4Nyw3ICsxODcsMTAgQEAgc3RhdGljIEltYWdlT3JpZW50YXRpb24gcmVhZElt
YWdlT3JpZW50YXRpb24oanBlZ19kZWNvbXByZXNzX3N0cnVjdCogaW5mbykKICAgICAgICAgdW5z
aWduZWQgaWZkT2Zmc2V0OwogICAgICAgICBpZiAoIWNoZWNrRXhpZkhlYWRlcihtYXJrZXIsIGlz
QmlnRW5kaWFuLCBpZmRPZmZzZXQpKQogICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGlm
ZE9mZnNldCArPSA2OyAvLyBBY2NvdW50IGZvciAnRXhpZlwwPGZpbGwgYnl0ZT4nIGhlYWRlci4K
KyAgICAgICAgY29uc3QgdW5zaWduZWQgb2Zmc2V0VG9UaWZmRGF0YSA9IDY7IC8vIEFjY291bnQg
Zm9yICdFeGlmXDA8ZmlsbCBieXRlPicgaGVhZGVyLgorICAgICAgICBpZiAobWFya2VyLT5kYXRh
X2xlbmd0aCA8IG9mZnNldFRvVGlmZkRhdGEgfHwgaWZkT2Zmc2V0ID49IG1hcmtlci0+ZGF0YV9s
ZW5ndGggLSBvZmZzZXRUb1RpZmZEYXRhKQorICAgICAgICAgICAgY29udGludWU7CisgICAgICAg
IGlmZE9mZnNldCArPSBvZmZzZXRUb1RpZmZEYXRhOwogCiAgICAgICAgIC8vIFRoZSBqcGVnIGV4
aWYgY29udGFpbmVyIGZvcm1hdCBjb250YWlucyBhIHRpZmYgYmxvY2sgZm9yIG1ldGFkYXRhLgog
ICAgICAgICAvLyBBIHRpZmYgaW1hZ2UgZmlsZSBkaXJlY3RvcnkgKGlmZCkgY29uc2lzdHMgb2Yg
YSB1aW50MTZfdCBkZXNjcmliaW5nCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>