100310 2012-10-24 17:09:04 -0700 [WK2] Fix assertion after r132386. 2012-11-19 00:06:31 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 100334 100342 102200 102651 1 bw80.lee bw80.lee andersca gyuyoung.kim kangil.han kenneth kling laszlo.gombos lucas.de.marchi ostap73 oldest_to_newest 750225 0 bw80.lee 2012-10-24 17:09:04 -0700 Unit test is failed with below assersion after r132386 ASSERTION FAILED: !decoder.destinationID() /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/Platform/CoreIPC/MessageReceiverMap.cpp(79) : bool CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 750267 1 170529 bw80.lee 2012-10-24 18:11:45 -0700 Created attachment 170529 Patch 750305 2 170529 ostap73 2012-10-24 19:14:39 -0700 Comment on attachment 170529 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170529&action=review > Source/WebKit2/Platform/CoreIPC/MessageReceiverMap.cpp:81 > + // ASSERT(!decoder.destinationID()); Can you do additional condition to assert for the messages that should have destinationID? 750307 3 ap 2012-10-24 19:23:17 -0700 If the assertion is incorrect, it should be removed, not commented out. I'm not sure if I understand how you determined that it was incorrect though. 750334 4 bw80.lee 2012-10-24 20:47:54 -0700 Thanks for your review, Viatcheslav and Alexey. In the r132386, new addMessageReceiver() function (that has destinationID as it's parameter) is added to set messageReceiver to m_messageReceivers. (not m_globalMessageReceivers) I think the purpose of this patch is that, if messageReceiver need destinationID, not to use the messageReceiver globally. So, If there can be two destinationID for DownloadProxy::DidStart, messageReceiver of DownloadProxy should be set for each destinationID. I thought that this patch is on progress, because some related source doesn't handled. (e.g. messageReceiver for DownloadProxy is set to global message receiver in the WebContext, but DownloadProxy ipc messages uses downloadID for the destinationID. Is it better to fix each issues on setting messageReceivers of DownloadProxy and VibrationProvider instead of patching temporarily? 750366 5 bw80.lee 2012-10-24 22:19:10 -0700 Andersca told to check this issue. (in irc channel) 750372 6 kangil.han 2012-10-24 22:37:47 -0700 Do we need work-around patch to keep EFL bot green for API test at a moment? 750408 7 bw80.lee 2012-10-24 23:19:43 -0700 (In reply to comment #6) > Do we need work-around patch to keep EFL bot green for API test at a moment? Now, I'm not sure that work-around patch is the right way, because this patch is already work-around :) I made a patch to fix the assertions from the messageReceiver of WebVibrationProxy : Bug 100334 750479 8 bw80.lee 2012-10-25 00:28:30 -0700 (In reply to comment #7) > (In reply to comment #6) > > Do we need work-around patch to keep EFL bot green for API test at a moment? > > Now, I'm not sure that work-around patch is the right way, because this patch is already work-around :) > > I made a patch to fix the assertions from the messageReceiver of WebVibrationProxy : Bug 100334 I made a patch about the assertion from the message receiver of DownloadProxy : Bug 100342 751382 9 ostap73 2012-10-25 17:52:56 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Do we need work-around patch to keep EFL bot green for API test at a moment? > > > > Now, I'm not sure that work-around patch is the right way, because this patch is already work-around :) > > > > I made a patch to fix the assertions from the messageReceiver of WebVibrationProxy : Bug 100334 > > I made a patch about the assertion from the message receiver of DownloadProxy : Bug 100342 So, as I understand, this bug will be fixed by pending commit in bug 100342 and can be closed? 752752 10 bw80.lee 2012-10-27 05:19:18 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #6) > > > > Do we need work-around patch to keep EFL bot green for API test at a moment? > > > > > > Now, I'm not sure that work-around patch is the right way, because this patch is already work-around :) > > > > > > I made a patch to fix the assertions from the messageReceiver of WebVibrationProxy : Bug 100334 > > > > I made a patch about the assertion from the message receiver of DownloadProxy : Bug 100342 > > So, as I understand, this bug will be fixed by pending commit in bug 100342 and can be closed? Yes, but Bug 100334(or Bug 100473) also need to be fixed to close this issue. 170529 2012-10-24 18:11:45 -0700 2012-10-25 00:30:09 -0700 Patch bug-100310-20121025101019.patch text/plain 2992 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmQ5YjMyOGIxMDAzZjJm OTBjMTdhYjc5MjkxNGNmYjI3YjVkMGJhMy4uMTgxYmE0YTViNDMyMzEyNDQ0NDhjMzVjMDhhMDJh YjEzYjkyNjk0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTI0ICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBGaXggYXNz ZXJ0aW9uIGFmdGVyIHIxMzIzODYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDAzMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDb21tZW50IG91dCB0aGUgYXNzZXJ0aW9uIGxpbmUgZm9yIGNoZWNraW5n IGRlc3RpbmF0aW9uIGlkIG9mIG1lc3NhZ2UgZGVjb2Rlci4KKworICAgICAgICBUaGVyZSBhciBz b21lIGdsb2JhbCBtZXNzYWdlIHJlY2VpdmVycyB0aGF0IGhhdmUgaXBjIG1lc3NhZ2VzIHVzaW5n IGRlc3RpbmF0aW9uIGlkLgorICAgICAgICBlZy4gV2ViVmlicmF0aW9uUHJveHk6OlZpYnJhdGUg YW5kIERvd25sb2FkUHJveHk6OkRpZFN0YXJ0LgorICAgICAgICBUaGlzIG1ha2VzIGFzc2VydGlv bnMgb24gRUZMIEFQSSB0ZXN0LgorICAgICAgICBodHRwOi8vYnVpbGQud2Via2l0Lm9yZy9idWls ZGVycy9FRkwlMjBMaW51eCUyMDY0LWJpdCUyMERlYnVnL2J1aWxkcy83NjYyL3N0ZXBzL0FQSSUy MHRlc3RzL2xvZ3Mvc3RkaW8KKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvTWVzc2FnZVJl Y2VpdmVyTWFwLmNwcDoKKyAgICAgICAgKENvcmVJUEM6Ok1lc3NhZ2VSZWNlaXZlck1hcDo6ZGlz cGF0Y2hNZXNzYWdlKToKKyAgICAgICAgKENvcmVJUEM6Ok1lc3NhZ2VSZWNlaXZlck1hcDo6ZGlz cGF0Y2hTeW5jTWVzc2FnZSk6CisKIDIwMTItMTAtMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJp c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIEdldCByaWQgb2Yg RXdrX1ZpZXcgcHJpdmF0ZSBDIEFQSSAoUGFydCAxKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vQ29yZUlQQy9NZXNzYWdlUmVjZWl2ZXJNYXAuY3BwIGIvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vQ29yZUlQQy9NZXNzYWdlUmVjZWl2ZXJNYXAuY3BwCmluZGV4IDA2ZGZiYzc0 ZTJiMThlMDA4ZGMzZTM1YzMwZmE5MTExNDY4YmM0ZTEuLmNlZWJmOTAzOWM2MDA0ZDVhNGIzNjNl Y2M3N2I4MTQyMmJmNmU2ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0Nv cmVJUEMvTWVzc2FnZVJlY2VpdmVyTWFwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9Db3JlSVBDL01lc3NhZ2VSZWNlaXZlck1hcC5jcHAKQEAgLTc2LDcgKzc2LDkgQEAgdm9pZCBN ZXNzYWdlUmVjZWl2ZXJNYXA6OmludmFsaWRhdGUoKQogYm9vbCBNZXNzYWdlUmVjZWl2ZXJNYXA6 OmRpc3BhdGNoTWVzc2FnZShDb25uZWN0aW9uKiBjb25uZWN0aW9uLCBNZXNzYWdlSUQgbWVzc2Fn ZUlELCBNZXNzYWdlRGVjb2RlciYgZGVjb2RlcikKIHsKICAgICBpZiAoTWVzc2FnZVJlY2VpdmVy KiBtZXNzYWdlUmVjZWl2ZXIgPSBtX2dsb2JhbE1lc3NhZ2VSZWNlaXZlcnMuZ2V0KGRlY29kZXIu bWVzc2FnZVJlY2VpdmVyTmFtZSgpKSkgewotICAgICAgICBBU1NFUlQoIWRlY29kZXIuZGVzdGlu YXRpb25JRCgpKTsKKyAgICAgICAgLy8gRklYTUU6IENvbW1lbnRlZCBvdXQgd2l0aCBidWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDMxMAorICAgICAgICAvLyAgICAgICAgVGhlcmUg aXMgc29tZSBnbG9iYWwgbWVzc2FnZSByZWNlaXZlciB0aGF0IHVzZXMgZGVzdGluYXRpb24gaWQu IGVnLiBXZWJWaWJyYXRpb25Qcm94eTo6VmlicmF0ZSBhbmQgRG93bmxvYWRQcm94eTo6RGlkU3Rh cnQKKyAgICAgICAgLy8gQVNTRVJUKCFkZWNvZGVyLmRlc3RpbmF0aW9uSUQoKSk7CiAKICAgICAg ICAgbWVzc2FnZVJlY2VpdmVyLT5kaWRSZWNlaXZlTWVzc2FnZShjb25uZWN0aW9uLCBtZXNzYWdl SUQsIGRlY29kZXIpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTkzLDcgKzk1LDkgQEAgYm9v bCBNZXNzYWdlUmVjZWl2ZXJNYXA6OmRpc3BhdGNoTWVzc2FnZShDb25uZWN0aW9uKiBjb25uZWN0 aW9uLCBNZXNzYWdlSUQgbWVzc2EKIGJvb2wgTWVzc2FnZVJlY2VpdmVyTWFwOjpkaXNwYXRjaFN5 bmNNZXNzYWdlKENvbm5lY3Rpb24qIGNvbm5lY3Rpb24sIE1lc3NhZ2VJRCBtZXNzYWdlSUQsIE1l c3NhZ2VEZWNvZGVyJiBkZWNvZGVyLCBPd25QdHI8TWVzc2FnZUVuY29kZXI+JiByZXBseUVuY29k ZXIpCiB7CiAgICAgaWYgKE1lc3NhZ2VSZWNlaXZlciogbWVzc2FnZVJlY2VpdmVyID0gbV9nbG9i YWxNZXNzYWdlUmVjZWl2ZXJzLmdldChkZWNvZGVyLm1lc3NhZ2VSZWNlaXZlck5hbWUoKSkpIHsK LSAgICAgICAgQVNTRVJUKCFkZWNvZGVyLmRlc3RpbmF0aW9uSUQoKSk7CisgICAgICAgIC8vIEZJ WE1FOiBDb21tZW50ZWQgb3V0IHdpdGggYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDAzMTAKKyAgICAgICAgLy8gICAgICAgIFRoZXJlIGlzIHNvbWUgZ2xvYmFsIG1lc3NhZ2UgcmVj ZWl2ZXIgdGhhdCB1c2VzIGRlc3RpbmF0aW9uIGlkLiBlZy4gV2ViVmlicmF0aW9uUHJveHk6OlZp YnJhdGUgYW5kIERvd25sb2FkUHJveHk6OkRpZFN0YXJ0CisgICAgICAgIC8vIEFTU0VSVCghZGVj b2Rlci5kZXN0aW5hdGlvbklEKCkpOwogCiAgICAgICAgIG1lc3NhZ2VSZWNlaXZlci0+ZGlkUmVj ZWl2ZVN5bmNNZXNzYWdlKGNvbm5lY3Rpb24sIG1lc3NhZ2VJRCwgZGVjb2RlciwgcmVwbHlFbmNv ZGVyKTsKICAgICAgICAgcmV0dXJuIHRydWU7Cg==