100197 2012-10-23 21:54:04 -0700 [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings 2012-10-24 00:34:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100191 1 noel.gordon noel.gordon abarth dglazkov fishd jamesr thakis tkent tkent+wkapi webkit.review.bot oldest_to_newest 749335 0 noel.gordon 2012-10-23 21:54:04 -0700 The DRT setting WebkitShouldRespectImageOrientation is used in two tests: fast/images/exif-orientation-css.html and fast/images/exif-orientation.html. Plumb the DRT WebkitShouldRespectImageOrientation enable through to the WebCore page setting setShouldRespectImageOrientation(true|false). 749371 1 170320 noel.gordon 2012-10-23 22:59:27 -0700 Created attachment 170320 Patch 749374 2 webkit.review.bot 2012-10-23 23:02:56 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 749375 3 170320 tkent 2012-10-23 23:05:46 -0700 Comment on attachment 170320 Patch ok 749431 4 170320 webkit.review.bot 2012-10-24 00:34:00 -0700 Comment on attachment 170320 Patch Clearing flags on attachment: 170320 Committed r132320: <http://trac.webkit.org/changeset/132320> 749432 5 webkit.review.bot 2012-10-24 00:34:04 -0700 All reviewed patches have been landed. Closing bug. 170320 2012-10-23 22:59:27 -0700 2012-10-24 00:34:00 -0700 Patch bug-100197-20121024165802.patch text/plain 6984 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGIxZjY3Zjc2YmM4MGU3OWE0M2ZmMTZiOTZmODAxNTM3NDQ4MTQwNzcuLjAxYzU1NmU2MmQ0OWQz MGM2YTkzODM0OWFhNDQ0ZjEyMDAxMmYxMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTAtMjMgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21h aWwuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gUGx1bWIgRFJUIFdlYmtpdFNob3VsZFJlc3Bl Y3RJbWFnZU9yaWVudGF0aW9uIHRocm91Z2ggdG8gcGFnZSBzZXR0aW5ncworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMTk3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViU2V0dGluZ3Mu aDoKKyAgICAgICAgKiBzcmMvV2ViU2V0dGluZ3NJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViU2V0dGluZ3NJbXBsOjpzZXRTaG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbik6IHNldCB0 aGUgV2ViQ29yZSBwYWdlCisgICAgICAgIHNldHRpbmcgZm9yIHNob3VsZFJlc3BlY3RJbWFnZU9y aWVudGF0aW9uLgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2ViU2V0dGluZ3NJ bXBsLmg6CisgICAgICAgIChXZWJTZXR0aW5nc0ltcGwpOgorCiAyMDEyLTEwLTIzICBWYXJ1biBK YWluICA8dmFydW5qYWluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDb250ZXh0IG1lbnUgZ2Vu ZXJhdGVkIGZyb20gdG91Y2ggZ2VzdHVyZXMgb24gdGV4dGFyZWFzIGhhcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgKaW5kZXggZDVkOTYzZjkxZTFhNzFlNzFh ODA2NDRhNGM4MzZiNTVmODI3ZWExYy4uZmYwNDMyOGQ3NjlkNjdjMmVlNWQyYjc1ZTZlN2I5ZmUy YTkyNmRlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0 dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5o CkBAIC0xNDEsNiArMTQxLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRTYW5zU2Vy aWZGb250RmFtaWx5KGNvbnN0IFdlYlN0cmluZyYsIFVTY3JpcHRDb2RlID0gVVNDUklQVF9DT01N T04pID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2VyaWZGb250RmFtaWx5KGNvbnN0IFdlYlN0 cmluZyYsIFVTY3JpcHRDb2RlID0gVVNDUklQVF9DT01NT04pID0gMDsKICAgICB2aXJ0dWFsIHZv aWQgc2V0U2hvdWxkUHJpbnRCYWNrZ3JvdW5kcyhib29sKSA9IDA7CisgICAgdmlydHVhbCB2b2lk IHNldFNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uKGJvb2wpID0gMDsKICAgICB2aXJ0dWFs IHZvaWQgc2V0U2hvd0RlYnVnQm9yZGVycyhib29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNl dFNob3dGUFNDb3VudGVyKGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvd1BhaW50 UmVjdHMoYm9vbCkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViU2V0dGluZ3NJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRp bmdzSW1wbC5jcHAKaW5kZXggYTY2N2JlZGY1NTY1NGRhOWE4ZWNlYzRiNmIxYzNmOGE1YWU2MWRj OS4uZWM4YTViNjZkZWRkYmRlYzMxZmQzNjFlYWQ3NjJiYjVmNzQwMzgxNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwCkBAIC02MzYsNiArNjM2 LDExIEBAIHZvaWQgV2ViU2V0dGluZ3NJbXBsOjpzZXRTaG91bGREaXNwbGF5VGV4dERlc2NyaXB0 aW9ucyhib29sIGVuYWJsZWQpCiAjZW5kaWYKIH0KIAordm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNl dFNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uKGJvb2wgZW5hYmxlZCkKK3sKKyAgICBtX3Nl dHRpbmdzLT5zZXRTaG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbihlbmFibGVkKTsKK30KKwog dm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldEFjY2VsZXJhdGVkUGFpbnRpbmdFbmFibGVkKGJvb2wg ZW5hYmxlZCkKIHsKICAgICBtX3NldHRpbmdzLT5zZXRBY2NlbGVyYXRlZERyYXdpbmdFbmFibGVk KGVuYWJsZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0 dGluZ3NJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwu aAppbmRleCA3NDk2OGM0ZjZkNDBiNzQ2OTNkMTMyNWI1NGNjMTdiOWRmMjYwNDY5Li5kNGFjNDc4 MDkzNGNiYTdlYTU0OTc5NGExZjAyM2FlNjQ4NTI0YWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaApAQCAtMTM2LDYgKzEzNiw3IEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvdWxkRGlzcGxheVN1YnRpdGxlcyhib29sKTsKICAgICB2 aXJ0dWFsIHZvaWQgc2V0U2hvdWxkRGlzcGxheVRleHREZXNjcmlwdGlvbnMoYm9vbCk7CiAgICAg dmlydHVhbCB2b2lkIHNldFNob3VsZFByaW50QmFja2dyb3VuZHMoYm9vbCk7CisgICAgdmlydHVh bCB2b2lkIHNldFNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uKGJvb2wpOwogICAgIHZpcnR1 YWwgdm9pZCBzZXRTaG93RGVidWdCb3JkZXJzKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRT aG93RlBTQ291bnRlcihib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvd1BhaW50UmVjdHMo Ym9vbCk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggNTRlNWNhM2FjM2FlOWVmMDkyZjkzMzJiMDVhN2RiYTM1MjU3NzljNS4uYWZkOTE3MzkzYTQ2 NDc1MDAxMzMxMjNlNWI3MGY0MTQ2MjQyNjE2ZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEwLTIzICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIFBs dW1iIERSVCBXZWJraXRTaG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbiB0aHJvdWdoIHRvIHBh Z2Ugc2V0dGluZ3MgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDAxOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBmYXN0L2ltYWdlcy9leGlmLW9yaWVudGF0aW9uLmh0bWwgYW5kIGZhc3QvaW1hZ2VzL2V4 aWYtb3JpZW50YXRpb24tY3NzLmh0bWwgcmVxdWlyZSBhIERSVAorICAgICAgICBXZWJraXRTaG91 bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbiBwcmVmZXJlbmNlLiAgQWRkIHRoZSBjaHJvbWl1bSBp bXBsZW1lbnRhdGlvbiBmb3IgdGhpcworICAgICAgICBwcmVmZXJlbmNlIGFuZCBwbHVtYiBpdCB0 aHJvdWdoIHRvIHBhZ2Ugc2V0dGluZ3MuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9EUlRUZXN0UnVubmVyLmNwcDoKKyAgICAgICAgKERSVFRlc3RSdW5uZXI6Om92ZXJyaWRl UHJlZmVyZW5jZSk6IFVwZGF0ZSB0aGUgdGVzdHMgV2Via2l0U2hvdWxkUmVzcGVjdEltYWdlT3Jp ZW50YXRpb24KKyAgICAgICAgc2V0dGluZyBpbiBEUlQgcHJlZnMuCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViUHJlZmVyZW5jZXMuY3BwOgorICAgICAgICAoV2ViUHJlZmVy ZW5jZXM6OnJlc2V0KTogRGlzYWJsZSB0aGUgcHJlZmVyZW5jZSBiZWZvcmUgYW5kIGFmdGVyIGVh Y2ggdGVzdC4KKyAgICAgICAgKFdlYlByZWZlcmVuY2VzOjphcHBseVRvKTogQXBwbHkgdGhlIHBy ZWZlcmVuY2UgdG8gdGhlIHBhZ2Ugc2V0dGluZ3Mgb2YgZWFjaCB0ZXN0LgorICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlByZWZlcmVuY2VzLmg6CisgICAgICAgIChXZWJQcmVm ZXJlbmNlcyk6CisKIDIwMTItMTAtMjMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgQWxsb3cgdGVzdHMgdG8gcnVuIHdpdGggYSB0aWxlIGNhY2hlLCBh bmQgb3B0aW9uYWxseSBkdW1wIHRoZSB0aWxlIGNhY2hlIHZpYSBsYXllclRyZWVBc1RleHQoKQpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRFJUVGVzdFJ1bm5lci5j cHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EUlRUZXN0UnVubmVyLmNwcAppbmRl eCBiMzFkN2RhNzBmZjU4YmU0MTY0YThkYjBmYjI0OWQxYmEyMGZlOTIwLi5mN2NkODAwZWE5ZjA1 ZDJiNTAwOTRkNmE3MzEzNWY5M2VhOTIxM2QxIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9EUlRUZXN0UnVubmVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9EUlRUZXN0UnVubmVyLmNwcApAQCAtMTYwNCw2ICsxNjA0LDggQEAgdm9pZCBE UlRUZXN0UnVubmVyOjpvdmVycmlkZVByZWZlcmVuY2UoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBh cmd1bWVudHMsIENwcFZhcmkKICAgICAgICAgcHJlZnMtPmFsbG93UnVubmluZ09mSW5zZWN1cmVD b250ZW50ID0gY3BwVmFyaWFudFRvQm9vbCh2YWx1ZSk7CiAgICAgZWxzZSBpZiAoa2V5ID09ICJX ZWJLaXRDU1NDdXN0b21GaWx0ZXJFbmFibGVkIikKICAgICAgICAgcHJlZnMtPmNzc0N1c3RvbUZp bHRlckVuYWJsZWQgPSBjcHBWYXJpYW50VG9Cb29sKHZhbHVlKTsKKyAgICBlbHNlIGlmIChrZXkg PT0gIldlYktpdFNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uIikKKyAgICAgICAgcHJlZnMt PnNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uID0gY3BwVmFyaWFudFRvQm9vbCh2YWx1ZSk7 CiAgICAgZWxzZSBpZiAoa2V5ID09ICJXZWJLaXRXZWJBdWRpb0VuYWJsZWQiKSB7CiAgICAgICAg IEFTU0VSVChjcHBWYXJpYW50VG9Cb29sKHZhbHVlKSk7CiAgICAgfSBlbHNlIHsKZGlmZiAtLWdp dCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlByZWZlcmVuY2VzLmNwcCBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlByZWZlcmVuY2VzLmNwcAppbmRleCA1Yzhj OTJjOTk5NDI2NDRkZDE5YTQ5Yzk4ZTY2YzFhNGYwNmQ0NDRkLi44ODI0MWRjY2ZkYzJkZmRkNDUz MWVhODY0ODYzNGY2ZmQ1ZDQwN2Q5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJQcmVmZXJlbmNlcy5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vV2ViUHJlZmVyZW5jZXMuY3BwCkBAIC0xMjAsNiArMTIwLDcgQEAgdm9pZCBXZWJQcmVm ZXJlbmNlczo6cmVzZXQoKQogICAgIG1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlID0g ZmFsc2U7CiAgICAgbW9ja1Njcm9sbGJhcnNFbmFibGVkID0gZmFsc2U7CiAgICAgY3NzQ3VzdG9t RmlsdGVyRW5hYmxlZCA9IGZhbHNlOworICAgIHNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9u ID0gZmFsc2U7CiB9CiAKIHN0YXRpYyB2b2lkIHNldFN0YW5kYXJkRm9udEZhbWlseVdyYXBwZXIo V2ViU2V0dGluZ3MqIHNldHRpbmdzLCBjb25zdCBXZWJLaXQ6OldlYlN0cmluZyYgZm9udCwgVVNj cmlwdENvZGUgc2NyaXB0KQpAQCAtMjI5LDYgKzIzMCw3IEBAIHZvaWQgV2ViUHJlZmVyZW5jZXM6 OmFwcGx5VG8oV2ViVmlldyogd2ViVmlldykKICAgICBzZXR0aW5ncy0+c2V0TWVkaWFQbGF5YmFj a1JlcXVpcmVzVXNlckdlc3R1cmUobWVkaWFQbGF5YmFja1JlcXVpcmVzVXNlckdlc3R1cmUpOwog ICAgIHNldHRpbmdzLT5zZXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWQobW9ja1Njcm9sbGJhcnNFbmFi bGVkKTsKICAgICBzZXR0aW5ncy0+c2V0QXBwbHlEZWZhdWx0RGV2aWNlU2NhbGVGYWN0b3JJbkNv bXBvc2l0b3IoZm9yY2VDb21wb3NpdGluZ01vZGUpOworICAgIHNldHRpbmdzLT5zZXRTaG91bGRS ZXNwZWN0SW1hZ2VPcmllbnRhdGlvbihzaG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbik7CiAK ICAgICAvLyBGaXhlZCB2YWx1ZXMuCiAgICAgc2V0dGluZ3MtPnNldFRleHREaXJlY3Rpb25TdWJt ZW51SW5jbHVzaW9uQmVoYXZpb3JOZXZlckluY2x1ZGVkKCk7CmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJQcmVmZXJlbmNlcy5oIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vV2ViUHJlZmVyZW5jZXMuaAppbmRleCBlMDMxNWYyZDA3YzFlNWI5ODU1 ZmU3YjNhYTJlMTRjZjdlMWU0MGJmLi44MWZlNjIyYzM2ZDE1OTg5ZjI2MjJhZWFjMGNmM2Q0YTY2 MTBjZDg2IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJQcmVm ZXJlbmNlcy5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlByZWZlcmVu Y2VzLmgKQEAgLTExMyw2ICsxMTMsNyBAQCBzdHJ1Y3QgV2ViUHJlZmVyZW5jZXMgewogICAgIGJv b2wgbWVkaWFQbGF5YmFja1JlcXVpcmVzVXNlckdlc3R1cmU7CiAgICAgYm9vbCBtb2NrU2Nyb2xs YmFyc0VuYWJsZWQ7CiAgICAgYm9vbCBjc3NDdXN0b21GaWx0ZXJFbmFibGVkOworICAgIGJvb2wg c2hvdWxkUmVzcGVjdEltYWdlT3JpZW50YXRpb247CiAKICAgICBXZWJQcmVmZXJlbmNlcygpIHsg cmVzZXQoKTsgfQogICAgIHZvaWQgcmVzZXQoKTsK