<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100191</bug_id>
          
          <creation_ts>2012-10-23 21:24:17 -0700</creation_ts>
          <short_desc>[chromium] [meta] Add auto-detection of image orientation from EXIF information</short_desc>
          <delta_ts>2012-11-26 20:11:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Images</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>19688</dependson>
    
    <dependson>100076</dependson>
    
    <dependson>100144</dependson>
    
    <dependson>100164</dependson>
    
    <dependson>100179</dependson>
    
    <dependson>100197</dependson>
    
    <dependson>100200</dependson>
    
    <dependson>100319</dependson>
    
    <dependson>100320</dependson>
    
    <dependson>100401</dependson>
    
    <dependson>100414</dependson>
    
    <dependson>100434</dependson>
    
    <dependson>100456</dependson>
    
    <dependson>100698</dependson>
    
    <dependson>100767</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="noel gordon">noel.gordon</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>davidbarr</cc>
    
    <cc>eric</cc>
    
    <cc>mikelawther</cc>
    
    <cc>thakis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>749309</commentid>
    <comment_count>0</comment_count>
    <who name="noel gordon">noel.gordon</who>
    <bug_when>2012-10-23 21:24:17 -0700</bug_when>
    <thetext>http://recursive-design.com/blog/2012/07/28/exif-orientation-handling-is-a-ghetto and I concur.

CG added EXIF support in bug 19688 for imageDocuments and for page &lt;img&gt; via the page WebKitShouldRespectImageOrientation setting.

We should add this EXIF support to the chromium port for imageDocument only, with the page setting to permit testing (leave the setting off-by-default) since auto-orientation of page &lt;img&gt; tags should be opt-in (author controlled) ...

[css3-images] Honoring EXIF orientation from images
  http://lists.w3.org/Archives/Public/www-style/2011Dec/0001.html
[css3-images] Processing model for transformations (image() vs. image-orientation)
  http://lists.w3.org/Archives/Public/www-style/2011Dec/0002.html
http://dev.w3.org/csswg/css4-images/#image-orientation
  img { image-orientation: from-image }

So in this bug, be aware of the CSS image-orientation work bug 89052 and how the platform code needs updating to examine an image renderer-&gt;style()-&gt;imageOrientation() at draw time, see bug 91566 and bug 92330, let&apos;s not break them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>749333</commentid>
    <comment_count>1</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-23 21:49:06 -0700</bug_when>
    <thetext>The image-only exif rotation bits are done in bug 100164 and bug 100179 (and http://trac.webkit.org/changeset/132260). From what I can tell, this should not collide with the bugs linked above.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>749364</commentid>
    <comment_count>2</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-23 22:43:51 -0700</bug_when>
    <thetext>Bug 100200 will clash with one of davidbarr&apos;s changes, but in a minor way (the code it adds will need to grow 2 additional lines to deal with the passed-in orientation he&apos;s adding.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>752162</commentid>
    <comment_count>3</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-10-26 10:25:30 -0700</bug_when>
    <thetext>This is mostly done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>758486</commentid>
    <comment_count>4</comment_count>
    <who name="noel gordon">noel.gordon</who>
    <bug_when>2012-11-05 06:31:36 -0800</bug_when>
    <thetext>http://crbug.com/56845 marked fixed, all done for Chrome M24.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>