100181 2012-10-23 19:24:40 -0700 Address review comments from bug 100144 2013-05-02 20:25:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 thakis thakis oldest_to_newest 749243 0 thakis 2012-10-23 19:24:40 -0700 Address review comments from bug 100144 749244 1 170294 thakis 2012-10-23 19:25:30 -0700 Created attachment 170294 Patch 749245 2 170294 thakis 2012-10-23 19:25:49 -0700 Comment on attachment 170294 Patch Clearing r?, this will accumulate more changes. 750167 3 170502 thakis 2012-10-24 16:13:05 -0700 Created attachment 170502 Patch 884052 4 thakis 2013-05-02 20:25:46 -0700 Seems like we didn't want this after all. 170294 2012-10-23 19:25:30 -0700 2012-10-24 16:13:04 -0700 Patch bug-100181-20121023192407.patch text/plain 1428 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQwNzNlMzVmMDU2MTc1 MzIyYjNiNGEyODUwNjQ0M2ZhOTQ3NzJjMS4uYWUwODQwMDZjMTk5ZWI3OTgyOTdiNDRiMGU4NDI4 MmNkN2E4ZThmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEyLTEwLTIzICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KIAorICAgICAgICBBZGRyZXNzIHJldmlldyBj b21tZW50cyBmcm9tIGJ1ZyAxMDAxNDQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMDE4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VE ZWNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpQRUdJbWFnZVJlYWRlcjo6SlBFR0ltYWdl UmVhZGVyKToKKworMjAxMi0xMC0yMyAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+ CisKICAgICAgICAgSW4gdGhlIG9wZW4tc291cmNlIGpwZWcgZGVjb2RlciwgcmVhZCBpbWFnZSBv cmllbnRhdGlvbiBmcm9tIHRoZSBleGlmIGRhdGEKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDE0NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVy LmNwcAppbmRleCAxNDEzMzdjZjAxODAzYjYxMjNmNTk1NzJmOWFkMzc4MDI0ODUxMjI3Li44YjIz NzNmMGYxODA4MzZkY2MyNTA0MGUyYjVmNWY4MzBmM2Y5MjNhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0lt YWdlRGVjb2Rlci5jcHAKQEAgLTI5MSw3ICsyOTEsNyBAQCBwdWJsaWM6CiAgICAgICAgIHNldHVw X3JlYWRfaWNjX3Byb2ZpbGUoJm1faW5mbyk7CiAjZW5kaWYKIAotICAgICAgICAvLyBLZWVwIEFQ UDEgYmxvY2tzLCBmb3Igb2J0YWluaW5nIGV4aWYgZGF0YS4KKyAgICAgICAgLy8gUmV0YWluIEVY SUYgbWV0YWRhdGEgbWFya2VyIEFQUDEgZm9yIG9yaWVudGF0aW9uIGRldGVjdGlvbi4KICAgICAg ICAganBlZ19zYXZlX21hcmtlcnMoJm1faW5mbywgZXhpZk1hcmtlciwgMHhGRkZGKTsKICAgICB9 CiAK 170502 2012-10-24 16:13:05 -0700 2012-10-24 16:13:05 -0700 Patch bug-100181-20121024161142.patch text/plain 2103 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhjZDVlZWQzMzAxMDJi ZDU0NzQ0Mjg2MDBiMzQ4ZmQ5YTY3ODdjMy4uNjdmZTllZmI1NWRlZGNiNjJhNmE2NTA1MDQyNjc3 YjdlYmE3NDJiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTIzICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGRyZXNzIHJldmlldyBj b21tZW50cyBmcm9tIGJ1ZyAxMDAxNDQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMDE4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VE ZWNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpQRUdJbWFnZVJlYWRlcjo6SlBFR0ltYWdl UmVhZGVyKToKKwogMjAxMi0xMC0yNCAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgRml4aW5nIHRoZSBDaHJvbWl1bSBidWlsZCBhZnRlciB0eXBvIGluIHIx MzIzNjcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAppbmRleCAxNDEzMzdjZjAxODAz YjYxMjNmNTk1NzJmOWFkMzc4MDI0ODUxMjI3Li5kMDAxMzY3NWM4ZjEzOWU0YjYwMTRiNjY2YWNk NjA2ZmJiNjYyYWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1k ZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHAKQEAgLTk3LDgg Kzk3LDYgQEAgaW5saW5lIGJvb2wgZG9GYW5jeVVwc2FtcGxpbmcoKSB7IHJldHVybiBmYWxzZTsg fQogaW5saW5lIGJvb2wgZG9GYW5jeVVwc2FtcGxpbmcoKSB7IHJldHVybiB0cnVlOyB9CiAjZW5k aWYKIAotY29uc3QgaW50IGV4aWZNYXJrZXIgPSBKUEVHX0FQUDAgKyAxOwotCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKIHN0cnVjdCBkZWNvZGVyX2Vycm9yX21nciB7CkBAIC0xNTYsNyArMTU0LDcg QEAgc3RhdGljIGJvb2wgY2hlY2tFeGlmSGVhZGVyKGpwZWdfc2F2ZWRfbWFya2VyX3B0ciBtYXJr ZXIsIGJvb2wmIGlzQmlnRW5kaWFuLCB1bnMKICAgICAvLyBmb2xsb3dlZCBieSBhbiB1aW50MzJf dCB3aXRoIHRoZSBvZmZzZXQgdG8gdGhlIHRhZyBibG9jaywgcmVsYXRpdmUgdG8gdGhlCiAgICAg Ly8gdGlmZiBmaWxlIHN0YXJ0LgogICAgIGNvbnN0IHVuc2lnbmVkIGV4aWZIZWFkZXJTaXplID0g MTQ7Ci0gICAgaWYgKCEobWFya2VyLT5tYXJrZXIgPT0gZXhpZk1hcmtlcgorICAgIGlmICghKG1h cmtlci0+bWFya2VyID09IEpQRUdfQVBQMCArIDEKICAgICAgICAgJiYgbWFya2VyLT5kYXRhX2xl bmd0aCA+PSBleGlmSGVhZGVyU2l6ZQogICAgICAgICAmJiBtYXJrZXItPmRhdGFbMF0gPT0gJ0Un CiAgICAgICAgICYmIG1hcmtlci0+ZGF0YVsxXSA9PSAneCcKQEAgLTI5MSw4ICsyODksOCBAQCBw dWJsaWM6CiAgICAgICAgIHNldHVwX3JlYWRfaWNjX3Byb2ZpbGUoJm1faW5mbyk7CiAjZW5kaWYK IAotICAgICAgICAvLyBLZWVwIEFQUDEgYmxvY2tzLCBmb3Igb2J0YWluaW5nIGV4aWYgZGF0YS4K LSAgICAgICAganBlZ19zYXZlX21hcmtlcnMoJm1faW5mbywgZXhpZk1hcmtlciwgMHhGRkZGKTsK KyAgICAgICAgLy8gUmV0YWluIEVYSUYgbWV0YWRhdGEgbWFya2VyIEFQUDEgZm9yIG9yaWVudGF0 aW9uIGRldGVjdGlvbi4KKyAgICAgICAganBlZ19zYXZlX21hcmtlcnMoJm1faW5mbywgSlBFR19B UFAwICsgMSwgMHhGRkZGKTsKICAgICB9CiAKICAgICB+SlBFR0ltYWdlUmVhZGVyKCkK