100111 2012-10-23 05:17:48 -0700 JSC SIGILL, problems with lower bit on ARMv7-thumb 2017-10-18 01:48:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED INVALID P2 Normal --- 108645 0 zhroma webkit-unassigned barraclough fpizlo zan oldest_to_newest 748524 0 zhroma 2012-10-23 05:17:48 -0700 Here I want to discuss problems I have found in JSC with lower bit on ARMv7-Thumb. Both of my test scripts are small cut versions which help to reproduce the problem. I cross-compile JSC from x86-64 in two modes — with gcc "-mthumb -O0" options in debug mode (debug-jsc), and with gcc "-mthumb -O2" options in release mode (release-jsc). Then I run my tests on ARM using command-line jsc program. First of all, since I start testing JSC on ARMv7-Thumb, the test1 example fails debug-jsc: ASSERTION FAILED: reinterpret_cast<intptr_t>(m_value) & 1 Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h(106) : JSC::FunctionPtr::FunctionPtr(returnType (*)(argType1)) [with returnType = int; argType1 = double] This failure doesn't give any problems — the release-jsc version works fine. So, I just commented two asserts which were broken — patch1. This problem exist at least since svn revision 129000, and maybe it was introduced much earlier. The next problem happens exaclty since svn revision 130826 (or 130828, because in revisions 130826-130827 the build was broken). If I build debug-jsc with patch1 the test1 works fine, but the test2 example fails with another assertion: ASSERTION FAILED: !(reinterpret_cast<intptr_t>(target) & 1) ../srcpeakd/Source/JavaScriptCore/assembler/ARMv7Assembler.h(2559) : static void JSC::ARMv7Assembler::linkJumpAbsolute(uint16_t*, void*) Here I tried the same, just commented all "wrong" asserts - patch2. As a result I can run the test, but sometimes (in 50% cases) it fails with "Illegal instruction" or "Segmentation fault". The same failure happens when running release-jsc version. When I run the test 15 times successively, it fails at least 3 times or more. Using the debugger I understand that this happens when baselineJIT-generated code is executed. Code (assembly) is fine, but the program counter gets the wrong position in it. So, the problem is maybe in wrong processor mode (arm vs thumb) controlled by the lower bit. And the last. While investigating the previous problem, I find some code introduced by the patch from https://bugs.webkit.org/show_bug.cgi?id=61161. There is no explaination why JSC needs such a randomization, and maybe additional nop creation should be at least disabled in debug mode? 748525 1 170130 zhroma 2012-10-23 05:18:39 -0700 Created attachment 170130 test1 748526 2 170131 zhroma 2012-10-23 05:19:13 -0700 Created attachment 170131 test2 748527 3 170132 zhroma 2012-10-23 05:19:48 -0700 Created attachment 170132 patch1 748528 4 170133 zhroma 2012-10-23 05:20:16 -0700 Created attachment 170133 patch2 748940 5 ap 2012-10-23 13:45:36 -0700 If you are submitting a patch for inclusion in WebKit, please follow the steps from <http://www.webkit.org/coding/contributing.html>. 768025 6 zhroma 2012-11-15 06:53:50 -0800 >If you are submitting a patch for inclusion in WebKit, please follow the steps from <http://www.webkit.org/coding/contributing.html>. These patches were for explanation, not for contributing. Now the main problem with JSC catching SIGILL on ARMv7 is fixed, since svn revision http://trac.webkit.org/changeset/133357 , but while running JSC-debug-version asserts commented in patch1 still fail on both of introduced tests. Can anybody explain, why we have to randomize JIT assembly code this way https://bugs.webkit.org/show_bug.cgi?id=61161 ? 1361607 7 zan 2017-10-18 01:48:30 -0700 This is too old to be actionable. 170130 2012-10-23 05:18:39 -0700 2012-10-23 05:18:39 -0700 test1 test1.js application/javascript 232 zhroma ZnVuY3Rpb24gZm9vICgpIHsKCXZhciBpOwoJdmFyIHggPSAweEVGQ0QxMjM0OwoJdmFyIGEgPSBu ZXcgQXJyYXkoKTsKCWEucHVzaCgwKTsKCWZvciAoaSA9IDA7IGkgPCBhLmxlbmd0aDsgaSsrKSB7 CgkJeCA9IHggJiAweDA7Cgl9CglyZXR1cm4geDsKfQpmdW5jdGlvbiBtYWluICgpIHsKCXZhciBp OwoJZm9yIChpID0gMDsgaSA8IDcwOyBpKyspCgkJZm9vKCk7CglwcmludCgiT0siKTsKfQptYWlu KCk7Cg== 170131 2012-10-23 05:19:13 -0700 2012-10-23 05:19:13 -0700 test2 test2.js application/javascript 898 zhroma ZnVuY3Rpb24gYmIoZCkgewoJdGhpcy5kID0gZDsKCXRoaXMuc2V0ID0gc2V0OwoJdGhpcy5nZXQg PSBnZXQ7Cgl0aGlzLmYgPSBmOwoJZnVuY3Rpb24gZ2V0KHgsIHkpIHsKCQlpZiAodHlwZW9mKHRo aXMuZFs0Kih4K3kqNjApICsgMF0pID09ICJ1bmRlZmluZWQiCgkJCQl8fCB0eXBlb2YodGhpcy5k WzQqKHgreSo2MCkgKyAxXSkgPT0gInVuZGVmaW5lZCIKCQkJCXx8IHR5cGVvZih0aGlzLmRbNCoo eCt5KjYwKSArIDJdKSA9PSAidW5kZWZpbmVkIgoJCQkJfHwgdHlwZW9mKHRoaXMuZFs0Kih4K3kq NjApICsgM10pID09ICJ1bmRlZmluZWQiKQoJCQlyZXR1cm4gWzAsIDAsIDAsIDBdOwoJfQoJZnVu Y3Rpb24gc2V0KHgsIHksIHApIHsKCQl0aGlzLmRbNCAqICh5ICogNjAgKyB4KSArIDBdID0gcFsw XTsKCQl0aGlzLmRbNCAqICh5ICogNjAgKyB4KSArIDFdID0gcFsxXTsKCQl0aGlzLmRbNCAqICh5 ICogNjAgKyB4KSArIDJdID0gcFsyXTsKCQl0aGlzLmRbNCAqICh5ICogNjAgKyB4KSArIDNdID0g cFszXTsKCX0KCWZ1bmN0aW9uIGYoKSB7CgkJZm9yICh2YXIgeCA9IDA7IHggPCA2MDsgeCsrKSB7 CgkJCWZvciAodmFyIHkgPSAwOyB5IDwgNDM7IHkrKykgewoJCQkJdmFyIHAgPSBbCgkJCQkgICAg dGhpcy5nZXQoeCArIDAsIHkgLSAxKSwKCQkJCSAgICB0aGlzLmdldCh4ICsgMSwgeSAtIDEpLAoJ CQkJICAgIHRoaXMuZ2V0KHggLSAxLCB5ICsgMCksCgkJCQkgICAgdGhpcy5nZXQoeCArIDAsIHkg KyAwKSwKCQkJCSAgICB0aGlzLmdldCh4ICsgMSwgeSArIDApXTsKCQkJCXRoaXMuc2V0KHgsIHks IFswLDAsMCwwXSk7CgkJCX0KCQl9Cgl9Cn0KZnVuY3Rpb24gbWFpbiAoKSB7Cgl2YXIgYiA9IG5l dyBiYihbMF0pOwoJYi5mKCk7CglwcmludCgiT0siKTsKfQptYWluKCk7Cg== 170132 2012-10-23 05:19:48 -0700 2012-10-23 05:19:48 -0700 patch1 patch1 application/octet-stream 1353 zhroma ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJs ZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaApp bmRleCBlOWI5ZmNjLi43N2Y4MmQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCkBAIC0yMDU1LDcgKzIwNTUsNyBAQCBwdWJsaWM6CiAg ICAgewogICAgICAgICBBU1NFUlQoIShyZWludGVycHJldF9jYXN0PGludHB0cl90Pihjb2RlKSAm IDEpKTsKICAgICAgICAgQVNTRVJUKGZyb20uaXNTZXQoKSk7Ci0gICAgICAgIEFTU0VSVChyZWlu dGVycHJldF9jYXN0PGludHB0cl90Pih0bykgJiAxKTsKKyAgICAgICAgLy9BU1NFUlQocmVpbnRl cnByZXRfY2FzdDxpbnRwdHJfdD4odG8pICYgMSk7CiAKICAgICAgICAgc2V0UG9pbnRlcihyZWlu dGVycHJldF9jYXN0PHVpbnQxNl90Kj4ocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oY29kZSkg KyBmcm9tLm1fb2Zmc2V0KSAtIDEsIHRvKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckNvZGVSZWYuaAppbmRleCBjMmFm MjQwLi5jOGU4M2VhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJDb2RlUmVmLmgKQEAgLTQzLDggKzQzLDggQEAKIC8vIGRlY29y YXRlZCBhbmQgdW5kZWN0b3JhdGVkIG51bGwsIGFuZCB0aGUgc2Vjb25kIHRlc3QgZW5zdXJlcyB0 aGF0IHRoZSBwb2ludGVyIGlzCiAvLyBkZWNvcmF0ZWQuCiAjZGVmaW5lIEFTU0VSVF9WQUxJRF9D T0RFX1BPSU5URVIocHRyKSBcCi0gICAgQVNTRVJUKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+ KHB0cikgJiB+MSk7IFwKLSAgICBBU1NFUlQocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4ocHRy KSAmIDEpCisgICAgQVNTRVJUKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHB0cikgJiB+MSk7 CisvLyAgICBBU1NFUlQocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4ocHRyKSAmIDEpCiAjZGVm aW5lIEFTU0VSVF9WQUxJRF9DT0RFX09GRlNFVChvZmZzZXQpIFwKICAgICBBU1NFUlQoIShvZmZz ZXQgJiAxKSkgLy8gTXVzdCBiZSBtdWx0aXBsZSBvZiAyLgogI2Vsc2UK 170133 2012-10-23 05:20:16 -0700 2012-10-23 05:20:16 -0700 patch2 patch2 application/octet-stream 8471 zhroma ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJs ZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaApp bmRleCBlOWI5ZmNjLi4yN2UzYzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCkBAIC0yMDU1LDcgKzIwNTUsNyBAQCBwdWJsaWM6CiAg ICAgewogICAgICAgICBBU1NFUlQoIShyZWludGVycHJldF9jYXN0PGludHB0cl90Pihjb2RlKSAm IDEpKTsKICAgICAgICAgQVNTRVJUKGZyb20uaXNTZXQoKSk7Ci0gICAgICAgIEFTU0VSVChyZWlu dGVycHJldF9jYXN0PGludHB0cl90Pih0bykgJiAxKTsKKyAgICAgICAgLy9BU1NFUlQocmVpbnRl cnByZXRfY2FzdDxpbnRwdHJfdD4odG8pICYgMSk7CiAKICAgICAgICAgc2V0UG9pbnRlcihyZWlu dGVycHJldF9jYXN0PHVpbnQxNl90Kj4ocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oY29kZSkg KyBmcm9tLm1fb2Zmc2V0KSAtIDEsIHRvKTsKICAgICB9CkBAIC0yMzc4LDcgKzIzNzgsNyBAQCBw cml2YXRlOgogICAgIHN0YXRpYyBib29sIGNhbkJlSnVtcFQxKGNvbnN0IHVpbnQxNl90KiBpbnN0 cnVjdGlvbiwgY29uc3Qgdm9pZCogdGFyZ2V0KQogICAgIHsKICAgICAgICAgQVNTRVJUKCEocmVp bnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oaW5zdHJ1Y3Rpb24pICYgMSkpOwotICAgICAgICBBU1NF UlQoIShyZWludGVycHJldF9jYXN0PGludHB0cl90Pih0YXJnZXQpICYgMSkpOworICAgICAgICAv L0FTU0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7CiAgICAg ICAgIAogICAgICAgICBpbnRwdHJfdCByZWxhdGl2ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRy X3Q+KHRhcmdldCkgLSAocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oaW5zdHJ1Y3Rpb24pKTsK ICAgICAgICAgLy8gSXQgZG9lcyBub3QgYXBwZWFyIHRvIGJlIGRvY3VtZW50ZWQgaW4gdGhlIEFS TSBBUk0gKGJpZyBzdXJwcmlzZSksIGJ1dApAQCAtMjM5MSw3ICsyMzkxLDcgQEAgcHJpdmF0ZToK ICAgICBzdGF0aWMgYm9vbCBjYW5CZUp1bXBUMihjb25zdCB1aW50MTZfdCogaW5zdHJ1Y3Rpb24s IGNvbnN0IHZvaWQqIHRhcmdldCkKICAgICB7CiAgICAgICAgIEFTU0VSVCghKHJlaW50ZXJwcmV0 X2Nhc3Q8aW50cHRyX3Q+KGluc3RydWN0aW9uKSAmIDEpKTsKLSAgICAgICAgQVNTRVJUKCEocmVp bnRlcnByZXRfY2FzdDxpbnRwdHJfdD4odGFyZ2V0KSAmIDEpKTsKKyAgICAgICAgLy9BU1NFUlQo IShyZWludGVycHJldF9jYXN0PGludHB0cl90Pih0YXJnZXQpICYgMSkpOwogICAgICAgICAKICAg ICAgICAgaW50cHRyX3QgcmVsYXRpdmUgPSByZWludGVycHJldF9jYXN0PGludHB0cl90Pih0YXJn ZXQpIC0gKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KGluc3RydWN0aW9uKSk7CiAgICAgICAg IC8vIEl0IGRvZXMgbm90IGFwcGVhciB0byBiZSBkb2N1bWVudGVkIGluIHRoZSBBUk0gQVJNIChi aWcgc3VycHJpc2UpLCBidXQKQEAgLTI0MDQsNyArMjQwNCw3IEBAIHByaXZhdGU6CiAgICAgc3Rh dGljIGJvb2wgY2FuQmVKdW1wVDMoY29uc3QgdWludDE2X3QqIGluc3RydWN0aW9uLCBjb25zdCB2 b2lkKiB0YXJnZXQsIGJvb2wmIG1heVRyaWdnZXJFcnJhdGEpCiAgICAgewogICAgICAgICBBU1NF UlQoIShyZWludGVycHJldF9jYXN0PGludHB0cl90PihpbnN0cnVjdGlvbikgJiAxKSk7Ci0gICAg ICAgIEFTU0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7Cisg ICAgICAgIC8vQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4odGFyZ2V0KSAmIDEp KTsKICAgICAgICAgCiAgICAgICAgIGludHB0cl90IHJlbGF0aXZlID0gcmVpbnRlcnByZXRfY2Fz dDxpbnRwdHJfdD4odGFyZ2V0KSAtIChyZWludGVycHJldF9jYXN0PGludHB0cl90PihpbnN0cnVj dGlvbikpOwogICAgICAgICAvLyBGcm9tIENvcnRleC1BOCBlcnJhdGE6CkBAIC0yNDI1LDcgKzI0 MjUsNyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBib29sIGNhbkJlSnVtcFQ0KGNvbnN0IHVpbnQx Nl90KiBpbnN0cnVjdGlvbiwgY29uc3Qgdm9pZCogdGFyZ2V0LCBib29sJiBtYXlUcmlnZ2VyRXJy YXRhKQogICAgIHsKICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4o aW5zdHJ1Y3Rpb24pICYgMSkpOwotICAgICAgICBBU1NFUlQoIShyZWludGVycHJldF9jYXN0PGlu dHB0cl90Pih0YXJnZXQpICYgMSkpOworICAgICAgICAvL0FTU0VSVCghKHJlaW50ZXJwcmV0X2Nh c3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7CiAgICAgICAgIAogICAgICAgICBpbnRwdHJfdCBy ZWxhdGl2ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgLSAocmVpbnRlcnBy ZXRfY2FzdDxpbnRwdHJfdD4oaW5zdHJ1Y3Rpb24pKTsKICAgICAgICAgLy8gRnJvbSBDb3J0ZXgt QTggZXJyYXRhOgpAQCAtMjQ0Nyw3ICsyNDQ3LDcgQEAgcHJpdmF0ZToKICAgICB7CiAgICAgICAg IC8vIEZJTVhFOiB0aGlzIHNob3VsZCBiZSB1cCBpbiB0aGUgTWFjcm9Bc3NlbWJsZXIgbGF5ZXIu IDotKCAgICAgICAgCiAgICAgICAgIEFTU0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+ KGluc3RydWN0aW9uKSAmIDEpKTsKLSAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxp bnRwdHJfdD4odGFyZ2V0KSAmIDEpKTsKKyAgICAgICAgLy9BU1NFUlQoIShyZWludGVycHJldF9j YXN0PGludHB0cl90Pih0YXJnZXQpICYgMSkpOwogICAgICAgICBBU1NFUlQoY2FuQmVKdW1wVDEo aW5zdHJ1Y3Rpb24sIHRhcmdldCkpOwogICAgICAgICAKICAgICAgICAgaW50cHRyX3QgcmVsYXRp dmUgPSByZWludGVycHJldF9jYXN0PGludHB0cl90Pih0YXJnZXQpIC0gKHJlaW50ZXJwcmV0X2Nh c3Q8aW50cHRyX3Q+KGluc3RydWN0aW9uKSk7CkBAIC0yNDU3LDcgKzI0NTcsNyBAQCBwcml2YXRl OgogICAgICAgICByZWxhdGl2ZSAtPSAyOwogICAgICAgICAKICAgICAgICAgLy8gQWxsIGJyYW5j aCBvZmZzZXRzIHNob3VsZCBiZSBhbiBldmVuIGRpc3RhbmNlLgotICAgICAgICBBU1NFUlQoIShy ZWxhdGl2ZSAmIDEpKTsKKyAgICAgICAgLy9BU1NFUlQoIShyZWxhdGl2ZSAmIDEpKTsKICAgICAg ICAgaW5zdHJ1Y3Rpb25bLTFdID0gT1BfQl9UMSB8ICgoY29uZCAmIDB4ZikgPDwgOCkgfCAoKHJl bGF0aXZlICYgMHgxZmUpID4+IDEpOwogICAgIH0KICAgICAKQEAgLTI0NjUsNyArMjQ2NSw3IEBA IHByaXZhdGU6CiAgICAgewogICAgICAgICAvLyBGSU1YRTogdGhpcyBzaG91bGQgYmUgdXAgaW4g dGhlIE1hY3JvQXNzZW1ibGVyIGxheWVyLiA6LSggICAgICAgIAogICAgICAgICBBU1NFUlQoIShy ZWludGVycHJldF9jYXN0PGludHB0cl90PihpbnN0cnVjdGlvbikgJiAxKSk7Ci0gICAgICAgIEFT U0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7CisgICAgICAg IC8vQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4odGFyZ2V0KSAmIDEpKTsKICAg ICAgICAgQVNTRVJUKGNhbkJlSnVtcFQyKGluc3RydWN0aW9uLCB0YXJnZXQpKTsKICAgICAgICAg CiAgICAgICAgIGludHB0cl90IHJlbGF0aXZlID0gcmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4o dGFyZ2V0KSAtIChyZWludGVycHJldF9jYXN0PGludHB0cl90PihpbnN0cnVjdGlvbikpOwpAQCAt MjQ3NSw3ICsyNDc1LDcgQEAgcHJpdmF0ZToKICAgICAgICAgcmVsYXRpdmUgLT0gMjsKICAgICAg ICAgCiAgICAgICAgIC8vIEFsbCBicmFuY2ggb2Zmc2V0cyBzaG91bGQgYmUgYW4gZXZlbiBkaXN0 YW5jZS4KLSAgICAgICAgQVNTRVJUKCEocmVsYXRpdmUgJiAxKSk7CisgICAgICAgIC8vQVNTRVJU KCEocmVsYXRpdmUgJiAxKSk7CiAgICAgICAgIGluc3RydWN0aW9uWy0xXSA9IE9QX0JfVDIgfCAo KHJlbGF0aXZlICYgMHhmZmUpID4+IDEpOwogICAgIH0KICAgICAKQEAgLTI0ODMsNyArMjQ4Myw3 IEBAIHByaXZhdGU6CiAgICAgewogICAgICAgICAvLyBGSU1YRTogdGhpcyBzaG91bGQgYmUgdXAg aW4gdGhlIE1hY3JvQXNzZW1ibGVyIGxheWVyLiA6LSgKICAgICAgICAgQVNTRVJUKCEocmVpbnRl cnByZXRfY2FzdDxpbnRwdHJfdD4oaW5zdHJ1Y3Rpb24pICYgMSkpOwotICAgICAgICBBU1NFUlQo IShyZWludGVycHJldF9jYXN0PGludHB0cl90Pih0YXJnZXQpICYgMSkpOworICAgICAgICAvL0FT U0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7CiAgICAgICAg IGJvb2wgc2NyYXRjaDsKICAgICAgICAgVU5VU0VEX1BBUkFNKHNjcmF0Y2gpOwogICAgICAgICBB U1NFUlQoY2FuQmVKdW1wVDMoaW5zdHJ1Y3Rpb24sIHRhcmdldCwgc2NyYXRjaCkpOwpAQCAtMjQ5 MSw3ICsyNDkxLDcgQEAgcHJpdmF0ZToKICAgICAgICAgaW50cHRyX3QgcmVsYXRpdmUgPSByZWlu dGVycHJldF9jYXN0PGludHB0cl90Pih0YXJnZXQpIC0gKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRy X3Q+KGluc3RydWN0aW9uKSk7CiAgICAgICAgIAogICAgICAgICAvLyBBbGwgYnJhbmNoIG9mZnNl dHMgc2hvdWxkIGJlIGFuIGV2ZW4gZGlzdGFuY2UuCi0gICAgICAgIEFTU0VSVCghKHJlbGF0aXZl ICYgMSkpOworICAgICAgICAvL0FTU0VSVCghKHJlbGF0aXZlICYgMSkpOwogICAgICAgICBpbnN0 cnVjdGlvblstMl0gPSBPUF9CX1QzYSB8ICgocmVsYXRpdmUgJiAweDEwMDAwMCkgPj4gMTApIHwg KChjb25kICYgMHhmKSA8PCA2KSB8ICgocmVsYXRpdmUgJiAweDNmMDAwKSA+PiAxMik7CiAgICAg ICAgIGluc3RydWN0aW9uWy0xXSA9IE9QX0JfVDNiIHwgKChyZWxhdGl2ZSAmIDB4ODAwMDApID4+ IDgpIHwgKChyZWxhdGl2ZSAmIDB4NDAwMDApID4+IDUpIHwgKChyZWxhdGl2ZSAmIDB4ZmZlKSA+ PiAxKTsKICAgICB9CkBAIC0yNTAwLDcgKzI1MDAsNyBAQCBwcml2YXRlOgogICAgIHsKICAgICAg ICAgLy8gRklNWEU6IHRoaXMgc2hvdWxkIGJlIHVwIGluIHRoZSBNYWNyb0Fzc2VtYmxlciBsYXll ci4gOi0oICAgICAgICAKICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJf dD4oaW5zdHJ1Y3Rpb24pICYgMSkpOwotICAgICAgICBBU1NFUlQoIShyZWludGVycHJldF9jYXN0 PGludHB0cl90Pih0YXJnZXQpICYgMSkpOworICAgICAgICAvL0FTU0VSVCghKHJlaW50ZXJwcmV0 X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7CiAgICAgICAgIGJvb2wgc2NyYXRjaDsKICAg ICAgICAgVU5VU0VEX1BBUkFNKHNjcmF0Y2gpOwogICAgICAgICBBU1NFUlQoY2FuQmVKdW1wVDQo aW5zdHJ1Y3Rpb24sIHRhcmdldCwgc2NyYXRjaCkpOwpAQCAtMjUxMSw3ICsyNTExLDcgQEAgcHJp dmF0ZToKICAgICAgICAgICAgIHJlbGF0aXZlIF49IDB4QzAwMDAwOwogICAgICAgICAKICAgICAg ICAgLy8gQWxsIGJyYW5jaCBvZmZzZXRzIHNob3VsZCBiZSBhbiBldmVuIGRpc3RhbmNlLgotICAg ICAgICBBU1NFUlQoIShyZWxhdGl2ZSAmIDEpKTsKKyAgICAgICAgLy9BU1NFUlQoIShyZWxhdGl2 ZSAmIDEpKTsKICAgICAgICAgaW5zdHJ1Y3Rpb25bLTJdID0gT1BfQl9UNGEgfCAoKHJlbGF0aXZl ICYgMHgxMDAwMDAwKSA+PiAxNCkgfCAoKHJlbGF0aXZlICYgMHgzZmYwMDApID4+IDEyKTsKICAg ICAgICAgaW5zdHJ1Y3Rpb25bLTFdID0gT1BfQl9UNGIgfCAoKHJlbGF0aXZlICYgMHg4MDAwMDAp ID4+IDEwKSB8ICgocmVsYXRpdmUgJiAweDQwMDAwMCkgPj4gMTEpIHwgKChyZWxhdGl2ZSAmIDB4 ZmZlKSA+PiAxKTsKICAgICB9CkBAIC0yNTIwLDcgKzI1MjAsNyBAQCBwcml2YXRlOgogICAgIHsK ICAgICAgICAgLy8gRklNWEU6IHRoaXMgc2hvdWxkIGJlIHVwIGluIHRoZSBNYWNyb0Fzc2VtYmxl ciBsYXllci4gOi0oICAgICAgICAKICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxp bnRwdHJfdD4oaW5zdHJ1Y3Rpb24pICYgMSkpOwotICAgICAgICBBU1NFUlQoIShyZWludGVycHJl dF9jYXN0PGludHB0cl90Pih0YXJnZXQpICYgMSkpOworICAgICAgICAvL0FTU0VSVCghKHJlaW50 ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7CiAgICAgICAgIAogICAgICAgICBp bnN0cnVjdGlvblstM10gPSBpZlRoZW5FbHNlKGNvbmQpIHwgT1BfSVQ7CiAgICAgICAgIGxpbmtK dW1wVDQoaW5zdHJ1Y3Rpb24sIHRhcmdldCk7CkBAIC0yNTMwLDcgKzI1MzAsNyBAQCBwcml2YXRl OgogICAgIHsKICAgICAgICAgLy8gRklNWEU6IHRoaXMgc2hvdWxkIGJlIHVwIGluIHRoZSBNYWNy b0Fzc2VtYmxlciBsYXllci4gOi0oCiAgICAgICAgIEFTU0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8 aW50cHRyX3Q+KGluc3RydWN0aW9uKSAmIDEpKTsKLSAgICAgICAgQVNTRVJUKCEocmVpbnRlcnBy ZXRfY2FzdDxpbnRwdHJfdD4odGFyZ2V0KSAmIDEpKTsKKyAgICAgICAgLy9BU1NFUlQoIShyZWlu dGVycHJldF9jYXN0PGludHB0cl90Pih0YXJnZXQpICYgMSkpOwogICAgICAgICAKICAgICAgICAg Y29uc3QgdWludDE2X3QgSlVNUF9URU1QT1JBUllfUkVHSVNURVIgPSBBUk1SZWdpc3RlcnM6Omlw OwogICAgICAgICBBUk1UaHVtYkltbWVkaWF0ZSBsbzE2ID0gQVJNVGh1bWJJbW1lZGlhdGU6Om1h a2VVSW50MTYoc3RhdGljX2Nhc3Q8dWludDE2X3Q+KHJlaW50ZXJwcmV0X2Nhc3Q8dWludDMyX3Q+ KHRhcmdldCkgKyAxKSk7CkBAIC0yNTQ2LDcgKzI1NDYsNyBAQCBwcml2YXRlOgogICAgIHsKICAg ICAgICAgLy8gRklNWEU6IHRoaXMgc2hvdWxkIGJlIHVwIGluIHRoZSBNYWNyb0Fzc2VtYmxlciBs YXllci4gOi0oICAgICAgICAKICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxpbnRw dHJfdD4oaW5zdHJ1Y3Rpb24pICYgMSkpOwotICAgICAgICBBU1NFUlQoIShyZWludGVycHJldF9j YXN0PGludHB0cl90Pih0YXJnZXQpICYgMSkpOworICAgICAgICAvL0FTU0VSVCghKHJlaW50ZXJw cmV0X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7CiAgICAgICAgIAogICAgICAgICBsaW5r QlgoaW5zdHJ1Y3Rpb24sIHRhcmdldCk7CiAgICAgICAgIGluc3RydWN0aW9uWy02XSA9IGlmVGhl bkVsc2UoY29uZCwgdHJ1ZSwgdHJ1ZSkgfCBPUF9JVDsKQEAgLTI1NTYsNyArMjU1Niw3IEBAIHBy aXZhdGU6CiAgICAgewogICAgICAgICAvLyBGSU1YRTogdGhpcyBzaG91bGQgYmUgdXAgaW4gdGhl IE1hY3JvQXNzZW1ibGVyIGxheWVyLiA6LSgKICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRf Y2FzdDxpbnRwdHJfdD4oaW5zdHJ1Y3Rpb24pICYgMSkpOwotICAgICAgICBBU1NFUlQoIShyZWlu dGVycHJldF9jYXN0PGludHB0cl90Pih0YXJnZXQpICYgMSkpOworICAgICAgICAvL0FTU0VSVCgh KHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRhcmdldCkgJiAxKSk7CiAgICAgICAgIAogICAg ICAgICBBU1NFUlQoKGlzTU9WX2ltbV9UMyhpbnN0cnVjdGlvbiAtIDUpICYmIGlzTU9WVChpbnN0 cnVjdGlvbiAtIDMpICYmIGlzQlgoaW5zdHJ1Y3Rpb24gLSAxKSkKICAgICAgICAgICAgICAgIHx8 IChpc05PUF9UMShpbnN0cnVjdGlvbiAtIDUpICYmIGlzTk9QX1QyKGluc3RydWN0aW9uIC0gNCkg JiYgaXNCKGluc3RydWN0aW9uIC0gMikpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJDb2RlUmVmLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oCmluZGV4IGMyYWYyNDAuLjZm Y2EyMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJDb2RlUmVmLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckNvZGVSZWYuaApAQCAtNDMsOCArNDMsOCBAQAogLy8gZGVjb3JhdGVkIGFu ZCB1bmRlY3RvcmF0ZWQgbnVsbCwgYW5kIHRoZSBzZWNvbmQgdGVzdCBlbnN1cmVzIHRoYXQgdGhl IHBvaW50ZXIgaXMKIC8vIGRlY29yYXRlZC4KICNkZWZpbmUgQVNTRVJUX1ZBTElEX0NPREVfUE9J TlRFUihwdHIpIFwKLSAgICBBU1NFUlQocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4ocHRyKSAm IH4xKTsgXAotICAgIEFTU0VSVChyZWludGVycHJldF9jYXN0PGludHB0cl90PihwdHIpICYgMSkK KyAgICBBU1NFUlQocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4ocHRyKSAmIH4xKTsKKy8vICAg IEFTU0VSVChyZWludGVycHJldF9jYXN0PGludHB0cl90PihwdHIpICYgMSkKICNkZWZpbmUgQVNT RVJUX1ZBTElEX0NPREVfT0ZGU0VUKG9mZnNldCkgXAogICAgIEFTU0VSVCghKG9mZnNldCAmIDEp KSAvLyBNdXN0IGJlIG11bHRpcGxlIG9mIDIuCiAjZWxzZQo=