100109 2012-10-23 04:28:51 -0700 Regression(r132143): Assertion hit in JSC::Interpreter::StackPolicy::StackPolicy(JSC::Interpreter&, const WTF::StackBounds&) 2012-10-23 22:03:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99872 1 cdumez cdumez fpizlo ggaren mark.lam webkit.review.bot oldest_to_newest 748487 0 cdumez 2012-10-23 04:28:51 -0700 On EFL 64bit debug build bot, we hit the following assertion after r132143: ASSERTION FAILED: (requiredCapacity >= 0) && (requiredCapacity < size) /home/chris/Devel/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp(194) : JSC::Interpreter::StackPolicy::StackPolicy(JSC::Interpreter&, const WTF::StackBounds&) 1 0x2b6781fbd5a6 JSC::Interpreter::StackPolicy::StackPolicy(JSC::Interpreter&, WTF::StackBounds const&) 2 0x2b6781fc095c JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) 3 0x2b6782080af4 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 4 0x2b677e445e65 WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 5 0x2b677e462bbc WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) 6 0x2b677e462cbe WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) 7 0x2b677d70490c WebCore::ScriptController::executeScript(WebCore::ScriptSourceCode const&) 8 0x2b677d704862 WebCore::ScriptController::executeScript(WTF::String const&, bool) 9 0x2b677aa55aa9 WebKit::WebPage::runJavaScriptInMainFrame(WTF::String const&, unsigned long) 10 0x2b677aae383e void CoreIPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(WTF::String const&, unsigned long), WTF::String, unsigned long>(CoreIPC::Arguments2<WTF::String, unsigned long> const&, WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&, unsigned long)) 11 0x2b677aae159a void CoreIPC::handleMessage<Messages::WebPage::RunJavaScriptInMainFrame, WebKit::WebPage, void (WebKit::WebPage::*)(WTF::String const&, unsigned long)>(CoreIPC::MessageDecoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&, unsigned long)) 12 0x2b677aadf44e WebKit::WebPage::didReceiveWebPageMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 13 0x2b677aa58d2e WebKit::WebPage::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 14 0x2b677a988b88 WebKit::WebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 15 0x2b677a98459f WebKit::WebConnectionToUIProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 16 0x2b677a84bb4c CoreIPC::Connection::dispatchMessage(CoreIPC::MessageID, CoreIPC::MessageDecoder&) 17 0x2b677a84bc85 CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::MessageDecoder>&) 18 0x2b677a84be21 CoreIPC::Connection::dispatchOneMessage() 19 0x2b677a855f76 WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) 20 0x2b677a855d7c WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() 21 0x2b677aa3775c WTF::Function<void ()>::operator()() const 22 0x2b677deee132 WebCore::RunLoop::performWork() 23 0x2b677e8a88a7 WebCore::RunLoop::wakeUpEvent(void*, void*, unsigned int) 24 0x2b6780d28901 25 0x2b6780d27851 26 0x2b6780d27d97 ecore_main_loop_begin 27 0x2b677e8a8871 WebCore::RunLoop::run() 28 0x2b677aab4d78 WebProcessMainEfl 29 0x4007c4 main 30 0x2b677ae7e76d __libc_start_main 31 0x4006e9 When we hit this assertion, the size is negative which seems to indicate a possible integer overflow. 748494 1 170120 cdumez 2012-10-23 04:40:57 -0700 Created attachment 170120 Patch This patch fixes crashing on EFL port. 748592 2 cdumez 2012-10-23 06:49:10 -0700 On my machine I got before the crash: stack.size(): 92967688560640 Max INT: 2147483647 748664 3 mark.lam 2012-10-23 08:20:32 -0700 (In reply to comment #2) > On my machine I got before the crash: > stack.size(): 92967688560640 > Max INT: 2147483647 Thanks for catching this issue. I didn't think it was possible (because it seemed highly impractical) that someone would want to have a stack that is greater than 2G. Your case proves otherwise, although I would be suspicious of that size value. 92967688560640 makes for 84 terabytes of memory. That's more memory than most machines have just to be used for a single stack. While it is programmatically legal for you to set the stack limit/size this high, I suspect that in practice, what this actually means is that on your platform, the stack check will be defeated, and you are effectively not doing any checks at all. One side effect of this is that some of the layout tests will start to fail in a flaky manner. The reason is because, by defeating the stack check with an artificially high stack size, you allow the code to run with a stack check. As a result, the test will fail and crash wherever you physically run out of stack space, which is long before you reached the specified limit, and which may vary depending on system load and available memory at the time of the run. And again, I point you to StackBounds. StackBounds::initialize() is platform dependent. I suggest that you add something for PLATFORM(EFL) there that bounds the stack to a more reasonable limit so that the stack recursion checks can be effective. Regardless, you are right that I should have used size_t instead of int for the StackPolicy calculations. I will comment on your patch shortly. Thanks again for catching this issue. 748683 4 170120 mark.lam 2012-10-23 08:55:29 -0700 Comment on attachment 170120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170120&action=review > Source/JavaScriptCore/ChangeLog:14 > + happy. See comment below. > Source/JavaScriptCore/interpreter/Interpreter.cpp:123 > + const size_t DefaultErrorModeRequiredStack = 32 * 1024; I prefer that you leave these capitalized as in the original. I understand that the style checker is not happy about it, but I consider this a bug in the style checker rather than in the code, and I made a comment about it in my original patch here: https://bugs.webkit.org/show_bug.cgi?id=99872#c3 > Source/JavaScriptCore/interpreter/Interpreter.cpp:128 > + // but require that we have at least DefaultRequiredStack capacity Ditto. > Source/JavaScriptCore/interpreter/Interpreter.cpp:133 > + // | ... | <-- DefaultRequiredStack --> | ... Ditto. > Source/JavaScriptCore/interpreter/Interpreter.cpp:146 > + // DefaultErrorModeRequiredStack capacity. Ditto, and similarly below. > Source/JavaScriptCore/interpreter/Interpreter.cpp:180 > + size_t useableStack = (requiredCapacity <= size) ? size - requiredCapacity : DefaultMinimumUseableStack; Nit: (not in the coding style, just my personal pref but ...) can you break this line into 2 lines (as in example above) so as to keep the lengths < ~80 per line. That was one of my goals when I wrote this function. Would like to keep it consistent if that's ok with you. Thanks. > Source/JavaScriptCore/interpreter/Interpreter.cpp:191 > + ASSERT(useableStack >= DefaultMinimumUseableStack && useableStack <= size); This assertion is not true. If the stack size is less than DEFAULT_MINIMUM_USEABLE_STACK, then (useableStack >= DEFAULT_MINIMUM_USEABLE_STACK) will never be true. Please fix the assertion or delete it. > Source/JavaScriptCore/interpreter/Interpreter.cpp:195 > // interpreter stack checks: Please delete this line. It was a half edited comment from my patch. Thanks. LGTM after you address the above issues. Thanks. 748739 5 cdumez 2012-10-23 09:44:58 -0700 Ok, thanks. I'll fix and reupload now. 748750 6 170184 cdumez 2012-10-23 10:00:18 -0700 Created attachment 170184 Patch Take Mark Lam's feedback into consideration. BTW, the extremely high stack size value is returned by pthread_attr_getstack(&sattr, &stackBase, &stackSize) (in #elif OS(UNIX) implementation of StackBounds::initialize()). I'll look further into it but this is anyway a separate issue. 748753 7 webkit.review.bot 2012-10-23 10:03:21 -0700 Attachment 170184 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/interpreter/Interpreter.cpp:121: DEFAULT_REQUIRED_STACK is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:122: DEFAULT_MINIMUM_USEABLE_STACK is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:123: DEFAULT_ERROR_MODE_REQUIRED_STACK is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 748797 8 170184 webkit.review.bot 2012-10-23 10:58:36 -0700 Comment on attachment 170184 Patch Clearing flags on attachment: 170184 Committed r132244: <http://trac.webkit.org/changeset/132244> 748798 9 webkit.review.bot 2012-10-23 10:58:40 -0700 All reviewed patches have been landed. Closing bug. 170120 2012-10-23 04:40:57 -0700 2012-10-23 10:00:18 -0700 Patch 100109_integer_overflow.patch text/plain 6266 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGMwOTZjNGIuLjQ0MTNmN2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTIzICBDaHJpc3RvcGhlIER1 bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihy MTMyMTQzKTogQXNzZXJ0aW9uIGhpdCBpbiBKU0M6OkludGVycHJldGVyOjpTdGFja1BvbGljeTo6 U3RhY2tQb2xpY3koSlNDOjpJbnRlcnByZXRlciYsIGNvbnN0IFdURjo6U3RhY2tCb3VuZHMmKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMTA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHBvc3Np YmxlIGludGVnZXIgb3ZlcmZsb3cgaW4gU3RhY2tQb2xpY3kgY29uc3RydWN0b3IgYnkKKyAgICAg ICAgdXNpbmcgc2l6ZV90IHR5cGUgaW5zdGVhZCBvZiBpbnQgZm9yIHN0YWNrIHNpemVzLiBUaGUg dmFsdWUKKyAgICAgICAgcmV0dXJuZWQgYnkgU3RhY2tCb3VuZHM6OnNpemUoKSBpcyBvZiB0eXBl IHNpemVfdCBidXQgd2FzCisgICAgICAgIGFzc2lnbmVkIHRvIGFuIGludCwgd2hpY2ggbWF5IG92 ZXJmbG93LgorCisgICAgICAgIEFsc28gZml4IHNvbWUgY29kaW5nIHN0eWxlIHZpb2xhdGlvbnMg dG8gbWFrZSB0aGUgc3R5bGUgc2NyaXB0CisgICAgICAgIGhhcHB5LgorCisgICAgICAgICogaW50 ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwOgorICAgICAgICAoSlNDOjpJbnRlcnByZXRlcjo6U3Rh Y2tQb2xpY3k6OlN0YWNrUG9saWN5KToKKwogMjAxMi0xMC0yMyAgTWFyayBMYW0gIDxtYXJrLmxh bUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSB0b3BDYWxsRnJhbWUgcmVsaWFibGUuCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAppbmRl eCAwZDQ3NWI0Li5lZDY4YmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50 ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRl cnByZXRlci9JbnRlcnByZXRlci5jcHAKQEAgLTExNiwyMSArMTE2LDIxIEBAIEludGVycHJldGVy OjpFcnJvckhhbmRsaW5nTW9kZTo6fkVycm9ySGFuZGxpbmdNb2RlKCkKIEludGVycHJldGVyOjpT dGFja1BvbGljeTo6U3RhY2tQb2xpY3koSW50ZXJwcmV0ZXImIGludGVycHJldGVyLCBjb25zdCBT dGFja0JvdW5kcyYgc3RhY2spCiAgICAgOiBtX2ludGVycHJldGVyKGludGVycHJldGVyKQogewot ICAgIGludCBzaXplID0gc3RhY2suc2l6ZSgpOworICAgIGNvbnN0IHNpemVfdCBzaXplID0gc3Rh Y2suc2l6ZSgpOwogCi0gICAgY29uc3QgaW50IERFRkFVTFRfUkVRVUlSRURfU1RBQ0sgPSAxMDI0 ICogMTAyNDsKLSAgICBjb25zdCBpbnQgREVGQVVMVF9NSU5JTVVNX1VTRUFCTEVfU1RBQ0sgPSAx MjggKiAxMDI0OwotICAgIGNvbnN0IGludCBERUZBVUxUX0VSUk9SX01PREVfUkVRVUlSRURfU1RB Q0sgPSAzMiAqIDEwMjQ7CisgICAgY29uc3Qgc2l6ZV90IERlZmF1bHRSZXF1aXJlZFN0YWNrID0g MTAyNCAqIDEwMjQ7CisgICAgY29uc3Qgc2l6ZV90IERlZmF1bHRNaW5pbXVtVXNlYWJsZVN0YWNr ID0gMTI4ICogMTAyNDsKKyAgICBjb25zdCBzaXplX3QgRGVmYXVsdEVycm9yTW9kZVJlcXVpcmVk U3RhY2sgPSAzMiAqIDEwMjQ7CiAKICAgICAvLyBIZXJlJ3MgdGhlIHBvbGljeSBpbiBhIG51dHNo ZWxsOgogICAgIC8vCiAgICAgLy8gMS4gSWYgd2UgaGF2ZSBhIGxhcmdlIHN0YWNrLCBsZXQgSlMg dXNlIGFzIG11Y2ggc3RhY2sgYXMgcG9zc2libGUKLSAgICAvLyAgICBidXQgcmVxdWlyZSB0aGF0 IHdlIGhhdmUgYXQgbGVhc3QgREVGQVVMVF9SRVFVSVJFRF9TVEFDSyBjYXBhY2l0eQorICAgIC8v ICAgIGJ1dCByZXF1aXJlIHRoYXQgd2UgaGF2ZSBhdCBsZWFzdCBEZWZhdWx0UmVxdWlyZWRTdGFj ayBjYXBhY2l0eQogICAgIC8vICAgIHJlbWFpbmluZyBvbiB0aGUgc3RhY2s6CiAgICAgLy8KICAg ICAvLyAgICBzdGFjayBncm93cyB0aGlzIHdheSAtLT4gICAKICAgICAvLyAgICAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KLSAgICAvLyAg ICB8ICAgICAgICAgLi4uIHwgPC0tIERFRkFVTFRfUkVRVUlSRURfU1RBQ0sgLS0+IHwgLi4uCisg ICAgLy8gICAgfCAgICAgICAgIC4uLiB8IDwtLSBEZWZhdWx0UmVxdWlyZWRTdGFjayAtLT4gfCAu Li4KICAgICAvLyAgICAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KICAgICAvLyAgICBeICAgICAgICAgICAgIF4KICAgICAvLyAgICBzdGFy dCAgICAgICAgIGN1cnJlbnQgc3AKQEAgLTE0MywxNiArMTQzLDE2IEBAIEludGVycHJldGVyOjpT dGFja1BvbGljeTo6U3RhY2tQb2xpY3koSW50ZXJwcmV0ZXImIGludGVycHJldGVyLCBjb25zdCBT dGFja0JvdW5kCiAgICAgLy8gICAgb3ZlcmZsb3cgYmFzZWQgb24gdGhlIG5vcm1hbGx5IGNvbXB1 dGVkIHJlcXVpcmVkIHN0YWNrIGNhcGFjaXR5LgogICAgIC8vICAgIEhvd2V2ZXIsIHRoZSBub3Jt YWwgcmVxdWlyZWQgY2FwYWNpdHkgZmFyIGV4Y2VlZHMgd2hhdCBpcyBuZWVkZWQKICAgICAvLyAg ICBmb3IgZXhjZXB0aW9uIGhhbmRsaW5nIHdvcmsuIEhlbmNlLCBpbiBlcnJvciBtb2RlLCB3ZSBv bmx5IHJlcXVpcmUKLSAgICAvLyAgICBERUZBVUxUX0VSUk9SX01PREVfUkVRVUlSRURfU1RBQ0sg Y2FwYWNpdHkuCisgICAgLy8gICAgRGVmYXVsdEVycm9yTW9kZVJlcXVpcmVkU3RhY2sgY2FwYWNp dHkuCiAgICAgLy8KICAgICAvLyAgICBzdGFjayBncm93cyB0aGlzIHdheSAtLT4gICAKICAgICAv LyAgICAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQotICAgIC8vICAgIHwgICAgICAgICAuLi4gfCA8LS0gREVGQVVMVF9FUlJP Ul9NT0RFX1JFUVVJUkVEX1NUQUNLIC0tPiB8IC4uLgorICAgIC8vICAgIHwgICAgICAgICAuLi4g fCA8LS0gRGVmYXVsdEVycm9yTW9kZVJlcXVpcmVkU3RhY2sgLS0+IHwgLi4uCiAgICAgLy8gICAg LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KICAgICAvLyAgICBeICAgICAgICAgICAgIF4KICAgICAvLyAgICBzdGFydCAgICAg ICAgIGN1cnJlbnQgc3AKICAgICAvLwotICAgIC8vICAgIFRoaXMgc21hbGxlciByZXF1cmllZCBj YXBhY2l0eSBhbHNvIG1lYW5zIHRoYXQgd2Ugd29uJ3QgcmUtdHJpZ2dlcgorICAgIC8vICAgIFRo aXMgc21hbGxlciByZXF1aXJlZCBjYXBhY2l0eSBhbHNvIG1lYW5zIHRoYXQgd2Ugd29uJ3QgcmUt dHJpZ2dlcgogICAgIC8vICAgIGEgc3RhY2sgb3ZlcmZsb3cgZm9yIHByb2Nlc3NpbmcgdGhlIGV4 Y2VwdGlvbiBjYXVzZWQgYnkgdGhlIG9yaWdpbmFsCiAgICAgLy8gICAgU3RhY2tPdmVyZmxvd0Vy cm9yLgogICAgIC8vCkBAIC0xNjEsMzggKzE2MSw0MCBAQCBJbnRlcnByZXRlcjo6U3RhY2tQb2xp Y3k6OlN0YWNrUG9saWN5KEludGVycHJldGVyJiBpbnRlcnByZXRlciwgY29uc3QgU3RhY2tCb3Vu ZAogICAgIC8vCiAgICAgLy8gICAgc3RhY2sgZ3Jvd3MgdGhpcyB3YXkgLS0+ICAgCiAgICAgLy8g ICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KLSAgICAvLyAgICB8IDwtLSBERUZBVUxUX01JTklNVU1fVVNFQUJMRV9T VEFDSyAtLT4gfCA8LS0gcmVxdWlyZWRDYXBhY2l0eSAtLT4gfAorICAgIC8vICAgIHwgPC0tIERl ZmF1bHRNaW5pbXVtVXNlYWJsZVN0YWNrIC0tPiB8IDwtLSByZXF1aXJlZENhcGFjaXR5IC0tPiB8 CiAgICAgLy8gICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICAgICAvLyAgICBeICAgICAgICAgICAgIF4KICAgICAv LyAgICBzdGFydCAgICAgICAgIGN1cnJlbnQgc3AKICAgICAvLwotICAgIC8vICAgIFRoZSBtaW5p bXVtIHVzZWFibGUgY2FwYWNpdHkgaXMgREVGQVVMVF9NSU5JTVVNX1VTRUFCTEVfU1RBQ0suCisg ICAgLy8gICAgVGhlIG1pbmltdW0gdXNlYWJsZSBjYXBhY2l0eSBpcyBEZWZhdWx0TWluaW11bVVz ZWFibGVTdGFjay4KICAgICAvLyAgICBJbiB0aGlzIGNhc2UsIHRoZSByZXF1aXJlZENhcGFjaXR5 IGlzIHdoYXRldmVyIGlzIGxlZnQgb2YgdGhlCiAgICAgLy8gICAgdG90YWwgc3RhY2sgY2FwYWNp dHkgYWZ0ZXIgd2UgaGF2ZSBnaXZlIEpTIGl0cyBtaW5pbXVtIHN0YWNrCi0gICAgLy8gICAgaS5l LiByZXF1aXJlZENhcGNpdHkgY2FuIGV2ZW4gYmUgMCBpZiB0aGVyZSdzIG5vdCBlbm91Z2ggc3Rh Y2suCisgICAgLy8gICAgaS5lLiByZXF1aXJlZENhcGFjaXR5IGNhbiBldmVuIGJlIDAgaWYgdGhl cmUncyBub3QgZW5vdWdoIHN0YWNrLgogCiAKLSAgICAvLyBQb2xpY3kgMTogTm9ybWFsIG1vZGU6 IHJlcXVpcmVkID0gREVGQVVMVF9SRVFVSVJFRF9TVEFDSy4KLSAgICAvLyBQb2xpY3kgMjogRXJy byBtb2RlOiByZXF1aXJlZCA9IERFRkFVTFRfRVJST1JfTU9ERV9SRVFVSVJFRF9TVEFDSy4KLSAg ICBpbnQgcmVxdWlyZWRDYXBhY2l0eSA9ICFtX2ludGVycHJldGVyLm1fZXJyb3JIYW5kbGluZ01v ZGVSZWVudHJ5ID8KLSAgICAgICAgREVGQVVMVF9SRVFVSVJFRF9TVEFDSyA6IERFRkFVTFRfRVJS T1JfTU9ERV9SRVFVSVJFRF9TVEFDSzsKKyAgICAvLyBQb2xpY3kgMTogTm9ybWFsIG1vZGU6IHJl cXVpcmVkID0gRGVmYXVsdFJlcXVpcmVkU3RhY2suCisgICAgLy8gUG9saWN5IDI6IEVycm9yIG1v ZGU6IHJlcXVpcmVkID0gRGVmYXVsdEVycm9yTW9kZVJlcXVpcmVkU3RhY2suCisgICAgc2l6ZV90 IHJlcXVpcmVkQ2FwYWNpdHkgPSBtX2ludGVycHJldGVyLm1fZXJyb3JIYW5kbGluZ01vZGVSZWVu dHJ5ID8KKyAgICAgICAgRGVmYXVsdEVycm9yTW9kZVJlcXVpcmVkU3RhY2sgOiBEZWZhdWx0UmVx dWlyZWRTdGFjazsKIAotICAgIGludCB1c2VhYmxlU3RhY2sgPSBzaXplIC0gcmVxdWlyZWRDYXBh Y2l0eTsKKyAgICBzaXplX3QgdXNlYWJsZVN0YWNrID0gKHJlcXVpcmVkQ2FwYWNpdHkgPD0gc2l6 ZSkgPyBzaXplIC0gcmVxdWlyZWRDYXBhY2l0eSA6IERlZmF1bHRNaW5pbXVtVXNlYWJsZVN0YWNr OwogCiAgICAgLy8gUG9saWN5IDM6IEVuc3VyZSB0aGUgdXNlYWJsZSBzdGFjayBpcyBub3QgdG9v IHNtYWxsOgotICAgIGlmICh1c2VhYmxlU3RhY2sgPCBERUZBVUxUX01JTklNVU1fVVNFQUJMRV9T VEFDSykKLSAgICAgICAgdXNlYWJsZVN0YWNrID0gREVGQVVMVF9NSU5JTVVNX1VTRUFCTEVfU1RB Q0s7CisgICAgaWYgKHVzZWFibGVTdGFjayA8IERlZmF1bHRNaW5pbXVtVXNlYWJsZVN0YWNrKQor ICAgICAgICB1c2VhYmxlU3RhY2sgPSBEZWZhdWx0TWluaW11bVVzZWFibGVTdGFjazsKIAogICAg IC8vIFNhbml0eSBjaGVjazogTWFrZSBzdXJlIHdlIGRvIG5vdCB1c2UgbW9yZSBzcGFjZSB0aGFu IHRoZSBzdGFjaydzCiAgICAgLy8gdG90YWwgY2FwYWNpdHk6CiAgICAgaWYgKHVzZWFibGVTdGFj ayA+IHNpemUpCiAgICAgICAgIHVzZWFibGVTdGFjayA9IHNpemU7CiAKKyAgICBBU1NFUlQodXNl YWJsZVN0YWNrID49IERlZmF1bHRNaW5pbXVtVXNlYWJsZVN0YWNrICYmIHVzZWFibGVTdGFjayA8 PSBzaXplKTsKKwogICAgIC8vIFJlLWNvbXB1dGUgdGhlIHJlcXVpcmVkQ2FwYWNpdHkgYmFzZWQg b24gdGhlIGFkanVzdGVkIHVzZWFibGUgc3RhY2sKICAgICAvLyBzaXplOgogICAgIC8vIGludGVy cHJldGVyIHN0YWNrIGNoZWNrczoKICAgICByZXF1aXJlZENhcGFjaXR5ID0gc2l6ZSAtIHVzZWFi bGVTdGFjazsKLSAgICBBU1NFUlQoKHJlcXVpcmVkQ2FwYWNpdHkgPj0gMCkgJiYgKHJlcXVpcmVk Q2FwYWNpdHkgPCBzaXplKSk7CisgICAgQVNTRVJUKHJlcXVpcmVkQ2FwYWNpdHkgPCBzaXplKTsK IAogICAgIG1fcmVxdWlyZWRDYXBhY2l0eSA9IHJlcXVpcmVkQ2FwYWNpdHk7ICAgIAogfQo= 170184 2012-10-23 10:00:18 -0700 2012-10-23 10:58:36 -0700 Patch 100109_jsc_overflow.patch text/plain 4690 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGY5NmY1MWMuLjllOWExMGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTIzICBDaHJpc3RvcGhlIER1 bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihy MTMyMTQzKTogQXNzZXJ0aW9uIGhpdCBpbiBKU0M6OkludGVycHJldGVyOjpTdGFja1BvbGljeTo6 U3RhY2tQb2xpY3koSlNDOjpJbnRlcnByZXRlciYsIGNvbnN0IFdURjo6U3RhY2tCb3VuZHMmKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMTA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHBvc3Np YmxlIGludGVnZXIgb3ZlcmZsb3cgaW4gU3RhY2tQb2xpY3kgY29uc3RydWN0b3IgYnkKKyAgICAg ICAgdXNpbmcgc2l6ZV90IHR5cGUgaW5zdGVhZCBvZiBpbnQgZm9yIHN0YWNrIHNpemVzLiBUaGUg dmFsdWUKKyAgICAgICAgcmV0dXJuZWQgYnkgU3RhY2tCb3VuZHM6OnNpemUoKSBpcyBvZiB0eXBl IHNpemVfdCBidXQgd2FzCisgICAgICAgIGFzc2lnbmVkIHRvIGFuIGludCwgd2hpY2ggbWF5IG92 ZXJmbG93LgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwOgorICAgICAg ICAoSlNDKToKKyAgICAgICAgKEpTQzo6SW50ZXJwcmV0ZXI6OlN0YWNrUG9saWN5OjpTdGFja1Bv bGljeSk6CisKIDIwMTItMTAtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeCBtYWtlIGRpc3RjaGVjay4KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCmluZGV4 IDBkNDc1YjQuLjNlNjQ3MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRl cnByZXRlci9JbnRlcnByZXRlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL0ludGVycHJldGVyLmNwcApAQCAtMTAwLDkgKzEwMCw5IEBAIEludGVycHJldGVyOjpF cnJvckhhbmRsaW5nTW9kZTo6fkVycm9ySGFuZGxpbmdNb2RlKCkKIAogLy8gVGhlIEludGVycHJl dGVyOjpTdGFja1BvbGljeSBjbGFzcyBpcyB1c2VkIHRvIGNvbXB1dGUgYSBzdGFjayBjYXBhY2l0 eQogLy8gcmVxdWlyZW1lbnQgdG8gZW5zdXJlIHRoYXQgd2UgaGF2ZSBlbm91Z2ggcm9vbSBvbiB0 aGUgbmF0aXZlIHN0YWNrIGZvcjoKLS8vIDEuIHRoZSBtYXggY3VtbXVsYXRpdmUgc3RhY2sgdXNl ZCBieSB0aGUgaW50ZXJwcmV0ZXIgYW5kIGFsbCBjb2RlCisvLyAxLiB0aGUgbWF4IGN1bXVsYXRp dmUgc3RhY2sgdXNlZCBieSB0aGUgaW50ZXJwcmV0ZXIgYW5kIGFsbCBjb2RlCiAvLyAgICBwYXRo cyBzdWIgb2YgaXQgdXAgdGlsbCBsZWFmIGZ1bmN0aW9ucy4KLS8vIDIuIHRoZSBtYXggY3VtbXVs YXRpdmUgc3RhY2sgdXNlZCBieSB0aGUgaW50ZXJwcmV0ZXIgYmVmb3JlIGl0IHJlYWNoZXMKKy8v IDIuIHRoZSBtYXggY3VtdWxhdGl2ZSBzdGFjayB1c2VkIGJ5IHRoZSBpbnRlcnByZXRlciBiZWZv cmUgaXQgcmVhY2hlcwogLy8gICAgdGhlIG5leHQgY2hlY2twb2ludCAoZXhlY3V0ZS4uLigpIGZ1 bmN0aW9uKSBpbiB0aGUgaW50ZXJwcmV0ZXIuCiAvLyAKIC8vIFRoZSBpbnRlcnByZXRlciBjYW4g YmUgcnVuIG9uIGRpZmZlcmVudCB0aHJlYWRzIGFuZCBoZW5jZSwgZGlmZmVyZW50CkBAIC0xMTYs MTEgKzExNiwxMSBAQCBJbnRlcnByZXRlcjo6RXJyb3JIYW5kbGluZ01vZGU6On5FcnJvckhhbmRs aW5nTW9kZSgpCiBJbnRlcnByZXRlcjo6U3RhY2tQb2xpY3k6OlN0YWNrUG9saWN5KEludGVycHJl dGVyJiBpbnRlcnByZXRlciwgY29uc3QgU3RhY2tCb3VuZHMmIHN0YWNrKQogICAgIDogbV9pbnRl cnByZXRlcihpbnRlcnByZXRlcikKIHsKLSAgICBpbnQgc2l6ZSA9IHN0YWNrLnNpemUoKTsKKyAg ICBjb25zdCBzaXplX3Qgc2l6ZSA9IHN0YWNrLnNpemUoKTsKIAotICAgIGNvbnN0IGludCBERUZB VUxUX1JFUVVJUkVEX1NUQUNLID0gMTAyNCAqIDEwMjQ7Ci0gICAgY29uc3QgaW50IERFRkFVTFRf TUlOSU1VTV9VU0VBQkxFX1NUQUNLID0gMTI4ICogMTAyNDsKLSAgICBjb25zdCBpbnQgREVGQVVM VF9FUlJPUl9NT0RFX1JFUVVJUkVEX1NUQUNLID0gMzIgKiAxMDI0OworICAgIGNvbnN0IHNpemVf dCBERUZBVUxUX1JFUVVJUkVEX1NUQUNLID0gMTAyNCAqIDEwMjQ7CisgICAgY29uc3Qgc2l6ZV90 IERFRkFVTFRfTUlOSU1VTV9VU0VBQkxFX1NUQUNLID0gMTI4ICogMTAyNDsKKyAgICBjb25zdCBz aXplX3QgREVGQVVMVF9FUlJPUl9NT0RFX1JFUVVJUkVEX1NUQUNLID0gMzIgKiAxMDI0OwogCiAg ICAgLy8gSGVyZSdzIHRoZSBwb2xpY3kgaW4gYSBudXRzaGVsbDoKICAgICAvLwpAQCAtMTUyLDcg KzE1Miw3IEBAIEludGVycHJldGVyOjpTdGFja1BvbGljeTo6U3RhY2tQb2xpY3koSW50ZXJwcmV0 ZXImIGludGVycHJldGVyLCBjb25zdCBTdGFja0JvdW5kCiAgICAgLy8gICAgXiAgICAgICAgICAg ICBeCiAgICAgLy8gICAgc3RhcnQgICAgICAgICBjdXJyZW50IHNwCiAgICAgLy8KLSAgICAvLyAg ICBUaGlzIHNtYWxsZXIgcmVxdXJpZWQgY2FwYWNpdHkgYWxzbyBtZWFucyB0aGF0IHdlIHdvbid0 IHJlLXRyaWdnZXIKKyAgICAvLyAgICBUaGlzIHNtYWxsZXIgcmVxdWlyZWQgY2FwYWNpdHkgYWxz byBtZWFucyB0aGF0IHdlIHdvbid0IHJlLXRyaWdnZXIKICAgICAvLyAgICBhIHN0YWNrIG92ZXJm bG93IGZvciBwcm9jZXNzaW5nIHRoZSBleGNlcHRpb24gY2F1c2VkIGJ5IHRoZSBvcmlnaW5hbAog ICAgIC8vICAgIFN0YWNrT3ZlcmZsb3dFcnJvci4KICAgICAvLwpAQCAtMTY5LDE1ICsxNjksMTYg QEAgSW50ZXJwcmV0ZXI6OlN0YWNrUG9saWN5OjpTdGFja1BvbGljeShJbnRlcnByZXRlciYgaW50 ZXJwcmV0ZXIsIGNvbnN0IFN0YWNrQm91bmQKICAgICAvLyAgICBUaGUgbWluaW11bSB1c2VhYmxl IGNhcGFjaXR5IGlzIERFRkFVTFRfTUlOSU1VTV9VU0VBQkxFX1NUQUNLLgogICAgIC8vICAgIElu IHRoaXMgY2FzZSwgdGhlIHJlcXVpcmVkQ2FwYWNpdHkgaXMgd2hhdGV2ZXIgaXMgbGVmdCBvZiB0 aGUKICAgICAvLyAgICB0b3RhbCBzdGFjayBjYXBhY2l0eSBhZnRlciB3ZSBoYXZlIGdpdmUgSlMg aXRzIG1pbmltdW0gc3RhY2sKLSAgICAvLyAgICBpLmUuIHJlcXVpcmVkQ2FwY2l0eSBjYW4gZXZl biBiZSAwIGlmIHRoZXJlJ3Mgbm90IGVub3VnaCBzdGFjay4KKyAgICAvLyAgICBpLmUuIHJlcXVp cmVkQ2FwYWNpdHkgY2FuIGV2ZW4gYmUgMCBpZiB0aGVyZSdzIG5vdCBlbm91Z2ggc3RhY2suCiAK IAogICAgIC8vIFBvbGljeSAxOiBOb3JtYWwgbW9kZTogcmVxdWlyZWQgPSBERUZBVUxUX1JFUVVJ UkVEX1NUQUNLLgotICAgIC8vIFBvbGljeSAyOiBFcnJvIG1vZGU6IHJlcXVpcmVkID0gREVGQVVM VF9FUlJPUl9NT0RFX1JFUVVJUkVEX1NUQUNLLgotICAgIGludCByZXF1aXJlZENhcGFjaXR5ID0g IW1faW50ZXJwcmV0ZXIubV9lcnJvckhhbmRsaW5nTW9kZVJlZW50cnkgPworICAgIC8vIFBvbGlj eSAyOiBFcnJvciBtb2RlOiByZXF1aXJlZCA9IERFRkFVTFRfRVJST1JfTU9ERV9SRVFVSVJFRF9T VEFDSy4KKyAgICBzaXplX3QgcmVxdWlyZWRDYXBhY2l0eSA9ICFtX2ludGVycHJldGVyLm1fZXJy b3JIYW5kbGluZ01vZGVSZWVudHJ5ID8KICAgICAgICAgREVGQVVMVF9SRVFVSVJFRF9TVEFDSyA6 IERFRkFVTFRfRVJST1JfTU9ERV9SRVFVSVJFRF9TVEFDSzsKIAotICAgIGludCB1c2VhYmxlU3Rh Y2sgPSBzaXplIC0gcmVxdWlyZWRDYXBhY2l0eTsKKyAgICBzaXplX3QgdXNlYWJsZVN0YWNrID0g KHJlcXVpcmVkQ2FwYWNpdHkgPD0gc2l6ZSkgPworICAgICAgICBzaXplIC0gcmVxdWlyZWRDYXBh Y2l0eSA6IERFRkFVTFRfTUlOSU1VTV9VU0VBQkxFX1NUQUNLOwogCiAgICAgLy8gUG9saWN5IDM6 IEVuc3VyZSB0aGUgdXNlYWJsZSBzdGFjayBpcyBub3QgdG9vIHNtYWxsOgogICAgIGlmICh1c2Vh YmxlU3RhY2sgPCBERUZBVUxUX01JTklNVU1fVVNFQUJMRV9TVEFDSykKQEAgLTE5MCw5ICsxOTEs OCBAQCBJbnRlcnByZXRlcjo6U3RhY2tQb2xpY3k6OlN0YWNrUG9saWN5KEludGVycHJldGVyJiBp bnRlcnByZXRlciwgY29uc3QgU3RhY2tCb3VuZAogCiAgICAgLy8gUmUtY29tcHV0ZSB0aGUgcmVx dWlyZWRDYXBhY2l0eSBiYXNlZCBvbiB0aGUgYWRqdXN0ZWQgdXNlYWJsZSBzdGFjawogICAgIC8v IHNpemU6Ci0gICAgLy8gaW50ZXJwcmV0ZXIgc3RhY2sgY2hlY2tzOgogICAgIHJlcXVpcmVkQ2Fw YWNpdHkgPSBzaXplIC0gdXNlYWJsZVN0YWNrOwotICAgIEFTU0VSVCgocmVxdWlyZWRDYXBhY2l0 eSA+PSAwKSAmJiAocmVxdWlyZWRDYXBhY2l0eSA8IHNpemUpKTsKKyAgICBBU1NFUlQocmVxdWly ZWRDYXBhY2l0eSA8IHNpemUpOwogCiAgICAgbV9yZXF1aXJlZENhcGFjaXR5ID0gcmVxdWlyZWRD YXBhY2l0eTsgICAgCiB9Cg==