100068 2012-10-22 20:17:50 -0700 Font’s fast code path is used for partial runs with kerning and ligatures, but shouldn’t be 2012-10-22 22:11:45 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 mitz mitz oldest_to_newest 748219 0 mitz 2012-10-22 20:17:50 -0700 As bug 100050 says, the fast code path doesn’t handle partial runs correctly when kerning or ligatures are enabled, but there is currently nothing stopping it from being used for partial runs. 748226 1 170054 mitz 2012-10-22 20:27:58 -0700 Created attachment 170054 Use the complex path for partial runs with any typesetting features 748272 2 mitz 2012-10-22 22:11:45 -0700 Fixed in <http://trac.webkit.org/r132178>. 170054 2012-10-22 20:27:58 -0700 2012-10-22 20:46:42 -0700 Use the complex path for partial runs with any typesetting features bug-100068-20121022202636.patch text/plain 3786 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjE3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTIyICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgRm9udOKAmXMgZmFzdCBjb2RlIHBh dGggaXMgdXNlZCBmb3IgcGFydGlhbCBydW5zIHdpdGgga2VybmluZyBhbmQgbGlnYXR1cmVzLCBi dXQgc2hvdWxkbuKAmXQgYmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMDA2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFzIGRlc2NyaWJlZCBpbiA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMDAwNTA+LCB0 aGUgZmFzdCBjb2RlIHBhdGggZG9lc27igJl0IGhhbmRsZSBwYXJ0aWFsIHJ1bnMKKyAgICAgICAg Y29ycmVjdGx5IHdoZW4ga2VybmluZyBvciBsaWdhdHVyZXMgYXJlIGVuYWJsZWQuIFNpbmNlIHRo ZSBwYXJ0aWFsLXJ1biBjYXNlIGlzIHVuY29tbW9uLAorICAgICAgICBmb3Igbm93IGp1c3QgdXNl IHRoZSBjb21wbGV4IGNvZGUgcGF0aCBpbiB0aGlzIGNhc2UuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9Gb250LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6OmRyYXdUZXh0KTog Q2hhbmdlZCB0byB1c2UgdGhlIGNvbXBsZXggcGF0aCBmb3IgcGFydGlhbCBydW5zIGlmIHRoZXJl IGFyZSBhbnkKKyAgICAgICAgdHlwZXNldHRpbmcgZmVhdHVyZXMuCisgICAgICAgIChXZWJDb3Jl OjpGb250OjpkcmF3RW1waGFzaXNNYXJrcyk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6Rm9u dDo6c2VsZWN0aW9uUmVjdEZvclRleHQpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6 Om9mZnNldEZvclBvc2l0aW9uKTogQ2hhbmdlZCB0byB1c2UgdGhlIGNvbXBsZXggcGF0aCBpZiB0 aGVyZSBhcmUgYW55CisgICAgICAgIHR5cGVzZXR0aW5nIGZlYXR1cmVzLgorCiAyMDEyLTEwLTIy ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbU2hh ZG93XSBGYWxsYmFjayBjb250ZW50IHNob3VsZCBhbHNvIGJlIHJlcHJvamVjdGlvbi4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCShyZXZpc2lvbiAxMzIx NzQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTU5LDYgKzE1OSw5IEBAIHZvaWQgRm9udDo6ZHJhd1RleHQoR3JhcGhpY3ND b250ZXh0KiBjb24KICAgICB0byA9ICh0byA9PSAtMSA/IHJ1bi5sZW5ndGgoKSA6IHRvKTsKIAog ICAgIENvZGVQYXRoIGNvZGVQYXRoVG9Vc2UgPSBjb2RlUGF0aChydW4pOworICAgIC8vIEZJWE1F OiBVc2UgdGhlIGZhc3QgY29kZSBwYXRoIG9uY2UgaXQgaGFuZGxlcyBwYXJ0aWFsIHJ1bnMgd2l0 aCBrZXJuaW5nIGFuZCBsaWdhdHVyZXMuIFNlZSBodHRwOi8vd2Via2l0Lm9yZy9iLzEwMDA1MAor ICAgIGlmIChjb2RlUGF0aFRvVXNlICE9IENvbXBsZXggJiYgdHlwZXNldHRpbmdGZWF0dXJlcygp ICYmIChmcm9tIHx8IHRvICE9IHJ1bi5sZW5ndGgoKSkpCisgICAgICAgIGNvZGVQYXRoVG9Vc2Ug PSBDb21wbGV4OwogCiAgICAgaWYgKGNvZGVQYXRoVG9Vc2UgIT0gQ29tcGxleCkKICAgICAgICAg cmV0dXJuIGRyYXdTaW1wbGVUZXh0KGNvbnRleHQsIHJ1biwgcG9pbnQsIGZyb20sIHRvKTsKQEAg LTE3NCw3ICsxNzcsMTIgQEAgdm9pZCBGb250OjpkcmF3RW1waGFzaXNNYXJrcyhHcmFwaGljc0Nv bgogICAgIGlmICh0byA8IDApCiAgICAgICAgIHRvID0gcnVuLmxlbmd0aCgpOwogCi0gICAgaWYg KGNvZGVQYXRoKHJ1bikgIT0gQ29tcGxleCkKKyAgICBDb2RlUGF0aCBjb2RlUGF0aFRvVXNlID0g Y29kZVBhdGgocnVuKTsKKyAgICAvLyBGSVhNRTogVXNlIHRoZSBmYXN0IGNvZGUgcGF0aCBvbmNl IGl0IGhhbmRsZXMgcGFydGlhbCBydW5zIHdpdGgga2VybmluZyBhbmQgbGlnYXR1cmVzLiBTZWUg aHR0cDovL3dlYmtpdC5vcmcvYi8xMDAwNTAKKyAgICBpZiAoY29kZVBhdGhUb1VzZSAhPSBDb21w bGV4ICYmIHR5cGVzZXR0aW5nRmVhdHVyZXMoKSAmJiAoZnJvbSB8fCB0byAhPSBydW4ubGVuZ3Ro KCkpKQorICAgICAgICBjb2RlUGF0aFRvVXNlID0gQ29tcGxleDsKKworICAgIGlmIChjb2RlUGF0 aFRvVXNlICE9IENvbXBsZXgpCiAgICAgICAgIGRyYXdFbXBoYXNpc01hcmtzRm9yU2ltcGxlVGV4 dChjb250ZXh0LCBydW4sIG1hcmssIHBvaW50LCBmcm9tLCB0byk7CiAgICAgZWxzZQogICAgICAg ICBkcmF3RW1waGFzaXNNYXJrc0ZvckNvbXBsZXhUZXh0KGNvbnRleHQsIHJ1biwgbWFyaywgcG9p bnQsIGZyb20sIHRvKTsKQEAgLTIzMiw3ICsyNDAsMTIgQEAgRmxvYXRSZWN0IEZvbnQ6OnNlbGVj dGlvblJlY3RGb3JUZXh0KGNvbgogewogICAgIHRvID0gKHRvID09IC0xID8gcnVuLmxlbmd0aCgp IDogdG8pOwogCi0gICAgaWYgKGNvZGVQYXRoKHJ1bikgIT0gQ29tcGxleCkKKyAgICBDb2RlUGF0 aCBjb2RlUGF0aFRvVXNlID0gY29kZVBhdGgocnVuKTsKKyAgICAvLyBGSVhNRTogVXNlIHRoZSBm YXN0IGNvZGUgcGF0aCBvbmNlIGl0IGhhbmRsZXMgcGFydGlhbCBydW5zIHdpdGgga2VybmluZyBh bmQgbGlnYXR1cmVzLiBTZWUgaHR0cDovL3dlYmtpdC5vcmcvYi8xMDAwNTAKKyAgICBpZiAoY29k ZVBhdGhUb1VzZSAhPSBDb21wbGV4ICYmIHR5cGVzZXR0aW5nRmVhdHVyZXMoKSAmJiAoZnJvbSB8 fCB0byAhPSBydW4ubGVuZ3RoKCkpKQorICAgICAgICBjb2RlUGF0aFRvVXNlID0gQ29tcGxleDsK KworICAgIGlmIChjb2RlUGF0aFRvVXNlICE9IENvbXBsZXgpCiAgICAgICAgIHJldHVybiBzZWxl Y3Rpb25SZWN0Rm9yU2ltcGxlVGV4dChydW4sIHBvaW50LCBoLCBmcm9tLCB0byk7CiAKICAgICBy ZXR1cm4gc2VsZWN0aW9uUmVjdEZvckNvbXBsZXhUZXh0KHJ1biwgcG9pbnQsIGgsIGZyb20sIHRv KTsKQEAgLTI0MCw3ICsyNTMsOCBAQCBGbG9hdFJlY3QgRm9udDo6c2VsZWN0aW9uUmVjdEZvclRl eHQoY29uCiAKIGludCBGb250OjpvZmZzZXRGb3JQb3NpdGlvbihjb25zdCBUZXh0UnVuJiBydW4s IGZsb2F0IHgsIGJvb2wgaW5jbHVkZVBhcnRpYWxHbHlwaHMpIGNvbnN0CiB7Ci0gICAgaWYgKGNv ZGVQYXRoKHJ1bikgIT0gQ29tcGxleCkKKyAgICAvLyBGSVhNRTogVXNlIHRoZSBmYXN0IGNvZGUg cGF0aCBvbmNlIGl0IGhhbmRsZXMgcGFydGlhbCBydW5zIHdpdGgga2VybmluZyBhbmQgbGlnYXR1 cmVzLiBTZWUgaHR0cDovL3dlYmtpdC5vcmcvYi8xMDAwNTAKKyAgICBpZiAoY29kZVBhdGgocnVu KSAhPSBDb21wbGV4ICYmICF0eXBlc2V0dGluZ0ZlYXR1cmVzKCkpCiAgICAgICAgIHJldHVybiBv ZmZzZXRGb3JQb3NpdGlvbkZvclNpbXBsZVRleHQocnVuLCB4LCBpbmNsdWRlUGFydGlhbEdseXBo cyk7CiAKICAgICByZXR1cm4gb2Zmc2V0Rm9yUG9zaXRpb25Gb3JDb21wbGV4VGV4dChydW4sIHgs IGluY2x1ZGVQYXJ0aWFsR2x5cGhzKTsK