100056 2012-10-22 16:57:11 -0700 Handle ArgumentCoder template specializations that take the ArgumentEncoder as a reference 2012-10-23 02:26:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100094 1 andersca andersca ossy webkit.review.bot oldest_to_newest 748093 0 andersca 2012-10-22 16:57:11 -0700 Handle ArgumentCoder template specializations that take the ArgumentCoder as a reference 748097 1 170028 andersca 2012-10-22 16:59:24 -0700 Created attachment 170028 Patch 748104 2 webkit.review.bot 2012-10-22 17:04:34 -0700 Attachment 170028 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h:68: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 748135 3 170028 kling 2012-10-22 17:51:55 -0700 Comment on attachment 170028 Patch r=me. 748142 4 170028 webkit.review.bot 2012-10-22 17:58:24 -0700 Comment on attachment 170028 Patch Clearing flags on attachment: 170028 Committed r132169: <http://trac.webkit.org/changeset/132169> 748143 5 webkit.review.bot 2012-10-22 17:58:27 -0700 All reviewed patches have been landed. Closing bug. 748408 6 ossy 2012-10-23 02:26:31 -0700 (In reply to comment #4) > (From update of attachment 170028 [details]) > Clearing flags on attachment: 170028 > > Committed r132169: <http://trac.webkit.org/changeset/132169> It caused a regression - https://bugs.webkit.org/show_bug.cgi?id=100094 Could you fix it, please? 170028 2012-10-22 16:59:24 -0700 2012-10-22 17:58:24 -0700 Patch bug-100056-20121022165806.patch text/plain 7379 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjczZTIwODVlNGM1NDY1 NGI4NmRkYWJmZTdhOTIwNmQyZWVjZTdjYS4uNDk2OTQzODk3M2MwMTgzNWVkYWZmMzA2ZGQ2NTNk OTQ0NWEyMTY4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEwLTIyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgSGFuZGxlIEFyZ3Vt ZW50Q29kZXIgdGVtcGxhdGUgc3BlY2lhbGl6YXRpb25zIHRoYXQgdGFrZSB0aGUgQXJndW1lbnRF bmNvZGVyIGFzIGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDAwNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVc2UgdGVtcGxhdGUgbWFnaWMgdG8gbWFrZSBpdCBwb3NzaWJsZSB0byBo YXZlIEFyZ3VtZW50Q29kZXIgc3BlY2lhbGl6YXRpb25zIHdoZXJlIHRoZSBlbmNvZGUKKyAgICAg ICAgZnVuY3Rpb24gdGFrZXMgdGhlIEFyZ3VtZW50RW5jb2RlciBvYmplY3QgYXMgYSByZWZlcmVu Y2UgaW5zdGVhZCBvZiBhcyBhIHBvaW50ZXIuIEFsc28sIGFkZCBhbgorICAgICAgICBvcGVyYXRv cjw8IHRvIEFyZ3VtZW50RW5jb2RlciBhbmQgY2hhbmdlIHRoZSBzdHJpbmcgcmVsYXRlZCBBcmd1 bWVudENvZGVyIHNwZWNpYWxpemF0aW9ucyBvdmVyIHRvIHRha2luZworICAgICAgICB0aGUgZW5j b2RlciBhcyBhIHJlZmVyZW5jZSBhbmQgdXNpbmcgc3RyZWFtIG9wZXJhdG9ycy4KKworICAgICAg ICAqIFBsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRDb2RlcnMuY3BwOgorICAgICAgICAoQ29yZUlQ Qzo6OjplbmNvZGUpOgorICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRDb2RlcnMu aDoKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5oOgorICAgICAg ICAoQXJndW1lbnRFbmNvZGVyKToKKyAgICAgICAgKFVzZXNEZXByZWNhdGVkRW5jb2RlRnVuY3Rp b24pOgorICAgICAgICAoTm9UeXBlKToKKyAgICAgICAgKENvcmVJUEM6OkFyZ3VtZW50RW5jb2Rl cjo6ZW5jb2RlKToKKyAgICAgICAgKENvcmVJUEM6OkFyZ3VtZW50RW5jb2Rlcjo6b3BlcmF0b3I8 PCk6CisKIDIwMTItMTAtMjIgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVu aUBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBld2tfdmlld19jb2xvcl9waWNrZXJf Y29sb3Jfc2V0KCkgaXMgbGVha2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZv cm0vQ29yZUlQQy9Bcmd1bWVudENvZGVycy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9D b3JlSVBDL0FyZ3VtZW50Q29kZXJzLmNwcAppbmRleCBmMGMxN2QzOGU4ZTM4MzAzMDJlODYyZjZh ZWQ1ZTJkYjE4MmQwNDlkLi43MTUzYzI3NDgxZWIyYzVmNDdhMzBiMGJiOGFkYWYzYTU0ZDA4ZTg5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50Q29k ZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50Q29k ZXJzLmNwcApAQCAtMjYsMTQgKzI2LDE1IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVk ZSAiQXJndW1lbnRDb2RlcnMuaCIKIAorI2luY2x1ZGUgIkRhdGFSZWZlcmVuY2UuaCIKICNpbmNs dWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+ CiAKIG5hbWVzcGFjZSBDb3JlSVBDIHsKIAotdm9pZCBBcmd1bWVudENvZGVyPEF0b21pY1N0cmlu Zz46OmVuY29kZShBcmd1bWVudEVuY29kZXIqIGVuY29kZXIsIGNvbnN0IEF0b21pY1N0cmluZyYg YXRvbWljU3RyaW5nKQordm9pZCBBcmd1bWVudENvZGVyPEF0b21pY1N0cmluZz46OmVuY29kZShB cmd1bWVudEVuY29kZXImIGVuY29kZXIsIGNvbnN0IEF0b21pY1N0cmluZyYgYXRvbWljU3RyaW5n KQogewotICAgIGVuY29kZXItPmVuY29kZShhdG9taWNTdHJpbmcuc3RyaW5nKCkpOworICAgIGVu Y29kZXIgPDwgYXRvbWljU3RyaW5nLnN0cmluZygpOwogfQogCiBib29sIEFyZ3VtZW50Q29kZXI8 QXRvbWljU3RyaW5nPjo6ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciogZGVjb2RlciwgQXRvbWljU3Ry aW5nJiBhdG9taWNTdHJpbmcpCkBAIC00NiwxNyArNDcsMTYgQEAgYm9vbCBBcmd1bWVudENvZGVy PEF0b21pY1N0cmluZz46OmRlY29kZShBcmd1bWVudERlY29kZXIqIGRlY29kZXIsIEF0b21pY1N0 cmluZyYKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotdm9pZCBBcmd1bWVudENvZGVyPENTdHJpbmc+ OjplbmNvZGUoQXJndW1lbnRFbmNvZGVyKiBlbmNvZGVyLCBjb25zdCBDU3RyaW5nJiBzdHJpbmcp Cit2b2lkIEFyZ3VtZW50Q29kZXI8Q1N0cmluZz46OmVuY29kZShBcmd1bWVudEVuY29kZXImIGVu Y29kZXIsIGNvbnN0IENTdHJpbmcmIHN0cmluZykKIHsKICAgICAvLyBTcGVjaWFsIGNhc2UgdGhl IG51bGwgc3RyaW5nLgogICAgIGlmIChzdHJpbmcuaXNOdWxsKCkpIHsKLSAgICAgICAgZW5jb2Rl ci0+ZW5jb2RlKHN0ZDo6bnVtZXJpY19saW1pdHM8dWludDMyX3Q+OjptYXgoKSk7CisgICAgICAg IGVuY29kZXIgPDwgc3RkOjpudW1lcmljX2xpbWl0czx1aW50MzJfdD46Om1heCgpOwogICAgICAg ICByZXR1cm47CiAgICAgfQogCiAgICAgdWludDMyX3QgbGVuZ3RoID0gc3RyaW5nLmxlbmd0aCgp OwotICAgIGVuY29kZXItPmVuY29kZShsZW5ndGgpOwotICAgIGVuY29kZXItPmVuY29kZUZpeGVk TGVuZ3RoRGF0YShyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3QqPihzdHJpbmcuZGF0YSgp KSwgbGVuZ3RoLCAxKTsKKyAgICBlbmNvZGVyIDw8IGxlbmd0aCA8PCBDb3JlSVBDOjpEYXRhUmVm ZXJlbmNlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KHN0cmluZy5kYXRhKCkpLCBs ZW5ndGgpOwogfQogCiBib29sIEFyZ3VtZW50Q29kZXI8Q1N0cmluZz46OmRlY29kZShBcmd1bWVu dERlY29kZXIqIGRlY29kZXIsIENTdHJpbmcmIHJlc3VsdCkKQEAgLTg3LDIyICs4NywyMyBAQCBi b29sIEFyZ3VtZW50Q29kZXI8Q1N0cmluZz46OmRlY29kZShBcmd1bWVudERlY29kZXIqIGRlY29k ZXIsIENTdHJpbmcmIHJlc3VsdCkKIH0KIAogCi12b2lkIEFyZ3VtZW50Q29kZXI8U3RyaW5nPjo6 ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciogZW5jb2RlciwgY29uc3QgU3RyaW5nJiBzdHJpbmcpCit2 b2lkIEFyZ3VtZW50Q29kZXI8U3RyaW5nPjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYgZW5jb2Rl ciwgY29uc3QgU3RyaW5nJiBzdHJpbmcpCiB7CiAgICAgLy8gU3BlY2lhbCBjYXNlIHRoZSBudWxs IHN0cmluZy4KICAgICBpZiAoc3RyaW5nLmlzTnVsbCgpKSB7Ci0gICAgICAgIGVuY29kZXItPmVu Y29kZShzdGQ6Om51bWVyaWNfbGltaXRzPHVpbnQzMl90Pjo6bWF4KCkpOworICAgICAgICBlbmNv ZGVyIDw8IHN0ZDo6bnVtZXJpY19saW1pdHM8dWludDMyX3Q+OjptYXgoKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAogICAgIHVpbnQzMl90IGxlbmd0aCA9IHN0cmluZy5sZW5ndGgoKTsKLSAg ICBlbmNvZGVyLT5lbmNvZGUobGVuZ3RoKTsKICAgICBib29sIGlzOEJpdCA9IHN0cmluZy5pczhC aXQoKTsKLSAgICBlbmNvZGVyLT5lbmNvZGUoaXM4Qml0KTsKKworICAgIGVuY29kZXIgPDwgbGVu Z3RoIDw8IGlzOEJpdDsKKwogICAgIGlmIChpczhCaXQpCi0gICAgICAgIGVuY29kZXItPmVuY29k ZUZpeGVkTGVuZ3RoRGF0YShyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3QqPihzdHJpbmcu Y2hhcmFjdGVyczgoKSksIGxlbmd0aCAqIHNpemVvZihMQ2hhciksIF9fYWxpZ25vZihMQ2hhcikp OworICAgICAgICBlbmNvZGVyLmVuY29kZUZpeGVkTGVuZ3RoRGF0YShyZWludGVycHJldF9jYXN0 PGNvbnN0IHVpbnQ4X3QqPihzdHJpbmcuY2hhcmFjdGVyczgoKSksIGxlbmd0aCAqIHNpemVvZihM Q2hhciksIF9fYWxpZ25vZihMQ2hhcikpOwogICAgIGVsc2UKLSAgICAgICAgZW5jb2Rlci0+ZW5j b2RlRml4ZWRMZW5ndGhEYXRhKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KHN0cmlu Zy5jaGFyYWN0ZXJzMTYoKSksIGxlbmd0aCAqIHNpemVvZihVQ2hhciksIF9fYWxpZ25vZihVQ2hh cikpOworICAgICAgICBlbmNvZGVyLmVuY29kZUZpeGVkTGVuZ3RoRGF0YShyZWludGVycHJldF9j YXN0PGNvbnN0IHVpbnQ4X3QqPihzdHJpbmcuY2hhcmFjdGVyczE2KCkpLCBsZW5ndGggKiBzaXpl b2YoVUNoYXIpLCBfX2FsaWdub2YoVUNoYXIpKTsKIH0KIAogdGVtcGxhdGUgPHR5cGVuYW1lIENo YXJhY3RlclR5cGU+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBD L0FyZ3VtZW50Q29kZXJzLmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3Vt ZW50Q29kZXJzLmgKaW5kZXggZjE2ZDdjOTJmNDU1NWMwNzNjYjVhMDdjNWVhNmMxZDJkOWYyMGIx Mi4uZDc0NmIwMzJhMWE2MzMyNGRiM2UzOGUzMzNjMTg2OGEzZTI5MTNjMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudENvZGVycy5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRDb2RlcnMuaApAQCAtMTk3LDE3 ICsxOTcsMTcgQEAgdGVtcGxhdGU8dHlwZW5hbWUgS2V5QXJnLCB0eXBlbmFtZSBNYXBwZWRBcmcs IHR5cGVuYW1lIEhhc2hBcmcsIHR5cGVuYW1lIEtleVRyYWkKIH07CiAKIHRlbXBsYXRlPD4gc3Ry dWN0IEFyZ3VtZW50Q29kZXI8QXRvbWljU3RyaW5nPiB7Ci0gICAgc3RhdGljIHZvaWQgZW5jb2Rl KEFyZ3VtZW50RW5jb2RlciosIGNvbnN0IEF0b21pY1N0cmluZyYpOworICAgIHN0YXRpYyB2b2lk IGVuY29kZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBBdG9taWNTdHJpbmcmKTsKICAgICBzdGF0 aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyKiwgQXRvbWljU3RyaW5nJik7CiB9OwogCiB0 ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPENTdHJpbmc+IHsKLSAgICBzdGF0aWMgdm9p ZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyKiwgY29uc3QgQ1N0cmluZyYpOworICAgIHN0YXRpYyB2 b2lkIGVuY29kZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBDU3RyaW5nJik7CiAgICAgc3RhdGlj IGJvb2wgZGVjb2RlKEFyZ3VtZW50RGVjb2RlciosIENTdHJpbmcmKTsKIH07CiAKIHRlbXBsYXRl PD4gc3RydWN0IEFyZ3VtZW50Q29kZXI8U3RyaW5nPiB7Ci0gICAgc3RhdGljIHZvaWQgZW5jb2Rl KEFyZ3VtZW50RW5jb2RlciosIGNvbnN0IFN0cmluZyYpOworICAgIHN0YXRpYyB2b2lkIGVuY29k ZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBTdHJpbmcmKTsKICAgICBzdGF0aWMgYm9vbCBkZWNv ZGUoQXJndW1lbnREZWNvZGVyKiwgU3RyaW5nJik7CiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5oIGIvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudEVuY29kZXIuaAppbmRleCA1NDc4MDEzNGEzM2Ez MTNjNzIxMTZiYTMyZmQ0ZWE5N2Y0NmI4ZGUwLi41ZmEwMDZmZDMzODg4NTU1Njg1NmE4ZmVkMTQ2 OWZmNDNkNjUwNmFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBD L0FyZ3VtZW50RW5jb2Rlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMv QXJndW1lbnRFbmNvZGVyLmgKQEAgLTYwLDEzICs2MCw0NCBAQCBwdWJsaWM6CiAKICAgICAgICAg ZW5jb2RlKHN0YXRpY19jYXN0PHVpbnQ2NF90Pih0KSk7CiAgICAgfQorCisgICAgdGVtcGxhdGU8 Ym9vbCBCLCB0eXBlbmFtZSBUID0gdm9pZD4KKyAgICBzdHJ1Y3QgRW5hYmxlSWYgeyB9OworCisg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KKyAgICBzdHJ1Y3QgRW5hYmxlSWY8dHJ1ZSwgVD4geyB0 eXBlZGVmIFQgVHlwZTsgfTsKICAgICAKLSAgICAvLyBHZW5lcmljIHR5cGUgZW5jb2RlIGZ1bmN0 aW9uLgotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHZvaWQgZW5jb2RlKGNvbnN0IFQmIHQpCisg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gY2xhc3MgVXNlc0RlcHJlY2F0ZWRFbmNvZGVGdW5jdGlv biB7CisgICAgICAgIHR5cGVkZWYgY2hhciBZZXNUeXBlOworICAgICAgICBzdHJ1Y3QgTm9UeXBl IHsKKyAgICAgICAgICAgIGNoYXIgcGFkZGluZ1s4XTsKKyAgICAgICAgfTsKKworICAgICAgICBz dGF0aWMgWWVzVHlwZSBjaGVja0VuY29kZSh2b2lkICgqKShBcmd1bWVudEVuY29kZXIqLCBjb25z dCBUJikpOworICAgICAgICBzdGF0aWMgTm9UeXBlIGNoZWNrRW5jb2RlKC4uLik7CisKKyAgICBw dWJsaWM6CisgICAgICAgIHN0YXRpYyBjb25zdCBib29sIHZhbHVlID0gc2l6ZW9mKGNoZWNrRW5j b2RlKEFyZ3VtZW50Q29kZXI8VD46OmVuY29kZSkpID09IHNpemVvZihZZXNUeXBlKTsKKyAgICB9 OworCisgICAgLy8gRklYTUU6IFRoaXMgaXMgdGhlIGZ1bmN0aW9uIHRoYXQgZ2V0cyBjaG9zZW4g aWYgdGhlIGFyZ3VtZW50IGNvZGVyIHRha2VzIHRoZSBBcmd1bWVudEVuY29kZXIgYXMgYSBwb2lu dGVyLgorICAgIC8vIFRoaXMgaXMgdGhlIGRlcHJlY2F0ZWQgZm9ybSAtIGdldCByaWQgb2YgaXQu CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gdm9pZCBlbmNvZGUoY29uc3QgVCYgdCwgdHlwZW5h bWUgRW5hYmxlSWY8VXNlc0RlcHJlY2F0ZWRFbmNvZGVGdW5jdGlvbjxUPjo6dmFsdWU+OjpUeXBl KiA9IDApCiAgICAgewogICAgICAgICBBcmd1bWVudENvZGVyPFQ+OjplbmNvZGUodGhpcywgdCk7 CiAgICAgfQogCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gdm9pZCBlbmNvZGUoY29uc3QgVCYg dCwgdHlwZW5hbWUgRW5hYmxlSWY8IVVzZXNEZXByZWNhdGVkRW5jb2RlRnVuY3Rpb248VD46OnZh bHVlPjo6VHlwZSogPSAwKQorICAgIHsKKyAgICAgICAgQXJndW1lbnRDb2RlcjxUPjo6ZW5jb2Rl KCp0aGlzLCB0KTsKKyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBBcmd1bWVudEVu Y29kZXImIG9wZXJhdG9yPDwoY29uc3QgVCYgdCkKKyAgICB7CisgICAgICAgIGVuY29kZSh0KTsK KyAgICAgICAgcmV0dXJuICp0aGlzOworICAgIH0KKwogICAgIHVpbnQ4X3QqIGJ1ZmZlcigpIGNv bnN0IHsgcmV0dXJuIG1fYnVmZmVyOyB9CiAgICAgc2l6ZV90IGJ1ZmZlclNpemUoKSBjb25zdCB7 IHJldHVybiBtX2J1ZmZlclNpemU7IH0KIAo=