Attachment 373772 Details for Bug 199636 – Patch

[patch] Patch

bug-199636-20190710000624.patch (text/plain), 4.61 KB, created by Tadeu Zagallo on 2019-07-09 15:06:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tadeu Zagallo

Created: 2019-07-09 15:06:25 PDT

Size: 4.61 KB

patch

obsolete

>Subversion Revision: 247166
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index e903e4fd97709af5acd3934d319f42049f6f6196..0d65bc573ffdbb52c9e5982385abd49de03ae18b 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,32 @@
>+2019-07-09  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        Optimize join of large empty arrays
>+        https://bugs.webkit.org/show_bug.cgi?id=199636
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Replicate the behavior of `str.repeat(count)` when performing `new Array(count + 1).join(str)`.
>+        I added two new microbenchmarks:
>+        - large-empty-array-join, which does not use the result of the join and runs ~44x faster and uses ~18x less memory.
>+        - large-empty-array-join-resolve-rope, which uses the result of the join and runs 2x faster.
>+
>+                                                    baseline                    diff
>+        large-empty-array-join                2713.9698+-72.7621    ^     61.2335+-10.4836       ^ definitely 44.3217x faster
>+        large-empty-array-join-resolve-string   26.5517+-0.3995     ^     12.9309+-0.5516        ^ definitely 2.0533x faster
>+
>+        large-empty-array-join memory usage with baseline (dirty):
>+            733012 kB current_mem
>+            756824 kB lifetime_peak
>+
>+        large-empty-array-join memory usage with diff (dirty):
>+            41904 kB current_mem
>+            41972 kB lifetime_peak
>+
>+        Additionally, I ran JetStream2, sunspider and v8-spider and all were neutral.
>+
>+        * runtime/ArrayPrototype.cpp:
>+        (JSC::fastJoin):
>+
> 2019-07-05  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         Unreviewed, change the value used to scribble Heap::m_worldState
>diff --git a/Source/JavaScriptCore/runtime/ArrayPrototype.cpp b/Source/JavaScriptCore/runtime/ArrayPrototype.cpp
>index 7f0fc37dab699bd01f73f32b5822cba4d090e86d..8a424fb190b8a69777184835d98f7af6d920f99f 100644
>--- a/Source/JavaScriptCore/runtime/ArrayPrototype.cpp
>+++ b/Source/JavaScriptCore/runtime/ArrayPrototype.cpp
>@@ -516,6 +516,25 @@ inline JSValue fastJoin(ExecState& state, JSObject* thisObject, StringView separ
>             if (separator.is8Bit())
>                 RELEASE_AND_RETURN(scope, repeatCharacter(state, separator.characters8()[0], length - 1));
>             RELEASE_AND_RETURN(scope, repeatCharacter(state, separator.characters16()[0], length - 1));
>+        default:
>+            JSString* result = jsEmptyString(&state);
>+            if (!length)
>+                return result;
>+
>+            JSString* operand = jsString(&vm, separator.toString());
>+            RETURN_IF_EXCEPTION(scope, { });
>+            unsigned count = length - 1;
>+            for (;;) {
>+                if (count & 1) {
>+                    result = jsString(&state, result, operand);
>+                    RETURN_IF_EXCEPTION(scope, { });
>+                }
>+                count >>= 1;
>+                if (!count)
>+                    return result;
>+                operand = jsString(&state, operand, operand);
>+                RETURN_IF_EXCEPTION(scope, { });
>+            }
>         }
>         }
>     }
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index c6d1889cbef5fd572fdbab9916559e3c80163af4..05f6a219eecca4c556e671b0d7f6be83154c5a52 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-07-09  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        Optimize join of large empty arrays
>+        https://bugs.webkit.org/show_bug.cgi?id=199636
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * microbenchmarks/large-empty-array-join.js: Added.
>+        * microbenchmarks/large-empty-array-join-resolve-rope.js: Added.
>+
> 2019-07-02  Michael Saboff  <msaboff@apple.com>
> 
>         Exception from For..of loop assignment eliminates TDZ checks in subsequent code
>diff --git a/JSTests/microbenchmarks/large-empty-array-join-resolve-rope.js b/JSTests/microbenchmarks/large-empty-array-join-resolve-rope.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..85cb8e9860df4dd3950ea078fcc12881849a2d3f
>--- /dev/null
>+++ b/JSTests/microbenchmarks/large-empty-array-join-resolve-rope.js
>@@ -0,0 +1,3 @@
>+const array = [];
>+for (let i = 0; i < 100; ++i)
>+    array.push(new Array(1e4).join('â' + i).slice(1));
>diff --git a/JSTests/microbenchmarks/large-empty-array-join.js b/JSTests/microbenchmarks/large-empty-array-join.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..1a2ae07c6419f3c4b7f7ec5dafee9a47115f0a94
>--- /dev/null
>+++ b/JSTests/microbenchmarks/large-empty-array-join.js
>@@ -0,0 +1,3 @@
>+const array = [];
>+for (let i = 0; i < 100; ++i)
>+    array.push(new Array(1e6).join('â' + i));

Actions: View | Formatted Diff | Diff

Attachments on bug 199636: 373745 | 373748 | 373754 | 373755 | 373758 | 373772 | 373824