Attachment 373761 Details for Bug 199476 – Patch for landing

[patch] Patch for landing

bug-199476-20190709140244.patch (text/plain), 1.91 KB, created by Megan Gardner on 2019-07-09 14:02:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2019-07-09 14:02:45 PDT

Size: 1.91 KB

patch

obsolete

>Subversion Revision: 247113
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 13155d474e0853276544b1bdac2949dbfe2de9f3..9e824141609d962eda22d0e512322580db551cc0 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-07-03  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Don't strip out spaces for personalized Autocorrections
>+        https://bugs.webkit.org/show_bug.cgi?id=199476
>+        <rdar://problem/50782015>
>+
>+        Reviewed by Dean Jackson.
>+
>+        When inserting 'autocorrections' that are really predictive
>+        text suggestions based on personal data, we would remove the space
>+        before the suggestion, resulting in incorrect input.
>+        To fix, do not remove a space when the autocorrected text and the text it is 
>+        replacing do not have any length.
>+
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::applyAutocorrectionInternal):
>+
> 2019-07-03  Chris Dumez  <cdumez@apple.com>
> 
>         Fix a couple of thread safety issues in ResourceLoadStatisticsStore
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index e173f5e26634227885ef7775903c79bcff69b755..ff85f35601a72ecc5c882fee092d69c926f1105f 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -2360,7 +2360,7 @@ bool WebPage::applyAutocorrectionInternal(const String& correction, const String
>     frame.selection().setSelectedRange(range.get(), affinity, WebCore::FrameSelection::ShouldCloseTyping::Yes);
>     if (correction.length())
>         frame.editor().insertText(correction, 0, originalText.isEmpty() ? TextEventInputKeyboard : TextEventInputAutocompletion);
>-    else
>+    else if (originalText.length())
>         frame.editor().deleteWithDirection(DirectionBackward, CharacterGranularity, false, true);
>     return true;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 199476: 373427 | 373658 | 373761