Attachment 373739 Details for Bug 199629 – Patch

[patch] Patch

bug-199629-20190709115944.patch (text/plain), 1.86 KB, created by Chris Dumez on 2019-07-09 11:59:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-07-09 11:59:45 PDT

Size: 1.86 KB

patch

obsolete

>Subversion Revision: 247259
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 1ba70fea5d03f0d871b27db18228a6e5d54c5d15..e996c73cafa4740fcb4f933598762437e8c43d4a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-07-09  Chris Dumez  <cdumez@apple.com>
>+
>+        Fix validation of method signature in decodeInvocation()
>+        https://bugs.webkit.org/show_bug.cgi?id=199629
>+        <rdar://problem/52731659>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The decoder was mistakenly assigning remoteMethodSignature to localMethodSignature
>+        before comparing remoteMethodSignature and localMethodSignature, thus making the
>+        check useless.
>+
>+        * Shared/API/Cocoa/WKRemoteObjectCoder.mm:
>+        (decodeInvocation):
>+
> 2019-07-08  Chris Dumez  <cdumez@apple.com>
> 
>         Speculative fix for crashes under LocalStorageDatabaseTracker::databasePath()
>diff --git a/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm b/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm
>index 8a615bb2d1f244b59b1ee01fb14cc3d5ae9ef1ab..c4424f0e1ea49e92e389dd937b075c7cc784a92a 100644
>--- a/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm
>+++ b/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm
>@@ -607,7 +607,6 @@ static NSInvocation *decodeInvocation(WKRemoteObjectDecoder *decoder)
>         [NSException raise:NSInvalidUnarchiveOperationException format:@"Invocation had no type signature"];
> 
>     NSMethodSignature *remoteMethodSignature = [NSMethodSignature signatureWithObjCTypes:typeSignature.UTF8String];
>-    localMethodSignature = remoteMethodSignature;
>     if (![localMethodSignature isEqual:remoteMethodSignature])
>         [NSException raise:NSInvalidUnarchiveOperationException format:@"Local and remote method signatures are not equal for method \"%s\"", selector ? sel_getName(selector) : "(no selector)"];
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199629: 373739