Attachment 373730 Details for Bug 199625 – patch

[patch] patch

bug-199625-20190709192400.patch (text/plain), 3.18 KB, created by Pablo Saavedra on 2019-07-09 10:24:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Pablo Saavedra

Created: 2019-07-09 10:24:02 PDT

Size: 3.18 KB

patch

obsolete

>Subversion Revision: 247258
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 704778621117914aee9e0ded69e4d4d51beae911..310b90cffb90a67cda3ea19009566d8771acd2aa 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-07-09  Pablo Saavedra  <psaavedra@igalia.com>
>+
>+        [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
>+        https://bugs.webkit.org/show_bug.cgi?id=199625
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/CMakeLists.txt:
>+
> 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Do not run unix commands for windows in PrintConfiguration
>diff --git a/Tools/WebKitTestRunner/CMakeLists.txt b/Tools/WebKitTestRunner/CMakeLists.txt
>index b2335b25b4b8d16c8f2b5539a430297c4d7fd10b..bb5f860772824d0c07dfea2987228d29188bf936 100644
>--- a/Tools/WebKitTestRunner/CMakeLists.txt
>+++ b/Tools/WebKitTestRunner/CMakeLists.txt
>@@ -54,10 +54,6 @@ set(WebKitTestRunner_SYSTEM_INCLUDE_DIRECTORIES
> )
> 
> set(WebKitTestRunnerInjectedBundle_SOURCES
>-    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityController.cpp
>-    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityTextMarker.cpp
>-    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityTextMarkerRange.cpp
>-    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityUIElement.cpp
>     ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/EventSendingController.cpp
>     ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/GCController.cpp
>     ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/InjectedBundle.cpp
>@@ -69,17 +65,32 @@ set(WebKitTestRunnerInjectedBundle_SOURCES
>     ${WEBKIT_TESTRUNNER_BINDINGS_DIR}/JSWrapper.cpp
> )
> 
>+if (ACCESSIBILITY)
>+list(APPEND WebKitTestRunnerInjectedBundle_SOURCES
>+    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityController.cpp
>+    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityTextMarker.cpp
>+    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityTextMarkerRange.cpp
>+    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityUIElement.cpp
>+)
>+endif ()
>+
>+
> set(WebKitTestRunnerInjectedBundle_IDL_FILES
>-    "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityController.idl"
>-    "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityTextMarker.idl"
>-    "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityTextMarkerRange.idl"
>-    "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityUIElement.idl"
>     "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/EventSendingController.idl"
>     "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/GCController.idl"
>     "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/TestRunner.idl"
>     "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/TextInputController.idl"
> )
> 
>+if (ACCESSIBILITY)
>+list(APPEND WebKitTestRunnerInjectedBundle_IDL_FILES
>+    "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityController.idl"
>+    "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityTextMarker.idl"
>+    "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityTextMarkerRange.idl"
>+    "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityUIElement.idl"
>+)
>+endif ()
>+
> set(WebKitTestRunner_IDL_FILES
>     "${WEBKIT_TESTRUNNER_UISCRIPTCONTEXT_DIR}/Bindings/UIScriptController.idl"
> )

Actions: View | Formatted Diff | Diff

Attachments on bug 199625: 373730 | 373749 | 373828 | 373848 | 373912 | 373927 | 373936 | 378120 | 381015 | 449417