Attachment 373724 Details for Bug 199622 – Patch

[patch] Patch

bug-199622-20190709093849.patch (text/plain), 2.09 KB, created by youenn fablet on 2019-07-09 09:38:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-07-09 09:38:49 PDT

Size: 2.09 KB

patch

obsolete

>Subversion Revision: 247200
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 00d67c819822465ad60d885484f2bc26b00a8d73..aa50f46cbb869b2ad92a231fda80403c01f00393 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-07-09  Youenn Fablet  <youenn@apple.com>
>+
>+        Revert conditional WebPageProxy check to grant universal file read sandbox upon correct sandbox creation
>+        https://bugs.webkit.org/show_bug.cgi?id=199622
>+        <rdar://problem/52357508>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        On iOS, the sandbox extension to '/' will usually fail, thus the universal file read sandbox is not granted.
>+        This makes WebPageProxy cancel some file:// loads to the application own container.
>+        As a short term fix, go back to previous behavior.
>+        Covered by testing broken app identified in rdar://problem/52357508.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
>+
> 2019-07-08  Youenn Fablet  <youenn@apple.com>
> 
>         XHR CORS requests logged twice in the server
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index e40e4a867fafbff1b43f8b1fff17aaea26b750de..51c9c4bcb6ec48b6d1454feb5477815f05ac1ea5 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -1058,8 +1058,9 @@ void WebPageProxy::maybeInitializeSandboxExtensionHandle(WebProcessProxy& proces
>     // Inspector resources are in a directory with assumed access.
>     ASSERT_WITH_SECURITY_IMPLICATION(!WebKit::isInspectorPage(*this));
> 
>-    if (SandboxExtension::createHandle("/", SandboxExtension::Type::ReadOnly, sandboxExtensionHandle))
>-        willAcquireUniversalFileReadSandboxExtension(process);
>+    // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508.
>+    SandboxExtension::createHandle("/", SandboxExtension::Type::ReadOnly, sandboxExtensionHandle);
>+    willAcquireUniversalFileReadSandboxExtension(process);
> }
> 
> #if !PLATFORM(COCOA)

Actions: View | Formatted Diff | Diff

Attachments on bug 199622: 373724