Attachment 373721 Details for Bug 199605 – Patch for landing

[patch] Patch for landing

windows-print-configuration.patch (text/plain), 2.27 KB, created by Aakash Jain on 2019-07-09 09:13:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-07-09 09:13:08 PDT

Size: 2.27 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 247257)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-07-08  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Do not run unix commands for windows in PrintConfiguration
>+        https://bugs.webkit.org/show_bug.cgi?id=199605
>+
>+        Reviewed by Jonathan Bedard.
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+
> 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 247257)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -1221,11 +1221,9 @@ class PrintConfiguration(steps.ShellSequ
>     flunkOnFailure = False
>     warnOnFailure = False
>     logEnviron = False
>-    command_list_generic = [['hostname'],
>-                    ['df', '-hl'],
>-                    ['date']]
>-    command_list_apple = [['sw_vers'], ['xcodebuild', '-sdk', '-version']]
>-    command_list_linux = [['uname', '-a']]
>+    command_list_generic = [['hostname']]
>+    command_list_apple = [['df', '-hl'], ['date'], ['sw_vers'], ['xcodebuild', '-sdk', '-version']]
>+    command_list_linux = [['df', '-hl'], ['date'], ['uname', '-a']]
>     command_list_win = [[]]  # TODO: add windows specific commands here
> 
>     def __init__(self, **kwargs):
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 247257)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -1832,8 +1832,6 @@ BuildVersion:	17G7024'''),
> 
>         self.expectRemoteCommands(
>             ExpectShell(command=['hostname'], workdir='wkdir', timeout=60, logEnviron=False) + 0,
>-            ExpectShell(command=['df', '-hl'], workdir='wkdir', timeout=60, logEnviron=False) + 0,
>-            ExpectShell(command=['date'], workdir='wkdir', timeout=60, logEnviron=False) + 0,
>         )
>         self.expectOutcome(result=SUCCESS, state_string='Printed configuration')
>         return self.runStep()

Actions: View | Formatted Diff | Diff

Attachments on bug 199605: 373688 | 373721