Attachment 373682 Details for Bug 199597 – Patch

[patch] Patch

bug-199597-20190708172720.patch (text/plain), 3.33 KB, created by Wenson Hsieh on 2019-07-08 17:27:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-07-08 17:27:20 PDT

Size: 3.33 KB

patch

obsolete

>Subversion Revision: 247226
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 6ab8a3f8f1b1dfb35246861635768e08b07d1aae..8c7212e7b80ac8582957b61ae3ca7d3369c1c1ff 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-07-08  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS 13] paste-does-not-fire-promises-while-sanitizing-web-content.html times out when run with multiple iterations
>+        https://bugs.webkit.org/show_bug.cgi?id=199597
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make this test more robust to work around bugs in iOS 13 that currently prevent some single tap gestures from
>+        being recognized, due to conflicts with double tap gesture recognizers.
>+        -   Make both the subframe and editable element taller, so that they're easier to hit.
>+        -   Tap twice when attempting to trigger a paste, in hopes that at least one of the taps will be recognized as a
>+            single click.
>+        -   Make several event listeners one-shot, to prevent the double tap gesture from triggering paste twice.
>+
>+        * editing/pasteboard/paste-does-not-fire-promises-while-sanitizing-web-content.html:
>+
> 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Add test expectations and baselines for Catalina
>diff --git a/LayoutTests/editing/pasteboard/paste-does-not-fire-promises-while-sanitizing-web-content.html b/LayoutTests/editing/pasteboard/paste-does-not-fire-promises-while-sanitizing-web-content.html
>index 08f8272bc02736c2b2116fde6d59bc9777c51f1d..d621707479299d361b391d7e11e91a2c9b03cf96 100644
>--- a/LayoutTests/editing/pasteboard/paste-does-not-fire-promises-while-sanitizing-web-content.html
>+++ b/LayoutTests/editing/pasteboard/paste-does-not-fire-promises-while-sanitizing-web-content.html
>@@ -11,23 +11,28 @@ body {
> 
> #copy {
>     width: 100%;
>-    height: 50px;
>+    height: 100%;
>     border: 1px dashed black;
> }
> 
> #editor {
>     width: 100%;
>-    height: 100px;
>+    height: 200px;
>     border: 1px dashed tomato;
>     text-align: center;
> }
>+
>+iframe {
>+    width: 100%;
>+    height: 200px;
>+}
> </style>
> </head>
> <body>
> <div id="editor" contenteditable></div>
> <iframe id="copy" src="data:text/html,<div id='copy' style='font-size: 40px; text-align: center;'>Click here to copy</div>
>     <script>
>-    copy.addEventListener('mousedown', event => {
>+    document.body.addEventListener('mousedown', event => {
>         getSelection().selectAllChildren(copy);
>         document.execCommand('Copy');
>         getSelection().removeAllRanges();
>@@ -58,6 +63,7 @@ addEventListener("load", async () => {
> 
>     await UIHelper.activateElement(frame);
>     await UIHelper.activateElement(editor);
>+    await UIHelper.activateElement(editor);
>     checkDone();
> });
> 
>@@ -66,18 +72,18 @@ editor.addEventListener("mousedown", event => {
>     Promise.resolve().then(() => textarea.focus());
>     document.execCommand("Paste");
>     event.preventDefault();
>-});
>+}, { "once": true });
> 
> editor.addEventListener("paste", () => {
>     testPassed("Handled paste.");
>     checkDone();
> });
> 
>-editor.addEventListener("focus", () => testPassed("Focused editor."));
>+editor.addEventListener("focus", () => testPassed("Focused editor."), { "once": true });
> textarea.addEventListener("focus", () => {
>     testPassed("Focused textarea.");
>     checkDone();
>-});
>+}, { "once": true });
> </script>
> </body>
> </html>

Actions: View | Formatted Diff | Diff

Attachments on bug 199597: 373682