Attachment 373673 Details for Bug 199593 – Patch

[patch] Patch

bug-199593-20190708182847.patch (text/plain), 4.12 KB, created by Aakash Jain on 2019-07-08 15:28:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-07-08 15:28:48 PDT

Size: 4.12 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 247229)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-07-08  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Enable wincairo queue on new EWS
>+        https://bugs.webkit.org/show_bug.cgi?id=199593
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
>+        * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
>+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
>+        (StatusBubble): Enable wincairo status-bubble.
>+
> 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
> 
>         test-webkitpy: Explicitly use Python 2.7 lldb library
>Index: Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(revision 247229)
>+++ Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(working copy)
>@@ -39,9 +39,9 @@ import ews.config as config
> class StatusBubble(View):
>     # These queue names are from shortname in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/config.json
>     # FIXME: Auto-generate this list https://bugs.webkit.org/show_bug.cgi?id=195640
>-    ALL_QUEUES = ['ios', 'gtk', 'wpe', 'api-ios', 'api-mac', 'bindings', 'ios-sim', 'ios-wk2', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2',
>-                    'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'wincairo']
>-    ENABLED_QUEUES = ['ios', 'gtk', 'wpe', 'api-ios', 'api-mac', 'bindings', 'webkitperl', 'webkitpy']
>+    ALL_QUEUES = ['ios', 'gtk', 'wpe', 'wincairo', 'api-ios', 'api-mac', 'bindings', 'ios-sim', 'ios-wk2', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2',
>+                    'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win']
>+    ENABLED_QUEUES = ['ios', 'gtk', 'wpe', 'wincairo', 'api-ios', 'api-mac', 'bindings', 'webkitperl', 'webkitpy']
>     # FIXME: Auto-generate the queue's trigger relationship
>     QUEUE_TRIGGERS = {
>         'api-ios': 'ios-sim',
>Index: Tools/BuildSlaveSupport/ews-build/config.json
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/config.json	(revision 247229)
>+++ Tools/BuildSlaveSupport/ews-build/config.json	(working copy)
>@@ -455,14 +455,14 @@
>       "name": "try",
>       "port": 5555,
>       "builderNames": ["Bindings-Tests-EWS", "GTK-Webkit2-EWS", "iOS-12-Build-EWS", "iOS-12-Simulator-Build-EWS",
>-                       "macOS-High-Sierra-Release-Build-EWS", "WebKitPerl-Tests-EWS", "WebKitPy-Tests-EWS", "WPE-EWS"]
>+                       "macOS-High-Sierra-Release-Build-EWS", "WebKitPerl-Tests-EWS", "WebKitPy-Tests-EWS", "WPE-EWS", "WinCairo-EWS"]
>     },
>     {
>       "type": "Try_Userpass",
>       "name": "disabled",
>       "port": 5556,
>       "builderNames": ["JSC-Tests-EWS", "iOS-12-Simulator-WK2-Tests-EWS", "macOS-High-Sierra-Release-WK2-Tests-EWS",
>-                       "macOS-High-Sierra-Release-WK1-Tests-EWS", "macOS-High-Sierra-Debug-Build-EWS", "Style-EWS", "WinCairo-EWS", "Windows-EWS"]
>+                       "macOS-High-Sierra-Release-WK1-Tests-EWS", "macOS-High-Sierra-Debug-Build-EWS", "Style-EWS", "Windows-EWS"]
>     },
>     {
>       "type": "Triggerable",
>Index: Tools/BuildSlaveSupport/ews-build/factories.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/factories.py	(revision 247229)
>+++ Tools/BuildSlaveSupport/ews-build/factories.py	(working copy)
>@@ -137,7 +137,10 @@ class WindowsFactory(Factory):
> 
> 
> class WinCairoFactory(Factory):
>-    pass
>+    def __init__(self, platform, configuration=None, architectures=None, triggers=None, additionalArguments=None, **kwargs):
>+        Factory.__init__(self, platform, configuration, architectures, True, triggers, additionalArguments)
>+        self.addStep(KillOldProcesses())
>+        self.addStep(CompileWebKit(skipUpload=True))
> 
> 
> class GTKFactory(Factory):

Actions: View | Formatted Diff | Diff

Attachments on bug 199593: 373673