Attachment 373668 Details for Bug 199553 – Patch

[patch] Patch

bug-199553-20190708150356.patch (text/plain), 9.46 KB, created by Devin Rousso on 2019-07-08 15:03:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-07-08 15:03:57 PDT

Size: 9.46 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 1df39540308c474a657fd4d918c8968189b1f1c8..840618a9476255b18ffcaa6cc75a6145c1931910 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-07-06  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: the "x" in the Exception icon overlaps the border
>+        https://bugs.webkit.org/show_bug.cgi?id=199553
>+
>+        Reviewed by Joseph Pecoraro.
>+
>+        * UserInterface/Images/Exception.svg:
>+        * UserInterface/Images/Function.svg:
>+        * UserInterface/Images/TailDeletedFunction.svg:
>+
> 2019-07-06  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values
>diff --git a/Source/WebInspectorUI/UserInterface/Images/Exception.svg b/Source/WebInspectorUI/UserInterface/Images/Exception.svg
>index 3ab5a42006ba7aea80689902a9d91cbd19d2de27..8a64fad9f102c773cc619d6069ef3dfad59429a7 100644
>--- a/Source/WebInspectorUI/UserInterface/Images/Exception.svg
>+++ b/Source/WebInspectorUI/UserInterface/Images/Exception.svg
>@@ -2,7 +2,7 @@
> 
> <svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 16 16">
>     <path fill="rgb(148, 183, 219)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 Z"/>
>-    <path fill="rgb(106, 136, 170)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 M 13 2 C 13.550781 2 14 2.449219 14 3 L 14 13 C 14 13.550781 13.550781 14 13 14 L 3 14 C 2.449219 14 2 13.550781 2 13 L 2 3 C 2 2.449219 2.449219 2 3 2 L 13 2"/>
>     <path fill="white" d="M 11.460938 9.433594 L 13.074219 7.09375 L 11.421875 7.09375 L 10.988281 7.898438 C 10.859375 8.136719 10.738281 8.378906 10.609375 8.648438 L 10.589844 8.648438 C 10.457031 8.410156 10.328125 8.167969 10.1875 7.917969 L 9.703125 7.09375 L 8 7.09375 L 9.625 9.5 L 8 11.941406 L 8 10.5 L 5.625 10.5 L 5.625 8.582031 L 7.25 8.582031 L 7.25 7.09375 L 5.625 7.09375 L 5.625 5.414062 L 8 5.414062 L 8 4 L 4 4 L 4 12 L 9.636719 12 L 10.097656 11.117188 C 10.21875 10.875 10.347656 10.636719 10.46875 10.375 L 10.496094 10.375 C 10.617188 10.625 10.738281 10.875 10.878906 11.117188 L 11.371094 12 L 13.097656 12 Z"/>
>     <path fill="rgb(113, 146, 184)" d="M 9 3 L 3 3 L 3 13 L 10.242188 13 L 10.503906 12.5 L 10.78125 13 L 14.921875 13 L 13.941406 11.464844 L 12.660156 9.453125 L 13.898438 7.664062 L 14.980469 6.09375 L 10.824219 6.09375 L 10.5625 6.578125 L 10.277344 6.09375 L 9 6.09375 Z M 8 4 L 8 5.414062 L 5.628906 5.414062 L 5.628906 7.09375 L 7.25 7.09375 L 7.25 8.582031 L 5.628906 8.582031 L 5.628906 10.5 L 8 10.5 L 8 11.9375 L 9.625 9.503906 L 8 7.097656 L 8 7.09375 L 9.703125 7.09375 L 10.1875 7.917969 C 10.328125 8.167969 10.457031 8.410156 10.589844 8.648438 L 10.609375 8.648438 C 10.738281 8.378906 10.859375 8.136719 10.988281 7.898438 L 11.421875 7.09375 L 13.074219 7.09375 L 11.460938 9.433594 L 13.097656 12 L 11.371094 12 L 10.878906 11.117188 C 10.738281 10.875 10.617188 10.625 10.496094 10.375 L 10.46875 10.375 C 10.347656 10.636719 10.21875 10.875 10.097656 11.117188 L 9.636719 12 L 4 12 L 4 4 L 8 4"/>
>+    <path fill="rgb(106, 136, 170)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 M 13 2 C 13.550781 2 14 2.449219 14 3 L 14 13 C 14 13.550781 13.550781 14 13 14 L 3 14 C 2.449219 14 2 13.550781 2 13 L 2 3 C 2 2.449219 2.449219 2 3 2 L 13 2"/>
> </svg>
>diff --git a/Source/WebInspectorUI/UserInterface/Images/Function.svg b/Source/WebInspectorUI/UserInterface/Images/Function.svg
>index a0d4bdaf4cb8ba165cea6255ef940bc701da1963..b2a934d6e92c323e9b6b65fb0391c2351240a53e 100644
>--- a/Source/WebInspectorUI/UserInterface/Images/Function.svg
>+++ b/Source/WebInspectorUI/UserInterface/Images/Function.svg
>@@ -2,7 +2,7 @@
> 
> <svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 16 16">
>     <path fill="rgb(165, 202, 164)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 Z"/>
>-    <path fill="rgb(118, 153, 116)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 M 13 2 C 13.550781 2 14 2.449219 14 3 L 14 13 C 14 13.550781 13.550781 14 13 14 L 3 14 C 2.449219 14 2 13.550781 2 13 L 2 3 C 2 2.449219 2.449219 2 3 2 L 13 2"/>
>     <path fill="rgb(128, 166, 126)" d="M 10.503906 2.558594 C 8.164062 2.558594 6.574219 3.742188 5.882812 5.988281 L 4.445312 6 L 3.449219 6.007812 L 3.449219 9 L 5.15625 9 L 4.21875 12.925781 L 3.921875 14.15625 L 7.964844 14.15625 L 8.148438 13.386719 L 9.191406 9 L 11.300781 9 L 11.300781 6 L 9.902344 6 C 10.070312 5.589844 10.296875 5.589844 10.480469 5.589844 C 10.800781 5.589844 11.191406 5.652344 11.644531 5.769531 L 12.796875 6.074219 L 12.898438 4.890625 L 12.996094 3.757812 L 13.078125 2.828125 L 12.15625 2.683594 C 11.636719 2.597656 11.082031 2.558594 10.503906 2.558594 M 10.503906 3.558594 C 11.03125 3.558594 11.53125 3.59375 12 3.667969 L 11.902344 4.804688 C 11.363281 4.660156 10.890625 4.589844 10.480469 4.589844 C 9.605469 4.589844 9.050781 5.101562 8.820312 6.128906 L 8.625 7 L 10.300781 7 L 10.300781 8 L 8.398438 8 L 7.175781 13.15625 L 5.191406 13.15625 L 6.425781 8 L 4.449219 8 L 4.449219 7 L 6.613281 6.984375 L 6.742188 6.617188 C 7.257812 4.578125 8.507812 3.558594 10.503906 3.558594"/>
>     <path fill="white" d="M 5.191406 13.15625 L 6.425781 8 L 4.449219 8 L 4.449219 7 L 6.613281 6.984375 L 6.742188 6.617188 C 7.257812 4.578125 8.507812 3.558594 10.5 3.558594 C 11.03125 3.558594 11.53125 3.59375 12 3.667969 L 11.902344 4.804688 C 11.363281 4.660156 10.890625 4.589844 10.484375 4.589844 C 9.605469 4.589844 9.050781 5.101562 8.820312 6.128906 L 8.625 7 L 10.300781 7 L 10.300781 8 L 8.398438 8 L 7.175781 13.15625 Z"/>
>+    <path fill="rgb(118, 153, 116)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 M 13 2 C 13.550781 2 14 2.449219 14 3 L 14 13 C 14 13.550781 13.550781 14 13 14 L 3 14 C 2.449219 14 2 13.550781 2 13 L 2 3 C 2 2.449219 2.449219 2 3 2 L 13 2"/>
> </svg>
>diff --git a/Source/WebInspectorUI/UserInterface/Images/TailDeletedFunction.svg b/Source/WebInspectorUI/UserInterface/Images/TailDeletedFunction.svg
>index 4633e74c06a72c5dfee0141708f72eaf96c2d3c4..8c44574cbbf999fb965ed2e913d1032fbeb14474 100644
>--- a/Source/WebInspectorUI/UserInterface/Images/TailDeletedFunction.svg
>+++ b/Source/WebInspectorUI/UserInterface/Images/TailDeletedFunction.svg
>@@ -2,7 +2,7 @@
> 
> <svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 16 16">
>     <path fill="rgb(203, 203, 203)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 Z"/>
>-    <path fill="rgb(153, 153, 153)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 M 13 2 C 13.550781 2 14 2.449219 14 3 L 14 13 C 14 13.550781 13.550781 14 13 14 L 3 14 C 2.449219 14 2 13.550781 2 13 L 2 3 C 2 2.449219 2.449219 2 3 2 L 13 2"/>
>     <path fill="rgb(166, 166, 166)" d="M 10.503906 2.558594 C 8.164062 2.558594 6.574219 3.742188 5.882812 5.988281 L 4.445312 6 L 3.449219 6.007812 L 3.449219 9 L 5.15625 9 L 4.21875 12.925781 L 3.921875 14.15625 L 7.964844 14.15625 L 8.148438 13.386719 L 9.191406 9 L 11.300781 9 L 11.300781 6 L 9.902344 6 C 10.070312 5.589844 10.296875 5.589844 10.480469 5.589844 C 10.800781 5.589844 11.191406 5.652344 11.644531 5.769531 L 12.796875 6.074219 L 12.898438 4.890625 L 12.996094 3.757812 L 13.078125 2.828125 L 12.15625 2.683594 C 11.636719 2.597656 11.082031 2.558594 10.503906 2.558594 M 10.503906 3.558594 C 11.03125 3.558594 11.53125 3.59375 12 3.667969 L 11.902344 4.804688 C 11.363281 4.660156 10.890625 4.589844 10.480469 4.589844 C 9.605469 4.589844 9.050781 5.101562 8.820312 6.128906 L 8.625 7 L 10.300781 7 L 10.300781 8 L 8.398438 8 L 7.175781 13.15625 L 5.191406 13.15625 L 6.425781 8 L 4.449219 8 L 4.449219 7 L 6.613281 6.984375 L 6.742188 6.617188 C 7.257812 4.578125 8.507812 3.558594 10.503906 3.558594"/>
>     <path fill="white" d="M 5.191406 13.15625 L 6.425781 8 L 4.449219 8 L 4.449219 7 L 6.613281 6.984375 L 6.742188 6.617188 C 7.257812 4.578125 8.507812 3.558594 10.5 3.558594 C 11.03125 3.558594 11.53125 3.59375 12 3.667969 L 11.902344 4.804688 C 11.363281 4.660156 10.890625 4.589844 10.484375 4.589844 C 9.605469 4.589844 9.050781 5.101562 8.820312 6.128906 L 8.625 7 L 10.300781 7 L 10.300781 8 L 8.398438 8 L 7.175781 13.15625 Z"/>
>+    <path fill="rgb(153, 153, 153)" d="M 13 1 L 3 1 C 1.898438 1 1 1.898438 1 3 L 1 13 C 1 14.101562 1.898438 15 3 15 L 13 15 C 14.101562 15 15 14.101562 15 13 L 15 3 C 15 1.898438 14.101562 1 13 1 M 13 2 C 13.550781 2 14 2.449219 14 3 L 14 13 C 14 13.550781 13.550781 14 13 14 L 3 14 C 2.449219 14 2 13.550781 2 13 L 2 3 C 2 2.449219 2.449219 2 3 2 L 13 2"/>
> </svg>

Actions: View | Formatted Diff | Diff

Attachments on bug 199553: 373570 | 373573 | 373668