Attachment 373653 Details for Bug 199488 – Patch

[patch] Patch

bug-199488-20190708120525.patch (text/plain), 2.02 KB, created by Tim Horton on 2019-07-08 12:05:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2019-07-08 12:05:26 PDT

Size: 2.02 KB

patch

obsolete

>Subversion Revision: 247100
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c81df1f881583d617bcbe7e56a7e2fd8502cb30c..998b0ba072984d5b4a5f68034b8cc37274958343 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-07-08  Tim Horton  <timothy_horton@apple.com>
>+
>+        WKWebView fails to render when another view uses CoreImage filters
>+        https://bugs.webkit.org/show_bug.cgi?id=199488
>+        <rdar://problem/52695825>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::layerHostingModeDidChange):
>+        Update m_layerHostingMode when it changes, even if we can't message
>+        the Web Content process. This ensures that the next time we launch
>+        a Web Content process, WebPageCreationParameters will have the correct
>+        layer hosting mode, and is the usual pattern for such things.
>+
> 2019-07-03  Zalan Bujtas  <zalan@apple.com>
> 
>         [ContentChangeObserver] REGRESSION (r244356): Drop down menus collapse without user input - Ebay.com
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index 0635a6d0be7e5793da06e03a1ef4a68a50ec7266..f773674b04c0bef3c4b33389e052e4da4c3106d7 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -1858,15 +1858,14 @@ void WebPageProxy::updateHiddenPageThrottlingAutoIncreases()
> 
> void WebPageProxy::layerHostingModeDidChange()
> {
>-    if (!hasRunningProcess())
>-        return;
>-
>     LayerHostingMode layerHostingMode = pageClient().viewLayerHostingMode();
>     if (m_layerHostingMode == layerHostingMode)
>         return;
> 
>     m_layerHostingMode = layerHostingMode;
>-    m_process->send(Messages::WebPage::SetLayerHostingMode(layerHostingMode), m_pageID);
>+
>+    if (hasRunningProcess())
>+        m_process->send(Messages::WebPage::SetLayerHostingMode(layerHostingMode), m_pageID);
> }
> 
> void WebPageProxy::waitForDidUpdateActivityState(ActivityStateChangeID activityStateChangeID)

Actions: View | Formatted Diff | Diff

Attachments on bug 199488: 373653