Attachment 373650 Details for Bug 199582 – Patch

[patch] Patch

bug-199582-20190708114021.patch (text/plain), 3.81 KB, created by Devin Rousso on 2019-07-08 11:40:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-07-08 11:40:21 PDT

Size: 3.81 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 1df39540308c474a657fd4d918c8968189b1f1c8..fa7708223fde4732193b63bf4fb0c67d65a7d3fc 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-07-08  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Timelines: CPU: the Duration string isn't localized
>+        https://bugs.webkit.org/show_bug.cgi?id=199582
>+        <rdar://problem/51698165>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/CPUTimelineView.js:
>+        (WI.CPUTimelineView.prototype._layoutEnergyChart):
>+
>+        * Localizations/en.lproj/localizedStrings.js:
>+
> 2019-07-06  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index 224d44958befdad9b49f675c90ba624d3a9b7331..20fb76acbc735a4a3a6709e162b79d27951a7533 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -361,7 +361,9 @@ localizedStrings["Dropped Element"] = "Dropped Element";
> localizedStrings["Dropped Node"] = "Dropped Node";
> localizedStrings["Duplicate property"] = "Duplicate property";
> localizedStrings["Duration"] = "Duration";
>-localizedStrings["Duration: %s"] = "Duration: %s";
>+/* The duration of the Timeline recording in seconds (s). */
>+localizedStrings["Duration: %ss"] = "Duration: %ss";
>+localizedStrings["Duration: Short"] = "Duration: Short";
> localizedStrings["Dynamically calculated for the parent element"] = "Dynamically calculated for the parent element";
> localizedStrings["Dynamically calculated for the selected element"] = "Dynamically calculated for the selected element";
> localizedStrings["Dynamically calculated for the selected element and did not match"] = "Dynamically calculated for the selected element and did not match";
>@@ -962,7 +964,6 @@ localizedStrings["Shader Programs"] = "Shader Programs";
> localizedStrings["Shadow Content"] = "Shadow Content";
> localizedStrings["Shadow Content (%s)"] = "Shadow Content (%s)";
> localizedStrings["Shared Focus"] = "Shared Focus";
>-localizedStrings["Short"] = "Short";
> localizedStrings["Shortest property path to %s"] = "Shortest property path to %s";
> localizedStrings["Show %d More"] = "Show %d More";
> localizedStrings["Show All"] = "Show All";
>diff --git a/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js b/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js
>index 0c6b54909a0ebdfefba76c7e53119d6d18b69b18..f746454f60ebfad07b58d52937e07671a12f4813 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js
>@@ -1136,10 +1136,10 @@ WI.CPUTimelineView = class CPUTimelineView extends WI.TimelineView
>         this._energyImpactNumberElement.textContent = WI.UIString("Average CPU: %s").format(Number.percentageString(average / 100));
> 
>         if (visibleDuration < 5)
>-            this._energyImpactDurationElement.textContent = WI.UIString("Duration: %s").format(WI.UIString("Short"));
>+            this._energyImpactDurationElement.textContent = WI.UIString("Duration: Short");
>         else {
>-            let durationDisplayString = Math.floor(visibleDuration) + "s";
>-            this._energyImpactDurationElement.textContent = WI.UIString("Duration: %s").format(durationDisplayString);
>+            let durationDisplayString = Math.floor(visibleDuration);
>+            this._energyImpactDurationElement.textContent = WI.UIString("Duration: %ss", "The duration of the Timeline recording in seconds (s).").format(durationDisplayString);
>         }
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199582: 373650