Attachment 373643 Details for Bug 199578 – Patch

[patch] Patch

bug-199578-20190708110342.patch (text/plain), 2.13 KB, created by Jonathan Bedard on 2019-07-08 11:03:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-07-08 11:03:42 PDT

Size: 2.13 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 247212)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-07-08  Jonathan Bedard  <jbedard@apple.com>
>+
>+        test-webkitpy: Explicitly use Python 2.7 lldb library
>+        https://bugs.webkit.org/show_bug.cgi?id=199578
>+        <rdar://problem/51853557>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/common/system/systemhost.py:
>+        (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
>+        * Scripts/webkitpy/test/main.py:
>+        (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
>+
> 2019-07-08  Antoine Quint  <graouts@apple.com>
> 
>         [Pointer Events] Enable only on the most recent version of the supported iOS family
>Index: Tools/Scripts/webkitpy/common/system/systemhost.py
>===================================================================
>--- Tools/Scripts/webkitpy/common/system/systemhost.py	(revision 247210)
>+++ Tools/Scripts/webkitpy/common/system/systemhost.py	(working copy)
>@@ -54,7 +54,9 @@ class SystemHost(object):
>     def path_to_lldb_python_directory(self):
>         if not self.platform.is_mac():
>             return ''
>-        return self.executive.run_command(['xcrun', 'lldb', '--python-path'], return_stderr=False).rstrip()
>+        # Explicitly use Python 2.7
>+        path = self.executive.run_command(['xcrun', 'lldb', '--python-path'], return_stderr=False).rstrip()
>+        return self.filesystem.join(self.filesystem.dirname(path), 'Python')
> 
>     @property
>     def device_type(self):
>Index: Tools/Scripts/webkitpy/test/main.py
>===================================================================
>--- Tools/Scripts/webkitpy/test/main.py	(revision 247210)
>+++ Tools/Scripts/webkitpy/test/main.py	(working copy)
>@@ -107,7 +107,7 @@ def _supports_building_and_running_lldb_
>     build_version = _host.platform.build_version()
>     if build_version is None:
>         return False
>-    return not build_version.startswith('19A')
>+    return True
> 
> 
> def _print_results_as_json(stream, all_test_names, failures, errors):

Actions: View | Formatted Diff | Diff

Attachments on bug 199578: 373643