Attachment 373635 Details for Bug 199576 – Patch

[patch] Patch

bug-199576-20190708093232.patch (text/plain), 4.29 KB, created by Chris Dumez on 2019-07-08 09:32:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-07-08 09:32:34 PDT

Size: 4.29 KB

patch

obsolete

>Subversion Revision: 247207
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ad415c97f98ac9b08d3aabe279a27aa566ed9b50..3a482dbcda0919820cd3308c78316b273fe2d2e0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-07-08  Chris Dumez  <cdumez@apple.com>
>+
>+        Unable to play videos on xfinity.com/stream on macOS Catalina
>+        https://bugs.webkit.org/show_bug.cgi?id=199576
>+        <rdar://problem/50101264>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable invalidate Fetch signal quirk for all sites as the blacklist is getting too large and
>+        we are finding too much breakage too late in the release cycle.
>+
>+        * Modules/fetch/FetchRequest.cpp:
>+        (WebCore::processInvalidSignal):
>+        * page/Quirks.cpp:
>+        (WebCore::Quirks::shouldIgnoreInvalidSignal const):
>+
> 2019-07-08  Antoine Quint  <graouts@apple.com>
> 
>         [Pointer Events] Enable only on the most recent version of the supported iOS family
>diff --git a/Source/WebCore/Modules/fetch/FetchRequest.cpp b/Source/WebCore/Modules/fetch/FetchRequest.cpp
>index c37def31fdd3b9af7123a76fb9a2e192f4777af8..f101fd6879e721884280939d0bb618e835883042 100644
>--- a/Source/WebCore/Modules/fetch/FetchRequest.cpp
>+++ b/Source/WebCore/Modules/fetch/FetchRequest.cpp
>@@ -147,7 +147,7 @@ ExceptionOr<void> FetchRequest::initializeOptions(const Init& init)
> 
> static inline Optional<Exception> processInvalidSignal(ScriptExecutionContext& context)
> {
>-    ASCIILiteral message { "FetchRequestInit.signal should be undefined, null or an AbortSignal object."_s };
>+    ASCIILiteral message { "FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release."_s };
>     context.addConsoleMessage(MessageSource::JS, MessageLevel::Warning, message);
> 
>     if (is<Document>(context) && downcast<Document>(context).quirks().shouldIgnoreInvalidSignal())
>diff --git a/Source/WebCore/page/Quirks.cpp b/Source/WebCore/page/Quirks.cpp
>index 8ad31f0726ec9c86ece1b4de9a629585ae128ede..450741867c60c5559247064e38c51adcece7cb10 100644
>--- a/Source/WebCore/page/Quirks.cpp
>+++ b/Source/WebCore/page/Quirks.cpp
>@@ -90,13 +90,7 @@ Optional<LayoutUnit> Quirks::overriddenViewLayoutWidth(LayoutUnit currentViewLay
> 
> bool Quirks::shouldIgnoreInvalidSignal() const
> {
>-    if (!needsQuirks())
>-        return false;
>-
>-    auto host = m_document->topDocument().url().host();
>-    return equalLettersIgnoringASCIICase(host, "www.thrivepatientportal.com")
>-        || equalLettersIgnoringASCIICase(host, "www.bnz.co.nz")
>-        || equalLettersIgnoringASCIICase(host, "www.carvana.com");
>+    return needsQuirks();
> }
> 
> bool Quirks::needsFormControlToBeMouseFocusable() const
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b8845154d329b6e903e38cc5cbfa0ebecdb8a1a5..380dbe18b0c37aa767b6eea44158969db8120892 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-07-08  Chris Dumez  <cdumez@apple.com>
>+
>+        Unable to play videos on xfinity.com/stream on macOS Catalina
>+        https://bugs.webkit.org/show_bug.cgi?id=199576
>+        <rdar://problem/50101264>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Rebaseline existing test.
>+
>+        * http/wpt/fetch/request-abort-expected.txt:
>+
> 2019-07-08  Charlie Turner  <cturner@igalia.com>
> 
>         [GStreamer] media/video-volume.html broken after switching from cubic to linear scaling
>diff --git a/LayoutTests/http/wpt/fetch/request-abort-expected.txt b/LayoutTests/http/wpt/fetch/request-abort-expected.txt
>index 4ce025e590f490c97ea781858f67496150a29c97..a487f1a23ad92217d97e2e4b6fcfc942fd96f559 100644
>--- a/LayoutTests/http/wpt/fetch/request-abort-expected.txt
>+++ b/LayoutTests/http/wpt/fetch/request-abort-expected.txt
>@@ -1,5 +1,5 @@
>-CONSOLE MESSAGE: line 14: FetchRequestInit.signal should be undefined, null or an AbortSignal object.
>-CONSOLE MESSAGE: line 28: FetchRequestInit.signal should be undefined, null or an AbortSignal object.
>+CONSOLE MESSAGE: line 14: FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release.
>+CONSOLE MESSAGE: line 28: FetchRequestInit.signal should be undefined, null or an AbortSignal object. This will throw in a future release.
> 
> PASS Request from URL with signal 
> PASS Request from request with signal

Actions: View | Formatted Diff | Diff

Attachments on bug 199576: 373635