Attachment 373631 Details for Bug 199572 – Patch for landing

[patch] Patch for landing

bug-199572-20190708191134.patch (text/plain), 2.25 KB, created by Claudio Saavedra on 2019-07-08 09:11:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Claudio Saavedra

Created: 2019-07-08 09:11:35 PDT

Size: 2.25 KB

patch

obsolete

>Subversion Revision: 247203
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 7d656e04592e17f45ad1cd0ba5a5bddde19fc439..b0fcbcd5969f39bf7f0e7e8f84487404a55ce93c 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-07-08  Claudio Saavedra  <csaavedra@igalia.com>
>+
>+        REGRESSION(r246671): [WPE][GTK] Crash in NetworkProcess since the DNS cache landed
>+        https://bugs.webkit.org/show_bug.cgi?id=199572
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The GError coming from the wrapped resolver shouldn't be freed,
>+        but passed onto the caller.
>+
>+        * NetworkProcess/glib/WebKitCachedResolver.cpp:
>+        (webkitCachedResolverLookupByNameAsync):
>+        (webkitCachedResolverLookupByNameWithFlagsAsync):
>+
> 2019-07-08  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [GTK] ViewGestureController constructor leaves m_direction uninitialized
>diff --git a/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp b/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp
>index c544b65906252afbefa70be0d7fd6bcb55a092e8..3deab9e46ed1ffd85d1af2022b51adb1fbb21dfe 100644
>--- a/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp
>+++ b/Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp
>@@ -108,7 +108,7 @@ static void webkitCachedResolverLookupByNameAsync(GResolver* resolver, const cha
>             priv->cache.update(asyncData->hostname, addressListGListToVector(addressList));
>             g_task_return_pointer(task.get(), addressList, reinterpret_cast<GDestroyNotify>(g_resolver_free_addresses));
>         } else
>-            g_task_return_error(task.get(), error.get());
>+            g_task_return_error(task.get(), error.release().release());
>     }, task.leakRef());
> }
> 
>@@ -170,7 +170,7 @@ static void webkitCachedResolverLookupByNameWithFlagsAsync(GResolver* resolver,
>             priv->cache.update(asyncData->hostname, addressListGListToVector(addressList), asyncData->dnsCacheType);
>             g_task_return_pointer(task.get(), addressList, reinterpret_cast<GDestroyNotify>(g_resolver_free_addresses));
>         } else
>-            g_task_return_error(task.get(), error.get());
>+            g_task_return_error(task.get(), error.release().release());
>     }, task.leakRef());
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 199572: 373625 | 373629 | 373631