Attachment 373614 Details for Bug 199564 – Patch

[patch] Patch

bug-199564-20190707192017.patch (text/plain), 1.60 KB, created by Devin Rousso on 2019-07-07 19:20:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-07-07 19:20:17 PDT

Size: 1.60 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 81b5be3e689e68d8dd6e2fd96a6bdecc06460d12..58259b873c871168982f53e3fd3a1ca6b684b85b 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-07-07  Devin Rousso  <drousso@apple.com>
>+
>+        Uncaught Exception: Unexpected enum value: CPU
>+        https://bugs.webkit.org/show_bug.cgi?id=199564
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Controllers/TimelineManager.js:
>+        (WI.TimelineManager.prototype._updateAutoCaptureInstruments):
>+        Filter the list of auto-capture instruments based on what's actually supported, instead of
>+        directly using the saved list from the `WI.Setting`.
>+
> 2019-07-05  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: current call frame indicator not visible in dark mode
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js b/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
>index 874efba7bd4ffd8d1e4fb6e0c774fafd6db73713..b161a65965c5985c9599d5f94607fc6b0417ca0c 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
>@@ -1206,7 +1206,7 @@ WI.TimelineManager = class TimelineManager extends WI.Object
> 
>     _updateAutoCaptureInstruments(targets)
>     {
>-        let enabledTimelineTypes = this._enabledTimelineTypesSetting.value;
>+        let enabledTimelineTypes = this.enabledTimelineTypes;
> 
>         for (let target of targets) {
>             if (!target.TimelineAgent)

Actions: View | Formatted Diff | Diff

Attachments on bug 199564: 373614