WebKit Bugzilla
Attachment 373598 Details for
Bug 199562
: [Pointer Events] Enable only on the most recent version of the supported iOS family
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-199562-20190707211513.patch (text/plain), 17.47 KB, created by
Antoine Quint
on 2019-07-07 12:15:14 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Antoine Quint
Created:
2019-07-07 12:15:14 PDT
Size:
17.47 KB
patch
obsolete
>Subversion Revision: 247200 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index cebfd627debd4a8d93a786617c89a0550b514696..9a744eeabf57f8fa2576bef99d424ba490a979a8 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,12 @@ >+2019-07-07 Antoine Quint <graouts@apple.com> >+ >+ [Pointer Events] Enable only on the most recent version of the supported iOS family >+ https://bugs.webkit.org/show_bug.cgi?id=199562 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/FeatureDefines.xcconfig: >+ > 2019-07-06 Michael Saboff <msaboff@apple.com> > > switch(String) needs to check for exceptions when resolving the string >diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog >index 8938a9905328a6f5a02cb7d80b2a79127ee40ccb..6a794b7072cb344f733c77d69e8a6d53906a40fc 100644 >--- a/Source/WTF/ChangeLog >+++ b/Source/WTF/ChangeLog >@@ -1,3 +1,18 @@ >+2019-07-07 Antoine Quint <graouts@apple.com> >+ >+ [Pointer Events] Enable only on the most recent version of the supported iOS family >+ https://bugs.webkit.org/show_bug.cgi?id=199562 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ We really don't need HAVE_UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID since the UIKit SPI >+ that was added in iOS 13 that it's checking for is really required for all parts of the implementation of Pointer >+ Events, including dispatch of the "pointercancel" event and support for the "touch-action" CSS property. So we >+ remove ENABLE_POINTER_EVENTS from the various FeatureDefines.xcconfig files and instead define it in Platform.h >+ to enable Pointer Events on macOS and the latest versions of iOS, iPadOS and watchOS (tvOS is not supported). >+ >+ * wtf/Platform.h: >+ > 2019-07-05 Ryan Haddad <ryanhaddad@apple.com> > > Unreviewed, rolling out r247115. >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 7b8f6a802ddbb804ed7015c8783704f7158d8d63..0f2c87dc60ccfe68e8f7580e7f6e1d73b385cde1 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,14 @@ >+2019-07-07 Antoine Quint <graouts@apple.com> >+ >+ [Pointer Events] Enable only on the most recent version of the supported iOS family >+ https://bugs.webkit.org/show_bug.cgi?id=199562 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ No new tests (OOPS!). >+ >+ * Configurations/FeatureDefines.xcconfig: >+ > 2019-07-07 Zalan Bujtas <zalan@apple.com> > > [ContentChangeObserver] Difficult to control videos on iqiyi.com as the actions are mouse hover >diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog >index 4406811f6eb73982a456175d5d571e74c336122d..e1950ef3d552bfe63c71adaaa3f744b04e648516 100644 >--- a/Source/WebCore/PAL/ChangeLog >+++ b/Source/WebCore/PAL/ChangeLog >@@ -1,3 +1,12 @@ >+2019-07-07 Antoine Quint <graouts@apple.com> >+ >+ [Pointer Events] Enable only on the most recent version of the supported iOS family >+ https://bugs.webkit.org/show_bug.cgi?id=199562 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/FeatureDefines.xcconfig: >+ > 2019-07-05 Ryan Haddad <ryanhaddad@apple.com> > > Unreviewed, rolling out r247159. >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index f50f49e6bba7edf93e50fe99e14bfa7b19171433..7366129af90116297304d5955c83dcc8746e2903 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,21 @@ >+2019-07-07 Antoine Quint <graouts@apple.com> >+ >+ [Pointer Events] Enable only on the most recent version of the supported iOS family >+ https://bugs.webkit.org/show_bug.cgi?id=199562 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/FeatureDefines.xcconfig: >+ * UIProcess/ios/WKContentViewInteraction.mm: >+ (-[WKContentView cancelPointersForGestureRecognizer:]): >+ (-[WKContentView activeTouchIdentifierForGestureRecognizer:]): >+ (-[WKContentView touchActionActiveTouches]): >+ * UIProcess/ios/WKSyntheticTapGestureRecognizer.m: >+ (-[WKSyntheticTapGestureRecognizer touchesEnded:withEvent:]): >+ * UIProcess/ios/WKTouchActionGestureRecognizer.h: >+ * UIProcess/ios/WKTouchActionGestureRecognizer.mm: >+ (-[WKTouchActionGestureRecognizer canPreventGestureRecognizer:]): >+ > 2019-07-07 Zalan Bujtas <zalan@apple.com> > > [ContentChangeObserver] Difficult to control videos on iqiyi.com as the actions are mouse hover >diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog >index 0797db0aac26c902ca24c556dbbd6937a5827973..3ccd7455a629ee38f2fe099e3cb9a35e693f987b 100644 >--- a/Source/WebKitLegacy/mac/ChangeLog >+++ b/Source/WebKitLegacy/mac/ChangeLog >@@ -1,3 +1,12 @@ >+2019-07-07 Antoine Quint <graouts@apple.com> >+ >+ [Pointer Events] Enable only on the most recent version of the supported iOS family >+ https://bugs.webkit.org/show_bug.cgi?id=199562 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Configurations/FeatureDefines.xcconfig: >+ > 2019-07-03 Sam Weinig <weinig@apple.com> > > Adopt simple structured bindings in more places >diff --git a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >index 13ed2c0a96a8b0f61131c76d415ae0e3c0473dde..de8a3e0c585940282ad723ea62b9ad6183007017 100644 >--- a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >+++ b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig >@@ -315,14 +315,6 @@ ENABLE_PAYMENT_REQUEST = ENABLE_PAYMENT_REQUEST; > ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(WK_PLATFORM_NAME)); > ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN; > >-ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME)); >-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchsimulator = ENABLE_POINTER_EVENTS; >- > ENABLE_POINTER_LOCK = $(ENABLE_POINTER_LOCK_$(WK_PLATFORM_NAME)); > ENABLE_POINTER_LOCK_macosx = ENABLE_POINTER_LOCK; > >diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h >index b5e63a905eb4540636c244e4f33a2b798726f0c7..1d5a61678f4345e22622cd822adbd3ce48a70c18 100644 >--- a/Source/WTF/wtf/Platform.h >+++ b/Source/WTF/wtf/Platform.h >@@ -1533,8 +1533,8 @@ > #define ENABLE_MONOSPACE_FONT_EXCEPTION (__IPHONE_OS_VERSION_MIN_REQUIRED < 130000) > #endif > >-#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000 >-#define HAVE_UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID 1 >+#if PLATFORM(MAC) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 60000) || PLATFORM(MACCATALYST) >+#define ENABLE_POINTER_EVENTS 1 > #endif > > #if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000 >diff --git a/Source/WebCore/Configurations/FeatureDefines.xcconfig b/Source/WebCore/Configurations/FeatureDefines.xcconfig >index 13ed2c0a96a8b0f61131c76d415ae0e3c0473dde..de8a3e0c585940282ad723ea62b9ad6183007017 100644 >--- a/Source/WebCore/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebCore/Configurations/FeatureDefines.xcconfig >@@ -315,14 +315,6 @@ ENABLE_PAYMENT_REQUEST = ENABLE_PAYMENT_REQUEST; > ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(WK_PLATFORM_NAME)); > ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN; > >-ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME)); >-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchsimulator = ENABLE_POINTER_EVENTS; >- > ENABLE_POINTER_LOCK = $(ENABLE_POINTER_LOCK_$(WK_PLATFORM_NAME)); > ENABLE_POINTER_LOCK_macosx = ENABLE_POINTER_LOCK; > >diff --git a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >index 13ed2c0a96a8b0f61131c76d415ae0e3c0473dde..de8a3e0c585940282ad723ea62b9ad6183007017 100644 >--- a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig >@@ -315,14 +315,6 @@ ENABLE_PAYMENT_REQUEST = ENABLE_PAYMENT_REQUEST; > ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(WK_PLATFORM_NAME)); > ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN; > >-ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME)); >-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchsimulator = ENABLE_POINTER_EVENTS; >- > ENABLE_POINTER_LOCK = $(ENABLE_POINTER_LOCK_$(WK_PLATFORM_NAME)); > ENABLE_POINTER_LOCK_macosx = ENABLE_POINTER_LOCK; > >diff --git a/Source/WebKit/Configurations/FeatureDefines.xcconfig b/Source/WebKit/Configurations/FeatureDefines.xcconfig >index 13ed2c0a96a8b0f61131c76d415ae0e3c0473dde..de8a3e0c585940282ad723ea62b9ad6183007017 100644 >--- a/Source/WebKit/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebKit/Configurations/FeatureDefines.xcconfig >@@ -315,14 +315,6 @@ ENABLE_PAYMENT_REQUEST = ENABLE_PAYMENT_REQUEST; > ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(WK_PLATFORM_NAME)); > ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN; > >-ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME)); >-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchsimulator = ENABLE_POINTER_EVENTS; >- > ENABLE_POINTER_LOCK = $(ENABLE_POINTER_LOCK_$(WK_PLATFORM_NAME)); > ENABLE_POINTER_LOCK_macosx = ENABLE_POINTER_LOCK; > >diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >index fd3f5d67bf1b040d50fc8f0b9ccf7782e0ae4fd8..fa2df8502c5b2330d73c25436263517088dd9f02 100644 >--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >@@ -1287,28 +1287,22 @@ - (BOOL)resignFirstResponderForWebView > #if ENABLE(POINTER_EVENTS) > - (void)cancelPointersForGestureRecognizer:(UIGestureRecognizer *)gestureRecognizer > { >-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID) >- // FIXME: <rdar://problem/48035706> > NSMapTable<NSNumber *, UITouch *> *activeTouches = [_touchEventGestureRecognizer activeTouchesByIdentifier]; > for (NSNumber *touchIdentifier in activeTouches) { > UITouch *touch = [activeTouches objectForKey:touchIdentifier]; > if ([touch.gestureRecognizers containsObject:gestureRecognizer]) > _page->cancelPointer([touchIdentifier unsignedIntValue], WebCore::roundedIntPoint([touch locationInView:self])); > } >-#endif > } > > - (WTF::Optional<unsigned>)activeTouchIdentifierForGestureRecognizer:(UIGestureRecognizer *)gestureRecognizer > { >-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID) >- // FIXME: <rdar://problem/48035706> > NSMapTable<NSNumber *, UITouch *> *activeTouches = [_touchEventGestureRecognizer activeTouchesByIdentifier]; > for (NSNumber *touchIdentifier in activeTouches) { > UITouch *touch = [activeTouches objectForKey:touchIdentifier]; > if ([touch.gestureRecognizers containsObject:gestureRecognizer]) > return [touchIdentifier unsignedIntValue]; > } >-#endif > return WTF::nullopt; > } > #endif >@@ -1399,12 +1393,10 @@ - (BOOL)gestureRecognizerMayPinchToZoomWebView:(UIGestureRecognizer *)gestureRec > return gestureRecognizer == [_webView scrollView].pinchGestureRecognizer; > } > >-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID) > - (NSMapTable<NSNumber *, UITouch *> *)touchActionActiveTouches > { > return [_touchEventGestureRecognizer activeTouchesByIdentifier]; > } >-#endif > > - (void)_resetPanningPreventionFlags > { >diff --git a/Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m b/Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m >index 3c66527c19d7c673fc9433a7683a8f0dc6cec489..65e4c364942114d6bcb60cba0dcb12f6c5787b7a 100644 >--- a/Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m >+++ b/Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.m >@@ -78,7 +78,7 @@ - (void)reset > - (void)touchesEnded:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event > { > [super touchesEnded:touches withEvent:event]; >-#if ENABLE(POINTER_EVENTS) && HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID) >+#if ENABLE(POINTER_EVENTS) > if (!_supportingWebTouchEventsGestureRecognizer) > return; > >diff --git a/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.h b/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.h >index 7ce04dadba55a1cfd3a90119f152423e9c3edca2..1c44e9b5cd66f37420686cda202bd2300c25211b 100644 >--- a/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.h >+++ b/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.h >@@ -23,7 +23,7 @@ > * THE POSSIBILITY OF SUCH DAMAGE. > */ > >-#if PLATFORM(IOS_FAMILY) && ENABLE(POINTER_EVENTS) >+#if ENABLE(POINTER_EVENTS) > > #import "UIKitSPI.h" > #import <WebCore/TouchAction.h> >@@ -39,9 +39,7 @@ > > @protocol WKTouchActionGestureRecognizerDelegate <NSObject> > - (BOOL)gestureRecognizerMayPinchToZoomWebView:(UIGestureRecognizer *)gestureRecognizer; >-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID) > - (NSMapTable<NSNumber *, UITouch *> *)touchActionActiveTouches; >-#endif > @end > > #endif >diff --git a/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.mm b/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.mm >index 0f6b934c8f3bd6f6313fc2309299e569128509dd..835fc658e7c733d40799635c5ff33c068219b0d7 100644 >--- a/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.mm >+++ b/Source/WebKit/UIProcess/ios/WKTouchActionGestureRecognizer.mm >@@ -86,7 +86,6 @@ - (BOOL)canBePreventedByGestureRecognizer:(UIGestureRecognizer *)preventingGestu > return NO; > } > >-#if HAVE(UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID) > - (BOOL)canPreventGestureRecognizer:(UIGestureRecognizer *)preventedGestureRecognizer > { > if (_touchActionsByTouchIdentifier.isEmpty()) >@@ -111,7 +110,6 @@ - (BOOL)canPreventGestureRecognizer:(UIGestureRecognizer *)preventedGestureRecog > > return NO; > } >-#endif > > @end > >diff --git a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >index 13ed2c0a96a8b0f61131c76d415ae0e3c0473dde..de8a3e0c585940282ad723ea62b9ad6183007017 100644 >--- a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >+++ b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig >@@ -315,14 +315,6 @@ ENABLE_PAYMENT_REQUEST = ENABLE_PAYMENT_REQUEST; > ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(WK_PLATFORM_NAME)); > ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN; > >-ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME)); >-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchsimulator = ENABLE_POINTER_EVENTS; >- > ENABLE_POINTER_LOCK = $(ENABLE_POINTER_LOCK_$(WK_PLATFORM_NAME)); > ENABLE_POINTER_LOCK_macosx = ENABLE_POINTER_LOCK; > >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 822e3ef4e608bffe7da5685a55d7e886f349752e..cccc0b02f5b17a1cd9c067b18c418c369b78199f 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,12 @@ >+2019-07-07 Antoine Quint <graouts@apple.com> >+ >+ [Pointer Events] Enable only on the most recent version of the supported iOS family >+ https://bugs.webkit.org/show_bug.cgi?id=199562 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: >+ > 2019-07-06 Simon Fraser <simon.fraser@apple.com> > > Long hang when loading a cnn.com page on iOS >diff --git a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >index 13ed2c0a96a8b0f61131c76d415ae0e3c0473dde..de8a3e0c585940282ad723ea62b9ad6183007017 100644 >--- a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >+++ b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig >@@ -315,14 +315,6 @@ ENABLE_PAYMENT_REQUEST = ENABLE_PAYMENT_REQUEST; > ENABLE_PDFKIT_PLUGIN = $(ENABLE_PDFKIT_PLUGIN_$(WK_PLATFORM_NAME)); > ENABLE_PDFKIT_PLUGIN_macosx = ENABLE_PDFKIT_PLUGIN; > >-ENABLE_POINTER_EVENTS = $(ENABLE_POINTER_EVENTS_$(WK_PLATFORM_NAME)); >-ENABLE_POINTER_EVENTS_iphoneos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_iphonesimulator = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_maccatalyst = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_macosx = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchos = ENABLE_POINTER_EVENTS; >-ENABLE_POINTER_EVENTS_watchsimulator = ENABLE_POINTER_EVENTS; >- > ENABLE_POINTER_LOCK = $(ENABLE_POINTER_LOCK_$(WK_PLATFORM_NAME)); > ENABLE_POINTER_LOCK_macosx = ENABLE_POINTER_LOCK; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 199562
:
373598
|
373599
|
373600
|
373601
|
373603
|
373604
|
373618
|
373619